From patchwork Tue Jan 14 17:51:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 13939210 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB0A9C02183 for ; Tue, 14 Jan 2025 18:00:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41D496B009A; Tue, 14 Jan 2025 13:00:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CC8B6B009B; Tue, 14 Jan 2025 13:00:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 246F46B009C; Tue, 14 Jan 2025 13:00:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 044666B009A for ; Tue, 14 Jan 2025 13:00:20 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ACF55120C0F for ; Tue, 14 Jan 2025 18:00:20 +0000 (UTC) X-FDA: 83006821800.17.DE154F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id DB9E3160018 for ; Tue, 14 Jan 2025 18:00:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JppIlS87; spf=pass (imf08.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736877618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oEa6Jvbfjlidl4MXGQFSAZ9P76MqELccnrf7elTRMWU=; b=AIOu6OuSm9iLbt53JwHGNazMCTHTule55CSicSull3FhwtyJQpD2UBIUwqHHREvaeIZ8YA ulDnZ8e00mE0eZqqn/g2Ut8yVq92pv2TdvKrI5CvevHZX6K0sI7puMvSpH6TdGDB2mi0Xn 1V+iKB4hId+VUhL2335Qz4Jo8vQ1GsE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JppIlS87; spf=pass (imf08.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736877619; a=rsa-sha256; cv=none; b=qsayvv44np+puB/ndSmUCKRMX5gk4r2cdLo6xgr/10jLgOMtFVtm6k4uH8eccoddLEG1oM 1/0Yr8KVbOm/JCylAZ7+MfzHoZ4MzlYgrcCe72akSzI7hhNQmLe2eK+0T/+LrrXI964uSA b19y2/hzLPWtCB/TxSTuFv34ACae6Oo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736877618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oEa6Jvbfjlidl4MXGQFSAZ9P76MqELccnrf7elTRMWU=; b=JppIlS876yk7+hztdTwy+MKgYWDkCR0o/FIvk/erKeqgT66+EIo5SwPFhX8g09Fcfoo6ru Ip3/C5Q0lm1g4SEWMS6r23VZ4lNqojmbsKUmHICqvFNpAhbbC7hJ5j2dceXq+08VOZ+n8r rYmgB0ZnmcgL5Y3pckDaXRTFmg3fL9U= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-113-k3wLyZ7iPkiQIoWyV-6PFw-1; Tue, 14 Jan 2025 13:00:14 -0500 X-MC-Unique: k3wLyZ7iPkiQIoWyV-6PFw-1 X-Mimecast-MFC-AGG-ID: k3wLyZ7iPkiQIoWyV-6PFw Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BD2A51955DE0; Tue, 14 Jan 2025 18:00:10 +0000 (UTC) Received: from vschneid-thinkpadt14sgen2i.remote.csb (unknown [10.39.192.55]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 79BA9195E3E0; Tue, 14 Jan 2025 17:59:46 +0000 (UTC) From: Valentin Schneider To: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-perf-users@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Cc: Juergen Gross , Ajay Kaher , Alexey Makhalov , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Boris Ostrovsky , Josh Poimboeuf , Pawan Gupta , Sean Christopherson , Paolo Bonzini , Andy Lutomirski , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juri Lelli , Clark Williams , Yair Podemsky , Tomas Glozar , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Kees Cook , Andrew Morton , Christoph Hellwig , Shuah Khan , Sami Tolvanen , Miguel Ojeda , Alice Ryhl , "Mike Rapoport (Microsoft)" , Samuel Holland , Rong Xu , Nicolas Saenz Julienne , Geert Uytterhoeven , Yosry Ahmed , "Kirill A. Shutemov" , "Masami Hiramatsu (Google)" , Jinghao Jia , Luis Chamberlain , Randy Dunlap , Tiezhu Yang Subject: [PATCH v4 17/30] sched/clock, x86: Mark __sched_clock_stable key as allowed in .noinstr Date: Tue, 14 Jan 2025 18:51:30 +0100 Message-ID: <20250114175143.81438-18-vschneid@redhat.com> In-Reply-To: <20250114175143.81438-1-vschneid@redhat.com> References: <20250114175143.81438-1-vschneid@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Queue-Id: DB9E3160018 X-Stat-Signature: zagjhiuhgipgt9g194433efzo3oepn6p X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736877618-308858 X-HE-Meta: U2FsdGVkX194roztqKwt/vlCGegp5RmKVJVn9ZMG9Qx4QLUmSh6vuXZclB2LdXZCy3fe7H+6oWSyJIUqdEsb7wceDSjeku2F6RqmP6oSFmVqAgIer2XqQkk+HhvMyePpts8kudDHpllUZ6AaTsHDUrEwF8Fyx58HjJJO6hhxwFrtXi2BE2B7zMaBRQBDbU2wYXFPkiw6bDNSqV/Mkot64Q35ommJiXeeojHSeIaL/2oI40ceTJenKTBrnNJNnR0xfgcduPCgwa0C+oZHQj4J7aV8uspmS4vSGs6PZDpyHF3liCa/cLISzWrCTdT6HFgVyNEDoslwtsiVpTZDkyJ/9JMVUO7OXNbz8Xv1FIgkAQ147/H1/fbxTTm71D6rUksn1T9jXoZNexdRZGLC7mjkcYpvV+4U6Ps1dNrvsDSX+rMvMQPtNAW0GaC5N5pOjId9xgcSAIvbHTnwlrts9ZTvcnxzu4V+em0OxpSMfO369lUVliwWxul4kWAQzkTK6klSYRfyzrtcE2wLI9WQDeIRxqdGb8St8DGxQlu7t4hXIuuPJGxxPz1fQwmIwZajtNut/y+ZmC2rPcmUKqULapS8hZHpRU9eYZ8Cz9bpHRLgNVNmXyovbAKNjSQj5IByBhzeMWy2tNKSeZCsme8iHIcqEBvU0UMN3b2O79ZywN29h+s9IIH3vwg+RdhWJ+314/UtPH/IbfUuf6T+ThY7xbYcpDVAJShEE1LkPA7SjPC1sInamrPEKmF7ZdyhO8/H8+QyQ8rdKo0ELlFlK1MwZSeUSte9s5sDCujMrKCicZVbNoYw5ZNdS3Rq+QM1ALywkRq43cOhtpR4VUC7qgdoFXJsBdv7TICF61KEfBC7ewNyn9u5Lh63lECVojdvI0DkL0dG3ud2M+jy0UkIJRUcc1kn5LFHsaem/QH918FWLv4aLUW1MGy5nJc/ZTh9YnS0tqubu/EcDucU286eNeFtjaj k8szrR03 aZSXxt1kTT5PkRlFbUm/ODdflZzY0DMTWtEYilqgqSG9bB1mddH7pQjWEx3UX1X06pLVgK0Ve9Bb0t4uUjT9u+WqjX4q5cMEsMKHF/Cuqw/bsT9AUTKjVXiPt5+y5r8H3YBlvBJX6JSPTK7usWaPybvKdObdaaMQPxQGUSN6FjHi1ZpvaRC1kmAmakUnHdmlga2mKTF/azNVgDR7pQbyrDnNt1vt0te8e5hNLD3TGKrNMbFFK+Xja0gBTiDGEA+Z/nCrS11yxZ4lwdJpQYGYrM61WB6GerNGr38dcKfJ8D+amKS9bAI9JVe9F4KPKOujzvrcQzWWxilUL1NqhOkKYJMoeXXaLeqkd4c8a6o1LwyzQOYWQBwKiWNgj5+DMIq+in8CLm8Rrm768XViH5vECdhRY70wIk5TiQzrbuRRIz3YpaqozomvnifHvkzHFA4ZM/bHY3HbV/w4oc+PSJIiHwyQdEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Later commits will cause objtool to warn about static keys being used in .noinstr sections in order to safely defer instruction patching IPIs targeted at NOHZ_FULL CPUs. __sched_clock_stable is used in .noinstr code, and can be modified at runtime (e.g. time_cpufreq_notifier()). Suppressing the text_poke_sync() IPI has little benefits for this key, as NOHZ_FULL is incompatible with an unstable TSC anyway. Mark it to let objtool know not to warn about it. Signed-off-by: Valentin Schneider --- kernel/sched/clock.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c index 200e5568b9894..e59986bc14a43 100644 --- a/kernel/sched/clock.c +++ b/kernel/sched/clock.c @@ -75,8 +75,11 @@ static DEFINE_STATIC_KEY_FALSE_RO(sched_clock_running); * * Similarly we start with __sched_clock_stable_early, thereby assuming we * will become stable, such that there's only a single 1 -> 0 transition. + * + * Allowed in .noinstr as an unstable TLC is incompatible with NOHZ_FULL, + * thus the text patching IPI would be the least of our concerns. */ -static DEFINE_STATIC_KEY_FALSE(__sched_clock_stable); +static DEFINE_STATIC_KEY_FALSE_NOINSTR(__sched_clock_stable); static int __sched_clock_stable_early = 1; /*