From patchwork Tue Jan 14 17:51:41 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 13939221 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10877C02183 for ; Tue, 14 Jan 2025 18:04:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EB786B0096; Tue, 14 Jan 2025 13:04:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 99BC828001A; Tue, 14 Jan 2025 13:04:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EE6A28000C; Tue, 14 Jan 2025 13:04:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 626C36B0096 for ; Tue, 14 Jan 2025 13:04:36 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 16744C0C3C for ; Tue, 14 Jan 2025 18:04:36 +0000 (UTC) X-FDA: 83006832552.29.AA7B6A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 5E48F1C0021 for ; Tue, 14 Jan 2025 18:04:34 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dTN5U6o4; spf=pass (imf18.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736877874; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uZZLtjs3Zw6jRIC16nznFhpiKaBBT8sXvDLj8C27htE=; b=C/Lca1UokIPhrk18A9GJLHf+F4kazT8nTtDOgtCKZXlyieyXKQ41SDg+CzXXn4U/SO1iud l/jHUpOnYw03w3RFGJ0h+hMzlhx+QiefP8Ec5JzcLpWU2ET1IEPcmIs+qYHhleoZvpw2rD efuSoGys1ki4BYFpk8Z+Jt8N97EHQMo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dTN5U6o4; spf=pass (imf18.hostedemail.com: domain of vschneid@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736877874; a=rsa-sha256; cv=none; b=qVnhN69uBkX9vcOao7w4GNq0tGeidjDiiC6hz7Avd6mS2yv47bn0nz7GuIrNVEj4NXimax NkflUFJl0Wsi6hsvfpQ/GwI9CQGP5rK4zZErl0Vdp0/YKIBkD7VGFv4eRUw9dWUnx3oCu5 8A8GSJqdbUofMK3KAqAf/Y4hZA0noGI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736877873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uZZLtjs3Zw6jRIC16nznFhpiKaBBT8sXvDLj8C27htE=; b=dTN5U6o4wf67sy7YEmxWlenUbOZzHHePLrQ+e0ysRU+tCm/MY4O6sfCqPMuWfPUyhViSuR ixIjrOwyf0QKZEVPhwjff77MzqRMQG8EaQuKvlAQdOC6YqCaqU/WpMOkaDqU74ROICjPD1 1h2NdwIC+0PDBpM4wVAcqepBUGfEVK8= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-YsncyNivNYmsu48rkVhymA-1; Tue, 14 Jan 2025 13:04:29 -0500 X-MC-Unique: YsncyNivNYmsu48rkVhymA-1 X-Mimecast-MFC-AGG-ID: YsncyNivNYmsu48rkVhymA Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A7D431955DCF; Tue, 14 Jan 2025 18:04:25 +0000 (UTC) Received: from vschneid-thinkpadt14sgen2i.remote.csb (unknown [10.39.192.55]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6C14D195608A; Tue, 14 Jan 2025 18:04:03 +0000 (UTC) From: Valentin Schneider To: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-perf-users@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Cc: Juergen Gross , Ajay Kaher , Alexey Makhalov , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Boris Ostrovsky , Josh Poimboeuf , Pawan Gupta , Sean Christopherson , Paolo Bonzini , Andy Lutomirski , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juri Lelli , Clark Williams , Yair Podemsky , Tomas Glozar , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Kees Cook , Andrew Morton , Christoph Hellwig , Shuah Khan , Sami Tolvanen , Miguel Ojeda , Alice Ryhl , "Mike Rapoport (Microsoft)" , Samuel Holland , Rong Xu , Nicolas Saenz Julienne , Geert Uytterhoeven , Yosry Ahmed , "Kirill A. Shutemov" , "Masami Hiramatsu (Google)" , Jinghao Jia , Luis Chamberlain , Randy Dunlap , Tiezhu Yang Subject: [PATCH v4 28/30] x86/tlb: Make __flush_tlb_all() noinstr Date: Tue, 14 Jan 2025 18:51:41 +0100 Message-ID: <20250114175143.81438-29-vschneid@redhat.com> In-Reply-To: <20250114175143.81438-1-vschneid@redhat.com> References: <20250114175143.81438-1-vschneid@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Queue-Id: 5E48F1C0021 X-Rspamd-Server: rspam12 X-Stat-Signature: mk9o5wno57jbwb6a36dtcsd6uce3197e X-Rspam-User: X-HE-Tag: 1736877874-844485 X-HE-Meta: U2FsdGVkX1/yJI19TsGXWgE5J2K3lSsA4774D+pGuUqz3X8cHHgqhOCFcHhcSc+i/+UGEw/SwBO5d/MIyFL2WOPJtkrnYdCu2dBCene5hzsUeXoYJx5a+I3RZKlMFWmPcfVCyGf1aT7uoVrJS18BYFFKJGh59sa9BuTilMC6GN52oN0Ksfxl8Zj/obilaBoY0TikJf+pyF4KFuOLr1LL/pSs/dJYuPl2KVpuS7s3kcq38NKzjbgdI4AAa7v+aTadaptxukOTRC7QwzG880nO0UiBbisqglg14mN6nf/SgIJW8SK+i/J+077pUzXeDRHxY03ag4VrJdcu8c4mFHWCVXKhYhKqLC/Kyl7N1A+J2PslyV7GV2TCYlzGZMcpqZ87NaVAUOaDzjSwM7AdEexil1uPG+6o893rs3rW1i9hsIAWuOvlDQeEWHc5TVCIRQRW4HOZmJO8X2egv7RLmq+eSxEWMPeREDBeH00KWblQmI3r4Q7Dqd/9dxKjH4BKrkSvyhp6v7X85O5T5m4RYFQfI/697hh2SVIYLQ94wS6jIMT8GMZXyuOeXFrHdJcVj1UsVg++j9L+B7MaN7RHuXCMoAjp/3Rvsf8Uo46FlGam0QPo95aez82skT9P8InRTWWOm+HpdDRivlWyylsAFrFH5KW/JvKtrjpRJVSImadCuzc2BTHcrPOZbsJ7OyqCToi3fbrHzrDOR6UMBBrC8IzJ2ZAa9B4v+lkT0Js/7aBgFQwK7ZiuYOViREdx5B3tUqsFWzcWtr78pIPzQjvPb3/AqRs/lE+08nhYna1EyossQDgSOIWlBtmn75hlDje7cQIHmRjj/YfLggEaLEYfKtu0higZI8jT404FTbI8ckAD7qAXdnp0LH2Nt1pYmsQt+Z9AJImBajENdYWHnDlrNeUpn0pkKpedJmJAv380Wr3RphviLITSLYaoxc6CwT/Re1ol5+AJ0fTQ4GoN5VZ//43 +sF77k1L TYdgdIhO/5zaKTMq5Shf4V/c1IQ/KiyulWt+3EjY8m/0mguldj5fUy8A3XBSIV1jcKyXDa7gCKpa5aym7YJfb3XLQoFxeVJIzBPkwnaQyMwlXlw5lCg1JgqSui7sCKYPYQvfIGsRD5o7dfEAW7PwtKYtfM8pQfTzmAndECcpUlPo2ACdPV9JbruATFBVXYKzkZbuote4g3JrSEGueYofqh2OCnthtL5FlBkXQatMfuOyxo3dLJAM1NvSCGNUfw6K+w3lSIMki7xxsiJIntWDp/WXA4Q9kQmpP5BW8C26PqpFv2wWZ0r5j9ah9MnAkPMEc2gcnIcJ+hKp6FGgPUjlroLL+bB4cyAIhxZeMWdPMrIp9JjsV0zQ8xYJVetGZbjzepPAIgGpbaANngj6IoSaRT5o6yoPI4U/dbW4k+BZo2go3s4fZPECtoMMRbcOIzS545Xka12/QUT3Xs1C8SR2a0nb98g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Later patches will require issuing a __flush_tlb_all() from noinstr code. Both __flush_tlb_local() and __flush_tlb_global() are now noinstr-compliant, so __flush_tlb_all() can be made noinstr itself. Signed-off-by: Valentin Schneider --- arch/x86/include/asm/tlbflush.h | 2 +- arch/x86/mm/tlb.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h index 69e79fff41b80..4d11396250999 100644 --- a/arch/x86/include/asm/tlbflush.h +++ b/arch/x86/include/asm/tlbflush.h @@ -17,7 +17,7 @@ DECLARE_PER_CPU(u64, tlbstate_untag_mask); -void __flush_tlb_all(void); +noinstr void __flush_tlb_all(void); #define TLB_FLUSH_ALL -1UL #define TLB_GENERATION_INVALID 0 diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 18b40bbc2fa15..119765772ab11 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1229,7 +1229,7 @@ void flush_tlb_local(void) /* * Flush everything */ -void __flush_tlb_all(void) +noinstr void __flush_tlb_all(void) { /* * This is to catch users with enabled preemption and the PGE feature @@ -1243,7 +1243,7 @@ void __flush_tlb_all(void) /* * !PGE -> !PCID (setup_pcid()), thus every flush is total. */ - flush_tlb_local(); + __flush_tlb_local(); } } EXPORT_SYMBOL_GPL(__flush_tlb_all);