From patchwork Tue Jan 14 17:51:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Valentin Schneider X-Patchwork-Id: 13939048 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E19BE77188 for ; Tue, 14 Jan 2025 17:53:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E798B280002; Tue, 14 Jan 2025 12:53:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E2A1B280001; Tue, 14 Jan 2025 12:53:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7D07280002; Tue, 14 Jan 2025 12:53:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A5A34280001 for ; Tue, 14 Jan 2025 12:53:53 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 67A7D140BFC for ; Tue, 14 Jan 2025 17:53:53 +0000 (UTC) X-FDA: 83006805546.02.0F607A1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id A25B2180009 for ; Tue, 14 Jan 2025 17:53:51 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TTxCdhd3; spf=pass (imf16.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736877231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BIPe4J+MPkclOG0fZ/T6Ew0fi09A38ofFGJkEjEgffw=; b=XWZiGsPcH2Iu1oGPAIbTP8MfEvvk270Xhdt4nAtENeQmmJ9k7ra9B9fk0slP48U2FWsp7a JGKLfu9mSIO+iChnOF3ewCzuBcuqWkwP5WISrjTZ2DEhhUvEQNJWLT8Q/NrgltymVM81s4 zWpuBptIjHfuvGOXY4NKji7H4gPLGn4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736877231; a=rsa-sha256; cv=none; b=nFmSD4hJYz9w1hNV2tYrEpWeE37Zx3hTOlZSqPJfMmQ/37m+2C3aP382RXLmNpAC6lH0KS nlUMkEVlLsUJr2uwRD4u6sdRqy4U2ajrX2fV3wHQIiiRXtpr/cOqabCMmzrrsWSBWH5IOH NOLlMR7JyHVb/MZSQbFkf5kmuv9rrTY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TTxCdhd3; spf=pass (imf16.hostedemail.com: domain of vschneid@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=vschneid@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736877231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BIPe4J+MPkclOG0fZ/T6Ew0fi09A38ofFGJkEjEgffw=; b=TTxCdhd37xrPsWen86mS+Tf/+zJ8fXbdeOfhXzKZx5/pBhBXRCQClbDLtgUVxXYa8OGn3L CXQq0JgcYPzdH+52ZusgNEIJVB5quQ/PvJY0VVMUq2KD7ACK+IN5Z5ref9Lhm9TxkHw5Lj pTGvmlt7a3HSAJ4XlOuu1oIpKVHHSzE= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-5yEXaqhRNsqIKNRsVS1Lsw-1; Tue, 14 Jan 2025 12:53:46 -0500 X-MC-Unique: 5yEXaqhRNsqIKNRsVS1Lsw-1 X-Mimecast-MFC-AGG-ID: 5yEXaqhRNsqIKNRsVS1Lsw Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 91E941955D80; Tue, 14 Jan 2025 17:53:42 +0000 (UTC) Received: from vschneid-thinkpadt14sgen2i.remote.csb (unknown [10.39.192.55]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BE4B5195608A; Tue, 14 Jan 2025 17:53:14 +0000 (UTC) From: Valentin Schneider To: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-perf-users@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Cc: Josh Poimboeuf , Juergen Gross , Ajay Kaher , Alexey Makhalov , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Boris Ostrovsky , Pawan Gupta , Sean Christopherson , Paolo Bonzini , Andy Lutomirski , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juri Lelli , Clark Williams , Yair Podemsky , Tomas Glozar , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Kees Cook , Andrew Morton , Christoph Hellwig , Shuah Khan , Sami Tolvanen , Miguel Ojeda , Alice Ryhl , "Mike Rapoport (Microsoft)" , Samuel Holland , Rong Xu , Nicolas Saenz Julienne , Geert Uytterhoeven , Yosry Ahmed , "Kirill A. Shutemov" , "Masami Hiramatsu (Google)" , Jinghao Jia , Luis Chamberlain , Randy Dunlap , Tiezhu Yang Subject: [PATCH v4 02/30] objtool: Flesh out warning related to pv_ops[] calls Date: Tue, 14 Jan 2025 18:51:15 +0100 Message-ID: <20250114175143.81438-3-vschneid@redhat.com> In-Reply-To: <20250114175143.81438-1-vschneid@redhat.com> References: <20250114175143.81438-1-vschneid@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A25B2180009 X-Stat-Signature: pnerm3k3dcphy4gyutdwnn5fo7f1t7fa X-Rspam-User: X-HE-Tag: 1736877231-159100 X-HE-Meta: U2FsdGVkX1/icmGwiqnAEM/CCo4rYHTiZ7jwgxTJ9eVVYA/Ns5tmQA8qwRfMoDPNzuZx1vM/drFVKYznx2fHoKJfZyJMGfO+CvwoBKdEMmUiDQTH1o4/KqNJKh9DC2AFBawVIvmCr8dJXZ3S6cepooZfKsAEPfd9XNTVsdWbEX2OZsQTYdtj1aCSmhq7712wjGByRSvQkG554uJbdDYvxMPjLcyekdxKn1twPYs8js/62hdGX9Q/5vquIs0Xi1GeHmEeBFChG2cAlReGBX+icbVieM3kcmhyXet/6RjNIaLZFT+wyOgRYYRY5H8Y4oR0UCeDH79Kcb19IL5ZjNLI2PuVXgOF9f2APuWvnY6LqXpI7684A/SJM12iF8tIiZ70DKahn2MWCFFAqreUgRJZiKo0NlNXGqSt4ZjLaYNalFeB6FZxL/dAtVhjHAFXeevB+qjc7oYthdlSYxORWw9kPW7TayyEDJpmm3LrS95iyEFUhPhLokCaqUgKfZ8zyLIosQycKH7U5AHxG5cYDGJEh0d7Vztd7EPk/jolLFTGPf4bF10V8ulqozRoaEb2gMnrjT3H6YPQmW9aWefORoEoSWDecL5mc3xVnn+xO22pwvYXYW6VVLJMebjr77nFlW4PrRg3PVgvGR67bUuamMp5O6mSLjBLzcLF2XGnfEJjgbk1LMKbQxr3OhOpppp23eu0uKxmSMGDUC4/Z8pb+H7q3n6HzxLIrW5WnXsPvuBw79sTJEufLr5NL8R4pmquXwtyEnXOgMqCRJ+ca0HZelLQsMQWefG50Z9I3nq+hhKUBxw0bGCMSa+paj+zz/VM8LhhjR7aZQnzvZvtcphFq9yMf237Z9qP/1HWSHZvYk6w1FPVNZdxrqvolYehiCOlpW1EipvcfrutIvSqF0cR9ph8jkraqvDSEpn8EHG979yZzpjO9nmyOVmFOTWj+lgYywMi7n2yxISQCQv+e3Zyweq mch1fGoK kJZoQaJ+AOMNQaukWtrBcxsItmjU/dgo4e8IP9ILkTprYZUOGL7m9sDwMbJvi/Vr1IjWI8pSAqqkw0Xol/wIO/j6/PGOAAgDQiCR/E+zRMUkfthPTg4N5xdaV8NwmHdB1OJZ0vckbZ8v5NtmFG1DRcwLQRj7Fxp6mZpvxaC3XS138SVNED4qgWvPEbjlAwFgWT0U1ISp11gi9oXTwg4dfoLCz2KyHMS4POtS6ovUyflv2UFix3y14XhIGbU5tLXHB5/cc0uKDBnFQgmrMNB/BfJvfnvp9JRIQm8spNhpQZGu9KZ6ks+84czQL8BhY66tOSBVZ0Wc1HYJcT+MKqhijLcCTgBYwz7ffZBr9TFZ8jdEVTZW4gL/zbuflTZrxpQBpHf+/Uj1yTp0sP/cQ7SbhdqR5vdrBbsFO+K9VfVECMkIU8COlwFrMqDxO/JzyY5vvV6vGFVdIvzInAH4sdwkCLQ7o3hx5psXoyJy9Y8HxfhrTUMI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: I had to look into objtool itself to understand what this warning was about; make it more explicit. Signed-off-by: Valentin Schneider Acked-by: Josh Poimboeuf --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index b35763f05a548..6aa9259fc9940 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -3486,7 +3486,7 @@ static bool pv_call_dest(struct objtool_file *file, struct instruction *insn) list_for_each_entry(target, &file->pv_ops[idx].targets, pv_target) { if (!target->sec->noinstr) { - WARN("pv_ops[%d]: %s", idx, target->name); + WARN("pv_ops[%d]: indirect call to %s() leaves .noinstr.text section", idx, target->name); file->pv_ops[idx].clean = false; } }