From patchwork Wed Jan 15 02:17:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexei Starovoitov X-Patchwork-Id: 13939758 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29EE1C02183 for ; Wed, 15 Jan 2025 02:18:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0E646B0088; Tue, 14 Jan 2025 21:18:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABFFB6B0089; Tue, 14 Jan 2025 21:18:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95FAD6B008A; Tue, 14 Jan 2025 21:18:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 75EFB6B0088 for ; Tue, 14 Jan 2025 21:18:01 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 074F61A0F22 for ; Wed, 15 Jan 2025 02:18:01 +0000 (UTC) X-FDA: 83008075962.10.4995DC4 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf28.hostedemail.com (Postfix) with ESMTP id 1C1E8C000E for ; Wed, 15 Jan 2025 02:17:58 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RvjhG6RC; spf=pass (imf28.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736907479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RRfQnK0Xbq5jILYR704HtD9aPWYF0UoBSTHx/j1KDDk=; b=YKFeL78qubPqLM2UbgOv+ZuSAfbICgj7FkM03pE4h2fCUtPwl/DlbQ8IrRxJD6tdhC6uVx MNwZvTJwoZ9eMLkn9jj+IOVLIJj88QQTpUzk13fbZ73HFHJcdbzgyhUI20c8vqJRnTqR+S rNGV1pnbw01sZqXgtCcyEKdAhNdSVS4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736907479; a=rsa-sha256; cv=none; b=4sNJk5bQWRix0fXM5Xa1bOnw/itJfQLgUpJKEM5GPHhfMV6K0nY/Ss+BPoEbBnoyzxO1xK eCwkk7LPUrnw4akNXmdLSsd/mHjc/DJOV6HpfqcbBAhw9zLZ2sGg8T/6T8rjiqYkc7Iclp 1SzSjD2O1Kn0a6Xb7dC7nH7aNo9wb2Q= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RvjhG6RC; spf=pass (imf28.hostedemail.com: domain of alexei.starovoitov@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=alexei.starovoitov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-21675fd60feso136617045ad.2 for ; Tue, 14 Jan 2025 18:17:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736907478; x=1737512278; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RRfQnK0Xbq5jILYR704HtD9aPWYF0UoBSTHx/j1KDDk=; b=RvjhG6RCnrO0lQxfNUz6HL+Cr8wMIFsWL+h8dno+hKoUQDpp074xbj57mfRIRIkV7e PzjcI5ou1VjELVcQ114VXRnFc6PaJWhK2HjIyDrUHUUeEgQTHWZWIfcotmZbV2S5xVGt ZJctob6G6Owyd05YgmuTreJYUU7U/SpAVtXosQWt59EfqcsyUCb7A7nXw5P9y9TSADEA f2NhLzCzriQIrUR/iXquV5hJarEcEZYq7iMfQgf/dzv/rmL5g2+nicBlnjTLnoeuqOOq DpTe/FSxsd/HilUcBJnzE1yOrc1149nQiIOqmOULuCmdjVWszoMXXW5/Y0hoXiScLkVB iVgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736907478; x=1737512278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RRfQnK0Xbq5jILYR704HtD9aPWYF0UoBSTHx/j1KDDk=; b=s2w3e82r6WGDqdi2fpw9HJcMh88ySFNI7sA8XLO+biHe982DfDmpGrqxUX1eaRn5p6 Xve1XQ7Czfb6Xkn1OPN/uKf3X7glN9taloKgTY7I9FJiwn7TBCunOjN/m4RMb2VebICZ 0hltf6CIJlUErgN1vi56RExBTeFaPo6lWK8JsLK0iUChTisDfVdWm/PKZ4EN8B/8vfrs 3o/sk6IHRvXbI3H0av9LA3Pa6Asc+nR+r6Dp+Rw81cP9JWXegTBm+gzWMP3zxcu+JtZm 0MbjjP4sRt9QqKadRLqKHGTS6qsCjNbmOKXbo+0QQ//P9fUH0e//yAV0jvpxzR8/RRWU 4hKw== X-Forwarded-Encrypted: i=1; AJvYcCXeGa+d634LsZsXKXrUbfQ2lUKHRWsbWjxd0vItWM/rMRGjAJ6DHJSuoWaxVD11s3HefDZqj9Gdww==@kvack.org X-Gm-Message-State: AOJu0YzrcpuCa2y1l+gPmiCaovem5xxCLE+2OjoVED83G59TUmLLVIm4 e/eFhoKQttUUt/AofyyR8FRko9A8EtgrxdbHhPZHJokjax8A1I4y X-Gm-Gg: ASbGncsy9EGRt6/lCQgEzzblsNu4cQ68WTeWI0YJxL70AEQ3YMNsZW4wswp2jA6Uvrd 0QDfHLeINzSWaK3L0IUvPubxvdBQXyhG504uHIpbjnAJHK7RweuUJFcKjVuvm8Zh3g7bjs8Lw4Z G2roT2r+MmD1RUKTBJLL6RoAByycKQJJnmK+rO6UwRIhGxvwiT1v9XygB9JgCt1IGM8kIiL7++9 vx69yfAyXpVjtNIk2XyW8pNIM9pjk2cCovcMnorZqNXytiJOSV5v4mx0ESRXCVE9BbT2KBP/xs3 QDehlhbj X-Google-Smtp-Source: AGHT+IG6Y9Bj4+sss4AkgBmGlysFV+cBK96Pvs8KQSHpwbaMp6szpurOB66PeQKEY7FIq53RepZsSQ== X-Received: by 2002:a05:6a00:35ce:b0:729:1c0f:b94a with SMTP id d2e1a72fcca58-72d220077aamr40543484b3a.23.1736907477661; Tue, 14 Jan 2025 18:17:57 -0800 (PST) Received: from localhost.localdomain ([2620:10d:c090:400::5:4043]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72d40658dd7sm8357578b3a.102.2025.01.14.18.17.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 14 Jan 2025 18:17:57 -0800 (PST) From: Alexei Starovoitov To: bpf@vger.kernel.org Cc: andrii@kernel.org, memxor@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, vbabka@suse.cz, bigeasy@linutronix.de, rostedt@goodmis.org, houtao1@huawei.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, mhocko@suse.com, willy@infradead.org, tglx@linutronix.de, jannh@google.com, tj@kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: [PATCH bpf-next v5 1/7] mm, bpf: Introduce try_alloc_pages() for opportunistic page allocation Date: Tue, 14 Jan 2025 18:17:40 -0800 Message-Id: <20250115021746.34691-2-alexei.starovoitov@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250115021746.34691-1-alexei.starovoitov@gmail.com> References: <20250115021746.34691-1-alexei.starovoitov@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 1C1E8C000E X-Stat-Signature: ywz8joyb85cnyjhyy6n648zb19spga7x X-Rspam-User: X-HE-Tag: 1736907478-190878 X-HE-Meta: U2FsdGVkX18maOm3gWmKywkSgHJNR+2NAuZ0dY/axeuZAmHHNNWibQFZc0OuSCDgTWPWglKu8/PHLEIInV7ZCMPG0xXyZ2KSkl+EJ8k5JJq9BsGP/4TZG7Ytb2TwIMHTa7ZI0E0DqapAD3k2y10zxnaLC+8MHXDoUDgv57erS4/SHdq2joPcumS3BsYorX93Oz33yWZ/96M6ze4AreHEO9cMe+we9VQzKv8Dxtqd1BuTVzELb9/TaJ+eKNi1n+81ArzYkosSpyugcmZZcAUMl/6zuFltbTiaN+gDb6tn72VvUsnwQycvYVxMtropIJAgFhnpFc45AjS/dxxVtlkTEHvr1f3hfvkhvesDILpdyC2CIQPCZOwJYSVyla3uuarhKZCw19qbthKTleQWQRpABXGX6Aqf9KzEMwSDswewZG8kii1768L5grQbfkTl4TIaAyZ23v/7S7mmf029anQAHy70NFvW6B7WYEv54tlR0e1Pkn9t1nZ+4s9dbzhR+R3v00xVqCijo6DxGPoOcVEGONP9P9lgVO0H1wRQxgMikrkeI7CYHYgxNJs3pxyj2Q0AIVQFD6E9HYT2/F3YRm6V9qP41PMObbZcFTfOJFRHUclq8osqhT8CKC6cnSu3z0+wluGtD1IQYDXrT2MwE6lZwGQ4OeEQuDeOpWVNmuIpd6g/HuuEwYaJjZodT+P2LImyAP54OE8cAM2qZFuVGYMPUK4xCJ6RumEPkWhv+0nL+XdbbW3XxIdAKgsaCisxkSjvd25+ZLsIfVSZalOrM6L6Z5vGgwM4kv3/Upiw+rCF8hW2qrc0mRfAxVt93CvDCkrrBzi1HNbiqligZYEjt4OPLun+s46MOwE1ZGMnARiu4bxxzRwzbi8fbw0qoRzZ/ldWbeUl2O2ZZrijJ6Tt0bZBz2QmDBHJn1isenKMoFi53d3FrtO7nR0hO/xc8reC90R0J99nqh5h73Lhpo17v36 fu7DvQu7 hhnwJAfR363vfj6i5NmAsdmITggmjQMgiFa+typ88l3uBRX6oCLDa8pOYHvifDK0AYeT8UW1vTmsXrsJ++Ti77H2/950ISL7gXif7aoKm37fcSNrDLFllc9fROhMD9tYQ6MuMMBpdd9+ktYIbFxP+KyletYZCh6JEgx+JooUewSKyLDYHWQ0eFvZrNgc68sv2B9uBgUZPyFfJXKeb48d6mgU89dvw+EGyEvKoKJGlrOjHyhnIL/eK3QsWhK4uHa0xZF+2tp6ru/1hbs0BunhzJCbfmNeo4yBO3u3/ZRobsNO85t5PkvyD+NvyUkSTRW9mmY7p5Bzosdx1QSMu3j4as7XXI2eyHlq0W11Uumgm9jmC5HETakVQACFAhQElzq0md5cfklq6AxQHryLvZugJ0mJ2lz8fX6ZHJtgkYYQ4TSCE9H5q2pAtUxA+zNXQJold7aioh+UU90LFzA5BuJCAFeaBesziTLi0I0wYehKFJS8KWhKdmlHMglleiX5tXpwHU0HA1aFTZMOQck+n4ECrCLHLcS57I7DFDZHhou/ZWEbNoTXq9gnPZavg/mQUXCaMpWVVTTstRt7KPc1yMZR2KH2Wa7DgMShhLFGbIAHFk4C320h+TEZziT/mgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Alexei Starovoitov Tracing BPF programs execute from tracepoints and kprobes where running context is unknown, but they need to request additional memory. The prior workarounds were using pre-allocated memory and BPF specific freelists to satisfy such allocation requests. Instead, introduce gfpflags_allow_spinning() condition that signals to the allocator that running context is unknown. Then rely on percpu free list of pages to allocate a page. try_alloc_pages() -> get_page_from_freelist() -> rmqueue() -> rmqueue_pcplist() will spin_trylock to grab the page from percpu free list. If it fails (due to re-entrancy or list being empty) then rmqueue_bulk()/rmqueue_buddy() will attempt to spin_trylock zone->lock and grab the page from there. spin_trylock() is not safe in RT when in NMI or in hard IRQ. Bailout early in such case. The support for gfpflags_allow_spinning() mode for free_page and memcg comes in the next patches. This is a first step towards supporting BPF requirements in SLUB and getting rid of bpf_mem_alloc. That goal was discussed at LSFMM: https://lwn.net/Articles/974138/ Acked-by: Michal Hocko Signed-off-by: Alexei Starovoitov Acked-by: Vlastimil Babka --- include/linux/gfp.h | 22 ++++++++++ mm/internal.h | 1 + mm/page_alloc.c | 98 +++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 118 insertions(+), 3 deletions(-) diff --git a/include/linux/gfp.h b/include/linux/gfp.h index b0fe9f62d15b..b41bb6e01781 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -39,6 +39,25 @@ static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags) return !!(gfp_flags & __GFP_DIRECT_RECLAIM); } +static inline bool gfpflags_allow_spinning(const gfp_t gfp_flags) +{ + /* + * !__GFP_DIRECT_RECLAIM -> direct claim is not allowed. + * !__GFP_KSWAPD_RECLAIM -> it's not safe to wake up kswapd. + * All GFP_* flags including GFP_NOWAIT use one or both flags. + * try_alloc_pages() is the only API that doesn't specify either flag. + * + * This is stronger than GFP_NOWAIT or GFP_ATOMIC because + * those are guaranteed to never block on a sleeping lock. + * Here we are enforcing that the allaaction doesn't ever spin + * on any locks (i.e. only trylocks). There is no highlevel + * GFP_$FOO flag for this use in try_alloc_pages() as the + * regular page allocator doesn't fully support this + * allocation mode. + */ + return !(gfp_flags & __GFP_RECLAIM); +} + #ifdef CONFIG_HIGHMEM #define OPT_ZONE_HIGHMEM ZONE_HIGHMEM #else @@ -347,6 +366,9 @@ static inline struct page *alloc_page_vma_noprof(gfp_t gfp, } #define alloc_page_vma(...) alloc_hooks(alloc_page_vma_noprof(__VA_ARGS__)) +struct page *try_alloc_pages_noprof(int nid, unsigned int order); +#define try_alloc_pages(...) alloc_hooks(try_alloc_pages_noprof(__VA_ARGS__)) + extern unsigned long get_free_pages_noprof(gfp_t gfp_mask, unsigned int order); #define __get_free_pages(...) alloc_hooks(get_free_pages_noprof(__VA_ARGS__)) diff --git a/mm/internal.h b/mm/internal.h index cb8d8e8e3ffa..5454fa610aac 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -1174,6 +1174,7 @@ unsigned int reclaim_clean_pages_from_list(struct zone *zone, #define ALLOC_NOFRAGMENT 0x0 #endif #define ALLOC_HIGHATOMIC 0x200 /* Allows access to MIGRATE_HIGHATOMIC */ +#define ALLOC_TRYLOCK 0x400 /* Only use spin_trylock in allocation path */ #define ALLOC_KSWAPD 0x800 /* allow waking of kswapd, __GFP_KSWAPD_RECLAIM set */ /* Flags that allow allocations below the min watermark. */ diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 1cb4b8c8886d..74c2a7af1a77 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2304,7 +2304,11 @@ static int rmqueue_bulk(struct zone *zone, unsigned int order, unsigned long flags; int i; - spin_lock_irqsave(&zone->lock, flags); + if (!spin_trylock_irqsave(&zone->lock, flags)) { + if (unlikely(alloc_flags & ALLOC_TRYLOCK)) + return 0; + spin_lock_irqsave(&zone->lock, flags); + } for (i = 0; i < count; ++i) { struct page *page = __rmqueue(zone, order, migratetype, alloc_flags); @@ -2904,7 +2908,11 @@ struct page *rmqueue_buddy(struct zone *preferred_zone, struct zone *zone, do { page = NULL; - spin_lock_irqsave(&zone->lock, flags); + if (!spin_trylock_irqsave(&zone->lock, flags)) { + if (unlikely(alloc_flags & ALLOC_TRYLOCK)) + return NULL; + spin_lock_irqsave(&zone->lock, flags); + } if (alloc_flags & ALLOC_HIGHATOMIC) page = __rmqueue_smallest(zone, order, MIGRATE_HIGHATOMIC); if (!page) { @@ -4509,7 +4517,8 @@ static inline bool prepare_alloc_pages(gfp_t gfp_mask, unsigned int order, might_alloc(gfp_mask); - if (should_fail_alloc_page(gfp_mask, order)) + if (!(*alloc_flags & ALLOC_TRYLOCK) && + should_fail_alloc_page(gfp_mask, order)) return false; *alloc_flags = gfp_to_alloc_flags_cma(gfp_mask, *alloc_flags); @@ -7023,3 +7032,86 @@ static bool __free_unaccepted(struct page *page) } #endif /* CONFIG_UNACCEPTED_MEMORY */ + +/** + * try_alloc_pages_noprof - opportunistic reentrant allocation from any context + * @nid - node to allocate from + * @order - allocation order size + * + * Allocates pages of a given order from the given node. This is safe to + * call from any context (from atomic, NMI, and also reentrant + * allocator -> tracepoint -> try_alloc_pages_noprof). + * Allocation is best effort and to be expected to fail easily so nobody should + * rely on the success. Failures are not reported via warn_alloc(). + * + * Return: allocated page or NULL on failure. + */ +struct page *try_alloc_pages_noprof(int nid, unsigned int order) +{ + /* + * Do not specify __GFP_DIRECT_RECLAIM, since direct claim is not allowed. + * Do not specify __GFP_KSWAPD_RECLAIM either, since wake up of kswapd + * is not safe in arbitrary context. + * + * These two are the conditions for gfpflags_allow_spinning() being true. + * + * Specify __GFP_NOWARN since failing try_alloc_pages() is not a reason + * to warn. Also warn would trigger printk() which is unsafe from + * various contexts. We cannot use printk_deferred_enter() to mitigate, + * since the running context is unknown. + * + * Specify __GFP_ZERO to make sure that call to kmsan_alloc_page() below + * is safe in any context. Also zeroing the page is mandatory for + * BPF use cases. + * + * Though __GFP_NOMEMALLOC is not checked in the code path below, + * specify it here to highlight that try_alloc_pages() + * doesn't want to deplete reserves. + */ + gfp_t alloc_gfp = __GFP_NOWARN | __GFP_ZERO | __GFP_NOMEMALLOC; + unsigned int alloc_flags = ALLOC_TRYLOCK; + struct alloc_context ac = { }; + struct page *page; + + /* + * In RT spin_trylock() may call raw_spin_lock() which is unsafe in NMI. + * If spin_trylock() is called from hard IRQ the current task may be + * waiting for one rt_spin_lock, but rt_spin_trylock() will mark the + * task as the owner of another rt_spin_lock which will confuse PI + * logic, so return immediately if called form hard IRQ or NMI. + * + * Note, irqs_disabled() case is ok. This function can be called + * from raw_spin_lock_irqsave region. + */ + if (IS_ENABLED(CONFIG_PREEMPT_RT) && (in_nmi() || in_hardirq())) + return NULL; + if (!pcp_allowed_order(order)) + return NULL; + +#ifdef CONFIG_UNACCEPTED_MEMORY + /* Bailout, since try_to_accept_memory_one() needs to take a lock */ + if (has_unaccepted_memory()) + return NULL; +#endif + /* Bailout, since _deferred_grow_zone() needs to take a lock */ + if (deferred_pages_enabled()) + return NULL; + + if (nid == NUMA_NO_NODE) + nid = numa_node_id(); + + prepare_alloc_pages(alloc_gfp, order, nid, NULL, &ac, + &alloc_gfp, &alloc_flags); + + /* + * Best effort allocation from percpu free list. + * If it's empty attempt to spin_trylock zone->lock. + */ + page = get_page_from_freelist(alloc_gfp, order, alloc_flags, &ac); + + /* Unlike regular alloc_pages() there is no __alloc_pages_slowpath(). */ + + trace_mm_page_alloc(page, order, alloc_gfp, ac.migratetype); + kmsan_alloc_page(page, order, alloc_gfp); + return page; +}