| Message ID | 20250116204216.106999-2-thorsten.blum@linux.dev (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/damon/core: Use str_high_low() helper in damos_wmark_wait_us() | expand |
Hello Thorsten, On Thu, 16 Jan 2025 21:42:16 +0100 Thorsten Blum <thorsten.blum@linux.dev> wrote: > Remove hard-coded strings by using the str_high_low() helper function. Thank you for this patch! > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Reviewed-by: SeongJae Park <sj@kernel.org> Thanks, SJ > --- > mm/damon/core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index 0776452a1abb..ae1715a338d4 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -14,6 +14,7 @@ > #include <linux/psi.h> > #include <linux/slab.h> > #include <linux/string.h> > +#include <linux/string_choices.h> > > #define CREATE_TRACE_POINTS > #include <trace/events/damon.h> > @@ -1894,9 +1895,8 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme) > if (metric > scheme->wmarks.high || scheme->wmarks.low > metric) { > if (scheme->wmarks.activated) > pr_debug("deactivate a scheme (%d) for %s wmark\n", > - scheme->action, > - metric > scheme->wmarks.high ? > - "high" : "low"); > + scheme->action, > + str_high_low(metric > scheme->wmarks.high)); > scheme->wmarks.activated = false; > return scheme->wmarks.interval; > } > -- > 2.48.0
diff --git a/mm/damon/core.c b/mm/damon/core.c index 0776452a1abb..ae1715a338d4 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -14,6 +14,7 @@ #include <linux/psi.h> #include <linux/slab.h> #include <linux/string.h> +#include <linux/string_choices.h> #define CREATE_TRACE_POINTS #include <trace/events/damon.h> @@ -1894,9 +1895,8 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme) if (metric > scheme->wmarks.high || scheme->wmarks.low > metric) { if (scheme->wmarks.activated) pr_debug("deactivate a scheme (%d) for %s wmark\n", - scheme->action, - metric > scheme->wmarks.high ? - "high" : "low"); + scheme->action, + str_high_low(metric > scheme->wmarks.high)); scheme->wmarks.activated = false; return scheme->wmarks.interval; }
Remove hard-coded strings by using the str_high_low() helper function. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- mm/damon/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)