From patchwork Wed Jan 22 05:57:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Senozhatsky X-Patchwork-Id: 13946863 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16060C02181 for ; Wed, 22 Jan 2025 05:59:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1638280003; Wed, 22 Jan 2025 00:59:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C6B3280001; Wed, 22 Jan 2025 00:59:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8684C280003; Wed, 22 Jan 2025 00:59:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 67715280001 for ; Wed, 22 Jan 2025 00:59:37 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3342B473D2 for ; Wed, 22 Jan 2025 05:59:37 +0000 (UTC) X-FDA: 83034035994.01.5C153CA Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf13.hostedemail.com (Postfix) with ESMTP id 5553220009 for ; Wed, 22 Jan 2025 05:59:35 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=liE1IAIj; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737525575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BvDi8LZx+/IWsVw6XTpR4rzD/goHjjTNwP1dgLi65OA=; b=AryIHSDnYHQxDLCri8Bp/PzkzfqiMC+ZQZuHzzNqyFqQkAL4E8oHyW9qgWpDu1IxGGcQhF 54Aad3h+ALDY5kpMT7PJ/Ex5QTjaE/rZ+McwxDwKZoxm0qksotRmj3qPE4PM+dPMz9DP1X rKJphHWLfi8QiSGtilvv7C9uTxWvQTA= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=liE1IAIj; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737525575; a=rsa-sha256; cv=none; b=VCwj4Rqh8VzmSHTpUxnqYdF4CDfm8DmT1/tiXzXnaXGxmHQMWn1PJ08ucR4JYXli1ySDzQ WFPl0MNNMjlM1lG7pRtnxQHHZmX1vwVKXGOtHclJihDPw5Upe1driVp3B2jTqCW9nUqKBQ 8LuSKIYg667nE145Xd5JW1YrUobJimk= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-21bc1512a63so118799135ad.1 for ; Tue, 21 Jan 2025 21:59:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1737525574; x=1738130374; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BvDi8LZx+/IWsVw6XTpR4rzD/goHjjTNwP1dgLi65OA=; b=liE1IAIje78Xs3+dj4axrRTMNC8eG56c6mZLT7mhPduhPLDErvb7HwjmfIl9UyM5T4 9OuXX5Efq4o3I4AKeXl5tyK8m3pwjgcUfgZwzL/NGYm1Pn+1tK5G8aRsjPuRkigprx8j JoH8cm9T1iXSQ7Tqqslga+2Og3ml5uiR2L8sA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737525574; x=1738130374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BvDi8LZx+/IWsVw6XTpR4rzD/goHjjTNwP1dgLi65OA=; b=Mjg9GhfuMFkDqGdd9h9VgKQnq6K1SdWOqLPtFN9WW1EncOLIpI1Pcvma8lSRSoYknU ebLED4NTGnwxf6dR28XzRu28m9saADbXZ++4V/ieEFaxEEolC6O3AQtdsh0MQoC62d8N zzuNFywlNoRMS4T4lcaSPeotvQSAWzlDBxpDt3cEqIYIBnphsyJIQ6LxiK22dQZ5Aewo YaUG+/SKnVTa/YXu9+YZYr0xK9BV2J2SsmmINy413q4mz4ZvbQSJOkcI4lYon/gw4ovD 2ZNKeWW6YK1GCumnlvizfCHwoYULxC68kJsfyGSop6J4NUeP7vUkjVOjQwbGa8oYkJQm bqmQ== X-Gm-Message-State: AOJu0Yyr7/k6wFPO0O0BUm6AffLvfbm4KwilpRRrLPP/PCfYz9epTz1f eyHDkIq+VjJaQQECJhin0s/NBrrbd+ow7YxfHWbZP9BXiYri5J/ZetDE/FboUp/XJzjgaDvlW7w = X-Gm-Gg: ASbGncsMDoyd8hZWK5bF/Nd6L4fGbsJRll8LnamFABnttND9et+ZLi7+9s9v40TUKa7 MYDZu9E7RT72Jpsay5zWBu9p8YD8nmU5U29Zq1dqyuSSaaKyCv2Jxp5i0o6irEWbUHt62nPLscd ULZqQVgEpEgJsijLnQwQcHqgI/Q/6lhg4x5LnHoT0Ed6twJOlbBgoJbVdSm+1FyV4qCzkR3FYhk iDEzQuFXOqxkemKPC8O9EUXtK8Dn758vNPG8Alp/pmdq/F+FQE/EQIkivoPtucMnpAyGTdQ X-Google-Smtp-Source: AGHT+IF5DI4LMRdnglCGj0EuJR+qLfX7sRa9uFUVFiVN11N888cUyl0GHxvq1Dybvd7Sp+FVeBy9+g== X-Received: by 2002:a17:902:ea05:b0:216:3d72:1712 with SMTP id d9443c01a7336-21c3579359cmr340704225ad.48.1737525574148; Tue, 21 Jan 2025 21:59:34 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:2902:8f0f:12b3:c251]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-21c2d4027fcsm87386355ad.214.2025.01.21.21.59.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jan 2025 21:59:33 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCH 6/7] zram: remove writestall zram_stats member Date: Wed, 22 Jan 2025 14:57:44 +0900 Message-ID: <20250122055831.3341175-7-senozhatsky@chromium.org> X-Mailer: git-send-email 2.48.0.rc2.279.g1de40edade-goog In-Reply-To: <20250122055831.3341175-1-senozhatsky@chromium.org> References: <20250122055831.3341175-1-senozhatsky@chromium.org> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5553220009 X-Stat-Signature: he54gd7gw5pfoort4rd5gadyopwzqrss X-Rspam-User: X-HE-Tag: 1737525575-230365 X-HE-Meta: U2FsdGVkX1/DihzhVbRT4bfjkagPV9FULp12mtIqVDKwR9nLta4eEtBpcp2NxNWL5AIcC8SLQRKiwyHEtKvKKTlkj+oJuz6INIFH0lM1t37d+RIq7zXhT2Tc1Ju1iQ/d8pLsVOu5SdOM64lXyyqML+GKmajDWLAFGub/4UW6pcfpU9B02soNa58Vhij5707Wv4S2ckzFKiqe8Q0sfDluFlFU2cXwtI5qUtTeDZ/e6C5VV3mox4LwlYkuEYpSRVERmzX7+aw+Vgi4WkjNlXdzjyltzpGJ4fb5POrgMzfW7sc0JHXTKo7Gd4qXNqpu1lZbPXJ36ZWRnkT1h02L7hBM3R07TRmYyejzrfW3cSH0v+/Mhbo/jLClo/3nS288yxd516zFRO6qxTXnOTMfKNNbrMw5ie5QOOtXPeYZc/CGKjOP2hqYMYHCPkiloVhx78eIuxAVylg+uYtyiTg+2vB6TIZ/SirDLxAeH+skn4RQIy3f7Ls/4sg9JgeVfJnNDgoP0hkY6lc/mP5u8Z58yR1RsUmH4w+sIoJOLPOqx3jpQW4eceX/iR6KG4qJvZYSnq6U4IB4s3Rb0f8Sif4Kx/WaZ2BmymkGECwkOtqzHMXCLjbEuMi2dBuC5Jm11tZcZiEJdFf1VyzUHNuiSyb+g1X9E8DTLxVdqb4atm+02svebYKoNaXMvOCW+PuKqrVR0rcFEjEPde0Tuv4gr8Mqn0vO4mkoqmbsv4rjfPGF7hMKV6nm8D6HZLGqQlPaTU5I2UPZI9EErT1Kqx3l5mCeEa5FvAM2M1ip8ZdCagflrt7KInkCJpir6UAQ514cdkqvCxaYdkKR9ovT52jg/gM0C4QD+WdliHaAekOJ5M3JXQrHsRz8CLST4K6nLfKbvMz7SizdNYiaGpuinUbZRftTVcP3S4akdp9IXESVGvfUyQuWfwBqmS95w8YJL7Y8K8SSGr9b+HHafEpflPE8r5/Jiy7 C+2IBYQp s1Ll2yfo/9/Bss/nVHPCTEsxxUWXLcSDRaNzV6w4vNwkSOCjLRQGTFOYvWmXrYAmnPf5QDgFmYoKq66GQQBKHoCAdS/8DNdEA+1wFgt3zxSVZ+oEoKggqBLegwHZbkXuU1cESgaib3bPSh5ZX8mK+kDKmmEXpyq+qdgBXaNAwPjWDHuOwZKi284sce4xVJjrARa65iS1cuSBrn/RP8b5oUU9pbV5ZonGyBsK/jfiKuYQZ3+ePNf3CY6PlVxZAIpuvgUKyKHvfhuD3x1EnWuL+2l/WXy+hPk8c1omUmOMIEBNeMOjH1tH+f3/nAG8CnuVwQDeghn2SzO740pkt9ETuCgHsldXpNzMcaARZ1Lt/4sla6IU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: There is no zsmalloc handle allocation slow path now and writestall is not possible any longer. Remove it from zram_stats. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 3 +-- drivers/block/zram/zram_drv.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index faccf9923391..d516f968321e 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1443,9 +1443,8 @@ static ssize_t debug_stat_show(struct device *dev, down_read(&zram->init_lock); ret = scnprintf(buf, PAGE_SIZE, - "version: %d\n%8llu %8llu\n", + "version: %d\n0 %8llu\n", version, - (u64)atomic64_read(&zram->stats.writestall), (u64)atomic64_read(&zram->stats.miss_free)); up_read(&zram->init_lock); diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h index b272ede404b0..4f707dabed12 100644 --- a/drivers/block/zram/zram_drv.h +++ b/drivers/block/zram/zram_drv.h @@ -85,7 +85,6 @@ struct zram_stats { atomic64_t huge_pages_since; /* no. of huge pages since zram set up */ atomic64_t pages_stored; /* no. of pages currently stored */ atomic_long_t max_used_pages; /* no. of maximum pages stored */ - atomic64_t writestall; /* no. of write slow paths */ atomic64_t miss_free; /* no. of missed free */ #ifdef CONFIG_ZRAM_WRITEBACK atomic64_t bd_count; /* no. of pages in backing device */