Message ID | 20250124162248.60104eec848619a187242392@linux-foundation.org (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | [GIT,PULL] MM updates for 6.14-rc1 | expand |
On Fri, 24 Jan 2025 at 16:22, Andrew Morton <akpm@linux-foundation.org> wrote: > > Linus, please merge the MM updates for the 6.14 development cycle, This does not build at all for me. I get ./arch/x86/include/asm/current.h:49:9: error: call to undeclared function '__typeof_unqual__'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] when running the Rust 'bindgen', and what seems to be going on is that my version of *gcc* does support __typeof_unqual__, so I end up with CONFIG_CC_HAS_TYPEOF_UNQUAL=y in my kernel config, but I think that 'bindgen' that generates the Rust bindings is based on LLVM, and clearly does not understand __typeof_unqual__. I have bindgen 0.69.5 (plain F40 install), in case somebody wants to test. Apparently few people test linux-next with Rust enabled, and the reports that I find on lkml were ignored. I do see reports of this failure on lkml from mid-December, so it's not like I'm the first person ever to see this. Anyway, pulled and then unpulled again. Linus
On Sat, 25 Jan 2025 14:09:16 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote: > On Fri, 24 Jan 2025 at 16:22, Andrew Morton <akpm@linux-foundation.org> wrote: > > > > Linus, please merge the MM updates for the 6.14 development cycle, > > This does not build at all for me. > > I get > > ./arch/x86/include/asm/current.h:49:9: error: call to undeclared > function '__typeof_unqual__'; ISO C99 and later do not support > implicit function declarations [-Wimplicit-function-declaration] > > when running the Rust 'bindgen', and what seems to be going on is that > my version of *gcc* does support __typeof_unqual__, so I end up with > > CONFIG_CC_HAS_TYPEOF_UNQUAL=y > > in my kernel config, but I think that 'bindgen' that generates the > Rust bindings is based on LLVM, and clearly does not understand > __typeof_unqual__. > > I have bindgen 0.69.5 (plain F40 install), in case somebody wants to test. > > Apparently few people test linux-next with Rust enabled, and the > reports that I find on lkml were ignored. > > I do see reports of this failure on lkml from mid-December, so it's > not like I'm the first person ever to see this. > Well dang, nobody told me, and I assume Stephen didn't find out. Guys, if tree owners are carrying bad patches, please do give them a heads-up! > Anyway, pulled and then unpulled again. OK, I've dropped Uroz's series "Enable strict percpu address space checks", shall resend the pull request soon. And I shall continue to scratch my head over Documentation/rust/quick-start.rst.
On Sat, 25 Jan 2025 at 21:00, Andrew Morton <akpm@linux-foundation.org> wrote: > > And I shall continue to scratch my head over > Documentation/rust/quick-start.rst. It really should be as simple as installing the proper distro packages, and then "make allmodconfig" will enable Rust. It used to be much more complicated. So do the pacman / apt / dnf / emerge / zypper command line to just install the packages, and off you go. Of course, that assumes you have a modern enough distro that it _has_ sufficiently up-to-date rust packages. So if you are on something like Debian stable, it's simply not worth the pain. Linus
Hi all, On Sat, 25 Jan 2025 21:00:16 -0800 Andrew Morton <akpm@linux-foundation.org> wrote: > > On Sat, 25 Jan 2025 14:09:16 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote: > > > On Fri, 24 Jan 2025 at 16:22, Andrew Morton <akpm@linux-foundation.org> wrote: > > > > > > Linus, please merge the MM updates for the 6.14 development cycle, > > > > This does not build at all for me. > > > > I get > > > > ./arch/x86/include/asm/current.h:49:9: error: call to undeclared > > function '__typeof_unqual__'; ISO C99 and later do not support > > implicit function declarations [-Wimplicit-function-declaration] > > > > when running the Rust 'bindgen', and what seems to be going on is that > > my version of *gcc* does support __typeof_unqual__, so I end up with > > > > CONFIG_CC_HAS_TYPEOF_UNQUAL=y > > > > in my kernel config, but I think that 'bindgen' that generates the > > Rust bindings is based on LLVM, and clearly does not understand > > __typeof_unqual__. > > > > I have bindgen 0.69.5 (plain F40 install), in case somebody wants to test. > > > > Apparently few people test linux-next with Rust enabled, and the > > reports that I find on lkml were ignored. I don't recall seeing them ... were they cc'd to linux-next@vger or me? > > I do see reports of this failure on lkml from mid-December, so it's > > not like I'm the first person ever to see this. > > Well dang, nobody told me, and I assume Stephen didn't find out. I did not get any errors in my builds. I am running Debian Testing on a PowerPC LE machine (so my x86_64 allmodconfig builds are cross builds). $ gcc --version gcc (Debian 14.2.0-12) 14.2.0 $ bindgen --version bindgen 0.70.1 ~/next/x86_64_allmodconfig$ grep -E '(CONFIG_CC_HAS_TYPEOF_UNQUAL|_RUST)' .config CONFIG_RUSTC_VERSION=108300 CONFIG_RUST_IS_AVAILABLE=y CONFIG_RUSTC_LLVM_VERSION=190104 CONFIG_CC_HAS_TYPEOF_UNQUAL=y CONFIG_RUST=y CONFIG_RUSTC_VERSION_TEXT="rustc 1.83.0 (90b35a623 2024-11-26) (built from a source tarball)" CONFIG_HAVE_RUST=y CONFIG_RUST_FW_LOADER_ABSTRACTIONS=y CONFIG_BLK_DEV_RUST_NULL=m CONFIG_SAMPLES_RUST=y CONFIG_SAMPLE_RUST_MINIMAL=m CONFIG_SAMPLE_RUST_MISC_DEVICE=m CONFIG_SAMPLE_RUST_PRINT=m CONFIG_SAMPLE_RUST_DRIVER_PCI=m CONFIG_SAMPLE_RUST_DRIVER_PLATFORM=m CONFIG_SAMPLE_RUST_HOSTPROGS=y CONFIG_RUST_DEBUG_ASSERTIONS=y CONFIG_RUST_OVERFLOW_CHECKS=y CONFIG_RUST_BUILD_ASSERT_ALLOW=y