Message ID | 20250124182140.2243862-2-mclapinski@google.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6971FC02181 for <linux-mm@archiver.kernel.org>; Fri, 24 Jan 2025 18:21:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D151C28008A; Fri, 24 Jan 2025 13:21:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC50B280079; Fri, 24 Jan 2025 13:21:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B666E28008A; Fri, 24 Jan 2025 13:21:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 90859280079 for <linux-mm@kvack.org>; Fri, 24 Jan 2025 13:21:52 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 477D5B1C87 for <linux-mm@kvack.org>; Fri, 24 Jan 2025 18:21:52 +0000 (UTC) X-FDA: 83043164064.21.1E12F0A Received: from mail-ed1-f73.google.com (mail-ed1-f73.google.com [209.85.208.73]) by imf18.hostedemail.com (Postfix) with ESMTP id C75B91C0011 for <linux-mm@kvack.org>; Fri, 24 Jan 2025 18:21:49 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=m0n29oL4; spf=pass (imf18.hostedemail.com: domain of 3PNqTZwoKCIMtjshwpuzrpnvvnsl.jvtspu14-ttr2hjr.vyn@flex--mclapinski.bounces.google.com designates 209.85.208.73 as permitted sender) smtp.mailfrom=3PNqTZwoKCIMtjshwpuzrpnvvnsl.jvtspu14-ttr2hjr.vyn@flex--mclapinski.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737742909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MTdaJMw+GE/ToWZXQwf98N8OcNSfcH4MlIjaDI1DCcU=; b=qwBQhZ4/y72OFN4VbuzJ/RFbiLnT+cTEYeCFTbMBKp+V+migczyCbnKfj0V8lq6VqgNRBZ A3YQql/5X8E86/quT1rfaS6SrNtcExS8VXEwS7m0ZRvJtb8taXBJj27sESIDwIFiqIzydw 5zbxQE29COHymtBpTSCoJOU7GDhiXCs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=m0n29oL4; spf=pass (imf18.hostedemail.com: domain of 3PNqTZwoKCIMtjshwpuzrpnvvnsl.jvtspu14-ttr2hjr.vyn@flex--mclapinski.bounces.google.com designates 209.85.208.73 as permitted sender) smtp.mailfrom=3PNqTZwoKCIMtjshwpuzrpnvvnsl.jvtspu14-ttr2hjr.vyn@flex--mclapinski.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737742909; a=rsa-sha256; cv=none; b=11Wj0NdUL2E5wuo/t7wjnUvYO81uXTMlxFQrVUj2b2dExX5zw/U7CN1QLfxIU04ifHGnKs L0nTrz6xwDjyUOopxPIvW7+I22eUWieGIjqm2Aa24jFKVrGfwi0xkPozCRVzgzj36VG5Fd RIwrvwVWTZQs4uaITC4ZocYgyTIMywU= Received: by mail-ed1-f73.google.com with SMTP id 4fb4d7f45d1cf-5d3ff3c1b34so3280922a12.1 for <linux-mm@kvack.org>; Fri, 24 Jan 2025 10:21:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1737742908; x=1738347708; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MTdaJMw+GE/ToWZXQwf98N8OcNSfcH4MlIjaDI1DCcU=; b=m0n29oL4Oak99kz5Z07Nc4lmO7eun7R8LKZarOXDRezqUSN+bfFO2WfybvZ+u+YZgG yTK2fMR7ZYyLn6xF3hGlo1Qpm43MfzbuCVjNbgt+J20Ixql7ghlhtuSjFQzFBQLB4mV8 yEYpw5vAtG6Q2bKQuuCK670UQHZ97pL5MxNL3zXQ8/HJjM5X2NIk2svtddagR1PWIMk+ 5tgCPgfXERTQLxwGa5o4rCYme6bPxHEkjY+JR8qVA5xI4MCCB/vP46DOGz5r0xf1KqYp PLnjwF8raKgm/QcDXEs3QnVtoHBGizLOWYWtfJyscjTkZqKSMlPJpEyX5a2+rjgpwE6A cGbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737742908; x=1738347708; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MTdaJMw+GE/ToWZXQwf98N8OcNSfcH4MlIjaDI1DCcU=; b=JIbGoqibzgG/MN3+EHkC3i+JFWN6P/IrXNi82pRr8ny1ahJvkbN3twXksnZB7ibVMD e1tmw3KZ6IcuU4zxa6MYuFFufLSkQi9TLZShksypBeiKDAVxB7eagm62T29mHT9qX656 XP7nArOHQCdtZhulGrrueboB7q5Y5O1NIcL7fFse04tomgGKuXA3wtmKi2U23W3k+7aC ivaiT7XcZtp1pr2oh/cyUkZqgK8/UjEqIcSiz1QRJ2hOrDpnT/HZCPmWGm9NjsYlrEMF YI4p5qTezapmcrtTGSKHopgU9lIrWqMvJTX1deRqLYhdQOx6PSjrQdRs/ywfax5Nv82l sopw== X-Gm-Message-State: AOJu0YxWzzBdSawSpzopzZ79sCJYGug67zxnq7Hy2kDdP/1qJwPp7ldq yeqhSAGNkJh2kLQ+GnWz4cPnSsdlzNJ45GI+7kioqZVKTGgj/cZE/d5dgnQL6Sgg1/rkyTm1ovn VObhCkpEN7U9JIzHZOg== X-Google-Smtp-Source: AGHT+IGlll3ZJRgeYACjNMmQxU9JVECoCUtaZdkmY0U4Nk6wmeTTDMDT8oLJGMhd1iCVoe1QMCnpb3RypI8fcHaV X-Received: from edbds6.prod.google.com ([2002:a05:6402:1cc6:b0:5d9:12d3:9537]) (user=mclapinski job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:358b:b0:5dc:21a9:d0f1 with SMTP id 4fb4d7f45d1cf-5dc21a9d13bmr896896a12.14.1737742908471; Fri, 24 Jan 2025 10:21:48 -0800 (PST) Date: Fri, 24 Jan 2025 19:21:39 +0100 In-Reply-To: <20250124182140.2243862-1-mclapinski@google.com> Mime-Version: 1.0 References: <20250124182140.2243862-1-mclapinski@google.com> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog Message-ID: <20250124182140.2243862-2-mclapinski@google.com> Subject: [PATCH 1/2] mm/compaction: remove low watermark cap for proactive compaction From: Michal Clapinski <mclapinski@google.com> To: Andrew Morton <akpm@linux-foundation.org>, Nitin Gupta <nigupta@nvidia.com>, Pasha Tatashin <tatashin@google.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Clapinski <mclapinski@google.com> Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C75B91C0011 X-Stat-Signature: 1nocmpqmeio1rbig5zqyd57rzuotxpym X-Rspam-User: X-HE-Tag: 1737742909-191530 X-HE-Meta: U2FsdGVkX1+2R8CW/HH0pkX1RIU93fQ7jT2jd+2cTchtsTMVkCBClF9VoQyZt3fDYjNZdEEJjnd5eoXh/rSMz+9t0X9TmfIA8b+rVB6A2QMjtokM1Y0AsJaoHn/jrsfXpVqQNCVLl+0uakESlELxszBaEiTkLlnRZKXAwpkY3KuKQyfzjrkIC6KOkT70P4QmPAOMEfFH2EA7zAYFf531b8hTac6AsKxhQfvuKi2EAvcO6VBV75Jqly+v3+ewrId1/jsTQ3HttIwIvXL+RacsLwXv608zCL/kTRJHnuoapeYR2ywI10GXMwiYdR5qh6w6kG4PctytpGO+WDIHmsR+cBhdKYdFXR6RG/fs8tOTQbUBW8RIUNywjLpjfgQty3zSjG1qrFwaVIXCyyOunhJdDjUTeQy5aJ/qiClGTyz7kOL7kRMj8oUvrWh6NcI0tRixNPxgrU37AGymiveqaYXvjR1GJc3sx+J0QwDkBtv7eTBQshVw5akt7e5CZvRdSfKuxdnsQM9G12QcYh6Y50bLZrlp5dpUwVPKznRHWA5GX5SWBwgsE4ZuXV9TeNa/YpuW2ytsEI42+DPJfV1IO5NlR+OKrcNLLMt+MnGCjlfkAKXMN6ox5MtIVfcXLGLYIU3zumcnTE8YwmIDys5pqmNPxvmy/+cX/wx1xl8hjr79ogAzNi1Ke8QmpGESTxPnqSovn2TthKaByPfei/oBUcrJKtZmnxp4AXiDIvi8RJmSC8++XhRAkX4SLAvcD432RIjifM1TunmvqMJZ1ikY5L6uCZ3i07Brt/rrD1XbmKGqHRDyRIyUzNQjRWKAya8BYvFmicX7bh+2p9ImQCrzI5E+S+Eh5doCE/IMIt4xX0Ti47AlCvgxWUmUHi3Vppt/sqgrtKRgRKJ8wNKk0Bye/REkc6021DDxLnIkaSo8aeGagORcYS9CQvnwCmCc1qgNPJhHZgY2B81pqvFsLXLO5zo dTyvX4ZS lhrov0P23JmwXn6BCEUzxcaD5mXzioos2v01OB1wdXfJAEzWpcM/5h8boq5TH8rPQf2eKpTOlNtiWWDw4uuGf2ZEfj7qR2iQ+I/+i1cIk/nLReRoLn4uNzEW4NEXVl0S/LS3Y4vJli8E3vTLUx4pqv5M1xbtnCgIM/7GpuK8dhO7uU+ORehGBKeJlnhQibNcM0y/NnYPHJXEIGEqPl8mLMdrTVLqZsq49XAL+l013s9V0NPUnT/NxgDUzJarg3mCkBLPPwzGXXFNl3Z0ldwofBR4zRejFKF8/+FSgHG+1+IB06lfUA8QelizaNxKhI/CRLmvBAMEu/RNsOfpLzENQVpxigD0FCMf0nkXDyk7m2A5pQnLWUnOX59Pj+bYdlJb52YW5U5MZUmBAXR6tstKKtkNF58dW4BZuzr3xHHmUL1oK/QEfedWsN+2GK2GaueTHvLk3tQFOfHpABimG2sTEmxdVZqiyCThFPPBGUPRj2R/e0vJv8C/BXt1ufSIrKKePqTf/+JReU+XupWcA83kxWWs8hZmlyz2LgbB9WrriavVB9fE+q1lxV8Qh9gOS6zHIH6pD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
mm/compaction: allow more aggressive proactive compaction
|
expand
|
diff --git a/mm/compaction.c b/mm/compaction.c index a2b16b08cbbff..29524242a16ef 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2253,7 +2253,7 @@ static unsigned int fragmentation_score_wmark(bool low) * activity in case a user sets the proactiveness tunable * close to 100 (maximum). */ - wmark_low = max(100U - sysctl_compaction_proactiveness, 5U); + wmark_low = 100U - sysctl_compaction_proactiveness; return low ? wmark_low : min(wmark_low + 10, 100U); }
Previously a min cap of 5 has been set in the commit introducing proactive compaction. This was to make sure users don't hurt themselves by setting the proactiveness to 100 and making their system unresponsive. But the compaction mechanism has a backoff mechanism that will sleep for 30s if no progress is made, so I don't see a significant risk here. My system (20GB of memory) has been perfectly fine with proactiveness set to 100 and leeway set to 0. Signed-off-by: Michal Clapinski <mclapinski@google.com> --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)