From patchwork Mon Jan 27 07:29:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Senozhatsky X-Patchwork-Id: 13951028 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A68CC0218C for ; Mon, 27 Jan 2025 07:30:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9981280128; Mon, 27 Jan 2025 02:30:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A48292800DA; Mon, 27 Jan 2025 02:30:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E999280128; Mon, 27 Jan 2025 02:30:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 726482800DA for ; Mon, 27 Jan 2025 02:30:25 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2ACD512200C for ; Mon, 27 Jan 2025 07:30:25 +0000 (UTC) X-FDA: 83052408810.28.4D667F4 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf07.hostedemail.com (Postfix) with ESMTP id 53B434000D for ; Mon, 27 Jan 2025 07:30:23 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SfEzD7IJ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737963023; a=rsa-sha256; cv=none; b=HCKePmr8hv/FzY+8CuZUwGFLSq6Bz7VPJ3AO75OaclmP0AzFbC/2neoKpEDeUtw0MeTJzk 1wJbSLXMBG3QPq1tnzWBlynZXXQrLguig4SjcHcgGsM2JXquwS2OiW9toNSPsvFEyUyVRT jCF/Ezzi+QPcDEQtp7F5PjN+kn6zDNA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SfEzD7IJ; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf07.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737963023; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kSgdSt89nTEWoMlDHQC4zKaDJjnbZfjCeF+nCuROQ6c=; b=wndLDVUxjES+FdSAq2TpEmLZa6MKb3BTNDIViMVxkck3rNfgc8NOfURiNFnurVQWesTK76 OIW7GAuuzQ0/q+CGm4h+tm1EmzJgNj5L6oW4yWpGWayKMnUuKWaNhZw7JzAig8ROWicUV2 atD6pn+XmVUMUH5sw9RKVSqTnV4MCCQ= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2164b1f05caso68078395ad.3 for ; Sun, 26 Jan 2025 23:30:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1737963022; x=1738567822; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kSgdSt89nTEWoMlDHQC4zKaDJjnbZfjCeF+nCuROQ6c=; b=SfEzD7IJKwYIATMCTkJX7+qV0H6yKKrwN/0qwt88cGCJo4mNYd6UDVVjtyKxIqt+Pp rpMeRRDC4Eu+Vjbu3UjdhhcIHFf9x8Dhmw6l1qe5fcIxikg3W5/zJeNVwmbg66E4Bv9W 5RC7ukmNee4Xxd5RukIHjhjhfvsJWygP6tY9M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737963022; x=1738567822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kSgdSt89nTEWoMlDHQC4zKaDJjnbZfjCeF+nCuROQ6c=; b=mhB9Y+Ncukp9DHgwRcCuTYXXtwC3zvd69AJBHPRp85q684r89A6YuaBgAy92vIuXt1 XdJxWmlfsUWo0YXPpkC8VlvZhXmFsjhXB/2zWmlcXPDIRpd+TPrlN9W602bhI46ENLl7 3fMI8qeZ+48PQIJz4iLJyiT3glowhuPH1OyaObUi3alEzdhxRuIRuOTrIwsssQscJIZ/ 5k+jE4EYp/hMElwOWMl/DR0pfnoAX16j5rOXj8KLodQPICjMVXJ+g1VdaCDu88CNc8q3 9UQTE/ci9nYVbLPiKWSsumfQm2268zv7hSb4BFCbg84KMbQp5MLBCIg4akp4YdLjSMQM A0Fg== X-Gm-Message-State: AOJu0YwtLFB0zOrGJKeRGxrA2qGBPIVDax7Fm+zkBKCvDtpfjvZpRt3b fnGELBSPRmbkgku0lovno4dx3nwpuInUylaMThpauxD6g1ZUdch8rfUJ2y4GtQ== X-Gm-Gg: ASbGncuCUv1YxnIk0z3cOfwBKlENeICTjl0rpOt323ikKPf2zGOgF+/UQJiCUnh/rpa BklBRUIVrHefqfOSxMHVZzAHdN3FaSps/uosZ/nIGvMuK+YQJ/fRavDJajW09Tn4NimJNOyAZjA KTnVUpGyySxY/1Nrgz58AeWIIM22xBjW3HG0SaH/OCKr1YOICebkkKZwAGaqNDsNckOOARb7aEl 1SvE1leta1xb412RgKudUElcAHt5SlGWogkZS3Z6ec4998o09U6lTvUJnvyF9jvKrZ+fnCcKDYx DYoerjc= X-Google-Smtp-Source: AGHT+IFJkNEfxxGm9e2mhZinKXdaG+6TaYhwskg1qiYEq63JEXJ/MVr0HkgBllV11tnfS2o+XZnVNQ== X-Received: by 2002:a17:902:cf0b:b0:216:2af7:a2a3 with SMTP id d9443c01a7336-21c3560726cmr685117125ad.53.1737963022243; Sun, 26 Jan 2025 23:30:22 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:566d:6152:c049:8d3a]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-21da3d9e092sm56864765ad.28.2025.01.26.23.30.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jan 2025 23:30:21 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton , Minchan Kim Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCHv2 8/9] zram: remove writestall zram_stats member Date: Mon, 27 Jan 2025 16:29:19 +0900 Message-ID: <20250127072932.1289973-9-senozhatsky@chromium.org> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog In-Reply-To: <20250127072932.1289973-1-senozhatsky@chromium.org> References: <20250127072932.1289973-1-senozhatsky@chromium.org> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 53B434000D X-Stat-Signature: fccmux5mxnrd9jyr4k7kzuccz7rc4bx9 X-Rspam-User: X-HE-Tag: 1737963023-111677 X-HE-Meta: U2FsdGVkX1/SE7k78DTnZuwBRSBm8bd58OogyyBtVSgKyWQo8OV6hFne2vz9OuA4pGROmRVNK3cFoGJFHLEa7SQdkhhZT+V1rbUnq+VJ0spCUqtlZAEnDt+eEb9W4M9kyt9AAcZYGQp8NszIRlmESl2+/lM+jHru3HpaEG86qZxTfAMX6Q4VdedU0KJNJ7r4vt5T1bw7GOsWBbuCOcmbEDvmdUHPjbs0Qs2CsCVscHvBSvzBIihLGaOtJu5EV9oFhgBOTOPoW8oaLZwDfGYPvbDrz/APIyABuaGXOZmi2MWGww8LpGGKE6wxvZo1/RaPBbV0fr2ZDX/WaUeon2IaYApXkTXnBZvHAE0L3N84jXuD/zMUjjWIaK8haj/a5ryEvgwCPtLIXR48NCixzBrCexFu97zRD4JkCgOHgrAFORAUn3/E8BJ5w7yO8ViOhZ3TuHu1jhZq9mCzTROl3dxQ6rxtlw5K4S6KgVJMj98nmR29iwlC8oTEsEvcOjyBnnpNbUWmtfAFOZXMC842XpNE2Z8q8BM2ORE/4xVQVdN0YRI7QnlyCtslaDTDX0kh3dZui8lmP9eYhQpY1QhmW0Uoe/m4s4U7KILDd3laMQDi+gtb+uPD4g4pxVh3ytRqtubPiarIhLZVRBMr90PxPiHNomycDAjWyVK1rJ2gCqfXCOR/Bm9+5wSAgOxj4NgYuit+E726j0fTj574CSXSkMgrcGJJNwVpNBgUyXllOrVJslz30Le+QR/Crhs4kDyb67hFY5Mlfvoz1jCvAhn70Mnp9vMe0UZzkNpdKrYSOr0cb984w6ndV7BRJc2byjYUArE7VHTwmW+5aE9p/Yg+n/U7hVtfBUbEtq/7ojK9LbexDi/27hMrEoc3i9JAKHJoKz/8PeAeZsDn42rLO7R9Txftdvu7JZD9/bdbcoT/99T0shC4eUuhmgpF6ppL/tkiBn/792iKg3YLgs1LeiNX25/ lL9FyC5b 4Xv0FloLzjc7N2DepRSqCq8H9KpDLcgoGbm4MWopT/avOp8tSlYlzCEiJk17B89m+W70BJARsQ4eMg9E/c2N9RY6qOX5sjk3WaRgSh2tpjs1ofE7hRhOtDCXlSUoVRRDkGwVB3qS5KiVNZyFz4tO+zNpFvv+6i8IjvuxLm267bmfbCKSF9UDV+JteVjrw+6pvSgqeH7tyzwOike4GpMdvxreO/2Fg6OyryM5OZCZckxOo+sxgBpZdl/i6vZZoAfo+rFZ8QI9Md9m8Z+iior3yX6yfi65lMm3coL/hgDNcYDcYnM38+D9vVnSvDPXqkVkVGBGpwZWGLDq0q7DJrCGrVRNdRG/xmDBQNzkM9NcLFqh0P1A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: There is no zsmalloc handle allocation slow path now and writestall is not possible any longer. Remove it from zram_stats. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 3 +-- drivers/block/zram/zram_drv.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 10e4c6a7735c..07cae8fe9b66 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1437,9 +1437,8 @@ static ssize_t debug_stat_show(struct device *dev, down_read(&zram->init_lock); ret = scnprintf(buf, PAGE_SIZE, - "version: %d\n%8llu %8llu\n", + "version: %d\n0 %8llu\n", version, - (u64)atomic64_read(&zram->stats.writestall), (u64)atomic64_read(&zram->stats.miss_free)); up_read(&zram->init_lock); diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h index 045032acb22f..b7e250d6fa02 100644 --- a/drivers/block/zram/zram_drv.h +++ b/drivers/block/zram/zram_drv.h @@ -78,7 +78,6 @@ struct zram_stats { atomic64_t huge_pages_since; /* no. of huge pages since zram set up */ atomic64_t pages_stored; /* no. of pages currently stored */ atomic_long_t max_used_pages; /* no. of maximum pages stored */ - atomic64_t writestall; /* no. of write slow paths */ atomic64_t miss_free; /* no. of missed free */ #ifdef CONFIG_ZRAM_WRITEBACK atomic64_t bd_count; /* no. of pages in backing device */