Message ID | 20250127214627.4021412-2-mclapinski@google.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4BD2C02188 for <linux-mm@archiver.kernel.org>; Mon, 27 Jan 2025 21:46:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63C162801B1; Mon, 27 Jan 2025 16:46:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EAD22801B0; Mon, 27 Jan 2025 16:46:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B3F42801B1; Mon, 27 Jan 2025 16:46:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2C5E42801B0 for <linux-mm@kvack.org>; Mon, 27 Jan 2025 16:46:52 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D52D7B080C for <linux-mm@kvack.org>; Mon, 27 Jan 2025 21:46:51 +0000 (UTC) X-FDA: 83054567022.17.8A5D74C Received: from mail-ed1-f73.google.com (mail-ed1-f73.google.com [209.85.208.73]) by imf25.hostedemail.com (Postfix) with ESMTP id 03572A0002 for <linux-mm@kvack.org>; Mon, 27 Jan 2025 21:46:49 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CdNnlh0A; spf=pass (imf25.hostedemail.com: domain of 3yP6XZwoKCGkTJSHWPUZRPNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--mclapinski.bounces.google.com designates 209.85.208.73 as permitted sender) smtp.mailfrom=3yP6XZwoKCGkTJSHWPUZRPNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--mclapinski.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738014410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sg18kjAFZeqr6iErPKWsTCmY69Yia/6QwhH3blqcAPY=; b=u6PwGpuKLPUO9lYG9jluuO749MJ0x/IWFOUVjJGh6H8hbiUKVXW1aLhb8TFjirkfa1xeVx yQWTcburrXBBrvEojdTE286kagrK0cGCX8grkyjPOKHipnUIrSIgk+7W94I68SE7cS8iiH esu0bhxPRP9OS5bCqcGhZr2kuBcKHlU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CdNnlh0A; spf=pass (imf25.hostedemail.com: domain of 3yP6XZwoKCGkTJSHWPUZRPNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--mclapinski.bounces.google.com designates 209.85.208.73 as permitted sender) smtp.mailfrom=3yP6XZwoKCGkTJSHWPUZRPNVVNSL.JVTSPUbe-TTRcHJR.VYN@flex--mclapinski.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738014410; a=rsa-sha256; cv=none; b=umE0F3+lOgymYr+1gyDUSAn1yPsrfa2MNXq45d/cTc6fTpp0bg1Ew0MLRzvV8Gd4A1Lc7g VZSlACdE2kBZ6Mhq6CRaAwcnTIltNuKLP+HAKI/pzXDM7Nz0DTA3uhKDNrOqaJwfZ68pIr 5x0UdDd6qgOWIQEqXan8vgDdfE6ToD4= Received: by mail-ed1-f73.google.com with SMTP id 4fb4d7f45d1cf-5da15447991so3826955a12.3 for <linux-mm@kvack.org>; Mon, 27 Jan 2025 13:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1738014408; x=1738619208; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=sg18kjAFZeqr6iErPKWsTCmY69Yia/6QwhH3blqcAPY=; b=CdNnlh0AnMfytk4kvdFssTGl+MTcm6Hkr43GxD6INhjblSCa6A2h0qnpjp5yCh7AM/ a0nCCtqgqtHZ1up6Wv0v29xmK3bNzgu5VpW4B4jVVWDbrBkPvKmqK1HatQlls8Aht2He TSIXDWEnZaCwvfrEZxenEC6d1lmS3SMFBQwgU4BqkSPNeH2Qvg0IhA8EKY3cW62d4JCa LJ3JUeMByZDPIipx35Fa556tSwewi4K/vEa4DFGE/oj/iV3R0cOUN6+X/qv4jeY9lR7n uR9LIQ2zzC+7cH4EL+DXOOvTDqn9yUrMnbWzyEDP3WSoqVOw7EslgvbL8DoSwsSXzVo6 COfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738014408; x=1738619208; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sg18kjAFZeqr6iErPKWsTCmY69Yia/6QwhH3blqcAPY=; b=Qp1Ema3mgw7hy4m1tPVjf/i3dH1j8+xdnFc/5jofZiuiOXe2CqDtNj927VP/ETqXEZ jYL3m7PBsYQS7EdPsGhJHV3iaqk/yYCZwJfmBJBBP/5335Wv7U/ctDbFI5wp8VuJkm7v nCqRoWpaAVfVKIariVCiBbJWMaZcevfHGsW3YcyO8HZX37k3jSKfy2O2YJ4Wj+z94YmA bd4GZHHqpy+9wpeIZ7qEmA8qrRNw61PpVkmRBwoVIgTnQEJXCZ4wXymGhPXfQughr/9Q u1b27CjuDEba8RcAXbSBVIhWTJqmQGuUxEAziH1k42fk5ZAPEI4fKQOVBWAlPyqVVURY GAgQ== X-Gm-Message-State: AOJu0YwmmwlBjFN1Vl6+9ffregwlcGQHmVFtbSPq0fzOxO9uGl6qEXBD eNBA3CnjDtrWRgC4+YW2jGXtOKZsrQNDJh/Di1IyXONQ8EJfazmm2iyqvA5Jq/9HXeUYETr/gP6 AnUP8vT+4v/N15aF8qw== X-Google-Smtp-Source: AGHT+IGaiRZr4EJB8fg1nV9+CzFnJep+BrzNkzXZQp0+QI20M+WZbOx8WndefkOa65xga+7THi3tCjTck34BBOyH X-Received: from ejeh21.prod.google.com ([2002:a17:906:3995:b0:ab6:945a:f185]) (user=mclapinski job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:1e8e:b0:5dc:1059:6b2 with SMTP id 4fb4d7f45d1cf-5dc105a5ec1mr41424107a12.7.1738014408681; Mon, 27 Jan 2025 13:46:48 -0800 (PST) Date: Mon, 27 Jan 2025 22:46:26 +0100 In-Reply-To: <20250127214627.4021412-1-mclapinski@google.com> Mime-Version: 1.0 References: <20250127214627.4021412-1-mclapinski@google.com> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog Message-ID: <20250127214627.4021412-2-mclapinski@google.com> Subject: [PATCH v2 1/2] mm/compaction: remove low watermark cap for proactive compaction From: Michal Clapinski <mclapinski@google.com> To: Andrew Morton <akpm@linux-foundation.org>, Vlastimil Babka <vbabka@suse.cz>, Pasha Tatashin <tatashin@google.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Clapinski <mclapinski@google.com> Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 03572A0002 X-Stat-Signature: 1cda15gja9n9e8cjuu4tmtfkakmxirb9 X-HE-Tag: 1738014409-154352 X-HE-Meta: U2FsdGVkX188FF1LkiKZLwLNIiCx1WKV8jtXNoiZxcz/b9aSfLWqH4c/4e0PghgONZoqEWRlwMU8Uu6OR/c+9Mc79JcCHMjOiU00ONcglA8vcVnZKuU56glucVLPBTz7LPo2NZii6X7u0L8C9CZ8DVE31z2h65Yj8FEKpA4wvF//qyg85TNcgX7DLT89ca/z12WE/5Qj5Zkjh70ISsS9oFsKOFI1BIkyQ1Kr97y2HyCWGBUPVm6DjMQMdaavsz0ZSfDAu86XtKsWGXZlkViKIcmGlsNa4QmM/USW7Smvnmv/3R2sm4bL/NIHSYTGFssW8LRHEVCSG2HhlXjF09W61cdA/7DzMDPvrwPMMfaFumOCxWHyEnENJ/c+Vh+qw9uf11dtASjw9iXN6WxHbZrQGuPjoOJi/pyBPoJ3rDP6SqCjSKWzUiyMdGEb12PSQO2ZPKnrsKJ5XtkHo+HOM8AMyhirU72ZgQe4oVJKrqbzTwhy6zNNDO/5h33/LVg/LVxeumrL587YxJDz4I70aee6Gzdy4qVoVuSI9GXNCQhehM+XdduuxRXPLCUr1KS9T/CVB52r69GU6fL4a4i4eQDJJKmgpXQiY+2YS6KCtQ5ymY0Y28CTDAfpNcIe4i0Xz/DUcL1FNY+aNMDS/P8I2DYAVUvLuUyHV3iyCDNVo7gmCoFShruQwk3lFFN63EnndPK1XzPJRmCHKgHjZibtH62fsx3CQNtv+hVAJ1nxZdB3CS2MKVCHetFpy1mcNSsdGmwWkNCrtNAB/gDwYbPBCpdoQsRKqyBRE0VK0Fqo8Fr734wL4XTJlB1ktzG0lEceFeBTjq4WLh5tbPIMnc+HoD4MKXvXqwO2CPbWLfRiDxA2D8GGoOj3MpxzBujQdXiws2TdDyFrixVL4gVK1ymlnUNmIDj+EFaItJHpvlvOTZ2g9DHxbCfwsP0dVhAgFgiE1feloCDL3hIOsQGeVhjTVOL WxpNw9Be vFsc//L6LCb4E/SQp7GDUxS+PLenPsrd8f88eDOHoVfpfLeajNDPm8Rh8I33+jWXCK7Epv19vW29dZ9iywwqZZ4THDRdqMTDrEwxTwx7aoDlW/8hdPO/INv2R0FFHM1RTJryMcwwxUEWdtwIdwMGdRLrHaU+PGD8nfKLGcNQ7r+fl8fPZsoxQFmo4cyUdV7WTXDfnv3NUHiU3zKH5Bhb6oqemWzZQG6ZQ+QDLp49SLiiYqxaz9s2IRjZRC6V2TRtQZPDRPpl2jixB/GO33y3oYl+XSTYSpIcQNrEcf19cu36SbN5/kOMWtlOA505gTgIC+pHDRdbGCnlGBt4vao2N0//IdztN91z/QqKKVnG03QSFhTgyBzQ4+JnVhClrjOsp2/4cmkfUDMxdVs+PpNysIz1orG4+IMg3PLj4wD7no+MTiNUtoQSb/qeRsC2Clc7avUXb7C+rTwHasVLhxzo/ADIKpr+PuFiJ/a6MrHosohDGk/UzRIPnVHQelXi1883VFJ5ztSOBYc4Doi9eoaghQ17C3a/Kx8JdWi/LiMsuqvxC71p6jw2NfZedV7MqKPPZceAw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
mm/compaction: allow more aggressive proactive compaction
|
expand
|
diff --git a/mm/compaction.c b/mm/compaction.c index a2b16b08cbbff..29524242a16ef 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2253,7 +2253,7 @@ static unsigned int fragmentation_score_wmark(bool low) * activity in case a user sets the proactiveness tunable * close to 100 (maximum). */ - wmark_low = max(100U - sysctl_compaction_proactiveness, 5U); + wmark_low = 100U - sysctl_compaction_proactiveness; return low ? wmark_low : min(wmark_low + 10, 100U); }
Previously a min cap of 5 has been set in the commit introducing proactive compaction. This was to make sure users don't hurt themselves by setting the proactiveness to 100 and making their system unresponsive. But the compaction mechanism has a backoff mechanism that will sleep for 30s if no progress is made, so I don't see a significant risk here. My system (20GB of memory) has been perfectly fine with proactiveness set to 100 and leeway set to 0. Signed-off-by: Michal Clapinski <mclapinski@google.com> Change-Id: I007e3a02d126d3858ceecf5ce57a1c360177c37b --- mm/compaction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)