From patchwork Thu Jan 30 11:10:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Senozhatsky X-Patchwork-Id: 13954489 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D62C0218A for ; Thu, 30 Jan 2025 11:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5253C280284; Thu, 30 Jan 2025 06:12:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AFE32800D6; Thu, 30 Jan 2025 06:12:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3001A280284; Thu, 30 Jan 2025 06:12:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0C7CD2800D6 for ; Thu, 30 Jan 2025 06:12:28 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 38CD3C0EB3 for ; Thu, 30 Jan 2025 11:11:55 +0000 (UTC) X-FDA: 83063853390.25.99AFF5C Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf23.hostedemail.com (Postfix) with ESMTP id 42918140017 for ; Thu, 30 Jan 2025 11:11:53 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RzaoIwfA; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738235513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j8q0TE8Cfn/ZZzUdNtKaagvke7zTsDMFwn2syZsA7PY=; b=Jwct6f+/co6J1DzG7Dn+Wx4lPOTjo4rBlx0aM6F6RH7Rdrpd9s6k158HbojjU7UdRrBtFI rj+IY8CbCOox62HmgOKuARq6A5HHMTjdOOfxI+5o7/KLdrcGFziEMX8RfbCkULbyuaLnOj bgQqKPXjjdeoZX7/5fR90YnwdE/J3BM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RzaoIwfA; spf=pass (imf23.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738235513; a=rsa-sha256; cv=none; b=JGM2pmj9vs9nLMbog8WbYAAUdIP1mQSjrlJ1NUTvKyfyBBWODyqlUTVRBwlYOqFPzW7iV2 RjQLNEPLvwxHQM+wXinXFKP3H9x8t9VFoJGBn44CMxPpIFP5ygL/fm3/o5+quD5xwruae9 VMMB70npLqdV9YbT/cuWpr60vxzpMvk= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2166f1e589cso14903705ad.3 for ; Thu, 30 Jan 2025 03:11:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1738235512; x=1738840312; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j8q0TE8Cfn/ZZzUdNtKaagvke7zTsDMFwn2syZsA7PY=; b=RzaoIwfAJJntxSLsmC5gBZcowQs5WWg40tc8o2q7lvz4qIBEY5PHCRaiI/Lq0sFqa0 Aiqp/CzgyhjafrGTE810SwVEP58si+s1stdjeL2XPEUunSiiGQOkUcYsZ1itrCy1tAZv 7BU7yoHnenWfiZCUvS7Y8rKva61fSWgZCUAYg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738235512; x=1738840312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j8q0TE8Cfn/ZZzUdNtKaagvke7zTsDMFwn2syZsA7PY=; b=arGxECoJl+t/zLXOAuWHrJMXDVwjh9iATX+oCa89RK4Z98cnsdpdKQ0Y76XNzdhxum 7yXA9xN5cFfInGuALo8ZXvZjkqxZnH+RanCpsdEsceTLfkJTKKAn500Kj3i8bj8PEDu6 JAYyU1jMDAk44apl+ybXaJbwgKPPHqw89cwoNPCI8ztCO0Kg2hUis1PjXobvQtaTprnu oi9t/qGibq0bcKbHNQEgeq0vzUtLlYIhhoMwkMwbFBoW4lHI4bmchbdR+vfY//H9XXVM tuz+i74T5+ZOpANwvJJQtUB22BQOccYE/hQ/Rhuv741DBMFyBkAkVfeZeHSdp+edXLoi kgKQ== X-Forwarded-Encrypted: i=1; AJvYcCVaezyd06gv27KlR3G7pkiHEpoqhp4iHYeJd72H/3N7d5bSLP3NHVLdzu0H9j0zy5ot2mUnGqJCQw==@kvack.org X-Gm-Message-State: AOJu0Yz16AsBRz8kZYRe9iyN/VE9ZmkDgJBmxd2gktRN1CgJwvcFw8mD U3Ddy169MmocpOt+U1KoLDvEBZRCbMniJ/sRCYLr8jqSH3IYdB+gyw+YUFd2Ig== X-Gm-Gg: ASbGncv2Zjp8lyDl2t5Fu3Yg5Cp4jAu2zwOEoNhkL7RwF9betPRCUFpkexRyLUy6h0K Y3TvckJOP2KNkmO2QOVJ3NqWHtEpnMO1z40gjUYxnAmfaaDi608g6BcAoC/+pZbAMWjmP/jd916 GTHMOZ1k3t2GospK7Q2XdVu7FgzWwN6pBNb0oMcF9SvO74ejYkCXtL17i12tg/5EuajJ3EDdBhH 50rpk7uMMp9oRandxYmoXm29S2LmIXlsABI1nrD3Hs4sB3QPSrdNzMQ8bz5WyjGb+ZAnCRxpSOb ephPJUqc6vXQt1zb X-Google-Smtp-Source: AGHT+IERWIfj8pq2Tiil2nncQexj/06z4KXWkO06dhH+74uQD2LlR8gXztf4GGGtlqNiKmWRpbsKLg== X-Received: by 2002:a17:903:41c3:b0:215:b190:de6 with SMTP id d9443c01a7336-21dd7c49786mr81937115ad.3.1738235512078; Thu, 30 Jan 2025 03:11:52 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:d4ce:e744:f46b:4fb]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-21de31efba5sm11500615ad.6.2025.01.30.03.11.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 03:11:51 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton Cc: Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCHv3 08/11] zram: remove writestall zram_stats member Date: Thu, 30 Jan 2025 20:10:53 +0900 Message-ID: <20250130111105.2861324-9-senozhatsky@chromium.org> X-Mailer: git-send-email 2.48.1.262.g85cc9f2d1e-goog In-Reply-To: <20250130111105.2861324-1-senozhatsky@chromium.org> References: <20250130111105.2861324-1-senozhatsky@chromium.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 42918140017 X-Stat-Signature: m71qpafsf5w7i7o35xic8rasbh9ok67u X-HE-Tag: 1738235513-436188 X-HE-Meta: U2FsdGVkX1++2k5iSye5VK5W7XznpPePMqqxXYrEN9/145DiOwCvtCMzsIOiv9WTfrEGOBx+lxsAoOWKHI1EwFdmghvMYzFZ9YAOuxo/AHp5xRtYKJ8TMNVnoJULVlXYM2hVqmpGMR4+11LagT27lQA4GBbxNcUyT2L9fW2Gi0a1T4PkYsFjdsFvF9FGXO7t29E/PlPnDx8CkYLowweC+puwZp0ZR6F5wqQomd8jHnRSxr3F0CT+N1yfZauSDxTGyosVzhBABfoz7G+xO+SFPhHPLaeSpKaF8NggwMmt+rASZKkuVdgLIjQuFJ7eSxuh6hYX2TyrBo+Hk4SmYLc7Wnlx/NHkak6n+wpUJniujnqyU3141wpf7dCV4wQOtdf2omJr5Qc4bJANGeEIeFyuxfZI7xabiy1S5TQV0SI5yGYxvI1A9rjU/w4onioUgmX+kVEwVOilxA2J6UoCO85nuvBls5NPNJD14rnWRDrm1/WcQ6lUL0CpOkTbbjLf8/tSwaqU2z8HwQ0gnlVf/eXegc1SXWmtrp/XDPsSuAM11E9Ezg3T/sOO09enibdNFgbbAH8LQZJBjAIlowDJYeLvORDQxNaCSrVrSJCY96dyI6G078JR5pn73SjPvniFt1w0M2GK71liGQKaLGSYvsKrvt7O34dyb+6t/PEcaQ8D7vMyvAkGgLXeAbumcTPTYCjz/HiPUxNMSf0RcCkD33aWVF1CKfIA8cpqJQ/eZXVFmjuE/u91CODdOtt7hRVjGsPbsuoRsgI63LRHbp/cMGT557I2O/vgBjuYggN4CGHuR97fjwCVP4yvAdbM8fmv/AsAQ8Obi4UOvA6VXwcdoNmSIZ+IMf84ipbdubsjczc8EnEf/L65sOfI8DdCTKv8g2DF60p0SjkOzO6UejgZeJXIYkHJaLxK7CfI+QdYGRZ/Piq6oKtqskmyFjhfCP0jF2jqj7fNnOFTEMYDC4YQhQA IcgrO3Lz wlOtjXrv618u7DqUq53NePQf9dkF9zdp451vBXMd6qUQsFTvmYGppt8owvKu59uQC3fgWixS2Re/DRgc9sL0HRBn8hcqfJ1/u6IRd5excnLDVyfTDCxym++3WCfmAD0z6hAmKJsNeoWhvXB9k+cZtRGoERcG+APAgXUJzDAt3AcLxQnh/nKlTVfr7v6IXPMj0Z8dx9RM4Qnr9KGKW7NN668s+NET+gjZEhe0uzbiCLRzMHXzN2FKOx64jXxzyuajrcV6NShxd6zJZuOMdx6H8BUqKdOoq2qfdMED5FmWon6bv/Ig7R6KXgBRFip5qCFhOUDaCPZVCVxRTpaw3G1AMOYbgVNu46mAYrT3YdkqhjDMqnhc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: There is no zsmalloc handle allocation slow path now and writestall is not possible any longer. Remove it from zram_stats. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 3 +-- drivers/block/zram/zram_drv.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index ac8b4f47a496..af4bce1e5fe1 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1430,9 +1430,8 @@ static ssize_t debug_stat_show(struct device *dev, down_read(&zram->init_lock); ret = scnprintf(buf, PAGE_SIZE, - "version: %d\n%8llu %8llu\n", + "version: %d\n0 %8llu\n", version, - (u64)atomic64_read(&zram->stats.writestall), (u64)atomic64_read(&zram->stats.miss_free)); up_read(&zram->init_lock); diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h index 045032acb22f..b7e250d6fa02 100644 --- a/drivers/block/zram/zram_drv.h +++ b/drivers/block/zram/zram_drv.h @@ -78,7 +78,6 @@ struct zram_stats { atomic64_t huge_pages_since; /* no. of huge pages since zram set up */ atomic64_t pages_stored; /* no. of pages currently stored */ atomic_long_t max_used_pages; /* no. of maximum pages stored */ - atomic64_t writestall; /* no. of write slow paths */ atomic64_t miss_free; /* no. of missed free */ #ifdef CONFIG_ZRAM_WRITEBACK atomic64_t bd_count; /* no. of pages in backing device */