From patchwork Fri Jan 31 09:06:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Senozhatsky X-Patchwork-Id: 13955134 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE6BC0218D for ; Fri, 31 Jan 2025 09:07:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 385722800F4; Fri, 31 Jan 2025 04:07:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BD8C2800EF; Fri, 31 Jan 2025 04:07:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15EA02800F4; Fri, 31 Jan 2025 04:07:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EBDB62800EF for ; Fri, 31 Jan 2025 04:07:39 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A0EC645C69 for ; Fri, 31 Jan 2025 09:07:39 +0000 (UTC) X-FDA: 83067169038.17.F5E63BA Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf28.hostedemail.com (Postfix) with ESMTP id AE8D3C0006 for ; Fri, 31 Jan 2025 09:07:37 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=g3NVrxGv; spf=pass (imf28.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738314457; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oU99tlqEx3VP4Fr6vsoC6pVJUm4rK42GNNjPkPWz9Uo=; b=S1TQo7T1qZBPvUvMvGFh6mYB6G3u7D8n4HydOuA0jCTb3WdLCgt/ZJuUr+aftVcg0ha/lR 8A+Gl8nKVNJKfeAKXTScrYD6ZyVan/sgYoSfIIc+RVjItRvvxB3x46FfCBa7F0QspXGvw1 2N+aR+xxDWQqoZfwan/ZD5/biM0atyc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=g3NVrxGv; spf=pass (imf28.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738314457; a=rsa-sha256; cv=none; b=ZOAaJEzkvINi5fjIT49RUnD84TFL9WLTw3YQ3HGMcYWW7/JMGRt2Fu5npBlr2y7c0bvz6Q dz6g4oBPCJekfvu2XM7ywcaVaLIp2qn10mg4qFw23mJ3FC5FkHyIalTwKRNqQa8fVe9KPm O5lrFvUwRk6I8Hs6doJ5SKK8YoD8MMU= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-21669fd5c7cso29285185ad.3 for ; Fri, 31 Jan 2025 01:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1738314456; x=1738919256; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oU99tlqEx3VP4Fr6vsoC6pVJUm4rK42GNNjPkPWz9Uo=; b=g3NVrxGvHVvwzwS6W1wtCd8DeHyJCO4tXM0rdMpKpoU9E0KegE8Cr3nhmXYw4wkcYu BfAtvWoYL1ZFvNQbUPmR8fU8YaslcaVXuGnJ3cG8VxnIjBM7SziXx3piSU+jAqQS8rRl deiB2tjqg1/dRXyIGO2O0YpX7N/mA/XYbap3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738314456; x=1738919256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oU99tlqEx3VP4Fr6vsoC6pVJUm4rK42GNNjPkPWz9Uo=; b=vtB1ZVaT2rUz1H1J0J6YQhgFS31xlnennwN38leqMWCDrky25tmw9dTls8hvbX2FSX onRFr94FCGm7cAsOhA/VnEbKKINfYDIpKpkjLHoB5dDTTyURV2zshdWXySEasmfffRwR Ly5H3EWuDK+w4TP41cVHtLTtWFAIaOMvBgx2UZAv2A70bgbhpM6c4vD7awOL6Yu/perg VE96BdrZDaM1fuH0D1w7t35To5I8prX73Z8974VYxeTH795eBPFGk/taopax4kx3wncp 6KWhevP9QZHMzg13znvWMHdYKmL58HQYpoWMazHbh68lokmCDFR7ct9ZLtoHIGKenEOF 7a6A== X-Forwarded-Encrypted: i=1; AJvYcCUDPgZmpqDPaLzoGhGpDij3U/v+3F+u6w2SyRx8de9a00MfRWVw+9AZTGs+/iFnJOjQYRY1lnikQA==@kvack.org X-Gm-Message-State: AOJu0Yx5bMuUfZ/rJbTBmY4mUHfmRk7wR4WVFEMawU/B+CH6FadWlN10 04/x2+JTZEakc6mynBLxM9y3plSJ7TL19KzZHNRjlq7xm+sUwiHZAx0R3YhkCg== X-Gm-Gg: ASbGncuaON6yZXCafm4Q+veBeugFSIRHMm+8DpJWAUsWA59M0tnnh0GWgYKFGZcCw6z 7GKQSJPQbilm3iKmDQI2qWLl27Qm5ryNL+IhltwK/jjRuX2Oaiu9DSVbd/g6ttUUS95zn/abuLj EmPxMZcepgmy25hPxVEYW80yCkH544/464onYQwOJOlLoeDMwIWctuV0DubSCTbT+REFWA3NayH ZOECBmb03wyOnNQNxhFtV3lwWn8MSFXvfEAMw56xlREulcyDTsOWVa81/Y0YowJEdwnO3TzP+7e lIhQTrt++xYjACPAng== X-Google-Smtp-Source: AGHT+IGQyeOJINoq+3olFAJs8BwSF3tpMesiAuDGnBGSVFEb9/qgBFf2sNzJkKESZdssbJAVfH6Lfg== X-Received: by 2002:a05:6a21:33a8:b0:1db:915b:ab11 with SMTP id adf61e73a8af0-1ed7a640d42mr17388523637.24.1738314456497; Fri, 31 Jan 2025 01:07:36 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:c752:be9d:3368:16fa]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-72fe6a1a74esm2745081b3a.159.2025.01.31.01.07.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jan 2025 01:07:36 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton Cc: Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCHv4 08/17] zram: remove writestall zram_stats member Date: Fri, 31 Jan 2025 18:06:07 +0900 Message-ID: <20250131090658.3386285-9-senozhatsky@chromium.org> X-Mailer: git-send-email 2.48.1.362.g079036d154-goog In-Reply-To: <20250131090658.3386285-1-senozhatsky@chromium.org> References: <20250131090658.3386285-1-senozhatsky@chromium.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: AE8D3C0006 X-Stat-Signature: bj8mje5encdqfabr6a3yymhfdodqms6x X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1738314457-781057 X-HE-Meta: U2FsdGVkX19b9OEo7fjJH2rDi47WJhfnl7LmVE1YgmsdvEKyKoV5bs7h0Vzb6NKrl78pZKZ8ttSP7nnPUBhuFTr3Do0CpYDEexmzd7UHOsYw4H1xgJy+pvrPsRVYStScs+1e4e2P8v0tIYZQcJH8dgxOp0uaxIsU9EsCDLIjRNqp86jxW03gmS/VQ+Ci4D/taVaiiLes/464t/OXkMrBfE+nYsgUdnOzVIXI/YYdH21g67dSR+DXVC3CNMpSPW4q3HwzkGyuLi1pA7+cko59E1qCD7AHfUImfK95OQwAqQuCj/szTweYbSwJBSStROknnJbV3b5Vo/X0ed9nF/90FKRYVLbX9yhq1JppwgEGPpo2Q+iPcb+eohMa0tZjtPEkK7SCniU0ZmxcTN9fRb6WnowjbRUTw/z1AhmohCmAAzUy/O8l/dfqCyi/HsRcwfTWElNtBvZAhPvZ2cnGjHRsR40a1o96IGFa+Z3EjlDRbzGbnKNc40CG2nZ6SoU0riwMfJSq7c3ZVo9/Puo6LlcoOwmZk52L829Cbma1WaYjcB35qwRpiu1LUDx3VwamEjaerzIr41lXwahodmH17cmJdJbyuK4njHaHE8qWzwy9Ky8fIuPJC1zTsPqt8xO765KiLlT1I6eJgJV9eIAVQrZLO6Kghq6JRWwn9rfxA+lQjnvyeipJgKECORnPT15pMWTY833iQT1ZhGmPp95ukp8eWL5xAWr5ZCShn39z1k8s8XtAMKzD9Dsnx5pyo7hipVh70NLpmUCu7Eyuzk1MoknmHEFMhRP+lLoqSZ4QlAtr/zsG0C3z9HhUyQSEJP/UI1qHJ23iGs+7dlbJ7KqOv+/lmNu6BDGWPX1GFcZALz0PiErhlSDSshe7b5H12OJkO+CLQoE/BBJUdCw1AN3J6O8PeFphgXP4c697ZyyBwcqKSLuFNjmdSzwpI0R4wQkQ9Szvg6GWhJ6iUwOjxGChyHZ edCy/DNK /XNLaaOoBm5SA9gTdFL3wVeU7fRRhgvjZu40Sxfm7p5dMMeh4dyl6K2MHwmxHIsVE80aMAtqF2Cj9zDx1eWYj/nChNkPAWhOjb2O8mNz3rt2H9gN90XbgGNuZEG1OEmabGTbeglTstIyZKM2/y0a5pbQ0UdbSEbEAy3cIonjqozKehXXkWxgP0on6BbN9k73iBFS5IYKWpnNP6cOyhZ7Kx1wHRRRyGgWiRa2+1qdLsPo3MyQyjKhuglGhEdZZVOnzK721up+Qj1wqLH8+WTb+Hf+C/Js4TZAFvOAO5ZvDqfzXQ/aeiyf3IdYW3TcpX8ThoMAeOzVbB1aKtLHTWoGe98EV5vCEWgrWLlqidUaGdb2IsF8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: There is no zsmalloc handle allocation slow path now and writestall is not possible any longer. Remove it from zram_stats. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 3 +-- drivers/block/zram/zram_drv.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 33a7bfa53861..35fca4c468a7 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1430,9 +1430,8 @@ static ssize_t debug_stat_show(struct device *dev, down_read(&zram->init_lock); ret = scnprintf(buf, PAGE_SIZE, - "version: %d\n%8llu %8llu\n", + "version: %d\n0 %8llu\n", version, - (u64)atomic64_read(&zram->stats.writestall), (u64)atomic64_read(&zram->stats.miss_free)); up_read(&zram->init_lock); diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h index 3ae2988090b3..219d405fc26e 100644 --- a/drivers/block/zram/zram_drv.h +++ b/drivers/block/zram/zram_drv.h @@ -79,7 +79,6 @@ struct zram_stats { atomic64_t huge_pages_since; /* no. of huge pages since zram set up */ atomic64_t pages_stored; /* no. of pages currently stored */ atomic_long_t max_used_pages; /* no. of maximum pages stored */ - atomic64_t writestall; /* no. of write slow paths */ atomic64_t miss_free; /* no. of missed free */ #ifdef CONFIG_ZRAM_WRITEBACK atomic64_t bd_count; /* no. of pages in backing device */