From patchwork Tue Feb 4 23:12:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13960171 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B478C02193 for ; Tue, 4 Feb 2025 23:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E41AC28000D; Tue, 4 Feb 2025 18:12:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E12B280012; Tue, 4 Feb 2025 18:12:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AD8828000C; Tue, 4 Feb 2025 18:12:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2B2D228000D for ; Tue, 4 Feb 2025 18:12:19 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C69C41A02DD for ; Tue, 4 Feb 2025 23:12:18 +0000 (UTC) X-FDA: 83083812756.02.DFA0620 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 2C2F6C0002 for ; Tue, 4 Feb 2025 23:12:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KQXrbBpY; spf=none (imf22.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738710737; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gIJE1yXpif2CCfNIqrsdZ1ScxfCjjJhcAk10zquVIzE=; b=1iWfeZ7/XzVwf1oHAotGLG2uUNGCZ6ziiK1sY1UnFj1loOTw81o4+epayQ2r0ecrTuK2Zl h4DyThWc2QbeATGlpe36ZAeHAVA+JFsnH3X26wQ8HxOvYXzWYgfqY39+lb4KQ10fFvaYFh d5zqDNQ/38SO1GcEqVLJFLqkKmIP+o0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KQXrbBpY; spf=none (imf22.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738710737; a=rsa-sha256; cv=none; b=zwK9bEaAxpvi/xN/MsH0lbTTgS/0Rq9uoTq5cD9aua5+NBksww2CW2b21pg6lux3cirrAz HKWLJJ2HlXNOFIq3yQkUw2IX9UYvNeGEp2ord4xbgIEW06rXbWFdNcIzJt4yNLGUKxVW/q ZUkqtEYfT2jcKJMAsBKfKwyiY1kqjSI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=gIJE1yXpif2CCfNIqrsdZ1ScxfCjjJhcAk10zquVIzE=; b=KQXrbBpYImm6WQgyMBh8uZWBFd 8fhOrvLjp0Y/9fv2pHE6+OciYfileSX4qGXBfSqqNu9NuyuYUkiJofTC4mo/bfK0FpAbSt6pdDTKx e3LX6yUYJrHxU5f+VyUaDtY8raa3hM28p6lQaeocODVMM1sVq4eLRSY2ePqRtbR3cjBM79DMzRDtf TIy7gt97JTaLPvTuNE6PocSik5aH8Vu9kzVyVX86STWSLRWJtL2OlOsgBQTvjR4PpS210bT8QSeoA +Vt5POzfHSI8ksLlgyPmqy283VLaWdT45QWNdGiDEEyLEehOpBPhZEzsPXJnJ7RmgrjQYwc8UZaMj y4Uc0O/g==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tfS5T-00000001nhU-1fWW; Tue, 04 Feb 2025 23:12:11 +0000 From: Luis Chamberlain To: hare@suse.de, willy@infradead.org, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org Cc: john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com, mcgrof@kernel.org Subject: [PATCH v2 5/8] fs/buffer fs/mpage: remove large folio restriction Date: Tue, 4 Feb 2025 15:12:06 -0800 Message-ID: <20250204231209.429356-6-mcgrof@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250204231209.429356-1-mcgrof@kernel.org> References: <20250204231209.429356-1-mcgrof@kernel.org> MIME-Version: 1.0 X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspamd-Queue-Id: 2C2F6C0002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: zabt613g6c7cptkhswqkjynm1qoqay7o X-Rspam: Yes X-HE-Tag: 1738710737-180494 X-HE-Meta: U2FsdGVkX18B6LL86Siw/R22f7OvranNrs6Od2zZ150jE+HfCFOejjih+SuEgpxw/K4RskAacJ34zfjRgDMnEUxkDT2LfGiaEuFogHfEE+Jjo+In63dKDAnC6Mm+im3FNlbWqpN3f+Hy/Z5FpG4M0hOx5RkvgAkc8Yg6ULLqAFTLOubDhtSPjLtO7vvvBPkdxTR15ZIbhmuXJWPZEogRKbNQbjPQL5FAtJpm5BvK3fJgVfYh0puM2srNoZppUZz/9UBaj5MV3LoiUVoZYWGAjEj/IImD4sdIzd5K9w/Gdy0SI3nwtwjYU+Nq7bcF8Vu0pCVr9lsQh7zGVKxhRK4qkycE0yhzeJxlM8O1t/uK1FJiEQDcX8b9gUZrcgJtR2bdM1xC3tlVB8JJwZUaGU8WUak2qV+tJ08y+A95ENOqa/EyuSzuAPTdIzQczw+G7uP5PfjliSH0o7wuteMZzlYBqnkTSsW6bXYwhMuXqXxmcN+Itb9TAg53MZ9MCyxEqbGoNBSLfuZS6M++GlWPUBLdRLj/U5N/P4QE/icVvZKjguv2KsPg3LUp3+ECeQx6LhWetmp6Zv89T4nR8iRlEwZY+9DEBs7gEE+iWjdjOGqvMoD7ZbbCNNdIo1IoCQsgThmSWLus/qUvTJjL2vksTUczRTT7PdUMkQmYiM8u/f7fSGtlJ4S6QvKoXls1WR8ztPBEFKDGultZZ37HFeuJdZXWysAAcK6RjAxyVgDzAL0jXgw1Dm9lLhMeunXXrWit4EHZB0CXLYrwXIojFmtnm3VjdPJZs1QbY7r2T1mqXGRp6+x6u2yxBJD/NUE8ndE/L8Kgjxh59BIRHhrmI9Pdi5pzEmDuDJ46DZLfUMX/8vaaVB5rkGV6sD0G+FTVvlGO781gBl8XIa2387NUbiByGWFcQnUX0RKMNqvi0dvH8id3FhBkb6QdcLx5+aAve4FWPopoPIBSeLIc+M7TKKN+gpW 0+YECGlM R5mMq2U/ifV8WQlrhFkVBGum5bGAney9FrEQTYO1K/VxQDENUQs3P+ph5ijVboTM78y6x4qMO3CIIQKP5hgLSYELas2FmmSa3cpijOtqdrUVDarBv6m1oBJn1v6lSq0sJjwwwdbpC+EDAUd91SfG6LUm3QSZiBouH2kQBznGnicYQH+/6ZyzdpBQGFcmciY4fQza1ge5x8+lc76knP2gKrXNdgcxirj3ff7/6nnWlaQZkQiINRNCHmZRFVkJ7PqxGkz2vrUHX64EzfUF8+AIZrDKr0750SYmyfT2OCmlNULR3Kj79BqUajdiT7MApJ/lbtSo8x/tR/CfXl+ZmwQkdcRmKF0SkzYYTpKUSAWVJ8aNFLfNrLWNS44CmWUwRoZtF3yD4Qg4sqcnFh20Z0vuPRlP6/NkQX1V6ahdq4GSjjVgmQ68HDPIWtQO1zZlK77DlkCLTZKjfxH/5eu4Rl4fbf/rUbiXqE1uVVTyQ7qr9RX9vjkO1FC/4Ji65Xg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000332, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now that buffer-heads has been converted over to support large folios we can remove the built-in VM_BUG_ON_FOLIO() checks which prevents their use. Signed-off-by: Luis Chamberlain --- fs/buffer.c | 2 -- fs/mpage.c | 3 --- 2 files changed, 5 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 167fa3e33566..194eacbefc95 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2371,8 +2371,6 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) if (IS_ENABLED(CONFIG_FS_VERITY) && IS_VERITY(inode)) limit = inode->i_sb->s_maxbytes; - VM_BUG_ON_FOLIO(folio_test_large(folio), folio); - head = folio_create_buffers(folio, inode, 0); blocksize = head->b_size; diff --git a/fs/mpage.c b/fs/mpage.c index c17d7a724e4b..031230531a2a 100644 --- a/fs/mpage.c +++ b/fs/mpage.c @@ -170,9 +170,6 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) unsigned relative_block; gfp_t gfp = mapping_gfp_constraint(folio->mapping, GFP_KERNEL); - /* MAX_BUF_PER_PAGE, for example */ - VM_BUG_ON_FOLIO(folio_test_large(folio), folio); - if (args->is_readahead) { opf |= REQ_RAHEAD; gfp |= __GFP_NORETRY | __GFP_NOWARN;