From patchwork Tue Feb 4 23:12:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13960172 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 966B0C02193 for ; Tue, 4 Feb 2025 23:12:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16B48280012; Tue, 4 Feb 2025 18:12:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6E6228000C; Tue, 4 Feb 2025 18:12:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86379280010; Tue, 4 Feb 2025 18:12:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1583D28000F for ; Tue, 4 Feb 2025 18:12:19 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AA746C041B for ; Tue, 4 Feb 2025 23:12:18 +0000 (UTC) X-FDA: 83083812756.18.BEB5F43 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id DF99C100008 for ; Tue, 4 Feb 2025 23:12:15 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=btPrmYVU; spf=none (imf05.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738710736; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uOeLYsw9Sv9eePIry8YkgaAM0u7ucnWKFkLyfp328sM=; b=l6CUYCTDyO4sLCmuDw2B6Nyep06HzW8ro6gpZnZ2NUzisdKUh+UZY1snzprHg//12tZWoZ CJmvB2nBHt6OhR6v7NWuSYsk2U3gf7k7MF+/qu0oMYjyrqF5Kz7X8iAr8qowpvgDUT9THK m/j7da5SE/7TOAwe2DQmZu/fK1umqqE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738710736; a=rsa-sha256; cv=none; b=FhxM/vdYiG46Nt7nja4AzQn4aanYkPLQI1xWgcXyALn40Z+yI1TnSFFsuLq8/WE+1TrDEo kT9QwdeeYxD8+zQNrqYd8MJrseFdL0Bcs/xktybm4LyseyjS9q793+ydoEsSK73gnSm5Ry Ppli77YublJ+RnVHDgAvVzROb9DmClc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=btPrmYVU; spf=none (imf05.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=uOeLYsw9Sv9eePIry8YkgaAM0u7ucnWKFkLyfp328sM=; b=btPrmYVUIxv/PUPNXWIIMwBM6P xdr5bCfUDfEXVLeDiWlkcc9wcAAlPLtZcKGPl/KPku29F6Heroqfk02KMNylpMuKL7Plx2J0Is6pN r29mKYQRjTW2qgleR4u8VtGuYVSGPqq9kZpsczBByM/09yCXiLysvwsVPSRQAsqDj+akDHjW4yyY6 lQx6hToYIMU3ptGlugC+owrMVO0Vzv/+2A5D0t9Y0gB4ZVnyMiVlPkCKl27D9rZR1EGoeRcC8nHKO hGbQrFB6d9WIpejPUoWvCwLG9N3tbA/1BoMoDt4Mt/VctQGHM6yhkDu+8qidTpDefS6Em56DHpcCr bHlfs/cQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tfS5T-00000001nhY-1xER; Tue, 04 Feb 2025 23:12:11 +0000 From: Luis Chamberlain To: hare@suse.de, willy@infradead.org, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org Cc: john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com, mcgrof@kernel.org Subject: [PATCH v2 7/8] block/bdev: lift block size restrictions to 64k Date: Tue, 4 Feb 2025 15:12:08 -0800 Message-ID: <20250204231209.429356-8-mcgrof@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250204231209.429356-1-mcgrof@kernel.org> References: <20250204231209.429356-1-mcgrof@kernel.org> MIME-Version: 1.0 X-Stat-Signature: cudftxkrsh6u5yti1ngd5t33esz7mn7b X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam-User: X-Rspamd-Queue-Id: DF99C100008 X-Rspamd-Server: rspam03 X-Rspam: Yes X-HE-Tag: 1738710735-776736 X-HE-Meta: U2FsdGVkX18UbDqAFvgiWIt+qzuL8u4Z6/V3JCAhEwcyjZ3DsDdWB5/1fKRHrbUIG5pyK9vQEY/NuU8BEvi/beCiiOisqi/ihwUESa2By9TAjMgO3I/Ick7UrqeQ08GzcFxILkWjiPozP9xIeNIUfsKmFCvIeflgoUKkjzSBNSu19c1D4lZbkEC1vOI/VYuyFOzVmpfohsbb3I30XEuMi8kJpZbuA+rgy8RrneFOTkIF6cYdXN6ttRXFQU9mY7rtvU1b4ZhywPW2WHeNtlxadOIu7W8O8bjPuPgm11zpcp223A+SxOn0SZAmHTyAe9XpTp59Tbof1I31nQ9v+9U49Ed+b+lHJDqcxjWDfDaT7ykfim2z6UEAHImWrxn4wet2jyhp/+dj4QrAwI0QmrazqAIlIatO7vPIfMpIRaDNQy7GQjaCo0uv1n3ciVcp5dHQGF/67Q+4nZpwZI1YtLNAtCOLImwVNtZmYVQf9MjbzIkWu9StalgqEFo7GweFj7Z2yTWgzVd2H6+n4NJpWn6Pd2lfgSb+GDsOpUmX1PfVqYvp0/Fwz5KGYGIcROy7S/wdA++Q2gIoK9JJiCxGFYdrGTU+henxpyQtTcCJ5Gh4zq33vJMhC3fNg8YUz7rY8UZtBkuaA0NHxv/UyXT48owP4He0n2txL7fpDKORI+trO4txKOkV71eW8/3YM9CxsGMFtQcUwT07yHyfIDXTffnzKxt2PSjM9Tl0NNGJXA9jU0nxebOuvPDxcPMWzaTOquBoA9fATgQ5WAJKbo1Ma60bWJvxkSsX39DzfDtOH+FI0SZbu3xZk2Zo2IM9hhUz7dlS1nepKAG3bleA+QkpxKqs7NOxmcpobm3BTSPQ47IFyZuWvaNVhlrM4caIw8vuRGLfOw9EtwboODyuPwN9EouQdxS+5Xq8FbcaqDE2fAdK1z7ff8XhNJ3l1ZcCHrSGJEoY5pCJgTU8NPWizuKZkKG zYu3vUBH v8Wh7oR4oyob2xI37IlKCApw8/BUC8iQa2xihlue07bpKoh9pePRy9g1Xj7QuenCZuvUyd2Oows430GWOvRrESWd8f3cGfHwf6yuIGABHhejUJtWWgosRM8qpb/GvkubTstgoNgpkSL38mQig7VQaGGB7Pu25p3Xu/zmPH623JwIA4nFlTIuB/uHOIbuVIPcXK1pscZESXG/pr5ICmFLc8ltQ+6qU/FNYa/VewbCPvI6rW0l6U4bbtLnz8WHZEt++KAb0d/PdzyDliys09XJS82k1oLOz0HOl1zxLr94fCPlHkIlidW/BaUh0bCD21wywxqeay5L7OqIzZU+x775Eq1C+rjSRb08lhwzxww1vAu2hCYIXV05ezY2MJHCZ4I87hmpVhs6z4eBF3qjHIT6Ea7aPAJizpIEBYHDXMMNpq3/9zGwBztC2SQVc/C2sCeF//tcyBRN+GwKGznpcEH2zGvwT5MprYuaByHTaX9z7X/wv1RL2B3yLeSHLLQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We now can support blocksizes larger than PAGE_SIZE, so in theory we should be able to lift the restriction up to the max supported page cache order. However bound ourselves to what we can currently validate and test. Through blktests and fstest we can validate up to 64k today. Reviewed-by: Hannes Reinecke Signed-off-by: Luis Chamberlain --- block/bdev.c | 3 +-- include/linux/blkdev.h | 9 ++++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/block/bdev.c b/block/bdev.c index 8aadf1f23cb4..22806ce11e1d 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -183,8 +183,7 @@ int sb_set_blocksize(struct super_block *sb, int size) { if (set_blocksize(sb->s_bdev_file, size)) return 0; - /* If we get here, we know size is power of two - * and it's value is between 512 and PAGE_SIZE */ + /* If we get here, we know size is validated */ sb->s_blocksize = size; sb->s_blocksize_bits = blksize_bits(size); return sb->s_blocksize; diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 248416ecd01c..a89513302977 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -26,6 +26,7 @@ #include #include #include +#include struct module; struct request_queue; @@ -267,10 +268,16 @@ static inline dev_t disk_devt(struct gendisk *disk) return MKDEV(disk->major, disk->first_minor); } +/* + * We should strive for 1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER) + * however we constrain this to what we can validate and test. + */ +#define BLK_MAX_BLOCK_SIZE SZ_64K + /* blk_validate_limits() validates bsize, so drivers don't usually need to */ static inline int blk_validate_block_size(unsigned long bsize) { - if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize)) + if (bsize < 512 || bsize > BLK_MAX_BLOCK_SIZE || !is_power_of_2(bsize)) return -EINVAL; return 0;