From patchwork Tue Feb 4 23:12:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13960173 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 698ADC02193 for ; Tue, 4 Feb 2025 23:12:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52AEE280013; Tue, 4 Feb 2025 18:12:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 499B7280010; Tue, 4 Feb 2025 18:12:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27407280013; Tue, 4 Feb 2025 18:12:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F37CA280010 for ; Tue, 4 Feb 2025 18:12:19 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A8F411604B5 for ; Tue, 4 Feb 2025 23:12:19 +0000 (UTC) X-FDA: 83083812798.17.CEB9F8B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf08.hostedemail.com (Postfix) with ESMTP id EE4AB160007 for ; Tue, 4 Feb 2025 23:12:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0nzOxxML; spf=none (imf08.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738710738; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vsI3NrYDCkaTTiln7YWklNd5/+H3Tzw74X2k8TbvG94=; b=fS64BERRgWI0ciAz6zXIBdkZtqoykv/gOJ1Sohz8Ge4mUTEiF7q5NdH7ULJ2l+tv883TM6 leHXIMGOmIqLcFD5Hwahyl3oDiWunxnWtfxwXmhfOa9DKd5pVzQHFGSwWjoNcHcemopk6c ipEPyOM58jfLpk1PGhyEZ9y9pKSi8PI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=0nzOxxML; spf=none (imf08.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738710738; a=rsa-sha256; cv=none; b=6RcrSk5YoyHIcbvA05/8rSUuk15Ybr5mbIE3HQq76jDxwtYeEXqPUmai+4jFwPSOd1Ddhr hIsBZTxkuZrSl2wBiyV0NGgtxo5abRHw4kDeMg3Ek66KWc59Nn7L7eiacNOUIb617znu7r wcD3w2MGyNb/hPOR3sNsyxNFVnGe02s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=vsI3NrYDCkaTTiln7YWklNd5/+H3Tzw74X2k8TbvG94=; b=0nzOxxMLwU+TflgBQMEtdhAsm8 +xmsBu/qY0JwCI1dXIoV5MXYXGahDwQF1Ibbnvkoarthv7xByRdwPYPpQ/searzACLLZUcBGbwb/f hsWuhQ1VpcW+/la2tFAWJkaS4gmr4MAUuS+SdmOEHQkdAErpyyqnSP6+j1uLcQhyu+w7AJGOwPZH/ 5zwlFRBnUrjElWvfumBsjkqRVi3pBEMglKpJgQcR6fRgwwIzyz+3bubKGK8cPLv01+aHwHmYpzTSK yr+uAl+OC6m/bYnoo6CNNI0vb3mMHP96V+hxotakRfuquvEe2QcVD+tT4Xnj8F+kvdZGCm75aRJOF YAgjVBWw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tfS5T-00000001nha-261m; Tue, 04 Feb 2025 23:12:11 +0000 From: Luis Chamberlain To: hare@suse.de, willy@infradead.org, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org Cc: john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com, mcgrof@kernel.org Subject: [PATCH v2 8/8] bdev: use bdev_io_min() for statx block size Date: Tue, 4 Feb 2025 15:12:09 -0800 Message-ID: <20250204231209.429356-9-mcgrof@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250204231209.429356-1-mcgrof@kernel.org> References: <20250204231209.429356-1-mcgrof@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: EE4AB160007 X-Stat-Signature: 66zf7r4u983ey68dn85bb48twedccu1e X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam: Yes X-HE-Tag: 1738710737-656956 X-HE-Meta: U2FsdGVkX19RZaeCrqbjWVZHMTCdNoDq+OiCQFGF5qtVDMhYt4H9qY8IwkJhKfPZZ30AcD9wZH24SxNoAQiJ0esQbPrKLC/s/vPzJOjJgmaeXPpj86venmnQEjGFSCdXOYS4ScBmOstvnPsviCRN1pXFxkmd9brtIJFanf/IGdARK5DFg6qtrvdfA1vCEoUWbppQN0cyas+CMIkM3VC1kNehRgTSiuceCwGNZqYShNUd4K7e7BE8kDkaIc73ycTs5ReJgL3g38V+gb0pXbJnu33D7Q31mJkRfpESyO2exRg1177x2QokgtBE9dQEqmLY8tBuF7s1qTqix5QxoOPefN9bvnbdy19pDRrHx769FIAIIiW5WqEKovINLzXUT3b/Q9qXLHrn2k0OjpaJg6yBZrXGax5Mz9HRHIDt8ntHNxNvsQJy/C3XEHUso4AxkMj2X3eKgERb+xBrdNSX7CdEFytD6mM+p7ENA228bei0QNXiClz4jWye96XFXB+sHZP7L5igei5TFjVPgbrMOtAysMmkmitd1ZRX/Hn17ci6J2CvL0NhPwUWlMrPC9h474N7htlbkykzRiwPzwgdohkrtv/4qyFrRIKzu/LiqCnd+IHtu5j5ZWFbxZENq7jU8nmJdpmyoGjeKsuk3wHHWOarmofF0GCSM0Neo1tQMbRqgpPvci+IM7I+Xu9pN+Op/3ykc/cPgv9MyxgkqPTSXMrq0xElJIW3OKmtVDR/tuuU3vewWqwCY25dToPDRs4fNrVbH9M30DnrPtSazr1Qd56Xr2QtncIjpHqGrLQiuLdPxF2bmGgXCOMLKtDFuDPwP5MQ9yvgSf+fv06M+W6Z8iNFdDzjbznOsjCYcjDVgGi2h7sbPL7Fe1sdTvzadRoCVQsLIK+1c4xq3206hOfz6seQZbONd6Cxv8Sb2zQj15ffQTVxwVoGeNGRkvbdZUPN2f/h5G4AomI8/FO0709rEY7 9a7xdJR4 8nepvgmUW06SWE8pjFqbUDTQAT+9yX9Hx2eWLpVXhfZY2hm0XR8y3jFNbv1rPj9GgFqLIPXfkBKLziCH3wP/L1ATCUerfQK5lKYT8wVhdoM5p/yVFTleCuX0+NVKeklhBVOJYeBzfYz/NxqWpP20d9e0JL3rDm3CsFKD7Yxhg+ymJH6L9eMHfsNsxjqe39a2uLee6xVPE0Isus7u2GvH02dcHhKlAW0AdaBm5rMIsIPpjnfLCcWN+hih+geOkv2zpRjDwM9mFp6a9KVdoosxA4ZnU0rOrYmwvCqrgRKrxobO4Pnh/DfkwEdJe5TIK0bqlC5BatTYErivW2y3pu8R0P1WLGA06ghjaqHPJbPpdVZOfNuaku0bMEPyMMg/i+yTYeDfG0Li12dmxdwz46EG7GdER4bq0eAOV5/oajahJ8NsBvxe4B80D0Bb9T1Q4/60vt4Z+VK/pD7AnBT9GKftecdmBQ7CNDX4f4+SSaR18/C0/+eeTLSg+iMU9S/5IjMKCTeVXlVYqu6xalJwpXbq9QHNJ7ICr/TUDZrGl85MVptugpfw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.004033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: You can use lsblk to query for a block device block device block size: lsblk -o MIN-IO /dev/nvme0n1 MIN-IO 4096 The min-io is the minimum IO the block device prefers for optimal performance. In turn we map this to the block device block size. The current block size exposed even for block devices with an LBA format of 16k is 4k. Likewise devices which support 4k LBA format but have a larger Indirection Unit of 16k have an exposed block size of 4k. This incurs read-modify-writes on direct IO against devices with a min-io larger than the page size. To fix this, use the block device min io, which is the minimal optimal IO the device prefers. With this we now get: lsblk -o MIN-IO /dev/nvme0n1 MIN-IO 16384 And so userspace gets the appropriate information it needs for optimal performance. This is verified with blkalgn against mkfs against a device with LBA format of 4k but an NPWG of 16k (min io size) mkfs.xfs -f -b size=16k /dev/nvme3n1 blkalgn -d nvme3n1 --ops Write Block size : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 0 | | 2048 -> 4095 : 0 | | 4096 -> 8191 : 0 | | 8192 -> 16383 : 0 | | 16384 -> 32767 : 66 |****************************************| 32768 -> 65535 : 0 | | 65536 -> 131071 : 0 | | 131072 -> 262143 : 2 |* | Block size: 14 - 66 Block size: 17 - 2 Algn size : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 0 | | 2048 -> 4095 : 0 | | 4096 -> 8191 : 0 | | 8192 -> 16383 : 0 | | 16384 -> 32767 : 66 |****************************************| 32768 -> 65535 : 0 | | 65536 -> 131071 : 0 | | 131072 -> 262143 : 2 |* | Algn size: 14 - 66 Algn size: 17 - 2 Signed-off-by: Luis Chamberlain --- block/bdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/bdev.c b/block/bdev.c index 22806ce11e1d..3bd948e6438d 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -1276,9 +1276,6 @@ void bdev_statx(struct path *path, struct kstat *stat, struct inode *backing_inode; struct block_device *bdev; - if (!(request_mask & (STATX_DIOALIGN | STATX_WRITE_ATOMIC))) - return; - backing_inode = d_backing_inode(path->dentry); /* @@ -1305,6 +1302,8 @@ void bdev_statx(struct path *path, struct kstat *stat, queue_atomic_write_unit_max_bytes(bd_queue)); } + stat->blksize = bdev_io_min(bdev); + blkdev_put_no_open(bdev); }