From patchwork Wed Feb 5 01:39:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13960412 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61600C02196 for ; Wed, 5 Feb 2025 01:42:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 209DB280030; Tue, 4 Feb 2025 20:42:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B9B4280029; Tue, 4 Feb 2025 20:42:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01029280030; Tue, 4 Feb 2025 20:42:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D27B0280029 for ; Tue, 4 Feb 2025 20:42:01 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 891B012045F for ; Wed, 5 Feb 2025 01:42:01 +0000 (UTC) X-FDA: 83084190042.09.9D38859 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf22.hostedemail.com (Postfix) with ESMTP id 1437DC000E for ; Wed, 5 Feb 2025 01:41:59 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738719720; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7SMC/pD10vzfyOvE9rsu6eXTFlWmc349QpZ60zv8sKo=; b=DqsS1OfyO9fnKom+RFOnfy44TgnZK3vtZShDJfAlyKNFv7KAv+NoBJt06Mze9APinr6UTk VN+Guv5iqV4GlTCXhz4ueVRV1i/ogSPw7R1u2Uw8Kk3kSa9x/H6yo1phnNsTKgweqAULbS 6WiI2sM9w6egk6z0OpkSZYkfZ9xLcHA= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738719720; a=rsa-sha256; cv=none; b=J3sx5Jcfr/kWDYQcrptQW1oRrn5zvRE+vH3isx0Z2a2euka/H8b8iYWWR3WsyuNpuq2iaB jW65PcOlrI0rgmxRzcnJaz9D8LK/LGokq8axm5cKTMIEuxQIsE8jOPCIm6U75mv0Lfakfl HQ/zncvBTxZzVhbRk/1u3oxZL1CrdsE= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tfUP4-000000004Cs-2ZIj; Tue, 04 Feb 2025 20:40:34 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Rik van Riel , Manali Shukla Subject: [PATCH v8 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call Date: Tue, 4 Feb 2025 20:39:51 -0500 Message-ID: <20250205014033.3626204-3-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250205014033.3626204-1-riel@surriel.com> References: <20250205014033.3626204-1-riel@surriel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1437DC000E X-Stat-Signature: pkf5krgkfcs1bxuuj3pejnntn89r7j4k X-Rspam-User: X-HE-Tag: 1738719719-168204 X-HE-Meta: U2FsdGVkX19E/JfijbtQWludGHoZ3aB7BrfD54Of40uNQJB5by8TG91rQlkg9NDzSSBekxnS6M1r3rr2V08qwwLX00YNhqTh9K3bmwZ8/S6YWJg7xoUxuBSeY+wzYIp/ljTi5d7F2tn26RvemorCWpmkKlxry+HZGv8RL37ZMgyb+VFN/K6vHM2Q+fydjf6IH1b9OvY9YRqTWMUTSVDEQDsVdv/2Xvj0+tf8bNqstOLzgHtJ0X1Bv7O5Ha+8GZS3Y0aQUIrqfvLtJEhlRu1p/rS09a2g+S83lLX3yanIaThiwH+xmLWIrdlnamONGeZe4MXlES+NvpoEVf2Yq7WCWM9U3QpQ9bdFKzo4IhsY5eBIzacJw3zoN33Eecj2fOowI9CrVGXjIG5NsuqfwaP4xPHq2DDaT3u4K7l4Gs/5NvHoGxrjMw0g4fr+0rXffnIgSfiY+v3otWvB5m7M/mwAquWL6fGMZIDltwUzrVyOXZ4POaWktPAR5ZjDTuVYxHcDf5GwvA+Ioj0Txevo9wT2CY9mRcJpG8Vb1IyNQ4Yto9yI3XneLrMboc30tJxY299L7//ZSLK+gv3m8Rp16hAosZb0DWUf0BI5mUSdzc6uQvym5sQsoAGmfPre/YHTs8sdTZAeDEnQvORsBbGYcu2ovmRsDYBBP9L4F5zseTQbXU5ZnPqUUo/iT9CE398DO2t7cBxffgvLsNf3R+M1qYnF3dXefr1T0k24UT/fzwZW7N3RH1qUA0NLBzfppEP33tt3rw+8SLFFBvodt/SIqI965DGvcpg9f70S8azTuOhDhPhgxyMVRzt60PUP7u7ijfvhQ3uUJtF+puh1jFTV0c1ZxTBjcctmtMWCdWdCyXkOCrUto7bTHuM3hDSlfRKXRVGGm3wkHN1CAH4qOLJx6cph+UdqDzqcQ8gCHA5JU83CIHEWoozaOg7m/hNG/zURNlDciT3uFzvhDvFDo9Ati4l 0/9Gw2vA VbJAEiPIWORgQkAuDKXQxVylyeApWT+3eSJF6EAFkhHM4YspxIJ+taxwsPhecmXNambUqczsw1C7CTHSvVvI+vqLSZzc1RizLeMd++OsRL6aMUjrPQZl71ednaxJ+yqt11R/oxGUh1eQzgnn+G9iVyUtd2OZWxeUrpvm4pCM64mFfbz0fV7Bh6NkcyFss0d2TbrdhQ4UI9Lx3uifCsmTDKZEWp1M27msfMUTacrpktoGCw8uBwRJOgpKwVbGTdEHLNdVCR89Bo8VWiqkZIKRjnnVc9pDXWftCri5VXo22WMj+LdvVBfJGvCDotsjqU+aUrwdxo2YmdzNDOiDOpgl/pS83OkHCciM2PR56KSApAakq0gQVHa/r31vUUJq8PzUP9jV+1bOWP3MvzXl/AQkhgHm9WMQZSu92ll1QHuhFbEUP5UT4AEEm56McbtdcOptiGE8i/tRDgdy6nj5xjIB3SCg8cwrNjmj5K/1p7pGmtZUluBIjSoOZBvRREH2OJO7dl357Woa4ZJQ8XP6+9So7bZ9M+06OityyETgLZlxTtJ+D5OxL9woNqTRE8zsSxUGoa7qUkcnmMjZxW+hb1ULeFKX53A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Every pv_ops.mmu.tlb_remove_table call ends up calling tlb_remove_table. Get rid of the indirection by simply calling tlb_remove_table directly, and not going through the paravirt function pointers. Signed-off-by: Rik van Riel Suggested-by: Qi Zheng Tested-by: Manali Shukla --- arch/x86/hyperv/mmu.c | 1 - arch/x86/include/asm/paravirt.h | 5 ----- arch/x86/include/asm/paravirt_types.h | 2 -- arch/x86/kernel/kvm.c | 1 - arch/x86/kernel/paravirt.c | 1 - arch/x86/xen/mmu_pv.c | 1 - 6 files changed, 11 deletions(-) diff --git a/arch/x86/hyperv/mmu.c b/arch/x86/hyperv/mmu.c index 1cc113200ff5..cbe6c71e17c1 100644 --- a/arch/x86/hyperv/mmu.c +++ b/arch/x86/hyperv/mmu.c @@ -240,5 +240,4 @@ void hyperv_setup_mmu_ops(void) pr_info("Using hypercall for remote TLB flush\n"); pv_ops.mmu.flush_tlb_multi = hyperv_flush_tlb_multi; - pv_ops.mmu.tlb_remove_table = tlb_remove_table; } diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index d4eb9e1d61b8..794ba3647c6c 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -91,11 +91,6 @@ static inline void __flush_tlb_multi(const struct cpumask *cpumask, PVOP_VCALL2(mmu.flush_tlb_multi, cpumask, info); } -static inline void paravirt_tlb_remove_table(struct mmu_gather *tlb, void *table) -{ - PVOP_VCALL2(mmu.tlb_remove_table, tlb, table); -} - static inline void paravirt_arch_exit_mmap(struct mm_struct *mm) { PVOP_VCALL1(mmu.exit_mmap, mm); diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 8d4fbe1be489..13405959e4db 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -136,8 +136,6 @@ struct pv_mmu_ops { void (*flush_tlb_multi)(const struct cpumask *cpus, const struct flush_tlb_info *info); - void (*tlb_remove_table)(struct mmu_gather *tlb, void *table); - /* Hook for intercepting the destruction of an mm_struct. */ void (*exit_mmap)(struct mm_struct *mm); void (*notify_page_enc_status_changed)(unsigned long pfn, int npages, bool enc); diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 7a422a6c5983..3be9b3342c67 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -838,7 +838,6 @@ static void __init kvm_guest_init(void) #ifdef CONFIG_SMP if (pv_tlb_flush_supported()) { pv_ops.mmu.flush_tlb_multi = kvm_flush_tlb_multi; - pv_ops.mmu.tlb_remove_table = tlb_remove_table; pr_info("KVM setup pv remote TLB flush\n"); } diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 2b78a6b466ed..c019771e0123 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -186,7 +186,6 @@ struct paravirt_patch_template pv_ops = { .mmu.flush_tlb_kernel = native_flush_tlb_global, .mmu.flush_tlb_one_user = native_flush_tlb_one_user, .mmu.flush_tlb_multi = native_flush_tlb_multi, - .mmu.tlb_remove_table = tlb_remove_table, .mmu.exit_mmap = paravirt_nop, .mmu.notify_page_enc_status_changed = paravirt_nop, diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index 55a4996d0c04..041e17282af0 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -2137,7 +2137,6 @@ static const typeof(pv_ops) xen_mmu_ops __initconst = { .flush_tlb_kernel = xen_flush_tlb, .flush_tlb_one_user = xen_flush_tlb_one_user, .flush_tlb_multi = xen_flush_tlb_multi, - .tlb_remove_table = tlb_remove_table, .pgd_alloc = xen_pgd_alloc, .pgd_free = xen_pgd_free,