[11/12] mm/swapfile.c: remove the incorrect code comment

Message ID	20250205092721.9395-12-bhe@redhat.com (mailing list archive)
State	New
Headers	show Return-Path: <owner-linux-mm@kvack.org> From: Baoquan He <bhe@redhat.com> To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, ryncsn@gmail.com, chrisl@kernel.org, Baoquan He <bhe@redhat.com> Subject: [PATCH 11/12] mm/swapfile.c: remove the incorrect code comment Date: Wed, 5 Feb 2025 17:27:20 +0800 Message-ID: <20250205092721.9395-12-bhe@redhat.com> In-Reply-To: <20250205092721.9395-1-bhe@redhat.com> References: <20250205092721.9395-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	Tiny cleanup and improvements about SWAP code \| expand [00/12] Tiny cleanup and improvements about SWAP code [01/12] mm/swap_state.c: fix the obsolete code comment [02/12] mm/swap_state.c: optimize the code in clear_shadow_from_swap_cache() [03/12] mm/swap: remove SWAP_FLAG_PRIO_SHIFT [04/12] mm/swap: skip scanning cluster range if it's empty cluster [05/12] mm/swap: rename swap_is_has_cache() to swap_only_has_cache() [06/12] mm/swapfile.c: update the code comment above swap_count_continued() [07/12] mm/swapfile.c: optimize code in setup_clusters() [08/12] mm/swap_state.c: remove the meaningless code comment [09/12] mm/swapfile.c: remove the unneeded checking [10/12] mm/swap: rename swap_swapcount() to swap_entry_swapped() [11/12] mm/swapfile.c: remove the incorrect code comment [12/12] mm/swapfile.c: open code cluster_alloc_swap()

Message ID

20250205092721.9395-12-bhe@redhat.com (mailing list archive)

State

New

Headers

From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org,
	akpm@linux-foundation.org,
	ryncsn@gmail.com,
	chrisl@kernel.org,
	Baoquan He <bhe@redhat.com>
Subject: [PATCH 11/12] mm/swapfile.c: remove the incorrect code comment
Date: Wed,  5 Feb 2025 17:27:20 +0800
Message-ID: <20250205092721.9395-12-bhe@redhat.com>
In-Reply-To: <20250205092721.9395-1-bhe@redhat.com>
References: <20250205092721.9395-1-bhe@redhat.com>
MIME-Version: 1.0
Content-type: text/plain
Content-Transfer-Encoding: 8bit
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

Tiny cleanup and improvements about SWAP code | expand

Commit Message

Baoquan He Feb. 5, 2025, 9:27 a.m. UTC

Since commit eb085574a752 ("mm, swap: fix race between swapoff and
some swap operations"), the non_swap_entry() checking has been taken
off from function __swap_duplicate(). Hence, in the kernel-doc comment,
the line 'swp_entry is migration entry -> EINVAL' is obsolete. Remove
that line to avoid misleading people.

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 mm/swapfile.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/swapfile.c b/mm/swapfile.c
index 93fd12c12bba..12bb7556c7f1 100644
--- a/mm/swapfile.c
+++ b/mm/swapfile.c
@@ -3525,7 +3525,6 @@  void si_swapinfo(struct sysinfo *val)
  * Returns error code in following case.
  * - success -> 0
  * - swp_entry is invalid -> EINVAL
- * - swp_entry is migration entry -> EINVAL
  * - swap-cache reference is requested but there is already one. -> EEXIST
  * - swap-cache reference is requested but the entry is not used. -> ENOENT
  * - swap-mapped reference requested but needs continued swap count. -> ENOMEM

[11/12] mm/swapfile.c: remove the incorrect code comment

Commit Message

Patch