From patchwork Wed Feb 5 09:27:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baoquan He X-Patchwork-Id: 13960698 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EEFC02192 for ; Wed, 5 Feb 2025 09:28:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33D636B0082; Wed, 5 Feb 2025 04:28:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EE0D6B0085; Wed, 5 Feb 2025 04:28:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18F036B0088; Wed, 5 Feb 2025 04:28:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E82286B0082 for ; Wed, 5 Feb 2025 04:27:59 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 974B614079C for ; Wed, 5 Feb 2025 09:27:59 +0000 (UTC) X-FDA: 83085364278.12.23B9C04 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id D3668140009 for ; Wed, 5 Feb 2025 09:27:57 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GeFxOXxn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738747677; a=rsa-sha256; cv=none; b=5nLpoNNU0uehAE/32q6ZUf20bnUvfwvBqf8NhhLaaHQyyVWRtpF3VVzL35Rainy/oc2xyH MoLwATkzn9Vm+Uq+4F3We0FLLYiwrpPMplQj28ZRZxWh76MYcVBmo81HuPDyq5yQiGEih1 sQVMAA7BI1SiqajGXDF/e3NxVz8Hw6U= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GeFxOXxn; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738747677; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=baZcIm7AlnLIRm7Dd7CyR7YXStnIxeq19AKgfb6y8wo=; b=yFr59tSGFTu7kK365RQqbpbi29vMzry10Xxv+fTXI3LvsrsZt06nhjW4bQy1+AAQpwsl6v bd/eIFJ9RTAoGCA9bkU1DWt2smnMrsWRb0q65BdeBBuXogrJWyTB01duPCg3w6mnlk9NLO GT1GcPkZxR5DBLoSRq9dvOQ6C8v7WDM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738747677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=baZcIm7AlnLIRm7Dd7CyR7YXStnIxeq19AKgfb6y8wo=; b=GeFxOXxnmyO/l1afIth1PAXdDzcQTvfGbkGXBJreIbxz7wrpFsSsQgo+vZcl5DkLLLTwBW DcocNvD2FJOhwIUnYWkbg00A/wXPaB3xTvVX1gKRfZaKatqHW23OqwLL3Tpc67nOQRtCjF vvaQckW26tthBkGXwa44X7p+e7ncVFI= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-548-WOpEV56FPm2xOHG6ElSdSA-1; Wed, 05 Feb 2025 04:27:53 -0500 X-MC-Unique: WOpEV56FPm2xOHG6ElSdSA-1 X-Mimecast-MFC-AGG-ID: WOpEV56FPm2xOHG6ElSdSA Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A0616195D6AC; Wed, 5 Feb 2025 09:27:48 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.72.112.190]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 94030300019E; Wed, 5 Feb 2025 09:27:44 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, ryncsn@gmail.com, chrisl@kernel.org, Baoquan He Subject: [PATCH 04/12] mm/swap: skip scanning cluster range if it's empty cluster Date: Wed, 5 Feb 2025 17:27:13 +0800 Message-ID: <20250205092721.9395-5-bhe@redhat.com> In-Reply-To: <20250205092721.9395-1-bhe@redhat.com> References: <20250205092721.9395-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D3668140009 X-Stat-Signature: q8xn9bftccz56q837z5y478d4pypxmqu X-HE-Tag: 1738747677-35565 X-HE-Meta: U2FsdGVkX18tB8kUV5+fTPS5fYS6P/okv7pgxH0NFLFGMuuIjvReVAsLSB97WXoenkxXOxtexFI1ltJZH8T19LtW1t9H3Ba330Nld9VtFOdIXCiQ6tutGNJg56CpAAVCx3d5XGMbS2osdeNQJlWq5s02kDVbwdzFCFrpu9atWMP/KLRsvwJhUrVnHNgiXFDA6ayEhX+ulHdP/8T3UqP2DlzQP7GpAOxbXfJnjdiuQbj+nxaiPmuCDAYhnnKJO2XNI5bYrWfoQ/Ul/jmopaNEmJwJigzgtV7MVsau92MhxYRyxhI4iKnfQNqyXeGYi9Ph9i93WxgbnvBfAn5yZDsGF065nBxuVjIB1jMQ/ofzwnzNCxAve8+uqXIgF9pE+j+MkuGf9+AZ40zuasPCHiBY/Uy5j2Wb4nV6/H+SNWz/WxTD5Q56qsJUOQQbk/QZ4z7rX7wnLCVyFhvdKyGVvG7FhJZHklx4qyKRJtAv0m1hU4Gr14BtM4NBONOL2dSCCzwYmo3or+MwECF1qdmwoWDprhhiRxT1tgI7DnAbnN8EgXfiIMniqpqdZxooZVvGEZUGsrpnI0H6KnRYWrXNWaNSdhZUsslHJeAAOI5ivAyUVaeBhM7p3Jw7REpUlq95l6j2821Tov5liLyBCTTcMux7xF2EZFnnE1xXnosbe7RdE9MkrWh0D6w5i76oqpV4ew+U1AUSxa87MhSJUg9CEDgo9TUbRsO9xw1WcgkL6iVaiu45Z2uzT+0g2dfU0fnaaFcvUiOX1uJFsBJ3u2GLl3iIUwJLLPJjHukQDWTru2YWMQgv+2fihtzISD0FTUTf1IcKMU+OK0iGlCQaq6JIlyg8Yn9JeqSlTPs+SiWrShvQr+JjYrIvw7z4esFVsKoyjyAvkqG7ZkUhtiUmSX/vaElQo/PN0HnH3gejsEe1cpTDS43LjmaVrh9jBQxwS65CrK/djY3fYV3cliNktwnGM9G G4k1v2D0 7elwByMjv7LbTpNuA9/jajbxYceYgqu9p70iKIQ5+xTwIEqyUS3Qty2fmhk5r4NY0o+xtnXxGbWQMUI5MRFpwo9zy7iwSnI7yYBhzgE8Jc/mc3eTzvAER7g6JkX8EHip6/P/15htKTID/GiEVru6Ca9tOrU2VLTyQxvxiEoJbfuicKDOA4XjTSVdKr4pVC+hWhFHbBKjvIlFunThBOoP/9CysULB/ExATtGNvi/zTDuBl7UTr/e6GHDFZaTO0qVNQe6vr/oYKrQPPpGI9r5Mm7TuDS67iFLr2PRR4DoWNxrgaRuL3Of+5q0RpzobDtvq4PO94 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since ci->lock has been taken when isolating cluster from si->free_clusters or taking si->percpu_cluster->next[order], it's unnecessary to scan and check the cluster range availability if i'ts empty cluster, and this can accelerate the huge page swapping. Signed-off-by: Baoquan He --- mm/swapfile.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/swapfile.c b/mm/swapfile.c index 9c9a4ec6d4c6..61efde853eea 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -729,6 +729,9 @@ static bool cluster_scan_range(struct swap_info_struct *si, unsigned long offset, end = start + nr_pages; unsigned char *map = si->swap_map; + if (cluster_is_empty(ci)) + return true; + for (offset = start; offset < end; offset++) { switch (READ_ONCE(map[offset])) { case 0: