Message ID | 20250205092721.9395-9-bhe@redhat.com (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B435BC02197 for <linux-mm@archiver.kernel.org>; Wed, 5 Feb 2025 09:28:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4EC8C28000C; Wed, 5 Feb 2025 04:28:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49BE8280006; Wed, 5 Feb 2025 04:28:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 364DF28000C; Wed, 5 Feb 2025 04:28:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 165FF280006 for <linux-mm@kvack.org>; Wed, 5 Feb 2025 04:28:12 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C2BAA140796 for <linux-mm@kvack.org>; Wed, 5 Feb 2025 09:28:11 +0000 (UTC) X-FDA: 83085364782.10.8C3A8AD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 00F06180005 for <linux-mm@kvack.org>; Wed, 5 Feb 2025 09:28:09 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QxacZSE2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738747690; a=rsa-sha256; cv=none; b=zpC7Q+lXdbB2/J2ujbMWkgpei2JeRQYQMCp8uD3pjS1iUqdW9qnH5KV43tGdxRJjapZVph Oow9lMV6gp4b+N54r7ChjL+RGAKilZseEQQcMXE810ajCkTyPLh6Pwe7j7Vx4f/rjHDc8O x2ZT4aPAR93IzZYd1AIuQn2wNGtn2u8= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QxacZSE2; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738747690; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LKdSXZcqnstZAkYV6ff74HG8BN8BooEUO78YRxCe8Tc=; b=OZXEgFEBouRgrb3VMl3j/ZX+lwE/c+6KVgXXgwHA7UwikLEu1N+/WNAz167hGcCQP91HoK iaz0v52cj49Hnm3ymhE+yqobz55SXVaV7F1sqm6Y+CVvrhL8dG5CRjv15CjyoOo4W0pNdv UTK//CLJmWzGzEoaBkV64YoSk9XyRz0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738747689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LKdSXZcqnstZAkYV6ff74HG8BN8BooEUO78YRxCe8Tc=; b=QxacZSE23nAAQ2pPoLkxkrx3tt29gxrCIMtY43cU9bQkiMnXt4zeAuu4rBKOpMT1vRBJ/4 K6taEIksDAHQjGHPPXjotxLZqZazfK7daiLRzYZpIBa1qrF8i9hzCt0vIVAL4UhtQ1qqO3 rIK/2wYsWsbR6c4gpgWyKvzdH3JKMgo= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-cXFiB-0CPGi7ksJUR4_nxw-1; Wed, 05 Feb 2025 04:28:08 -0500 X-MC-Unique: cXFiB-0CPGi7ksJUR4_nxw-1 X-Mimecast-MFC-AGG-ID: cXFiB-0CPGi7ksJUR4_nxw Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1900819560B2; Wed, 5 Feb 2025 09:28:07 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.72.112.190]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 394AE300018D; Wed, 5 Feb 2025 09:28:02 +0000 (UTC) From: Baoquan He <bhe@redhat.com> To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, ryncsn@gmail.com, chrisl@kernel.org, Baoquan He <bhe@redhat.com> Subject: [PATCH 08/12] mm/swap_state.c: remove the meaningless code comment Date: Wed, 5 Feb 2025 17:27:17 +0800 Message-ID: <20250205092721.9395-9-bhe@redhat.com> In-Reply-To: <20250205092721.9395-1-bhe@redhat.com> References: <20250205092721.9395-1-bhe@redhat.com> MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 00F06180005 X-Stat-Signature: dio63xo65xpsumpn8hnanpn34ynna1g9 X-Rspam-User: X-HE-Tag: 1738747689-521802 X-HE-Meta: U2FsdGVkX1/hkJsoX2UYXMnsYDsU/dJNwKoPHP4GfdUb+YkQ0emwcyxAd/u7c7CpubgzfKujRvkf9yk5vhSg6ZLHJTbk1Uy4vYX2Xsaw3A1cDzLpWkjfqO4l3DZudAE1ae1AlJBjaor8Le6PQlBaTfMXknzhoamovXEGy+dXvVCrPUwwRm4J+lL5JWEkc2v9KQRx4hqjp56YCFzyrRQKwRQlrQLZMynips++aZ08hJ4+V5FafQ2Al5W85SKdrMYPYvy691w6uzgwAPI15+9dYyT9409m5hnifW1hLbrDix4T9jPAaY93Etc/7OW8PICovonrVGQsDJP5LAHPsYZtGH/LktqPZtas+pEOOS0Kz7GZ4fQei6TzFBH1v35AKOrlfAZR8WNx+dF/0ioHP9CPvWQCKvAxo/MbJkyjHzfjOtdaZwr2nCBFJ08ensknqLkVBtMSshFAVqKBLohcxur1EI9JjtvUC8vx5NoseYwXiBAE4/y1aat5BT4fNjdUmlv+SkmlfCcgxEikJX//sQkU9ybHwO2V0V6fJhJdNFrO3DUBg3vEq1NEYqWBfIw0IkUu8mVrKrSPNY9bIWFZZBqb9emRJ03RMfzXxUwbe7xHGl0kBoO4QmLHL+B+JopjbDOQoPel5Sj43WFrImpjnqE5vrA6LbRqibahxwsocr8sIB+krvYCu3muhFgtgSfJXDyCaZKhiM37AGNnRtFUA2CdAnP/TBDHOhLFrZV1rKCuSyhYfqIrIS/xzuyULgpRAlvB9OyNPv/juOF++5iMhIBGotJ5324nnJhvaIBkDicRLBA3NxAHwQfvAyeX7JWc/qrxNpK11lulE1ojp5CsEhN/kivqX3DQxvV2ec01wu3HRoUZHzZDswMgVAWvuS7fhKo6HGuTikIcCZ9GwIqYUiHyFkqdrco1E03BiijZmKjOtFIElgSFxSGk12t1fUYwgPNDOD58lZQq2Eu56uk8DlJ fjpqfO0F K/9yvAeILwCRFpq99Ye/V2dJg/aFz+0teZ5L0rJk6zbehjJniPtAqbSJeePMinO7gcradJmpzcCVicjLx4XcbycN86PKWLiHYu/IxL9uLp1OeQaTvIzABieZkyrquo5vGgVw7SP87//DMNOOW8rBly7CvK5fAqdrnwCclkQ7LV5i3clgAJY9rRet3FT2giLS3N6iCeVD2zXn9p1VH9l2UK76d9THme0zbWmBhB364R8dCWUct2W0+Jce0dEoHeV3Ys6GKzw8B8guAy2XCxObQyS6xm3NJLvReX3wJFq4tqaTyD0ysQHd+RTqRc8qb2oc6XqZGbpxnEc45yIUfsyg/Vt3GeD9kwkPL8Rx+nvJBG+u8DL2AVZLTgy1UmQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
Tiny cleanup and improvements about SWAP code
|
expand
|
diff --git a/mm/swap_state.c b/mm/swap_state.c index d7cbf5bb2450..b393cefb3be0 100644 --- a/mm/swap_state.c +++ b/mm/swap_state.c @@ -203,10 +203,6 @@ bool add_to_swap(struct folio *folio) err = add_to_swap_cache(folio, entry, __GFP_HIGH|__GFP_NOMEMALLOC|__GFP_NOWARN, NULL); if (err) - /* - * add_to_swap_cache() doesn't return -EEXIST, so we can safely - * clear SWAP_HAS_CACHE flag. - */ goto fail; /* * Normally the folio will be dirtied in unmap because its
Since commit 8d93b41c09d1 ("mm: Convert add_to_swap_cache to XArray"), there's no returned _EEXIT, so the code comment doesn't make sense any more. Signed-off-by: Baoquan He <bhe@redhat.com> --- mm/swap_state.c | 4 ---- 1 file changed, 4 deletions(-)