From patchwork Thu Feb 6 04:43:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13962184 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B7AC02198 for ; Thu, 6 Feb 2025 04:45:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64BB86B0082; Wed, 5 Feb 2025 23:45:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 000B16B0099; Wed, 5 Feb 2025 23:45:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C46546B0089; Wed, 5 Feb 2025 23:45:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4BF0D6B0085 for ; Wed, 5 Feb 2025 23:45:12 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 038BE1A0E65 for ; Thu, 6 Feb 2025 04:45:11 +0000 (UTC) X-FDA: 83088280464.18.391C8AE Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf27.hostedemail.com (Postfix) with ESMTP id 703CE40012 for ; Thu, 6 Feb 2025 04:45:10 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738817110; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7SMC/pD10vzfyOvE9rsu6eXTFlWmc349QpZ60zv8sKo=; b=laFXc0AcV7xfqKYmdNr2xly2oiYDeZny/xSgBplStGQZ2vMk9T+JSTOJF6mLXnMVMo8JA2 N9BXFzaY8L1ZtW6me3SvAbn6hcAzcJZPumByEjxT1XoPywifM9Rh7Q/QPv60Cev2YwROZi QCrH6HC1N5cgdTaoL6K4BmCtHKpRxeE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738817110; a=rsa-sha256; cv=none; b=AAAXbV7HTk9mkKT56NoLWEfT4rbcdMfwSkgxRdhN8oreb1HyPPGZagRPnPWkwOQNO1w1qY ENh/CAHIcyig7ByM9ND+Ru0BZLE4CC4ox0jW9bYHi7rXOcduxbqtFI2WyWgLBUvRJjWPmJ /QCRjuKJE8Sw9RPYO6WFuzO5wbf5cxE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tftjw-000000004tQ-1pX5; Wed, 05 Feb 2025 23:43:48 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Rik van Riel , Manali Shukla Subject: [PATCH v9 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call Date: Wed, 5 Feb 2025 23:43:21 -0500 Message-ID: <20250206044346.3810242-3-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250206044346.3810242-1-riel@surriel.com> References: <20250206044346.3810242-1-riel@surriel.com> MIME-Version: 1.0 X-Stat-Signature: 1u4nz9p54it61qq6s89chtra7cs4bq17 X-Rspam-User: X-Rspamd-Queue-Id: 703CE40012 X-Rspamd-Server: rspam03 X-HE-Tag: 1738817110-901477 X-HE-Meta: U2FsdGVkX1/1FPCxM+KFSnlR8RsNt8Hh898HbPvpvAL6q22TT8U7h6rURcXB5yJc4y6Ms/jeESZ1KkML1awJDYygqiaz4iWyAZKqzMAOAsWAUQl0pvWu7/pVn5/YIKpxXwQ1p5qOYOPLoEGPVjC9ONcONTaQt5YlOajoWMpxON32tMnZB1WUfUWdWmDqXICqxRHxdsgpgk6tjmGqc+nEwU3fNylDJzNaALiOQ+GHOPia2qb9LN5yKlX9PENlfgagkEDqU2eIFEwF8aRsy6dMYHCkcAJajD0Q1x01vibftf/tqNFD/49zS7UDxl0qusStr8RuVUYAzR5od5d4ABzbJ5kNmgASzM2GBIw8mtn213f/fMOAdd+nEwXuC7bInRv8WXOZV+tMp4/iVpnkN0TZMcxcy/biGi/FmkUWRhYLqrl/Lq1lBYxhOpxqzarKNoh0NJ+Jq4LqECeJbuaK+tOq7QxwOY7Ecos6UXpEuecOiuSs1w0+QHZ+ushcEba4+c1Ub9P08qJv61m3CdPiUDQrQTYg3kz2f4oW18r+aeAZmyY+wCM7ak2uIuU782BDfLjt4bIpTBiw8rkvXCdZHKVHiFSiunWfTPJY+w0LSiK+AADurVAVi+IWeTbwitmNUWZR1noSjswvlC9PLLTTUzm0fkgkulJ8+VIDyoPZm05x0TXM5BC25xlsbvY4qWYTAGSALWrNToffeGMZJwOs1cRKEto/cllMIDcwt3/Ru9ZRkueBPZOEkcVG23KpQ2CRgy9r5aFmDE5fJHuh4ClYzUr9amRH1YN3QyPkqKGZtoTmGTCAVHLgnsa3EsT47f4p1wjEjMAwFlMiAu30XY9z04K9J478Bb1vzOBPGuVM02I1QSTTekkbVo35O3Ph43wlZA9DQioy6SVi47nSqaCt+9+rwy6XsSJueqJ/4YfTQeNY4Mm5GgtoezHI/gB99ev9jdd4ZPALPE5Rt1yyvn9BbqP VcDjKGF+ GG5t+bJrr9EePtR7kfaWRUFgCmTBdV1LkD058N+cl/thnilF4B2ns8+gPRnCT/aBG8ifiEaTp+MAjpYzs/pckUvcApDk4EF0gowPXZz3j1y0Sd6Uxpt+QuMxyGeOTSwnUxcUZL98Rhgy/t9PPNoOm9XK2xxJUcwRfZvPJk9AD4jbE4K2zrtdCEt4rbV2QXnLNo9R11/VOovGZd4wfzr+AzUqVrW/XIBRfnt7apBt2ysmeImxGblIOweKL+mk2+Ze6G3U8va41LoKgSSveZ99i4CS9LsmSY6IPYDh+9GGzuSVmq3VCFXzoJQeCxcD4mGH7Nqv5APbFE9x5MG6iB9qo4i7euR1+H8T9NSfEmcCoAgyUjtVDSoiZZGOgorOe82AiGlFY5GLw/BK0rdXjpqWza5jw2xrI/0J5rcMnGC9Eb5DLwSLdbRXJm99KR3PrV7Qn0WI07uHLaHwapa9UkhXMj33cSQe+L95cUomv9IEGUiMZN9i7j+wPCxtQXk4zFeqvqKXVqy5eQGzxtQhiMHOreFy9J51cMYGlWlDteQnf6gVsxMEDDHKrDZv10688NOvXn4//KWhcbK6Kf/dbB2KryVPhr4ddh/zuqFG0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Every pv_ops.mmu.tlb_remove_table call ends up calling tlb_remove_table. Get rid of the indirection by simply calling tlb_remove_table directly, and not going through the paravirt function pointers. Signed-off-by: Rik van Riel Suggested-by: Qi Zheng Tested-by: Manali Shukla --- arch/x86/hyperv/mmu.c | 1 - arch/x86/include/asm/paravirt.h | 5 ----- arch/x86/include/asm/paravirt_types.h | 2 -- arch/x86/kernel/kvm.c | 1 - arch/x86/kernel/paravirt.c | 1 - arch/x86/xen/mmu_pv.c | 1 - 6 files changed, 11 deletions(-) diff --git a/arch/x86/hyperv/mmu.c b/arch/x86/hyperv/mmu.c index 1cc113200ff5..cbe6c71e17c1 100644 --- a/arch/x86/hyperv/mmu.c +++ b/arch/x86/hyperv/mmu.c @@ -240,5 +240,4 @@ void hyperv_setup_mmu_ops(void) pr_info("Using hypercall for remote TLB flush\n"); pv_ops.mmu.flush_tlb_multi = hyperv_flush_tlb_multi; - pv_ops.mmu.tlb_remove_table = tlb_remove_table; } diff --git a/arch/x86/include/asm/paravirt.h b/arch/x86/include/asm/paravirt.h index d4eb9e1d61b8..794ba3647c6c 100644 --- a/arch/x86/include/asm/paravirt.h +++ b/arch/x86/include/asm/paravirt.h @@ -91,11 +91,6 @@ static inline void __flush_tlb_multi(const struct cpumask *cpumask, PVOP_VCALL2(mmu.flush_tlb_multi, cpumask, info); } -static inline void paravirt_tlb_remove_table(struct mmu_gather *tlb, void *table) -{ - PVOP_VCALL2(mmu.tlb_remove_table, tlb, table); -} - static inline void paravirt_arch_exit_mmap(struct mm_struct *mm) { PVOP_VCALL1(mmu.exit_mmap, mm); diff --git a/arch/x86/include/asm/paravirt_types.h b/arch/x86/include/asm/paravirt_types.h index 8d4fbe1be489..13405959e4db 100644 --- a/arch/x86/include/asm/paravirt_types.h +++ b/arch/x86/include/asm/paravirt_types.h @@ -136,8 +136,6 @@ struct pv_mmu_ops { void (*flush_tlb_multi)(const struct cpumask *cpus, const struct flush_tlb_info *info); - void (*tlb_remove_table)(struct mmu_gather *tlb, void *table); - /* Hook for intercepting the destruction of an mm_struct. */ void (*exit_mmap)(struct mm_struct *mm); void (*notify_page_enc_status_changed)(unsigned long pfn, int npages, bool enc); diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 7a422a6c5983..3be9b3342c67 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -838,7 +838,6 @@ static void __init kvm_guest_init(void) #ifdef CONFIG_SMP if (pv_tlb_flush_supported()) { pv_ops.mmu.flush_tlb_multi = kvm_flush_tlb_multi; - pv_ops.mmu.tlb_remove_table = tlb_remove_table; pr_info("KVM setup pv remote TLB flush\n"); } diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 2b78a6b466ed..c019771e0123 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -186,7 +186,6 @@ struct paravirt_patch_template pv_ops = { .mmu.flush_tlb_kernel = native_flush_tlb_global, .mmu.flush_tlb_one_user = native_flush_tlb_one_user, .mmu.flush_tlb_multi = native_flush_tlb_multi, - .mmu.tlb_remove_table = tlb_remove_table, .mmu.exit_mmap = paravirt_nop, .mmu.notify_page_enc_status_changed = paravirt_nop, diff --git a/arch/x86/xen/mmu_pv.c b/arch/x86/xen/mmu_pv.c index 55a4996d0c04..041e17282af0 100644 --- a/arch/x86/xen/mmu_pv.c +++ b/arch/x86/xen/mmu_pv.c @@ -2137,7 +2137,6 @@ static const typeof(pv_ops) xen_mmu_ops __initconst = { .flush_tlb_kernel = xen_flush_tlb, .flush_tlb_one_user = xen_flush_tlb_one_user, .flush_tlb_multi = xen_flush_tlb_multi, - .tlb_remove_table = tlb_remove_table, .pgd_alloc = xen_pgd_alloc, .pgd_free = xen_pgd_free,