From patchwork Thu Feb 6 04:43:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13962178 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E00C02196 for ; Thu, 6 Feb 2025 04:45:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 434A46B0093; Wed, 5 Feb 2025 23:45:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3969C6B0092; Wed, 5 Feb 2025 23:45:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 266266B0082; Wed, 5 Feb 2025 23:45:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 086D26B0082 for ; Wed, 5 Feb 2025 23:45:12 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A44C7B18D9 for ; Thu, 6 Feb 2025 04:45:11 +0000 (UTC) X-FDA: 83088280422.09.04912C5 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf15.hostedemail.com (Postfix) with ESMTP id 26767A0004 for ; Thu, 6 Feb 2025 04:45:09 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738817110; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LwsWehzYjkF1dDnuvGvtM8fVrbVxjj6sQ0wzVHF9uqw=; b=M002Mv1v824hpnyKlkKpKmgb30zkLdIOxUxBTX3/TYP032m0OCR3y2N08JADWxXESuZsO6 gOQIaoH7jY6D5azTKhELETBjfbj9m39FjQUiMK+lamq0Un1wAfLs4qscG3ldjs0o/0vyHd buD9WhE0l5OA0dSX8PLes6Jhqc5Zml4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738817110; a=rsa-sha256; cv=none; b=lNgFE31qq5NAtPVrRXRapuLyUrxhUx7Rvr6ovOgW6xAIsqciptAVZr42NBC4n3oxJlVn/q ZqdsZ5xWmRBi4eEgCvS5NWooUN3s4+ZFmPtW1Qlh6eVkfOJsJbiLU1VkYOasx1I08vM4Br eXpIJnEEvRjhRdX79RRG8jXbfjeDlO4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tftjw-000000004tQ-2FVL; Wed, 05 Feb 2025 23:43:48 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Rik van Riel , Manali Shukla Subject: [PATCH v9 06/12] x86/mm: use INVLPGB for kernel TLB flushes Date: Wed, 5 Feb 2025 23:43:25 -0500 Message-ID: <20250206044346.3810242-7-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250206044346.3810242-1-riel@surriel.com> References: <20250206044346.3810242-1-riel@surriel.com> MIME-Version: 1.0 X-Stat-Signature: 54wbx8ipxkhedyp3y1hn6ciqgho6z6cg X-Rspam-User: X-Rspamd-Queue-Id: 26767A0004 X-Rspamd-Server: rspam03 X-HE-Tag: 1738817109-932806 X-HE-Meta: U2FsdGVkX18/UNQIKHtgyL2DNqK7uutlPuMM4MCQ73VjpMu8pxlnwELOXYByBcaPOh+M7pDLNlhWGjkRSGpwya/qoizUTocvxFr93uVNVHuThvARFrwI39edDHmRvf7WgoDbk5U4wwTLBOWzMMo1Sn79qaomF+HIguPJTtCKZEVK+9Hp65K2p0ULasmcTcHjlvXM9xXU03KZnhEdJZxfvJwX7ZTgatqyvNcnda9/kNv8kod3d4sLHTtQhyUIsaWKcd+quE+hx3j2MRfKqD0ncYtl6ekSdCPsPlNgArhKai7VF64WoDEp9EfYRgR6anXLz0DXB9c0C1onwCAETo3qLnlgVE2HSP/Y7wAQ+4gyL44ZTX94sjus5L0JbenaLrJnOFmt34pEDmg9gGpBkkYlm6sCyz/Ff/S9WcjFBU0mnuKnxwjAL9luIalnRveQTP3YhSOqe1z/ru4cXch0tZdbQ0AJhXrrW7vUbNWzMN3YYEwKIwHSSd3IhI3FPycwz56RcgzK51uDF8WA+oGB2+CT4efuk6ImsJnR1P0vDeN2jnVD2ERPVDRVzGflEsiS9PQJmKeIlu4N/Kb3manFIWyKwEIMpXbw1qmuHT1SsNdvsvTgDlXvYto8HBkE+zqUmcJRcytM1QJf9TZTFXLToqvwIUlicifWB01bA9EsV4GeUEVmLIy21MSOAEWRQ9/UYEWbYWnnwFhB62lbvTkfdrlAWrvUwIiyC0fNBN4RejSUcxSJz0113yK+GjNQUOLZcN3exWVTEpxys4ztR4XX8UCisIx93NmpP6tXWNmGNEWAxuRrw5CGBbcf9OOQohkiJeyt44RcVAbBScWquUc0q1mD8Lpg/WFCCRewe3PozhdLg8FdnKoxEvhDRm11l3luwQoQiz/blUWCXfNMRmz5+nIX4Z1AYKYYikn7CAlKEHku6qZ2qneCjtIjnEbO+kkYCwQ7YYZbqgacKALJpRGmO5S KMLTIuLu QfRiI3uiPYWVo+GhmMqu+ubAdM9DjHqdpVkW2XYu9VrHF0d/4Ykx8ZouL59dy48YXcomp1DxKoB3cTehTzD6qUrKeeSDg9ut57dFN0EETYaA2VDaKAEjXUdqvIhm3A5c3Po8RfINDnmuC5EGvoG7Zf08onJlwbSdx297r+x37vvr/3S2nounkD1vrxUzSzaWTww/FXUhNuewDrh9hQIS7Mj1S27OKkGwBNmVqHTDzso7rTxJiVXL76qEFByE2t5nJAhLDs5Stpmx0MLP7R3hMVXtafWD6/djzV/Sr5kT7yL/UXAPFOwsfGEgFPtT85MMt1Jq3Qfr4axUZPus376i7zNz7Myl2/LaNytjZYDNV+kIe6OzLS1hq1BPHXCDV9geZ9VoYm3nVslcuZFDXRTg+GzGVt4VdUzu2/ZowoFwg7aoRs8rer6fUsar/t6rSVKvKD8VL6rC79/Qy6CDI+A/IOQgBaI+0d7GSsKkszWQl1Noj5ErnVZhf4a1YkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use broadcast TLB invalidation for kernel addresses when available. Remove the need to send IPIs for kernel TLB flushes. Signed-off-by: Rik van Riel Tested-by: Manali Shukla --- arch/x86/mm/tlb.c | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 36939b104561..227e972b6fbc 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1086,6 +1086,30 @@ void flush_tlb_all(void) on_each_cpu(do_flush_tlb_all, NULL, 1); } +static bool broadcast_kernel_range_flush(struct flush_tlb_info *info) +{ + unsigned long addr; + unsigned long nr; + + if (!IS_ENABLED(CONFIG_X86_BROADCAST_TLB_FLUSH)) + return false; + + if (!cpu_feature_enabled(X86_FEATURE_INVLPGB)) + return false; + + if (info->end == TLB_FLUSH_ALL) { + invlpgb_flush_all(); + return true; + } + + for (addr = info->start; addr < info->end; addr += nr << PAGE_SHIFT) { + nr = min((info->end - addr) >> PAGE_SHIFT, invlpgb_count_max); + invlpgb_flush_addr_nosync(addr, nr); + } + tlbsync(); + return true; +} + static void do_kernel_range_flush(void *info) { struct flush_tlb_info *f = info; @@ -1105,7 +1129,9 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end) info = get_flush_tlb_info(NULL, start, end, PAGE_SHIFT, false, TLB_GENERATION_INVALID); - if (info->end == TLB_FLUSH_ALL) + if (broadcast_kernel_range_flush(info)) + ; /* Fall through. */ + else if (info->end == TLB_FLUSH_ALL) on_each_cpu(do_flush_tlb_all, NULL, 1); else on_each_cpu(do_kernel_range_flush, info, 1);