From patchwork Fri Feb 7 06:04:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: liuye X-Patchwork-Id: 13964366 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7704C02192 for ; Fri, 7 Feb 2025 06:05:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5ED06280003; Fri, 7 Feb 2025 01:05:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59D1A280001; Fri, 7 Feb 2025 01:05:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 464B4280003; Fri, 7 Feb 2025 01:05:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 28B0B280001 for ; Fri, 7 Feb 2025 01:05:08 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9E672C16BE for ; Fri, 7 Feb 2025 06:05:07 +0000 (UTC) X-FDA: 83092110654.29.2F29B5C Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf26.hostedemail.com (Postfix) with ESMTP id C95AD14000B for ; Fri, 7 Feb 2025 06:05:04 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738908305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=jDtWAbdaeh/YssPcWza1mnx44SHUMp/rnWE0piwEZks=; b=NacOzMY5txMBit+hivn6Q3P36sPAiJ7M0cm5BL083GesJkPktIJIDslsDnCMnlbfcTN2zL dfYJ0idroSVV7dRMUe005ULnjYKfxmg5BPVRqbGZzPO7Cj9SPYyqapZ5cAshVRMDOZqYfU eQymyXikdUO/hjngGbRI1Agh0bd4I0Y= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of liuye@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=liuye@kylinos.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738908305; a=rsa-sha256; cv=none; b=UCOCkXSC7W3mBw7ryfhlDIYpvj5w3FgxKx7thsYRs+PWvYUcxXMFq2m9qZEMBixKLEtewB denaIl/pbOua7HwM/BfiBno5UV5HZvdkbhBbfAxI4PNpkiaqqU69H2jIAI7BQXlIu3umbM Mr/N5ME+pSTnM8NpSxUJLsvK8MuFJMI= X-UUID: 73c7495ee51911efa216b1d71e6e1362-20250207 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS CIE_BAD, CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:396ae1c4-c3c3-4ad1-800b-23b4ff26ea62,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.45,REQID:396ae1c4-c3c3-4ad1-800b-23b4ff26ea62,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:6493067,CLOUDID:1e909fe92a23362bffd0d5b830b00e05,BulkI D:250207140457V2MBV3HK,BulkQuantity:0,Recheck:0,SF:17|19|24|38|44|66|78|10 2,TC:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,B EC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 73c7495ee51911efa216b1d71e6e1362-20250207 X-User: liuye@kylinos.cn Received: from localhost.localdomain [(223.70.160.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 2000563527; Fri, 07 Feb 2025 14:04:55 +0800 From: Liu Ye To: akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Liu Ye Subject: [PATCH] mm/mlock: Fix WARN_ON_ONCE condition. Date: Fri, 7 Feb 2025 14:04:48 +0800 Message-Id: <20250207060448.146606-1-liuye@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C95AD14000B X-Stat-Signature: nssbchmrf9gd41yz49pd6tbx1nn1aig4 X-HE-Tag: 1738908304-584815 X-HE-Meta: U2FsdGVkX1/1Pq75leIwaQHFxTZXcQvkyEHB3oZohHpPIMcre1EZ1z45WchvDm4E4ahERaj08bKlVtnkhGUKViyoLfnQAH6n24itkRdBMiGAJcvsOGOMSK5vOSon31rHBTQGv4Fe9Fqh8EkurE2Xzt70evuiqpJZF8ZzSh2P0JO9hCbcLTOuqWxsljZ1OiKWoR0eVSJptMdgXnlfoMPtasiYenYZu113B/31O8vKwxOBbBjgkoRWBLNdEgOH7wXU8+6hBUJXXM5tnSlglQ+3FKEfxWcAt8JBoRKct2niiy9Hh/q5hmblCXTz1Aqz7IV5oMLlI5zy6fOVUeEZkTzDUbTljS/A3IlgYAutrPPCx2FClzxAOv8QKmvMuyajdZtt53lKT5pMlV/spr0yK8Ep9jlWND2cP/Rsza8gm2wmES2akC3JQsN/cYw7HxwqxE4LJb1xvvSXLjy2EeBvqMn/JN1upd5elSiN7EVmqOslqskrfKk6tDJyc0EV++y/vHQW7hg3JNaGmTxugDcZcs2rugTpv8YJODl1dRxA87+3TH8ncKkVr8gaVN1nzMSND4Sf/XQkMTWGgEEwTlZthRcPNz5TaVHTj6+uy8gxU/EkZMYVnH6f6qDy9aWoIWuHNiJgo8mYaJxCJhMDGMipF2dgnbMjy0necW6HWrIQgkiHzAjxXw2hFTPUrl8Wsl+1QmFtD7rF1rmrd3oY9sFcQ3CvMbsNlCjrrBBF+CfVECwE5wo86Tl75FPtwG3Th+vJsj9tlRJuz8DtwmZDL5f2k8m6O/xxylRFr9nROaRQWBoheXosMSs3GvuyOle3vMEDqN38hZ34t4FwUaf0JTvYxazL7qx76JGADppX8BuI5XEVtJYpMwMoEBuQAkFvdIbC3zfIwAjKZWuNbBx/NsgpqWawMswbZEbNMLNe3kO7IjSK4+5a7mX/s7QeoiTkV/ZobN8lbk43kzXgH0zKWGSXbAI eFXRIstg HpKGPS/OEAJBkND3oRA9VyQa65xsAywhsM1NMrpTzCjy08wAIWFSyLSVPQlIrLfigcithAyog1QM25+c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001908, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The condition in WARN_ON_ONCE(cpu_online(cpu)) should be !cpu_online(cpu) to ensure the warning is triggered when the CPU is offline. Signed-off-by: Liu Ye --- mm/mlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mlock.c b/mm/mlock.c index cde076fa7d5e..40acf7897917 100644 --- a/mm/mlock.c +++ b/mm/mlock.c @@ -224,7 +224,7 @@ void mlock_drain_remote(int cpu) { struct folio_batch *fbatch; - WARN_ON_ONCE(cpu_online(cpu)); + WARN_ON_ONCE(!cpu_online(cpu)); fbatch = &per_cpu(mlock_fbatch.fbatch, cpu); if (folio_batch_count(fbatch)) mlock_folio_batch(fbatch);