From patchwork Sun Feb 9 22:30:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 13967156 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7E3DC021A1 for ; Sun, 9 Feb 2025 22:30:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 312E66B0089; Sun, 9 Feb 2025 17:30:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C4406B008A; Sun, 9 Feb 2025 17:30:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13B026B0092; Sun, 9 Feb 2025 17:30:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E9C5C6B0089 for ; Sun, 9 Feb 2025 17:30:24 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8BAA01A0F42 for ; Sun, 9 Feb 2025 22:30:24 +0000 (UTC) X-FDA: 83101851168.28.773AAA3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id 070F212000F for ; Sun, 9 Feb 2025 22:30:22 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=i3yc1Tcl; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of frederic@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=frederic@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739140223; a=rsa-sha256; cv=none; b=uuEKsX7kNjR0mIllKPKCbD621H76eQC+ZqQotQMmTuYipjrN5bSPj56+cYBSt1y12yJ8y3 jI9b9aARZLBAiPGFDM1fQH/zrrgnID/Yfk/4n3JhVuw1g6NwO4G2WXQqwoLb8HRtc04uk1 dJGo7lSph9JEC3jLiHSDzp2F8rrQMTs= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=i3yc1Tcl; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf29.hostedemail.com: domain of frederic@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=frederic@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739140223; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a7uGpIMKlk6nj4vQQW/vGZhG72gVz8uknW/7qvfGUMY=; b=TZtqEQ+PzB4IMcvgwjlHNGNo3vIOC6NuhU93vd53wjEuVx38ayUOeo1bDKkCQF496XT4Pt LH3Fxt+CO2UjMZHPm2C7KzI6hpvGKTHJiZttb71afhdB1lSSqlZfC0426kmwJjNIv9H6p9 DcqoO8wj/41DTlVMVVYZzBDkYtoVKYw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B978E5C5A66; Sun, 9 Feb 2025 22:29:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DBEFC4CEDF; Sun, 9 Feb 2025 22:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739140222; bh=FqNJ6UqFojjpII8sBMn0id8eG6MSR2NFISi/uXoXOtU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i3yc1TclMFUBV7la89jwOBPVVcbWq9j9foLUc+l8S0j49dsWRkglTHczvWZ8vSUbr wD8rxcG6eePf4kB/0zJICVTMcSta23HMamwJHE6fo8Fp0v0A/ZkcOUtU9XTzHwlNZy +Gyep4bt1xDGZTNwnAkA2n28MRQnXc6BcSBuVaqslF+JGVWoaypjRynftsYAbPdiKf C7J0qpFDBdeJpw12H1SK8BUhLmUyc5msm80v3jZ7Ryi0H+ejgxjDYhgQGw+HwxKjQo x7TmecEPgKUGc1ZAqYnJ6g+Y9xrKsHJG2JEsdQx1RPMLftIKiFUFxpU+TT64Gd/iyV 6KMEvGDKLmi5Q== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Peter Zijlstra , Ingo Molnar , Valentin Schneider , Marcelo Tosatti , Vlastimil Babka , Andrew Morton , Michal Hocko , Thomas Gleixner , Oleg Nesterov , linux-mm@kvack.org Subject: [PATCH 3/6 v2] sched: Use task_work_queued() on cid_work Date: Sun, 9 Feb 2025 23:30:01 +0100 Message-ID: <20250209223005.11519-4-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250209223005.11519-1-frederic@kernel.org> References: <20250209223005.11519-1-frederic@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 070F212000F X-Stat-Signature: zmdi6cgwf1gqbmdsw7hjbjkyxix8zjyr X-Rspam-User: X-HE-Tag: 1739140222-325244 X-HE-Meta: U2FsdGVkX1+GeZ5SmfbG0PPW2so0w5W8G4NRDMYs8upNUgkgkp5qR6XqqPeNIqN8n/IMB6h/xdPSlI7oHwIrfgCBkIUabX617gXFgqZvaPndohbBbpqvBF6GtyJrPbqJBuDO7vMo8hTy6Jed7ZxfHnENhKBEOMziVYKjg6qxY2o5RJbmoBkKTh8CLyfof9uWZRgqAHj0h1dlSHS5u2OqU9bOm75G6bpSkoOIrepUMLaos0eMUU2K6khKP66lRm1w+MBeK4qATKQ6tk0JIdKQsclqiuiAl3JcqLcepWUEmXU2G0PV55EIkS36NjAl2voSkAKXbaJaLn7oFCCraK20XJ/Mb8iBzC3/OQt8dWBLZKxeCsK01yEH4vRgvwivcMiJL1NIS38M9Gh9shI0jHy6piR0eco+8SvtWwglf4jM7495RgR7XVCGKeVzrDvN2M61chaS3FWz7KmKiwJyOpf6POL14vM0kjQJ2H8kQfX45JHR3D3rC0ycxCU0e2qXWvKpzX0OuoF3MIWJq/1vXvWcTZzozdPtjW5ltvNSIGPhLPbdfcQ7i/OHAx58LvoAdPPvgOckmdhbi13Sku+887sNDY8COkFA4eb6uTlVwk8jMo6ZI5TL5i+/5ZVQrolwOHCplmnjTytCOKkBncXZ8N2t/3szjO53hu2OKl6S0tuqMIldcdHDZKnWkTySt+FdjZJqmlGFXSwABo9s8DcmVfSqftP0ByWejxlBSeRY5vL7zdR+h7OsNSvg4xaG1ZO8NqWF0uzPbjLNWw8KZTNHbIweRosu621mgVw7vHa73eZYlDXB/GHd+KZwqtFFCwSDJ7fKgvDJl2xOrQD/qy0nZdHW+TM3ZZyCsPjDiRjv4OMsmHR13+eo92ExCIG7qUMFb+0vMdANlUgDsLtU/vsQGCyoCF9yap06neXW3LhFuCrH3imrPgRRyJCav5TDKflRrDsIRDBLr11tSYE1+gvRrQG S2lT662N 83j2FnpCaF9YK2GNpSFqXVODRRxOvm7pnesqt0ntTHw5a6bxMHxXqaAJZdRyjI2aVK/tLzoAw/260Vm3EQxjSSqnZJWSa5BiNF3QEGZkvN+T7L1XqZije9lI9GY+6DtfiuBKjgpa6dbZJUU/cXcBkBRmDTlU6q2f7Len84W4qmNhojMgeQVVR4++Q+zyVujmcvddoziTWt9EJM9DjuXibwUjU0KHWaCrz9gthR+XNiP7Ynw7PCxWJs+qVnbyIBci8uZGg9Y/jhpOlTS4I2ttKtnOOcN3kYL3UdYxc3EwtN/Kd2UZgYNfTQIHZyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Remove the ad-hoc implementation of task_work_queued() Reviewed-by: Valentin Schneider Signed-off-by: Frederic Weisbecker Reviewed-by: Oleg Nesterov --- kernel/sched/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 165c90ba64ea..606f596a6e0d 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -10538,7 +10538,6 @@ static void task_mm_cid_work(struct callback_head *work) SCHED_WARN_ON(t != container_of(work, struct task_struct, cid_work)); - work->next = work; /* Prevent double-add */ if (t->flags & PF_EXITING) return; mm = t->mm; @@ -10582,7 +10581,6 @@ void init_sched_mm_cid(struct task_struct *t) if (mm_users == 1) mm->mm_cid_next_scan = jiffies + msecs_to_jiffies(MM_CID_SCAN_DELAY); } - t->cid_work.next = &t->cid_work; /* Protect against double add */ init_task_work(&t->cid_work, task_mm_cid_work); } @@ -10591,8 +10589,7 @@ void task_tick_mm_cid(struct rq *rq, struct task_struct *curr) struct callback_head *work = &curr->cid_work; unsigned long now = jiffies; - if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || - work->next != work) + if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || task_work_queued(work)) return; if (time_before(now, READ_ONCE(curr->mm->mm_cid_next_scan))) return;