From patchwork Sun Feb 9 22:30:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 13967157 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D39E1C0219D for ; Sun, 9 Feb 2025 22:30:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66E19280001; Sun, 9 Feb 2025 17:30:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61F2B6B0095; Sun, 9 Feb 2025 17:30:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 470DD280001; Sun, 9 Feb 2025 17:30:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2BF216B0092 for ; Sun, 9 Feb 2025 17:30:28 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A331D1A0F83 for ; Sun, 9 Feb 2025 22:30:27 +0000 (UTC) X-FDA: 83101851294.26.1D9F2E1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 251A9180007 for ; Sun, 9 Feb 2025 22:30:26 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="GZIidSr/"; spf=pass (imf24.hostedemail.com: domain of frederic@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739140226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0GRnoQstWRF5YH6CvkAyI7a+IxCpygSOTbnLHR+rnTs=; b=cd/fwjcM3w1Vvlo/fLBnwdQN2Bjf+VXPSbkaxHEPvWjy/hVpXLQTRAMFU08RE2/8lp3l/e xYFV40pIIlZFRK0Jz+xxr94x3o6D0DFOz7W2fl5a36e76dXlF552DucuriSgGOhmcqu728 A1UPtxAMKKBjojbeBnOgSfgfKCEE1+E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739140226; a=rsa-sha256; cv=none; b=Uk7asyz9qMwCQW5nLejGuwg4gMmqQW6vegkU/Yh2V67JXFKQKCmUoh8qVw42S+BHdb52om u0cvFuAVRnFSj1l+HqXsb8OanIX5TXdU5wl2rsoIpyN3WxM/NqtjhwV7lrsgF7MDtxYwIU xOqRByJ0AdSPdunck+0nm49d7O8Wx/A= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="GZIidSr/"; spf=pass (imf24.hostedemail.com: domain of frederic@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D09465C5AFF; Sun, 9 Feb 2025 22:29:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DE7BC4CEDD; Sun, 9 Feb 2025 22:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739140225; bh=TXaR3PXscB0IR2zu2ykA6NDQs55O4UuGlAU5yWSXoiE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GZIidSr/P6waR4fDq5bCpnMDJ/9CJnNUWMNJm2VsqNQoj5A+V+IecPyfvvCnFJedQ uWCQySMec2pbxlzt6O3nszier5u2Q+MhW9zH3TeiMwbTiCDWRfw/XwHw3bNvSV07nT jv1IUqSyzNgavbpRXwQVNK3kpXQJlEM2E1O6k7UsmMzeAXDxEdDooxhJtVZdCBp5e3 75BhwkH7VaYwBbSZneZEvagRZTWxuJ1rgjsyXEWTEDxRKmBNuM+GfxL+ON9wYrEroQ jrp4RdT8Zf3ab8qNiYvPZRVUQ/ghWDBWrSO4qEyw8aF8L/Nf9r2hdzQlcn7LgoI4Ih YxlqbBf8xueMw== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Peter Zijlstra , Ingo Molnar , Valentin Schneider , Marcelo Tosatti , Vlastimil Babka , Andrew Morton , Michal Hocko , Thomas Gleixner , Oleg Nesterov , linux-mm@kvack.org Subject: [PATCH 4/6 v2] tick/nohz: Move nohz_full related fields out of hot task struct's places Date: Sun, 9 Feb 2025 23:30:02 +0100 Message-ID: <20250209223005.11519-5-frederic@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20250209223005.11519-1-frederic@kernel.org> References: <20250209223005.11519-1-frederic@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 251A9180007 X-Rspamd-Server: rspam07 X-Stat-Signature: mkhbx5fj49ib59fpwcepbuhjk9rdxn85 X-HE-Tag: 1739140226-662757 X-HE-Meta: U2FsdGVkX18otl/xrwfW6rM6IuYuQ2OlZXt547CovNFs9ZGpbC4i8bKR6OqUmkvixe2ntZNQWG/+/TPLYpCEzBbQz9x1Az49fNxUuRifp1HezjU/v9jPKRZS5dmbYk3rYJx7jHTqI2S4B6I1zL8mPFzvVLuKGfjI0RLv9qrFKjZFE1T2FmLyw2SgIwQ/lK4qmFimzNHJaVz8vyf0pTLcCoIX+XLDZwoz8qWa2/5OOj+v3MpsbK/UM5jDqdkjHSFwq5AUxHkpR0tgQh/dm0/Mxy6XCEW3+8JvD/+XiWZXixGCJ+gtD4YDfOd6IWZDM+0MfjBeDk0VtD838sWkBQpYEAd4SG6pWq/93ONxxhjhqeHRHclHCQ2RSmMPr/ng3j+WD3TqgM3r8keK7d2oEwHvkgcxNfnIaJiADiMg8ccsv9Rth+/SNT8JwX533dEs31zmIfq/R2NBFFcAYmBYvnzYqsX5YYIvBWIp89BuNcmIqelW66gbz3EentwkvOoxSokE8X/XEZbEjaij4WV7NOGbeD6BoCEX+G6Na+Zxiwj3D5OezXAkHm9yfWxPYQsUblvu9hRQ3yIxkJ5ZqRP5rrgWCO6ad9UNvRAywJ32nHW9kKDglHAvumAqFw0aLeG918urq6zXlWtZRLt0NQeTkQH/xrQMaywYSipvI7nfTCkG7DiFDgmzL9naYwWZJPVlwjGXH0TirndgHEbwIyzOU2BE3AzH0Zix1aCxq5L6CpekXwS3gp0iD/7rsAgMm2i2gObJ81l4j3csZCdy+YAmS2BJasDg5W1dfLYcMIUilQQG3X7el+pUZvfq3grQVX2u0fpxmTEUOGmLQX4YWFemevJQK+NZKGDcQ78rv2oGRdkUSr6Wn/Un8GZM1a1TKyfBCKdEu9G08k0USTz3HFAx0lqFR87C+JWCcwucaK5P5xBPF4d7lbiexl43Pf6bJYEUwg5OoxM3I+LkeGh+xDbf0Gw vGakI8E+ fYwKx3DjpkMKi9kgJbAY9W8mqUx+moQfxLPXTQ6FegNnmul+yj6Vr/OohgEXhriYvnUg4ey4xM6hwE6gBu+EfJnx/IaLobsnupz1z40YIq9GabnUeAGkvoSldlApXYyd8vEiHvY4oxTDmHjs7NpXOkxzh3cbAQWKNJNj+T2TAFHzRCcaMR5S1V1EsdEIHj3I6/uQLn7d639x9cSVbfDXvbJuPNkcFjk6bKJfdgjCxwbEpt0L54lKGHazhsRQGZlYInLJ8rBi2Nz4DDHgSUP8Salp0u+PW/O/4qaZR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: nohz_full is a feature that only fits into rare and very corner cases. Yet distros enable it by default and therefore the related fields are always reserved in the task struct. Those task fields are stored in the middle of cacheline hot places such as cputime accounting and context switch counting, which doesn't make any sense for a feature that is disabled most of the time. Move the nohz_full storage to colder places. Signed-off-by: Frederic Weisbecker --- include/linux/sched.h | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index 9632e3318e0d..10a9aa41b43a 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1088,13 +1088,7 @@ struct task_struct { #endif u64 gtime; struct prev_cputime prev_cputime; -#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN - struct vtime vtime; -#endif -#ifdef CONFIG_NO_HZ_FULL - atomic_t tick_dep_mask; -#endif /* Context switch counts: */ unsigned long nvcsw; unsigned long nivcsw; @@ -1411,6 +1405,14 @@ struct task_struct { struct task_delay_info *delays; #endif +#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN + struct vtime vtime; +#endif + +#ifdef CONFIG_NO_HZ_FULL + atomic_t tick_dep_mask; +#endif + #ifdef CONFIG_FAULT_INJECTION int make_it_fail; unsigned int fail_nth;