From patchwork Mon Feb 10 08:35:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: I Hsin Cheng X-Patchwork-Id: 13967469 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3722C0219D for ; Mon, 10 Feb 2025 08:35:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F5856B0089; Mon, 10 Feb 2025 03:35:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47F40280002; Mon, 10 Feb 2025 03:35:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32021280001; Mon, 10 Feb 2025 03:35:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 12F8F6B0089 for ; Mon, 10 Feb 2025 03:35:56 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B9DF0806D6 for ; Mon, 10 Feb 2025 08:35:55 +0000 (UTC) X-FDA: 83103377070.05.98FBAB4 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf15.hostedemail.com (Postfix) with ESMTP id ECD9EA0002 for ; Mon, 10 Feb 2025 08:35:53 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WRRdGVzG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard120310@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=richard120310@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739176554; a=rsa-sha256; cv=none; b=pf4wPiZglq6/zk7KS3DYdmHxdqXs5ygHHR12C6CpH2VkkwS+6T+7OyGdG6eUcCXwIuHBzb csFgXOY1SHJb8qAzaBPMifLXDDFz5+Nh8Xrx+5f7SZLEJ633TS0kUUk6GyA+C/TnesOLXg 6+R87HvH9YdykJhMBsrXA3tQAJtG5dE= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WRRdGVzG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard120310@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=richard120310@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739176554; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=yEgYNCSdq6WKd+60zP458jWGuq44OxO28Xoq9wCvIbM=; b=mqdj9Pbg1dLAfkWeDuJs8w6dzuLskeJELpXs6mdznQ11/6rNSNwZFzDenhTSbXlBAjvlaq vj6sRgbgwv6KWHokcbhrOCqXyJjj7ls5o0q8UssvrHaRSTj9yVUSv9uLjcZeIRDxsvjRaO mdacdZ/CplOc7m3Z7XsM7nj3juawwF4= Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2fa19e1d027so4831655a91.0 for ; Mon, 10 Feb 2025 00:35:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739176553; x=1739781353; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=yEgYNCSdq6WKd+60zP458jWGuq44OxO28Xoq9wCvIbM=; b=WRRdGVzGbqt1R+wKkJ11jBpZPEEXeLQ2rgauUFWLFmURBv2PO8GtiSjCwf6KfBcfr+ F/N1vxuS0OyJcUE+642+vuiB2fgn2CYn2GmQHeMbc9z/OE0bKkY2G/vJueFVnQa0t5X5 VxJ4A9xWCgWlluOffy60HuxA2H5Ac/QCJ+d3hqmMCtI++FKM4GD7UqDGzyLTiZxMa/B9 eOlsfMR6Cb0TIqAXFg4YvVCcr6yB2fVJ6X17e6zbyP9W/j9MvwO9zxOs5PTsC4ARtaSx H5c9lQv8IJZl9Oh1TsCaiJziMQXOSaNET4zVAUSRsUF1b77kjf0D0cMBCEIgYcKF7XhM BD+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739176553; x=1739781353; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yEgYNCSdq6WKd+60zP458jWGuq44OxO28Xoq9wCvIbM=; b=FxPHv+9eNxi1twVRLSP9alWcwSWIHDeB2vCph0/8t5btMFDLwF18oFsJjD7yNhAEpd jpTqiA4ouR4nNUIoqk74dd92jlXKUTBH7XSU16ucsb35hc3jXmn7KM0FS00QjtaZolYb dFUJAgtCSmbrllkzbWofiGcEljZPQ11bF1jqZIlRjpywTvi+Lf9v8MNXERqlb1QYqq3P x8VoA2V18NwTn3SRTiLqa9fUhXIOYJeR3EP+20UOUKYfjfsmQufXl9ZLnZASnc0LwDtN OHbZ6ytBHqpVwyvcxVN9XvMLdDtQKmOJA6unyilQulLRbDMUUd7f/mJHgvkmOdiyO8uI lF3w== X-Forwarded-Encrypted: i=1; AJvYcCW4WQQKr7wKgctGPACSgmGwLTGO1vFDaWgd2qzPkoIE/M4IdtLmbXLWR0lNwQmT/EgmZOrVvd1Gew==@kvack.org X-Gm-Message-State: AOJu0Yxj6vX8nvJPiN3iXdt0rGR7HHwxLqWN6uNcp/PPD8d1B4vqXy1q hpRLZFuNK24LUfAIUuLHrXg+VFRW9E2S07rBPHARbDneWeMrpzqU X-Gm-Gg: ASbGncuX8cnUavimmrCc3yUjWKCGP0MFElJOBrDrI4cbbeDhqRos5hfqvrdNhwsxxS1 7lMRgnsoYuTovmjAteYBxiYbXbHI8d8JVIxWE01PLybO646OKay8y3a6l6sqfQ6s+GPnhe+IIbE qESfn+w+3moPr8xD+DmKpBHs5hAqw3Y5XM+ceQ+aJhxgJX/yqUIaPxVgxehAZdtxKSpyUhBTfrn sZrW+AUWtyQuktGdLq6KGiXSbg7uT8SzfvaWKaqAIxRFRHu72/33SHhzA244HpeTNcI72wI+uJf mkMO5vZUVTJzvGT0Ibcs8Svvi0vrLq6Va5iBDwjry1OF X-Google-Smtp-Source: AGHT+IGfssx8hA+7Ss+gH+glTzMWe0Bkr9bXf8ZoLMrQsWAeNJXYUC0Hw/7zOcKM2DDyRQPDjA3W+Q== X-Received: by 2002:a17:90b:38c3:b0:2f7:e201:a8cc with SMTP id 98e67ed59e1d1-2fa2416703fmr23162171a91.18.1739176552748; Mon, 10 Feb 2025 00:35:52 -0800 (PST) Received: from vaxr-ASUSPRO-D840MB-M840MB.. ([2001:288:7001:2703:7bd6:1a4:1a70:d836]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f3687c555sm73036965ad.182.2025.02.10.00.35.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 00:35:52 -0800 (PST) From: I Hsin Cheng To: Liam.Howlett@oracle.com Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, jserv@ccns.ncku.edu.tw, skhan@linuxfoundation.org, I Hsin Cheng Subject: [PATCH] maple_tree: Remove redundant mte_to_node() in mte_dead_node() Date: Mon, 10 Feb 2025 16:35:26 +0800 Message-ID: <20250210083526.252955-1-richard120310@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: ECD9EA0002 X-Stat-Signature: ydejy481ifw9ajatf685hpqm56danm9t X-Rspam-User: X-HE-Tag: 1739176553-655142 X-HE-Meta: U2FsdGVkX19QB7p6apcbRVzkEr41v3raBK99kq94f7oOdRZSKKe4P/4bkU9Q8R8JnoLeoQFWEs6yngj66nwbi2SdDDze+x89/4ZywPt2LIFqpNi/CaeP+ou3Y6O5rv2Ut4dr19fQBmYGVQfVvk7tBQq5t3qEO56vmhl92rI1HU/8k+UoXlaN76Cgw5ppuv1/96VFOkhZuN2hfd79HpKKnZGk0vgF8QCuWawQd6zAbucV5i8hs37hgEYrFZhlqTurkJABuVi11N+nzRKC3vO1oxGGNIZXScbOBkZpQWn/z/H00msRA0o8eaofz/L0Voya//C25VyLxu/kvfO0058t9L00cGCJM1wLqysGbrSEl/vux9sHQtz9v7GMSTMwdeEKhmCnW/Qgo/nKuSGEJGVUfG4OAuz84GVVd5pUCqimkd3W2U0vhrytR5ufx67a+gZTnIqFE+IlI4XZYGnjezHSNpP36Uu4hhxcwyg83ThwEHPzz2zGuhLyr4yKJHLOQzn+H+uhSx0CfUE7LV625LlcObFkq4iKSkWTSs98XcUhSxDnZixuFMavEkPHt2Zf3m96z/QMzNNk3dRuH4BxT6E8mnHOR/qp9xpGW9YSN+88D2JW3DVctJMvLNbbI+xuDyHU1eaIPA38frrnztgjhWbyoot6MFTjNu8xt8NoyowJa9NL4rb8NLo180+QmxV9oPBFg33VpvPnXzjWjw8SEu4IjV/pyAyuNdIl2//u4l+MsmKPenWSw2O55SBc8OlQn9TxuOknPGuNmx/uvAStQgu0UyI2/ICRjeJMUkam61dUsttpaNjbNCIvzbpF5Vy9CO9yNQo3c04sghnrmCuJhg1AVj7FasFnXNtUgJ0xIIpTV/rUfUA5Jrzrd/UykXd4tQwhz45NCcNLcIklsKzd43imo2Xq+i8NIu7RDfDCcC8V+1KtG+CprwfTnNPiN3aYK1aGHdxKZtILdv2N2JBP6/B 5Xj5rnve TvuPnrExnsA5jv0Kg+4LHB40os+mbD6gkBUHKN7OSsgh/mKk6W/yeovaiCp5/rqdN75zuHWzrHClk7WwKgCQPf+zb8bsWWmaeNvtX59FsUnOH4pX3iF6isdfnEUXZAsbEGKYY9iDqMHwgOsFc3zSg7DjZBmuLcF2a6PT1UnDq6iQVoZG8RYmeh3+cixbAOj2Kw43zTCxhIc/XXup+HNZ+/dTsG/2R10oiQ6SBROWEg95dDtfjzoKEpZvHXepW36pncByebo3bHD/Dv29QBsveZqCNpmY/2V7Tr+LlqGwd5HE5oo0jsvYHzGfAjjNe74nxEHwQVnlTOTpa9b2AB2ao/M9b7jc5iNY0fC0JY+yRctNzdxkhSvqflt2o1RkEvUTO2te2lOkmmHnMopDBuQqaiRA2ED3ksGQAh5/nbyPNsYWQzuU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In mte_dead_node(), it already assign "node" as "mte_to_node(enode)" in the first place, calling "mte_parent(enode)" will result in the same "mte_to_node(enode)" again which is redundant. Refactor mte_dead_node() and utilize ma_dead_node() to perform the parent check without the redundant "mte_to_node()". Signed-off-by: I Hsin Cheng --- lib/maple_tree.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index f7153ade1be5..362f85c62678 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -584,13 +584,10 @@ static __always_inline bool ma_dead_node(const struct maple_node *node) */ static __always_inline bool mte_dead_node(const struct maple_enode *enode) { - struct maple_node *parent, *node; + struct maple_node *node; node = mte_to_node(enode); - /* Do not reorder reads from the node prior to the parent check */ - smp_rmb(); - parent = mte_parent(enode); - return (parent == node); + return ma_dead_node(node); } /*