From patchwork Mon Feb 10 19:37:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Hildenbrand X-Patchwork-Id: 13968594 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1C5C021A1 for ; Mon, 10 Feb 2025 19:39:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0368280010; Mon, 10 Feb 2025 14:39:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EB21528000B; Mon, 10 Feb 2025 14:39:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDC3C280010; Mon, 10 Feb 2025 14:39:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AA51D28000B for ; Mon, 10 Feb 2025 14:39:03 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5EE3C160548 for ; Mon, 10 Feb 2025 19:39:03 +0000 (UTC) X-FDA: 83105048166.12.87CE574 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 2AAC320004 for ; Mon, 10 Feb 2025 19:39:01 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HENOEqYW; spf=pass (imf13.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739216341; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oE9Ja/aC61CHup4qeT96Odiagg40Q7TPEFXRUvHwXRo=; b=BJR2giGfO7ycaa7cUcz00akHacTZN6QRSqzztQsopnR/bdMfORApubCfPwyOC3/FBqpiO0 AUXyqmtegXHRkaPWrsGh0JNFQEAAFVxW0cF8nk4TDWT51kaIBtvxmNueaTSrD568JbuW93 O11BAVlY+heEIvIqwbmp7DpQIHbhwxY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HENOEqYW; spf=pass (imf13.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739216341; a=rsa-sha256; cv=none; b=4LjYKgzoWlPqx/DhIq573Hjw+z0tlDBZSRWezMNNzCvb3YbhNsoc0TnTW7S1CLvgopHcnJ km/aYF4pgDcwtk7Hd2uquUZyP5MnqGJ77Gsq2tikuJGMfPe4fzmwU404A1foAYFnNmJKXS 1SY6NK8rJPBgpeMHnD5/c0oyN6G67WA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739216340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oE9Ja/aC61CHup4qeT96Odiagg40Q7TPEFXRUvHwXRo=; b=HENOEqYW23FVkl2qDgOt1R9Yb2YQsPWKLOM7RE3Lz48FdX4WK6IjmMjQ3pPwnpSTyXYDuf w7jBnPIHOaeceoQaNQSfuxT7dsFlYfyy3jzEx0zmDHeAk5kH6M+hYBFq0RurpIBcTjw23V EHg3DsgrXoTX+ZQ2e/tGel8oyacktDM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-6bh0ebsuP2S2vgngL1_Gnw-1; Mon, 10 Feb 2025 14:38:59 -0500 X-MC-Unique: 6bh0ebsuP2S2vgngL1_Gnw-1 X-Mimecast-MFC-AGG-ID: 6bh0ebsuP2S2vgngL1_Gnw Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38dc6aad9f8so1835276f8f.1 for ; Mon, 10 Feb 2025 11:38:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739216338; x=1739821138; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oE9Ja/aC61CHup4qeT96Odiagg40Q7TPEFXRUvHwXRo=; b=JrDq+vWWKO+Rlas7m8p8aIhPaCrth69uduHca8vUdphtX3waDeEPQEUunQAAunkEnC s9VvdBfc2Y2QMEbJkd1LEPzdRZoY1cJudzO4dU0nozMh67GpYyLD+GGyw4MElf1G12kp 6FCQZbEq6P7P46AkFMFNXORErgeMbYcWnUC67yZTG0CxlcSwMIIB/itnutUE2T+sZtDH Uh6SZOSr6JUDvG0Ke7kUuKE7EtcvR1T7QmoAyTHYAJRzL6amnz7XHAs5fxhaP/tRpKUh /ovVOeV/HQClwNVKuz1Snu3ULiD+a2uSxEIjOHYGJ/eykISs4LDCFE6xa0lOm2JCV3L/ EjQA== X-Forwarded-Encrypted: i=1; AJvYcCUlbqF79eg8HHyZilEeb1X9X1sQK3p7Z5n2rKjktZimSrV3Dn7x8/3hPJ+aALbGK+/4+jDBRWHFKw==@kvack.org X-Gm-Message-State: AOJu0YxD0ridq+21Esqy88hpHKiO3tp8Omop7qS+E0sXurNX2f6q2khc FPAVS5LSGnDVZ0+E4MSzfjMGkO7657KlV1fKAcdKzEzAPPFd8efF1kJKBmKRMFOuIgBx6Rkknaw pyFUjgFEFWcnnzhmHXXHku+PXS+ghjR/LcyYtuz8rqLngsbgy X-Gm-Gg: ASbGncse6IejTFImLYENr2RLidwPr+m0zrKbj9A2PqenvAKSE4/w6rzvJZvQiD0g3oF mkWzoZ1Id63HSgHjuwo3gctEsnqoTFYIB+WQf3Zsgjctjjam2pRzlqNiNrhl3fxp4pKrUrO/LKk 6ww4mbDC3+190CmZ/2qtCT6RuDpzbkRvyDDQP6JrtpQ264nYK9oq1bHmtYHvHh+tbPsqD+zQ6dQ sYJP9tWDBK3QQrG728lvGkaZj4eRx6irL+3UnTlKzVgQXGfenzpx0jEpztvcNmZ7+0YBuAi76Rd HEn/L2LfO4sLUU+CaMV8ZqOPUTy9uXEKK6s3qdBIVVn9HahYJrEbIAI5bq8sUV1WdA== X-Received: by 2002:a05:6000:1887:b0:38b:f4e6:21aa with SMTP id ffacd0b85a97d-38de439b7e5mr512550f8f.5.1739216337897; Mon, 10 Feb 2025 11:38:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/uzgNmJSm7r4vj5m1RC+0Hk4d4M8qsuHzJI2p/6gaMOev6b/snbfbww+U3ctbsFbws8/HTA== X-Received: by 2002:a05:6000:1887:b0:38b:f4e6:21aa with SMTP id ffacd0b85a97d-38de439b7e5mr512516f8f.5.1739216337518; Mon, 10 Feb 2025 11:38:57 -0800 (PST) Received: from localhost (p200300cbc734b80012c465cd348aaee6.dip0.t-ipconnect.de. [2003:cb:c734:b800:12c4:65cd:348a:aee6]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-38dcc9bd251sm9816921f8f.9.2025.02.10.11.38.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 11:38:56 -0800 (PST) From: David Hildenbrand To: linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, damon@lists.linux.dev, David Hildenbrand , Andrew Morton , =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , SeongJae Park , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Alistair Popple , Jason Gunthorpe Subject: [PATCH v2 14/17] mm/damon: handle device-exclusive entries correctly in damon_folio_young_one() Date: Mon, 10 Feb 2025 20:37:56 +0100 Message-ID: <20250210193801.781278-15-david@redhat.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250210193801.781278-1-david@redhat.com> References: <20250210193801.781278-1-david@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: c6YDcDGUdajFGxZNzRy0UWfG55N5xSixbDj1bk4rhrc_1739216338 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 2AAC320004 X-Stat-Signature: ceonqk3yysq4ue6wbccptdq9jds5keru X-HE-Tag: 1739216341-855387 X-HE-Meta: U2FsdGVkX18L+ORTJCjPI2uTr4YRZ+0dfnn0tyE5c+g7PhTyaGFKqSidEVPy2OO4RlM9MQo6ytXNktbNRBSpoXFX08ijK1GjzYFhwBd2H7etC0pUeC8/q1LagfV4Wx5PQGb09bd39Mj5QjuXK7SPTO/CSGzI3JCqMW1ffX3KuYEbMQ3kn/iV/oORPhqFMp/T8CCbvENwSv1ajfEbaT9Hun0w2sht8JAuqmQVuMnKBhd2NbqOosNLvxsDE3rWpfRLJH/srCK/M53UtTU2GzrgdNGhG0UZnMrzO7b9v+/ZILUjPizG/6MX40ksNjfCPM2PHPUoXPlynsa5DPwmcju9eph49AMoJkrCuu3z4d6Rcrgxv0/2pe/Nw9XlZqPGTRZFhpH/OixUJMz3UaTykYq7s2KcMBO1ZZ+5TPiO5Q6M0sKPftrbuBNsuAoWNOyjvNYxicpdivdVOMP4WOlirDQvl4+QYuIBZLF0IjYdqst85zrWwHnELKfEW5kAKc/eEONKg47Zgf3rOdtswFQwnrlLgKiLZRXlP4IjLof0XbaDKFGt4xB4HeR7aWaQhCVWvYYftlZi85zL+UC9KlvQb5fqQ0R33UBDtJqHuJs8swsnWUvZMYC359Nx+GWRmn++O2sQhinx73FRpSBU0MXYT3HxlrziGRQlI7Jie71iHqnj3Q9CaKqn0CiQ7MB8Mr3Lqa0UmQk01i2qy5JffbBouL+5qHK4Jp5VsaSQyLYU9RaOkAYhAAsOZMoDWso9mvsWiFgNfcYbYrV9cFGp4+dZGmFV5ZskQ/O3tM8zgis3/352wWvqhXvWacTedm6phjf1e7w1r0Tojm/WxVjGiZ75CGrnQR1SiIUKN+l5GB7BzsAxZH2J1KBnvYIv5DZKlJ8AUMO1mF4+5Ut/iuPpIXBvE3oigwRR9J7F37AK6lTe0vIZPg38AtHaqaeqnSevQPZoyB9mq8bPh+SfMTUmm1Q+x6A nO04OLmR +v87jUIGtOJkjBg4a5u4FFxm0xC8eGapEPeL2TcUYf5v476LHu03eE8I1EVCv57uMoP811QF53LIdf0EFXlzUFegDO2S95ZuLKrQR+LGbSaNUvwXEMfrvVyF22jyXeZ2D8p9sSi1zcfZBb0c4LHGX5WoWctgwGSrIQ1HX5WhgMc4jB4i89aDAl20Oy85OQOV7pNmVxf0MWQRmlxOiDQHBlkO7J/DOT/1lfK7TL4ouQlH73VDlXLkNPGiTWqgV0LY9hbMMEoW6MJuC9nmTY/JM26GqgFigbBfvzZIaj7APCxZSVTyU8pG0xphYUbo5CLsWxn0qJTE/lEkl5bbOtzk2e0PP5VSxegBfcn746e9HGfSe6zSGHmwJpq5JyryztuO+8jKOyRHd0Wp6+l6NlWCd7neDVyUsQWQOkRkrX8rFf5dbjO/Y1YSguicSJjFCTy5ULZzGPzIXm54zk2IHdgiWc8FThu63PY8pOyIkGOwaT1fD2ub24NYDbOWzPlsoAQHu1IzU4574VDsVTMLq0e3lwX4cWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002423, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Ever since commit b756a3b5e7ea ("mm: device exclusive memory access") we can return with a device-exclusive entry from page_vma_mapped_walk(). damon_folio_young_one() is not prepared for that, so teach it about these PFN swap PTEs. Note that device-private entries are so far not applicable on that path, as we expect ZONE_DEVICE pages so far only in migration code when it comes to the RMAP. The impact is rather small: we'd be calling pte_young() on a non-present PTE, which is not really defined to have semantic. Note that we could currently only run into this case with device-exclusive entries on THPs. We still adjust the mapcount on conversion to device-exclusive; this makes the rmap walk abort early for small folios, because we'll always have !folio_mapped() with a single device-exclusive entry. We'll adjust the mapcount logic once all page_vma_mapped_walk() users can properly handle device-exclusive entries. Fixes: b756a3b5e7ea ("mm: device exclusive memory access") Signed-off-by: David Hildenbrand Reviewed-by: SeongJae Park --- mm/damon/paddr.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index 0f9ae14f884dd..10d75f9ceeafb 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -92,12 +92,20 @@ static bool damon_folio_young_one(struct folio *folio, { bool *accessed = arg; DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, addr, 0); + pte_t pte; *accessed = false; while (page_vma_mapped_walk(&pvmw)) { addr = pvmw.address; if (pvmw.pte) { - *accessed = pte_young(ptep_get(pvmw.pte)) || + pte = ptep_get(pvmw.pte); + + /* + * PFN swap PTEs, such as device-exclusive ones, that + * actually map pages are "old" from a CPU perspective. + * The MMU notifier takes care of any device aspects. + */ + *accessed = (pte_present(pte) && pte_young(pte)) || !folio_test_idle(folio) || mmu_notifier_test_young(vma->vm_mm, addr); } else {