From patchwork Tue Feb 11 21:08:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13970699 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 472F8C0219B for ; Tue, 11 Feb 2025 21:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85EBD6B0095; Tue, 11 Feb 2025 16:09:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57391280001; Tue, 11 Feb 2025 16:09:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F62B6B0093; Tue, 11 Feb 2025 16:09:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D58436B0095 for ; Tue, 11 Feb 2025 16:09:07 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 91BBD120BA0 for ; Tue, 11 Feb 2025 21:09:07 +0000 (UTC) X-FDA: 83108903934.23.0094F10 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf04.hostedemail.com (Postfix) with ESMTP id E09104000C for ; Tue, 11 Feb 2025 21:09:05 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739308146; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vnXS272Wjg7KQ1wY+9yT30v+pSEs7yyG8KzaUN+cYd8=; b=VA6j2ALIbR3hq9zHbfcy7mfNadSa7SNijFJTiLYj/Ff7+7DuPGXFKnpwDRY3FWE6RDzeHC d+sKSpbqHw5A3eJoi4UzSDLF7g/Ze7F/vLAYJrhqoPfr5rVNES7tqhcYkGbMtXyFFpwIoo LWa6GAO3eBBwqqXdDytXZFueL6llsec= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739308146; a=rsa-sha256; cv=none; b=ewhdHDaxgyVemqpxf5PAnexv3JS6sGdr7aEdlM8BZ9yBAa+uWmchXssQGyjK+T1/e6Fnid 8u5LQAF5bfQ6riu8bI4+MOZ6obh45lPr2jhJW4arr4/N/u7wxaMWHSfWhtaIN0KSw5DTEI 6WyR+XXQsRWm8S0rZitxuGr0NE8fp7I= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1thxUX-000000008HU-32ms; Tue, 11 Feb 2025 16:08:25 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Rik van Riel , Manali Shukla Subject: [PATCH v10 06/12] x86/mm: use INVLPGB for kernel TLB flushes Date: Tue, 11 Feb 2025 16:08:01 -0500 Message-ID: <20250211210823.242681-7-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250211210823.242681-1-riel@surriel.com> References: <20250211210823.242681-1-riel@surriel.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: E09104000C X-Stat-Signature: bwej6oom99zdgeisxxn9wjkdp3a88q7y X-Rspamd-Server: rspam03 X-HE-Tag: 1739308145-398394 X-HE-Meta: U2FsdGVkX18hqFxiO62QhvAsWGPgFJzBpexLoaRLbEtulsXMFo30uEKqh2eyWIr6ytRf5kd+EDnVwKktJOyAX0evuFM1jBb1TIJbvKRoOFWNCI7aQNrupZBqJPca66m/ppOb0LV/xW3hw3/26X+nakfnpkn3HLJ0c4IdqA1Fd/j5OYD1uDTfNBKZfGnAX9PK64vXpondx6+bjpfSLUcO6DgqLuSlQrQ5F3MwlbeRtPcoTQMpCLpDUjUvZZrWZVk/fjsOdoaa3TFZFeOORRLNqqlB8+FRJMM5uz4wTdTZJZeETDclXG+WpSuVQxJGOJ/ieThPAzY/gpK1kuzUeLS6dCuAgrzARCOpOxe8dNdV3Y8j3xdRlZddGa712/fVgS7XK+uA6gEJIiYV0LWu25z+mD/KW239Tc1gVgUucD32MqT8GTSZBLTV8lEubJadslr5ux5vd7OxrfG9T0eHnK8qyTuJNY6ZsW/Zg3jppwn7u+EDKXU2vGO0BI8hbmdtEuLdZAH5Rh5ee/hTEP4ITH7vyj7UI/zK+/n7pxorPvNlAkZAv+O0mD4RGyhuFgsEFK0WMGNcQUvPuWDoOXXVxr7C1Jrp5fmc2GorLhBMK+Z9T6mihI4pBVRxo3nmsGWRzsibRxB6bAhNGoSMBohQIWStrC486B+HnqdngSMGNjjyq1Kj1VRnSdyOpmsvTLU/YK/wu9I1/XDLW79hF93eK+ppapQbQOtk0zcYSMusqaUPGoT/A9uRb7Pk8QhCvEFqQZV6y0/NRkZv/V5Ro8Wzh3gVslwfvcI+vUwaKvRQyi0hSA3SbbTfyzpLYZYCvYl8n6fGY+J9vzlciAP+rCATlFHMTuNH3ew3AyVu0L6902qIwy+glb4stIa88KsHZhHROtE7i1h4B+/sIN/MLQSufNaqkPFdMKspDip6D2h4ECEAXmqWqVnOPpqAs1bGLOHeyoOuvk2lpVGo+SebOXKMGHW lMoCl67O 1neJgrggGyzS+mDtj0ujN9K8gczHfX9oFaqCrRws1lCEfrAqr2620R6CnY9W/fpDbUF7DEXEGYB//nH4Urf2RZA8Kv1+5ixX1r8fCBeapmM4OZuYXC5Lrzpm0/Q61gyUB4S3WcuzmSU43vnd/HmTOPapuckUfwuDZgExVVhbK+Qa0+4Hkuo62/lp1BUqQ+zDMURxNsquQiaOmngbKMK8O36R96stVWFF05IyqUYTuMyEBUwGYQQzTBzOI77oXkKS2qZsBS9ZidCX4LwvIYKQqKOI/lKqEiXX6fyiDzLx32vYa0r1/TXcv7xi82o8id9VzHMuF38VgsUtpFCclwjUAHmRUx+9JKRxGF9eGt4zMMOZT1WjjEJ9h/H701vcJrVM2g9u44IU6zbRDl1LN7V2CIDYyfkWcxzQmoToH1GTZhMkSB70x61R4Mrz/N4nWadWmnJqBsHv8IRu2wnKsgykiKuL/Ba0YoedG2vAbA1xU/Yb/Jkr2u2R6OzmzMhDFYnwcWGupJgMaWbEptFA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use broadcast TLB invalidation for kernel addresses when available. Remove the need to send IPIs for kernel TLB flushes. Signed-off-by: Rik van Riel Tested-by: Manali Shukla Tested-by: Brendan Jackman --- arch/x86/mm/tlb.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 58c8a6a94e65..54a118b22e59 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1077,6 +1077,28 @@ void flush_tlb_all(void) on_each_cpu(do_flush_tlb_all, NULL, 1); } +static bool broadcast_kernel_range_flush(struct flush_tlb_info *info) +{ + unsigned long addr; + unsigned long nr; + + if (!cpu_feature_enabled(X86_FEATURE_INVLPGB)) + return false; + + if (info->end == TLB_FLUSH_ALL) { + invlpgb_flush_all(); + return true; + } + + for (addr = info->start; addr < info->end; addr += nr << PAGE_SHIFT) { + nr = min((info->end - addr) >> PAGE_SHIFT, invlpgb_count_max); + nr = max(nr, 1); /* Round up if the last page is partial. */ + invlpgb_flush_addr_nosync(addr, nr); + } + tlbsync(); + return true; +} + static void do_kernel_range_flush(void *info) { struct flush_tlb_info *f = info; @@ -1096,7 +1118,9 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end) info = get_flush_tlb_info(NULL, start, end, PAGE_SHIFT, false, TLB_GENERATION_INVALID); - if (info->end == TLB_FLUSH_ALL) + if (broadcast_kernel_range_flush(info)) + ; /* Fall through. */ + else if (info->end == TLB_FLUSH_ALL) on_each_cpu(do_flush_tlb_all, NULL, 1); else on_each_cpu(do_kernel_range_flush, info, 1);