From patchwork Wed Feb 12 17:44:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13972256 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F397AC021A4 for ; Wed, 12 Feb 2025 17:45:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66FC26B0085; Wed, 12 Feb 2025 12:45:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 61DCE6B0089; Wed, 12 Feb 2025 12:45:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FD8A6B008A; Wed, 12 Feb 2025 12:45:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 19BBB6B0085 for ; Wed, 12 Feb 2025 12:45:54 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B9CFCA036A for ; Wed, 12 Feb 2025 17:45:53 +0000 (UTC) X-FDA: 83112020586.16.581445D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id DC2EA20011 for ; Wed, 12 Feb 2025 17:45:50 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AxzR0TVM; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739382350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ntZvdCM3c/JyXAKXy7qacXGsePAf2QmXkC0MAa2HJ9g=; b=IhA5VA74oAo84tY6NRANDsDdEkxLKsKiJMB76lGZZqENtZux50+inq507r0hxuC2fP2XKj BMsGU8Vp7uLQzoKqLJDXheva4AnT/VrktfRy+MYcG8lU30y70cPR4XzafwOu2mRgInjFP8 +FX9u1idhI5rfIxx1WBNUqv7X7V7qhw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AxzR0TVM; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739382351; a=rsa-sha256; cv=none; b=AMev/UONjhWo5h1BX7fuWFpLOkNiSQ0yAi5zOO0aOF/LUDWHWJ+TUoWDMKcsX+IB1VofpF XuBxLHzGbxTIt1Cr3lLAzVzlvjBt+P4eYhW/0UH+SIvLqkCXco5CpQqR9xDbPHpg4cA85v Z8BbslbN2gX42S1PI/dEykCoqXtnSDs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3A2955C611B; Wed, 12 Feb 2025 17:45:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2391C4CEE4; Wed, 12 Feb 2025 17:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739382349; bh=i+ImuvsxORMr/sR+be1Pph9bvunPitRZvD6hqlNBEDc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=AxzR0TVMTWyh7xnme+LP3aCMji8bjWSFBzALs5tg8UnbVBKsq2PQ1Ona5m/IAhNoZ QRhGuk4k1TGgC/0UNnLN5CJh2+StUeUYr3QQyRnIKneHc3HELKpImgcGE9hlp/vUoy MXY1WBustxHpoRrKjgrvzuc8TG7PmlpKNY/9EV7VbJbN777CmuUJ3TQR/De3pZZ+h9 yvASm51NVg1e32ubpwElq98lTnfOKBEqST7g8gW4Pi1jaeV64umfFaVBnoGstZNRg8 z2eXdmw14zdc0mmlvVQ9F632TXqdbpMY6TSFGMYAarNTLsD+Cq6ydEPFE18VmQDO+s imb23PLFpROyA== From: Mark Brown Date: Wed, 12 Feb 2025 17:44:25 +0000 Subject: [PATCH 1/2] selftests/mm: Fix check for running THP tests MIME-Version: 1.0 Message-Id: <20250212-kselftest-mm-no-hugepages-v1-1-44702f538522@kernel.org> References: <20250212-kselftest-mm-no-hugepages-v1-0-44702f538522@kernel.org> In-Reply-To: <20250212-kselftest-mm-no-hugepages-v1-0-44702f538522@kernel.org> To: Andrew Morton , Shuah Khan Cc: Nico Pache , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-1b0d6 X-Developer-Signature: v=1; a=openpgp-sha256; l=1316; i=broonie@kernel.org; h=from:subject:message-id; bh=i+ImuvsxORMr/sR+be1Pph9bvunPitRZvD6hqlNBEDc=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBnrN5IUrvy3XDSqCWlJNoAoldjlOInN9p/4/cpcJIZ Y9o6aq2JATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZ6zeSAAKCRAk1otyXVSH0JjuB/ 9DgRF7lxnlHn9mSwi0nb59wQR/eez2gNc3inHbieualr91tybkbV0y8Cpe1SWLVlq/7jK/rgEHpyLR ebFumJRsjPwdmvzTymL46uBAb58j00Gn2w4egP5T2pSEc65iseDUH8WfwjUf9CRLJx6IDUCpOXxx58 AFfbcw8iHN3lpVsaBqYmQ7Uo/i2qefQjvNXJ61hNkSqgt0XL1C+pAQ79L3ddx5A1Ek4uLl2XMvx8Cb ryFKehJBJaIAHkbTXkYfrPKqfTogBCDBQFNCHjXsDIftRSqq45VySEi77k2BJCFqg0THXV9Ah582oC HzdAPRTB+sesizmKW7o7WpPG09Skeo X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB X-Rspam-User: X-Stat-Signature: 37bn1xj5gotkcuy8xf499g31scx81af8 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DC2EA20011 X-HE-Tag: 1739382350-473717 X-HE-Meta: U2FsdGVkX19yOmuf1feKthzVh7aTTO4qc7aHKmENcsMzuX/w2mIA6zmoXVZs1IgRYbBKwjt54TW5TtXr2fV2gjXDJyo5fhprUP+P+cTPsJr75ZtCMAUMc0eSnSYIJt8U+1VRAA+Uc8ckC5g/Puh8STM7Ah1rKg6CmtFR4Obk9SOWDF9g9yGTpa6JZ3/WJzy/OD+222UOVozhIyPH5G5W5V5a9jeUA57mn9D49lKJIWIHHQzveKQBBYuA8JWH5z0bw5XsnH/2VW7J/SPAQiT/07S9JSgmL2JS/fue9gav/mPFhqe/Y8o400RUQCW9cOSdsegoYP2ikpsMubmS2MizFAHE75vP6ImR/ALjPDIOGTmj8QIlmzBrYXhPZ0+5NhhV6PnBVvtMQqf1zb5U2i8xiqj1Y6succJlIOOSKcWsGaDMyQTFlv9tXaDNhryKKED5vUIeCNsCQRHRjiA1GMxgC3WzbFr6hjOgHonnR9tTmp34OW+M84vf0gnJJwRmKPVLrnQXxwXAc7axSg/jq8ckbydcTQrIWhl8RQuVQwjCcWtMr9yf5EfNmBsdkPgLkftUHya56gpfW5bHArytN38dDceCaOhFL1vWciEF4oO+awP5E8soJ5C8CDA6cEHqY5HsOpsNllJRhNzjnkC9fsfnQyGPA+KhZqq9m+zQJ33VKj3/3Z6p9rJ8aLvojrWJYCQUtiimP0v/meHlq+iRN/rOuin+N3q5+/8jmvYtSVLGP/fcUBTFB8Kn44R4hGPsMiO1MXUfyb/JNkpxAz2gelMpnhiKXbQ3Nm0qjKJT0GYaB1hY3W2e1zFdo3XelNXAXOmRfpOhgUw6FJHiwzBaBp8nF5eMi3s0ctmbjxA+8ZqvAqftvZUt387bUDzJUKfermJq/qLp0mzAOeyIWjjlX2Aj4BmxP7ErGN2uoIGlkiHOu6meW7n5Gaz550rFixipGi4WM+a1RcZVkG1Bd2nbxDb GhmZeSe2 4eLSW4+Bp3kzZzkiuMwgIdZ7nE3oyRbnZ31EglyvczreYJhQ7DHnq/hHblmQDo//cHsslFYLTp35hTen5TofKSpQT/QfYR62Tq+hwCt4LBrSK7wRqv68RsCWER6vqOc9vAz/wmI2BaivIzB8CoQyYzE3NsXN2Ta9L1fxKWE+yrkChlbIPy6/Llnfng6hjoqHMYSWvK1uFJH3Hx/gfxTE+zopWKb0887qr1FdT9rwOVxmrwVmbDIYnGN8DeA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When testing if we should try to compact memory or drop caches before we run the THP or HugeTLB tests we use | as an or operator. This doesn't work since run_vmtests.sh is written in shell where this is used to pipe the output of the first argument into the second. Instead use the shell's -o operator. Fixes: b433ffa8dbac ("selftests: mm: perform some system cleanup before using hugepages") Signed-off-by: Mark Brown Reviewed-by: Nico Pache --- tools/testing/selftests/mm/run_vmtests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh index 333c468c26991421cd8f9ce6d995f9b64b0643c7..da7e266681031d2772fb0c4139648904a18e0bf9 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -220,7 +220,7 @@ run_test() { if test_selected ${CATEGORY}; then # On memory constrainted systems some tests can fail to allocate hugepages. # perform some cleanup before the test for a higher success rate. - if [ ${CATEGORY} == "thp" ] | [ ${CATEGORY} == "hugetlb" ]; then + if [ ${CATEGORY} == "thp" -o ${CATEGORY} == "hugetlb" ]; then echo 3 > /proc/sys/vm/drop_caches sleep 2 echo 1 > /proc/sys/vm/compact_memory