From patchwork Wed Feb 12 01:38:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yang X-Patchwork-Id: 13970915 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C205C0219B for ; Wed, 12 Feb 2025 01:38:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37E616B0082; Tue, 11 Feb 2025 20:38:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 32E5A6B0083; Tue, 11 Feb 2025 20:38:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F5526B0085; Tue, 11 Feb 2025 20:38:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 038476B0082 for ; Tue, 11 Feb 2025 20:38:33 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 64115B20E8 for ; Wed, 12 Feb 2025 01:38:33 +0000 (UTC) X-FDA: 83109582906.21.43502CE Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf18.hostedemail.com (Postfix) with ESMTP id A52A31C0002 for ; Wed, 12 Feb 2025 01:38:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VflapTDm; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739324311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=dOK/KCmFpe+yoS43CjXw3iE3RR23v2iyWjsE/vR+VjA=; b=zuF22vMqpVNIcQISoFvSJ6fchf3aHLUKyOJqOWZkghgptnOtK5Wb6jbWn90TvtTauK02Rt ou2XR+Tes7uuMoYBI5ueZuG1MfneSFLJY8H+pqzU+SrAYKeCSnqvtIvD47+/8UFtSSvhAg xNyQF/l7TNDKJSaNHeHga4XGdV5iMgo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VflapTDm; spf=pass (imf18.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739324311; a=rsa-sha256; cv=none; b=zoQBE6P24Z03t7bP7zzZw/Gt0bQeuFZGMigimWbAagBFjStlt5+kmgxJxdpuatyyiQ+gCv f+Gi6nR8Uw/knqMvYYisV9daLG/eOz3zH0yBYhoUTIkSGY4w5vs+89Te8RNfyejrWG2D/x AjrQMKHmat7um8vWK9/2fIp5j365huo= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5de4f4b0e31so7984227a12.0 for ; Tue, 11 Feb 2025 17:38:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739324310; x=1739929110; darn=kvack.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dOK/KCmFpe+yoS43CjXw3iE3RR23v2iyWjsE/vR+VjA=; b=VflapTDm1ZT4Vrw/bTDC0CbtNENgV0LfWOeSxsJIqn86bcv4FnF+btqQMNsLqa0fPC B0izSsnwBpE3R6eRFMQJUmzc8BAcKA/WcgVumzgyVMpzH+PxIr0amQQm1iubY9AyxqBs XfNV9nVXZZQ9o9hSvvljmMJtb4QQfHFOi/bklbppbBq02JnM5ymTOdtIlpfeSHmQHzqt 9pnZmvrTo/Mb8tygTFM/vNR9bHeu7oB9FvYvLfD9EanCMmuMAIKPk0YwN2IeXoaXb3KT gjxxkQCq7B/v2p8TdtiEh8RvJUGSAdr3M/Pd3BLusXRBT+Hf+vARylc69jSlarZIzfUB ri8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739324310; x=1739929110; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dOK/KCmFpe+yoS43CjXw3iE3RR23v2iyWjsE/vR+VjA=; b=bK7ekPdw7NISpyge7iQiLQbGkmTRU3lvvqWw9a4iw1q/JKhu+jImNvH5ZsoS7FsHjO fji24LEHTXxbPOL82TVn24fmg3+bgyYE+87yYWFqwAUs12mvmuBqI0StBunSUFiUtlv9 ajgdRqvD5Ai8WGNaPgRo64DO/hKGXf6l9IrjBRTHg7c10BCi/JFdU59QM9hOq5DsjlUB eAXp8YzzrRE3+hW0Wgc3VrPFEuR1s0Uyb2Q7M/SEjPbCyE0/NrdxEJkGHm8ZXiUB4zd+ tATlNHyxgNHGnA2cDZ9Cf74WOH3WOhe9kmJpE/WUzR1jdj4iSryC7sOzlU0/zQi5is82 2FdQ== X-Forwarded-Encrypted: i=1; AJvYcCWj1KpVjIUvqCus5UNvSGn31Svd/vyd4CC0cJwk7U7zGwFj2x9/ITZ4tcoBxm17ZyxmCebruUy5CQ==@kvack.org X-Gm-Message-State: AOJu0Yx8Ug7aN6UNYzmeFvgJMItIMzW5+0jn2N1SoWgD7mOPw8HpVnp7 EpoQlgb+5alYMD7x4GM+6CeXMfQsII/c6s/Wn20XGwxVSCRd5nZr X-Gm-Gg: ASbGncttkDCEc6nxoja5HRsZ4DAijBewEDS2TcvPq1wNJ2h+F03nw+zqOAJi+ywfD3G 7LkBsC5+eTkKdmlNsHgdZD1MKJro2JN5/ujSaMKFmk1u2kM/aoXyceY1g/LXKJK3BoRXvNHLGag 8mEyrSYNzueqGM0lScp0w9eaVPsEqE76r6mqYltK3pDiYYmBj71VeydntRp4zLEqRLdONmGvl4g 6Fz0AWkmwUCrbyk4HMDAue60pFv8trLGoopqdpriKFMhsLgLi0TT1G0GHommdJUJkMI8n55E7tX TtTrW1j17NxAYas= X-Google-Smtp-Source: AGHT+IFbol9HJnzdzkttOE6j4L9vcqlFws7HzRHi4BuBvWhtECu8n+ANj2NzgD5cMEtOFCxv1yz08g== X-Received: by 2002:a05:6402:1ed3:b0:5dc:d913:f8ae with SMTP id 4fb4d7f45d1cf-5deadde631cmr1092390a12.23.1739324309812; Tue, 11 Feb 2025 17:38:29 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5de62512da4sm6810022a12.81.2025.02.11.17.38.26 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Feb 2025 17:38:28 -0800 (PST) From: Wei Yang To: rppt@kernel.org, akpm@linux-foundation.org Cc: shivankg@amd.com, linux-mm@kvack.org, Wei Yang Subject: [PATCH] mm/mm_init.c: use round_up() to calculate usermap size Date: Wed, 12 Feb 2025 01:38:18 +0000 Message-Id: <20250212013818.873-1-richard.weiyang@gmail.com> X-Mailer: git-send-email 2.11.0 X-Rspam-User: X-Stat-Signature: 5cgqtoczkmq9j1fdm33th6he5ct51kug X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A52A31C0002 X-HE-Tag: 1739324311-191592 X-HE-Meta: U2FsdGVkX18qrJ9K0m/0t0/LFp3JeAJW2TOj1sGAb4cg1fzT7P6WyAxbtlzrP2RFnvbASU5I9bx3MXaVg5Pm473zB1gwcNs6xRWeW9Lu7PzonALJo+N78KsTO9tjctz2kbZIuSTbwnUPIsJwHIP5u7sKIGV48PTEdrm8GOJ0dWY33lWXiKP3PVGuELK8QlPhUeDBNpRTH9gSXoRGNCMV1bBwGNRKE0mA2CHkZzEU6RUYZAs0PZaZpMcPUqxKssDsntpdYas/gX4p0JsS2dY4Pa9RCIT+qUWvrmxQj5ralzVLV5KXeaTXytZI5HY9uq4Wn8bECOIbWEmtAA/Szw+k2FK9Tt0h3atjQpfWUbfDiP502GkNrQ5xgUVv/M2YXsKFWD4S+0wlsFuUALWnJR+Lr/RWh2sdtJ28qmHQiy76bIBi/9wxYF03OYTCCXP0ShvpLYmz0eoiFC2xHSVI1LMwbcJ1jjr9MXaNu10P95PuI1BmKq3Q8Dz+wOnapAakr9U1WY+iaagDDcKKCr3IFox4F2XZmb4B0DG7guvEqT/a/ca/qilN/b5iTsEUrUs1qWXx+1+rJOxxNKKdtR/BLKLyIB1IJDixktImXAZjsHkzJTJ3pIJOZCYxrEOFnDinN8mWtkypg3SMYQauNLys8GoQMe/slHJqj+Tfxo3PPJ8vsFdj2lfKNANJ7Kgt25HXsELOUkDISjSTCXXqa00fZxsWuVWu5ocvtiKi/qJBvCcQP+IED8Wp6HalHv9Th7zYeaqnHjiH5cxUBwQBQbnXmUuEN+S7ThYFB+u2gx4/c+lHXexal4FFIWxUAL5I51dnwlNDWpr1WyWj/qeloE6yBIw2HF/2KpHgk09s/+cQ715FXa/atBPfKtbdC61eWkDxgiED8wo2dQuN1r5M8DakGLoP4zzv02KiP80jPc5eNmEJarv9fr7Ajp/RbqthHIJZMkUnxOTXMbkRqSzcez4rf3F zHuY6Jep yehrpIRwriO0IqoFX/TR3ackFwRTYTKiVI8b2E9wlpdJ0HmZLdYUVZvOJWesl0B/R4WxmT28YV+NIlv+cK0yvnj8wTqRLEiY/FCgJKO2CeS7S6H4xCqocmq6Ju9F0aTsUGkttBE3O+wlCBHu3dJqwgceIGXd+YpGDr3KSAs3GyxmpgmyqGvZ9jTqcNTmgEnPHmxghMDpW+4oINxb3biTL71peUnp46C5R95bnYw1L3lRDadNSeTyUxDkGOVMRiZRpASTkXppTLtsHbyOIlvhAhG3KLY5c1YDKCt57bhnGuqyxLcdR+i1C4pm65SnZkK0b+Cyk54W8Jr4rOit+BC+TPWv2R29XJrxFZ4mRCw7MPPtxLMrKeYEKghkUTlepqNkir90Mxq5N+XB+B9cDVPLI/P8FK3ijT2mKRJtn3OCT6KSDub8ANwiki97iAkjAjTRavGM0+mNVP/noiypQOqbGVKcOpgTkrTJE0Dz+gVVEa2vS5TBhQO/7/WOKaFClv6ZzQtRG1aIikcKLA6ROzI+x47h8AGqU7KvAnEtsvDInd++n7m0EpQGL7H1X/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000078, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Since pageblock_nr_pages and BITS_PER_LONG are power of 2, we could use round_up() to calculate it. Also we have renamed blockflags to pageblock_flags, adjust the comment accordingly. Signed-off-by: Wei Yang Suggested-by: Shivank Garg Reviewed-by: Shivank Garg Acked-by: David Hildenbrand Reviewed-by: Anshuman Khandual Reviewed-by: Mike Rapoport (Microsoft) --- mm/mm_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/mm_init.c b/mm/mm_init.c index 3ec50b5fda12..550d5ae98cfd 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -1459,7 +1459,7 @@ void __meminit init_currently_empty_zone(struct zone *zone, #ifndef CONFIG_SPARSEMEM /* - * Calculate the size of the zone->blockflags rounded to an unsigned long + * Calculate the size of the zone->pageblock_flags rounded to an unsigned long * Start by making sure zonesize is a multiple of pageblock_order by rounding * up. Then use 1 NR_PAGEBLOCK_BITS worth of bits per pageblock, finally * round what is now in bits to nearest long in bits, then return it in @@ -1470,10 +1470,10 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l unsigned long usemapsize; zonesize += zone_start_pfn & (pageblock_nr_pages-1); - usemapsize = roundup(zonesize, pageblock_nr_pages); + usemapsize = round_up(zonesize, pageblock_nr_pages); usemapsize = usemapsize >> pageblock_order; usemapsize *= NR_PAGEBLOCK_BITS; - usemapsize = roundup(usemapsize, BITS_PER_LONG); + usemapsize = round_up(usemapsize, BITS_PER_LONG); return usemapsize / BITS_PER_BYTE; }