From patchwork Wed Feb 12 06:27:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Senozhatsky X-Patchwork-Id: 13971034 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8A5C02198 for ; Wed, 12 Feb 2025 06:32:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A3D7280004; Wed, 12 Feb 2025 01:32:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82C22280001; Wed, 12 Feb 2025 01:32:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CC47280004; Wed, 12 Feb 2025 01:32:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4896D280001 for ; Wed, 12 Feb 2025 01:32:36 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C45DD80C8D for ; Wed, 12 Feb 2025 06:32:35 +0000 (UTC) X-FDA: 83110323870.22.98EC05B Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf18.hostedemail.com (Postfix) with ESMTP id E211D1C000B for ; Wed, 12 Feb 2025 06:32:33 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SGmR7Cst; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739341953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MP/iUhuHVLA6wFxJBrfyM09o41KGkhO8ufnVXdUQ+KM=; b=2BJb+sTV/lH4sJgO9/PmUG5fHlVpmTKZBjIcltcUt8UTTw3nbmpWb3KpHtudBb7Pzn9/kL G2H3PdjpXmVnSY58zaoF+3ge0QK0B/ZQuSAJbVnmOUJNvbrM6iBWEtk12s8WXCn8l6NMc9 jsLhFCJbPW2Ktn1e/79lMfPC6VxJg58= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SGmR7Cst; spf=pass (imf18.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.181 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739341953; a=rsa-sha256; cv=none; b=SF7DuodHiHXv/x9esJIjBrvUhWN+fIxUToAL28aOG3Z/7V+NMvexMfFSnNfpCxVa65IQCj wh4P7598CyPK2ZqexUEMLF5n4SoEx2rccdu1e6kGDwc6nceHP4Xsa8PTjQ3xEkvCIc4fhE Y8scxD+G3lXRYT1gJn1a8xiIAC/e9AE= Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-21f818a980cso57281705ad.3 for ; Tue, 11 Feb 2025 22:32:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739341953; x=1739946753; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MP/iUhuHVLA6wFxJBrfyM09o41KGkhO8ufnVXdUQ+KM=; b=SGmR7Cst+/WCOBs//xeN9gBBd2A2DEdpu3uzPAFsW9xNRtWvlBGP3flT7Ar4IILtwn tK2nS7h2dUj76BqlJltB1tiy6IGz6GPkO9O2/sDe6wdIbQ/to0IbXm2jqv0uceYnIM3G tJCeU5t0AXHRhQL7Dl9sl2SBlUD1GAAqZcjAc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739341953; x=1739946753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MP/iUhuHVLA6wFxJBrfyM09o41KGkhO8ufnVXdUQ+KM=; b=CHX4Z/0kHmydvI42bCYnBHpwT2L4eIQ3c4sZeXrFHGiEsCp5loIZVn4VOqJspg5UgF 1rvELBR4cna3SDbsKcemTgic06mlbMX6rMr8x4IRHcQmb+zaUl9ikPYCnvkS03e4h0Nd IagJ4hfmHFc8o6hjiSIXITFJvSVjcWjwgj1fFnrwzJHPwRgV7T/izPG5Gz92/ZmpCQtu kE3H2J9HK5yJiCKa+dnViM6bWSCWKfNBa/vdTPZ7AcatKShvyRfnkmhUl2tUzZvB51k1 w+St3E1RgObSY0xfXY5WL2K3b3NHbMk9yI90hVG9IdtAQPSaqHCOeOSvkmEOMYF7IsN/ ckoQ== X-Forwarded-Encrypted: i=1; AJvYcCXWgoukVFDv1jSWGaBAFwO4qrspBEb00a5Ko75b8me8tfblVlaoDwA9IeG8ZcEqkKJyjO5wtP3fYw==@kvack.org X-Gm-Message-State: AOJu0Yxug4QdND/RfT7smRB+PTYdBlCEwsm5sEspZQBhGSfPsHie3FAJ kGB2t0LVLJRQKPuKGL6g+oIaOzt2VBjXBWLbpDdqiWCYDUELNE6O/0nmPrM4TQ== X-Gm-Gg: ASbGncuuYH7nFpmRZdkjwCqGLTgkSDhYIxFfbgj4yUw6rcKDhD9lL2sZH1+9c+/V7E4 bi3GPKiYvDZX5sypoV19YvgO4908p2lmABAZLO0yTlzfSVgBfhzi01e3jH6V9PU0E3EZ+dZl7Wh 1WKR7Bpok9fKwtzDxcIG1QPivEduAP6y0aZ0NWV65P4Dn099ZjyFjWBZxrZI0GpsXi3ARMGpRlx ed8fQQBo3DnLWtNI8A/RmETFVkh2KAznILBCp520xaQiymmrBHulFyxdedrqCNH4lg6q1F4HmHI idv7RRJEWTsHKtqtGA== X-Google-Smtp-Source: AGHT+IE7SyVtE81IRMZ7QuZhJlVL0CH3JofgG8lKolY4V/dbLjW0GVG8rwvz0sFKRCNuv1wj7rDucg== X-Received: by 2002:a05:6a21:6b17:b0:1cf:27bf:8e03 with SMTP id adf61e73a8af0-1ee5c840a69mr4005891637.26.1739341952903; Tue, 11 Feb 2025 22:32:32 -0800 (PST) Received: from localhost ([2401:fa00:8f:203:69f5:6852:451e:8142]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-73048ae7f6esm10423017b3a.74.2025.02.11.22.32.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 22:32:32 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton Cc: Yosry Ahmed , Kairui Song , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: [PATCH v5 06/18] zram: remove writestall zram_stats member Date: Wed, 12 Feb 2025 15:27:04 +0900 Message-ID: <20250212063153.179231-7-senozhatsky@chromium.org> X-Mailer: git-send-email 2.48.1.502.g6dc24dfdaf-goog In-Reply-To: <20250212063153.179231-1-senozhatsky@chromium.org> References: <20250212063153.179231-1-senozhatsky@chromium.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: E211D1C000B X-Stat-Signature: as3djy5b5syhbqpxaeudfgoi9wn64kqq X-Rspamd-Server: rspam03 X-HE-Tag: 1739341953-504418 X-HE-Meta: U2FsdGVkX19TiagQ3Yec5sBPUVWVis4BXzN7mXOe2M8t1hpMIXuoe3ObJetEFGu7efxkcfPPjMaSeJ11Dpqwz309RNJ099n5jpJYV5EG8fZZZkkq4SkHwlFNIGCHy1cWTKpGpBZIFQTEUjmRG4XLrcsEXRgOhgVtKYp2mKgEkWe8QMF5536Uc5vjuwkfQ8peFrrMGTreE3IFamWLtJydBYTi1dbow9xBloWKIjubZzShfhVCmA6V63sB1/cgSiUgy0jy3Zz2lr3DkGbZ82P0/khg9RXoERENsnoKp8/539/1b4bRpwt4hviG81ovikcsuPQ8FZHWR6tum2VaN54T7iHChzOYfDqru0sYhTk5WU9MUTm2SYOwNJ2j3phri/Dlf/dNpwMKr3qJkd54v76eQr03Yxzg3HDV0hLIcgXx/AwTEar7Kv5J7fjwmpaBqDnNGaqBqbHEFsTu2XATa3zHUswwg7ffFyurtBb+gm4A9wBYguimvaG9vGAAX95R//MTQPleXVM8AiYtCo6/PHElCXkOv/GBewp0PfmZKPqQzKpLnNjZZkJAUK9qwUS0eQp58kCdT/q3bqAVQQA86FLJE7mo0yot7jp9jS/CeQH4vCCbxRfVR9Zx8R49T2KjtiK+hwoDIqnKcFsnFOoiX8vOpwvxcCAcuFA04zhlQXTl63wQZVPR2rHURNaX5g0tbWdHrBBfAkAnh4+IIP+7xDkAlzfUAl25CrqtTw8jGPx8rNj7HiVWJ1W9ZeTpRFLK2iVSN9mXtkzzzCayuiIdOFFPyF9uFJJR/tKlVb0Cfkbf2k08DsEAciaGNr83amEx/Sr8lAiYXU6QuWQAX65E4ovD0AuNC8656C9UhbwwSkZjL8mDYbQ7hkxY+0GNuCMAyoFfBRdKyOqdewsKamuXK7XuLZKOF8m2MmaArZNg3tpMy3KnkR8tgOVm9wc2An3IoqX6p6iURtgA4K6bMWzeL1q uCzl5+R7 8jp6KQzta4M1D8OsQ3uPuJDQ+eP4k+wCARF3kQrIx3Q+RMi7yTY1+U55lv8ik32z5H97xTuMnmYG+qsMK08WnOTVgLfTkZpIxnJeFJL761zCpnDTLNZeW5j04fxkzyKiXB7H/2LFImQu6kQBlrN83ZBk6NlDurbBSh8vKo+h90p25GpX/JHUN8DGZpjzKKUcSY7puO+HMCU4fDdtPGs6I0e9t5Tg+ISNabh/X17ErTprbCQEGKv6XGi2OZsZvZp3SZb6Sshqfz8MHhqOiERJ0dE3IyZEWS/Nz/3jkL+R/B1tH9EKhYmRP+RrUz29icAYCFuABmSkaqiZH8kTfwi5i1ZNea+TLmAPqm2hxe0LygVu+a0A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: There is no zsmalloc handle allocation slow path now and writestall is not possible any longer. Remove it from zram_stats. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 3 +-- drivers/block/zram/zram_drv.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 6384c61c03bf..7e2694079760 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -1438,9 +1438,8 @@ static ssize_t debug_stat_show(struct device *dev, down_read(&zram->init_lock); ret = scnprintf(buf, PAGE_SIZE, - "version: %d\n%8llu %8llu\n", + "version: %d\n0 %8llu\n", version, - (u64)atomic64_read(&zram->stats.writestall), (u64)atomic64_read(&zram->stats.miss_free)); up_read(&zram->init_lock); diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h index 97c98fa07954..b9528a62521e 100644 --- a/drivers/block/zram/zram_drv.h +++ b/drivers/block/zram/zram_drv.h @@ -84,7 +84,6 @@ struct zram_stats { atomic64_t huge_pages_since; /* no. of huge pages since zram set up */ atomic64_t pages_stored; /* no. of pages currently stored */ atomic_long_t max_used_pages; /* no. of maximum pages stored */ - atomic64_t writestall; /* no. of write slow paths */ atomic64_t miss_free; /* no. of missed free */ #ifdef CONFIG_ZRAM_WRITEBACK atomic64_t bd_count; /* no. of pages in backing device */