From patchwork Thu Feb 13 01:44:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13972683 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D780C02198 for ; Thu, 13 Feb 2025 01:45:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 215D16B0095; Wed, 12 Feb 2025 20:44:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A6056B0096; Wed, 12 Feb 2025 20:44:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 064BB6B0098; Wed, 12 Feb 2025 20:44:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E02C56B0095 for ; Wed, 12 Feb 2025 20:44:58 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 96BE4A1605 for ; Thu, 13 Feb 2025 01:44:58 +0000 (UTC) X-FDA: 83113227876.18.FE26519 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf24.hostedemail.com (Postfix) with ESMTP id 1003C180009 for ; Thu, 13 Feb 2025 01:44:56 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="W0zx/kTI"; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739411097; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MQy8VeusXSXlPG0T/2RwmSSaH0w6VfVVSi7U9OjNhBw=; b=oHB33jcKkvj9XsxHC6lmNuDuHcLyJ+pUPjyBcAA5qpadPfGA06Ciy98fnYOizAPB0Ie4Ww NeAXRiT8cmY9zkVPyN1YAE5LSCKtUxdu0THKxkEmtLRX4qrygmMLB43BEQOmtz0npkR6yX O6gfcni5JwFqJJING+PZVtryGeeAmz8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="W0zx/kTI"; spf=pass (imf24.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739411097; a=rsa-sha256; cv=none; b=tpF2vr/Yb/oAZ9QitdQWD2GYfISiS1ZLmCDodEnYE1FEpqPAAmKiUFAzN0zD0hSFwgatwY nmvx/ueBMPFBD+pyYgJdcmdDZnBef4ofne63VWe4LCMRPCUB5Onz0tKUerX18YtOSGYmOk Did24I69npthb1kxGXiUVWzaICm1QoE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 1E257A41C4F; Thu, 13 Feb 2025 01:43:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA836C4AF09; Thu, 13 Feb 2025 01:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739411096; bh=MVqyX49p8y3GlcogxKD7CIx6rSRSsVTH0dE/ZziaIYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W0zx/kTIiC+vKHSnUdUAWWceChod/BOyQP/fsFYtN3UZVwjdEfKMwtMEtY8/+bqhA hUI5afRogWIuMib6k0KuzfoFI2gdcT8sbFTTgxIOaLhy/PoOXSOP4E8edZs5TSJrtX kR8vOYZHHcbIUpF475k1BM28SGZqylduU6kma3vAO+WLWIgC70PSit+vBvhsgb640/ jEKqaPnURFh67ucsczUBXUfHNU6Da+wAeukmMmWngkN91zIUt+AESfngjN6j31HBHt 8Dy4/89i61sCZUNeaFk/f6/X95Wk1VRfhz+YFqX3Yz8cN/WFl47n5BSDba4PW+23+T 8MWhy0WzbF2hQ== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 3/8] mm/damon/sysfs: implement intervals tuning goal directory Date: Wed, 12 Feb 2025 17:44:33 -0800 Message-Id: <20250213014438.145611-4-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250213014438.145611-1-sj@kernel.org> References: <20250213014438.145611-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 1003C180009 X-Stat-Signature: 9qkj4sa8jwc9rkins4x3kuw1ym8rx3mt X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739411096-161435 X-HE-Meta: U2FsdGVkX19K/KQlKhtiZJLEB1WQgb1R4FIW8xLRYW0zN0nFeREOPg8yqabFArt0I7dwn8rxR+QwXyZ9/uz8PXm3Rc1Zt+KfD2WnZb+ADEWDYotxsL+OvGaXauY+vzgNzU4RNE7psBLJ7gMlmmBwlei7fLH3dX810s069fIgNIZR8L1n6PTLP3woTIRlP3OEB0FMc/qurdr+K9saerPvAf/FEhVB00xwD9zFkHkLuQ0x8JfDRuXaI+SHMjX5na7Ow9rV1qfNFq09hUvMABQ3+/8zeixZlGNgJEztT/k17UnQ+2qm2eGGrjdWhBkO+zAP7uj+rOEVfNYwl/OhBEFe35TgSAHb8BzBIEMaD7025XJUo6ILu24uALcxOhWavi5zaeUX8DGVCTTpZK4dK9tESOZbHbUDqgohg1gDukhTnVzLBZnoEICbspfngdAeGUu5o+BC5niE3MKseZa7MdpJX7ax0H7Ejyncn8sRk05JU1sRCgXXZl/MH2ed5sf4DSC61M6RgJEnKd2JENt+8hCk0a2DlJqiu1WG5iMCPGV9Lz9RetHpwYXhq5lrEb9+K6G6cjaVnwiUk1eJSfBVNFxELYV1QcROll71O6P0NNXxLLgiyTEn7UP5kEpoacl2DUW2KRSPbPT+U9WD+LO7rT0CmfhESRck31oOWTbfxy3MmNq1tCi7I40xUF2HdP42nq4OW2fVN6ti6UX/QRnN20Roro6iHHmztd17ESg3RnDoDur961dj5FlFCkhVMm5KfUpSQ7rk/z4OWUqYM82v2VY1/iBKn5c9HB3eB0qtybhxt+wNam7KfmZnIRbGGsmPOOiq59ccPRdVEg4JOOlCkFkomcjzqVBQzkEoN5jWn6i6upuXgpWur7f1PR9o1QNlP9NPaS8k9Kq4q/Vgw0d5U8EXixNxJp4fPWExbXYbyCOhvn5wF4rYhMV8LFT7UgWBG+GW0oaGxTr28BaqhF2fxnu KAx0ClZV hnlxwi/TAkoxMSCcXDPQD0QwnahOgP66JP5HT+BKQGVGAowj4Cfkj76C/z8d0q0RY8gl4TOZA+eSJTBMbcXZwc1oPsNmnKfZzcMBoxhpQQGWFooNygJXo88Z4J5al18pv8sZ1K7YxOeLvFhexgBkxl5/yYhtDPebqA+WgpsI9uY48982PqFZJLZzAPnCOCYA1+AlsVuFZNaEGqJcNhMGIwaoFySVY9ROUhZHkGPFT1kBf6m8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Implement DAMON sysfs interface directory and its files for setting DAMON sampling and aggregation intervals auto-tuning goal. Nearly all kernel API data structures that newly introduced for this new feature are directly exposed. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 189 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 189 insertions(+) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index deeab04d3b46..ff774cc19d1f 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -408,6 +408,164 @@ static const struct kobj_type damon_sysfs_targets_ktype = { .default_groups = damon_sysfs_targets_groups, }; +/* + * intervals goal directory + */ + +struct damon_sysfs_intervals_goal { + struct kobject kobj; + unsigned long samples_bp; + unsigned long aggrs; + unsigned long min_sample_us; + unsigned long max_sample_us; +}; + +static struct damon_sysfs_intervals_goal *damon_sysfs_intervals_goal_alloc( + unsigned long samples_bp, unsigned long aggrs, + unsigned long min_sample_us, unsigned long max_sample_us) +{ + struct damon_sysfs_intervals_goal *goal = kmalloc(sizeof(*goal), + GFP_KERNEL); + + if (!goal) + return NULL; + + goal->kobj = (struct kobject){}; + goal->samples_bp = samples_bp; + goal->aggrs = aggrs; + goal->min_sample_us = min_sample_us; + goal->max_sample_us = max_sample_us; + return goal; +} + +static ssize_t samples_bp_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + + return sysfs_emit(buf, "%lu\n", goal->samples_bp); +} + +static ssize_t samples_bp_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + unsigned long nr; + int err = kstrtoul(buf, 0, &nr); + + if (err) + return err; + + goal->samples_bp = nr; + return count; +} + +static ssize_t aggrs_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + + return sysfs_emit(buf, "%lu\n", goal->aggrs); +} + +static ssize_t aggrs_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + unsigned long nr; + int err = kstrtoul(buf, 0, &nr); + + if (err) + return err; + + goal->aggrs = nr; + return count; +} + +static ssize_t min_sample_us_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + + return sysfs_emit(buf, "%lu\n", goal->min_sample_us); +} + +static ssize_t min_sample_us_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + unsigned long nr; + int err = kstrtoul(buf, 0, &nr); + + if (err) + return err; + + goal->min_sample_us = nr; + return count; +} + +static ssize_t max_sample_us_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + + return sysfs_emit(buf, "%lu\n", goal->max_sample_us); +} + +static ssize_t max_sample_us_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damon_sysfs_intervals_goal *goal = container_of(kobj, + struct damon_sysfs_intervals_goal, kobj); + unsigned long nr; + int err = kstrtoul(buf, 0, &nr); + + if (err) + return err; + + goal->max_sample_us = nr; + return count; +} + +static void damon_sysfs_intervals_goal_release(struct kobject *kobj) +{ + kfree(container_of(kobj, struct damon_sysfs_intervals_goal, kobj)); +} + +static struct kobj_attribute damon_sysfs_intervals_goal_samples_bp_attr = + __ATTR_RW_MODE(samples_bp, 0600); + +static struct kobj_attribute damon_sysfs_intervals_goal_aggrs_attr = + __ATTR_RW_MODE(aggrs, 0600); + +static struct kobj_attribute damon_sysfs_intervals_goal_min_sample_us_attr = + __ATTR_RW_MODE(min_sample_us, 0600); + +static struct kobj_attribute damon_sysfs_intervals_goal_max_sample_us_attr = + __ATTR_RW_MODE(max_sample_us, 0600); + +static struct attribute *damon_sysfs_intervals_goal_attrs[] = { + &damon_sysfs_intervals_goal_samples_bp_attr.attr, + &damon_sysfs_intervals_goal_aggrs_attr.attr, + &damon_sysfs_intervals_goal_min_sample_us_attr.attr, + &damon_sysfs_intervals_goal_max_sample_us_attr.attr, + NULL, +}; +ATTRIBUTE_GROUPS(damon_sysfs_intervals_goal); + +static const struct kobj_type damon_sysfs_intervals_goal_ktype = { + .release = damon_sysfs_intervals_goal_release, + .sysfs_ops = &kobj_sysfs_ops, + .default_groups = damon_sysfs_intervals_goal_groups, +}; + /* * intervals directory */ @@ -417,6 +575,7 @@ struct damon_sysfs_intervals { unsigned long sample_us; unsigned long aggr_us; unsigned long update_us; + struct damon_sysfs_intervals_goal *intervals_goal; }; static struct damon_sysfs_intervals *damon_sysfs_intervals_alloc( @@ -436,6 +595,32 @@ static struct damon_sysfs_intervals *damon_sysfs_intervals_alloc( return intervals; } +static int damon_sysfs_intervals_add_dirs(struct damon_sysfs_intervals *intervals) +{ + struct damon_sysfs_intervals_goal *goal; + int err; + + goal = damon_sysfs_intervals_goal_alloc(0, 0, 0, 0); + if (!goal) + return -ENOMEM; + + err = kobject_init_and_add(&goal->kobj, + &damon_sysfs_intervals_goal_ktype, &intervals->kobj, + "intervals_goal"); + if (err) { + kobject_put(&goal->kobj); + intervals->intervals_goal = NULL; + return err; + } + intervals->intervals_goal = goal; + return 0; +} + +static void damon_sysfs_intervals_rm_dirs(struct damon_sysfs_intervals *intervals) +{ + kobject_put(&intervals->intervals_goal->kobj); +} + static ssize_t sample_us_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) { @@ -569,6 +754,9 @@ static int damon_sysfs_attrs_add_dirs(struct damon_sysfs_attrs *attrs) err = kobject_init_and_add(&intervals->kobj, &damon_sysfs_intervals_ktype, &attrs->kobj, "intervals"); + if (err) + goto put_intervals_out; + err = damon_sysfs_intervals_add_dirs(intervals); if (err) goto put_intervals_out; attrs->intervals = intervals; @@ -599,6 +787,7 @@ static int damon_sysfs_attrs_add_dirs(struct damon_sysfs_attrs *attrs) static void damon_sysfs_attrs_rm_dirs(struct damon_sysfs_attrs *attrs) { kobject_put(&attrs->nr_regions_range->kobj); + damon_sysfs_intervals_rm_dirs(attrs->intervals); kobject_put(&attrs->intervals->kobj); }