From patchwork Thu Feb 13 01:44:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13972685 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4452C02198 for ; Thu, 13 Feb 2025 01:45:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7461C6B0099; Wed, 12 Feb 2025 20:45:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F4976B009A; Wed, 12 Feb 2025 20:45:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CF6D280001; Wed, 12 Feb 2025 20:45:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2B2D36B0099 for ; Wed, 12 Feb 2025 20:45:01 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A500F16162C for ; Thu, 13 Feb 2025 01:45:00 +0000 (UTC) X-FDA: 83113227960.02.D1519C0 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf17.hostedemail.com (Postfix) with ESMTP id 223DF4000D for ; Thu, 13 Feb 2025 01:44:58 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=crw6qJnY; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739411099; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9h1XuM2m/K3Qv6r3rhrWTatrcoUK0FxZ62cXNff5xgA=; b=LkqqDwBRmpuU2bbb+JWCCkP4KCEFkjliJJ9cZp8t14LM2+dbV7xLHZh6IQcRmx4EgdNm0W aM9KgmQv8pfWmKjVNdaO/e9DE3JdxdyNalbxjTc6lKWLlb1AhcwuScUVmZFrTEwUddkYr8 qREDxMxZ7liKUpuiFQXudhoGmSXeRJk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=crw6qJnY; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739411099; a=rsa-sha256; cv=none; b=DFdKhDtZkX/8gk8k0azvxhXqIbEP7R5yCgXmHDnq/uP6Nv+5PuHKpr1MDopRIKsUkZQiQK xHlnrC8Z32UyLPgs8RjNkkewZvJEW31V/Q9IvByn8AUXbAjTTXJFqcMxo0zMmIw7maLuYA /3WQACV3/Mv45xe7rEjrI4E2W1vgKWQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2B89CA41C36; Thu, 13 Feb 2025 01:43:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C108C4CEE8; Thu, 13 Feb 2025 01:44:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739411098; bh=5mT7etGAhFimYWHp8UnnlxRdq2vvO4qVjTFtFfnATX0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=crw6qJnYGnrLWb24ECzEINhxpjP3mM72df9H+zpoOtoR8AB6uExB0pLzuuQWNOUsS NrOGmSwrw369SR/lm6+IxcpVnKf8XZw2fN6E0Z0rvPKzHtKFGZuo+ewP8MNMr4DWoI NrDAf3zXl1wdUmj5PsQ8qfuvf56wTTsTUFOHCflsiHGRGGhQp04K5KUnj2owNS/B6h XqU2ZiDM/5WnPZoFfuRJ8i5EYB7JzSRwDIcokE3FMcQ3SRE4HlY/4HewfnQmxNutoj b52EfXn+0jWiBYaPPL+1i2rH/+0FqqoDlrVIa1hpZZjgUBE6FTgN0fw24sOhrgZITn 1cAF3/y9x/LPQ== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 5/8] mm/damon/sysfs: implement a command to update auto-tuned monitoring intervals Date: Wed, 12 Feb 2025 17:44:35 -0800 Message-Id: <20250213014438.145611-6-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250213014438.145611-1-sj@kernel.org> References: <20250213014438.145611-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 223DF4000D X-Stat-Signature: 9w4kx4kry8harzq8n7anpz7exxfineoj X-HE-Tag: 1739411098-233399 X-HE-Meta: U2FsdGVkX19ZbJcCKtYpn30f9Oov92RevauUri1C8z9Kv5/f+CsvY9q2MEmlXfxbJcNFtdY08OcgfOgR5cablNuUoJjYJaWyi8Ekjav5qHsbb6+3AGJ4c4136F1amoC0h8uhQFPQCduylN6kgS497Eyu4qMASxCEb3KjNS1TbsWh7gKAc4CP5lVhDBOtprFMsaYpo9QZoFZ9e0BavXJXx+4IyVTFdOlI5mMhlkOWdiAOM04UhM4MGREeL/dQAF8v8zYoTdN5hMSYCR7MwvAckIXrvINIsWK2kWWluJ9KyFpiZv+yGzhAuQlUEurHdo3vMf7YxbGsCy2szDq0kg0yxS5rYgDycEZBE3SIcx+bgw5l3JT2xODejL8wguEzfKOZZxWasMvj6WhRbtr/MgNjIYfdzC9l+EvRqFuWiA3f8hUbND2bCYVk1vKCdNvUH9r2+C2t5xFJ4mGdY2IvBGQx/20MMn3aw/7hoirhp/Q4TT/z1lZWjN6IRwN/f8sbLqOLXBx9hQD0WppJaxB6NQdZP0/7uWY046JUvr+G0bRAw8v2F08AgdIrNYiGsLLWSnX7dK5pVlp/0r2ZKfzyUGML31DWZD1NIfZg1iG5aTzkREc2d8EBmuxiBN0OU8N00wJFoJdKswuv2TcGoaRL66fA3fSeyzwykGBtYKSrt8vJs57weDmCvCk/nT26Vco56hODPWcjOrlUwW+NhoxzU/d1f/LVAbcdsfjeZx9MA8LKV5fnWreDL4U4cCcZmvcHEGJ1ak814wWQVueT2fbYkwYtQlb3uDGZ3egTNpOgc1ygZuw3milH/AkA21b/Idk/jARRfeie7LHZHhSXkBataw8vYZsDm3ywsXdJASl4QiBkCRyv4RBaFOVggJMZBdNs1ZqY4j0W78OL2Rq9HgwUMB2srR+TH8ffip69k/kQB65giVyNjXfCo4vZkPIGh1kaiR7J5yhey69VvmdQiUwPfH7 jZM9Ztnz wa1ZL8678ZpYtfFt5PX7I5Srw/0HRNPqK2ZLKtKmMc+0ztENf9Z7P2vn9meprJLsZV/+ZeXyw5bofdSKZL1STAzkQ88/wUJlezg37Yj02Tlt0aWkyGPG+zh0jEYPyg1XlDXXlpWA7LB0GQjGpXOo2fXiYwaocK0Itw7v2g97WmRSDzj70aNmAx3+Rsxh+Cx8k5G7Are/eBdnHjRlMbONCp7wFy/gboQxKk4md4edZImIbgXs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON kernel API callers can show auto-tuned sampling and aggregation intervals from the monmitoring attributes data structure. That can be useful for debugging or tuning of the feature. DAMON user-space ABI users has no way to see that, though. Implement a new DAMON sysfs interface kdamond state command, namely 'update_tuned_intervals', for the purpose. Once the command is written to the kdamond state file, the tuned sampling and aggregation intervals will be updated to the corresponding sysfs interface. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index f9bfe9ea0ae6..b1829ee67762 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1213,6 +1213,11 @@ enum damon_sysfs_cmd { * effective size quota of the scheme in bytes. */ DAMON_SYSFS_CMD_UPDATE_SCHEMES_EFFECTIVE_QUOTAS, + /* + * @DAMON_SYSFS_CMD_UPDATE_TUNED_INTERVALS: Update the tuned monitoring + * intevals. + */ + DAMON_SYSFS_CMD_UPDATE_TUNED_INTERVALS, /* * @NR_DAMON_SYSFS_CMDS: Total number of DAMON sysfs commands. */ @@ -1230,6 +1235,7 @@ static const char * const damon_sysfs_cmd_strs[] = { "update_schemes_tried_regions", "clear_schemes_tried_regions", "update_schemes_effective_quotas", + "update_tuned_intervals", }; /* @@ -1502,6 +1508,17 @@ static int damon_sysfs_upd_schemes_effective_quotas(void *data) return 0; } +static int damon_sysfs_upd_tuned_intervals(void *data) +{ + struct damon_sysfs_kdamond *kdamond = data; + struct damon_ctx *ctx = kdamond->damon_ctx; + + kdamond->contexts->contexts_arr[0]->attrs->intervals->sample_us = + ctx->attrs.sample_interval; + kdamond->contexts->contexts_arr[0]->attrs->intervals->aggr_us = + ctx->attrs.aggr_interval; + return 0; +} /* * damon_sysfs_cmd_request_callback() - DAMON callback for handling requests. @@ -1723,6 +1740,9 @@ static int damon_sysfs_handle_cmd(enum damon_sysfs_cmd cmd, return damon_sysfs_damon_call( damon_sysfs_upd_schemes_effective_quotas, kdamond); + case DAMON_SYSFS_CMD_UPDATE_TUNED_INTERVALS: + return damon_sysfs_damon_call( + damon_sysfs_upd_tuned_intervals, kdamond); default: break; }