From patchwork Thu Feb 13 16:13:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13973654 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A4D5C021A4 for ; Thu, 13 Feb 2025 16:22:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C85C66B009E; Thu, 13 Feb 2025 11:22:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C35CA6B009F; Thu, 13 Feb 2025 11:22:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B24ED6B00A0; Thu, 13 Feb 2025 11:22:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9687F6B009E for ; Thu, 13 Feb 2025 11:22:48 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5BC26B189E for ; Thu, 13 Feb 2025 16:22:48 +0000 (UTC) X-FDA: 83115440016.28.260CD5B Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf07.hostedemail.com (Postfix) with ESMTP id D00E840002 for ; Thu, 13 Feb 2025 16:22:46 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739463766; a=rsa-sha256; cv=none; b=7tV/4mGNMEyySe81iG2p2xD4oXOUgxaU/iWImvuPxfqWQ7mX27lmARGmJLz8R6CogokyTw 9HYI3zNCK3JoNtnTZ1T8pBXemDbIK6mQqVR4TrLb6BGP9Qaah3nChCTx8obrLgAKlaXXxl 0E8xsbUlvspMLIyHDT2GMG/Nd39d6zU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739463766; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MZekwt/a2g4QHVCMg0sD0VVM0bg8cvPBbYfZSuWrOGs=; b=aIGYJMwm/WKn4TrliV0Q2sfWGmTrBit/viQ0tWefU2pcgWV0+mmX0BxxromWd9PcAlsWLA B/ldTVn4sFI20Hh0dufIeRUl42U3s/mTFB3JPre/GjQlrXWY6quYTeMTR7706bpSlOrXJV rBxuLJARmUW1xt0/1hrDAQkMbaBaa48= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tibr7-000000003xx-0qLG; Thu, 13 Feb 2025 11:14:25 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Rik van Riel , Manali Shukla Subject: [PATCH v11 06/12] x86/mm: use INVLPGB for kernel TLB flushes Date: Thu, 13 Feb 2025 11:13:57 -0500 Message-ID: <20250213161423.449435-7-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250213161423.449435-1-riel@surriel.com> References: <20250213161423.449435-1-riel@surriel.com> MIME-Version: 1.0 X-Stat-Signature: y8xx6n3j4pgzfqxg6yet83i77ge4rhiy X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D00E840002 X-Rspam-User: X-HE-Tag: 1739463766-352026 X-HE-Meta: U2FsdGVkX19pvXf9eUWHfEPCn4NPQ4nNwTunyMJMDyrsCyizTjV+DyM2/U26e9BK466dHdoS6Cz/VEpKTfmhrfB6Mt8q5G27zlcHtWQNH4vh7kal+yvpzSVzAhv6Cnhw3TXC2hvDRRCyge28i5D4u6ghCfmn50AOn8CyGi5MA4GO1YuEelYH27qflV9WusqqMGUoe1d8coTVGBH0j4geAJdaVy4PRUG8nENjZ25z78okEG/i9/QwqZx0KEQ+8haXvuupLaWL+W5xwHSMUYAhp2Prl0aPJ92BT/93QnXwPWrrQAKG5wFOaOmbZCJpWCcRzGKR3Ld5zZ46mIY+MzzC5o/koxLbX1thLdAoaKMnkQDGc8jV7rC72Y2RapXAgZdXiwSb+t26yKkNsxZDbWpHl+tv/VrShMj8/fpgZmYR8MBnbe+UGabVFkje0bmRrrRT44ldtCcga97E96RmnoI8mKnD4QjtAEHbTRs0YdunD/lZ4yLCiZ61e/Y93qddWLeDdG1FzxEO77kewmp80ODhy8hv6gYmp5j1yzBDtMkC+VGCnW+8XZtcgv2KQuTfTFyqme08H6b+uSkNjf292C5PA1xk6L9vkbMCxSDp7QjMKcNUCrJL5oik/Av/COwR2RtNhmbORkA0XRV5JQoZtlMfy+pkrlmBE/FIZyG6dO0psnhLy7FZkYihEnyJAp0FNtQY5On2kt8duDLX9v5Dqgv9UL2TBmgcDGYVr3oPUuxFuSsmlOYoMZLD3D2IIAplq0PMYPuw3P0Mpby8sU3VQqM6p4XIG/X7P+e6dxR9mS4TKp/sfxi5/KwtLmfSwSLanNBTLbfDCa4kIKkCpW6i9r8UDMVef1tn/sAB5x4BjyU2An/YSFfrApsmEV8zFAp3rQda/zquYPI6I4QvFpa9rwcizhKWpkprysWQt2tp0VXN+KR6jMJq9W8jgNdKlijJz1oaaWdtLKiOv8Kiz1l+N7o ECwnWron c5Sr7bGNY20z7E3J973Ja4hdsviNKr6XaeljhiPr4FtTTr18z3QErpVij4VZi1jJNsSz5Lx7W8I6yDYuRjFlB2zu8n/VuTH/Um/qAbiiViv+AcgXMDYjwyt6pbSRetpxOnVN12JPT1rcaNugHmN65OV0WmPXu4B909LlhUblHtCo2yCdxgPyfNXeiQU9VP2PUj+HrkY37fN/Lppd86V48EWMS60g331m4hpyB7ndhpQl7lslYaZKMLeLyc1zVvxtchMGzLr2stycr9xwnxOkXfBu8hzOXOp9+V7+NozdcDkO6PWMD0MHoUVCsEywde3mwiTqR0MDTjnvgi/UCMO2m2eUd+nArSU1GDNCOJ9QIIDkQPr4fDO31HKZpYRJu8ZmQ4mxm1/ln2Fc5r1m4j4yxzLsFI1tVMc1OetzLQqIlcHugHdJOCmGD0aqJ/QhJVruyB6Lvwd+scvy0QItKLWz+42hMySZU69Glu6NcfBtVOprJBYrPUbXwxRDbD5ixBteR+g2r559M/8BkRDddXoA4sbjm9sf3soSNTeLq9FgCJetwC7gvMZDcMFthWptucpNC5LNp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use broadcast TLB invalidation for kernel addresses when available. Remove the need to send IPIs for kernel TLB flushes. Signed-off-by: Rik van Riel Reviewed-by: Nadav Amit Tested-by: Manali Shukla Tested-by: Brendan Jackman Tested-by: Michael Kelley --- arch/x86/mm/tlb.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 924ac2263725..ce9df82754ce 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1077,6 +1077,28 @@ void flush_tlb_all(void) on_each_cpu(do_flush_tlb_all, NULL, 1); } +static bool broadcast_kernel_range_flush(struct flush_tlb_info *info) +{ + unsigned long addr; + unsigned long nr; + + if (!cpu_feature_enabled(X86_FEATURE_INVLPGB)) + return false; + + if (info->end == TLB_FLUSH_ALL) { + invlpgb_flush_all(); + return true; + } + + for (addr = info->start; addr < info->end; addr += nr << PAGE_SHIFT) { + nr = (info->end - addr) >> PAGE_SHIFT; + nr = clamp_val(nr, 1, invlpgb_count_max); + invlpgb_flush_addr_nosync(addr, nr); + } + tlbsync(); + return true; +} + static void do_kernel_range_flush(void *info) { struct flush_tlb_info *f = info; @@ -1096,7 +1118,9 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end) info = get_flush_tlb_info(NULL, start, end, PAGE_SHIFT, false, TLB_GENERATION_INVALID); - if (info->end == TLB_FLUSH_ALL) + if (broadcast_kernel_range_flush(info)) + ; /* Fall through. */ + else if (info->end == TLB_FLUSH_ALL) on_each_cpu(do_flush_tlb_all, NULL, 1); else on_each_cpu(do_kernel_range_flush, info, 1);