From patchwork Thu Feb 13 16:13:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13973650 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB23C021A4 for ; Thu, 13 Feb 2025 16:21:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4C676B0096; Thu, 13 Feb 2025 11:21:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AFCD16B0098; Thu, 13 Feb 2025 11:21:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C494280001; Thu, 13 Feb 2025 11:21:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7FB996B0096 for ; Thu, 13 Feb 2025 11:21:16 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 29C3CC1027 for ; Thu, 13 Feb 2025 16:21:16 +0000 (UTC) X-FDA: 83115436152.26.062A633 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf11.hostedemail.com (Postfix) with ESMTP id 2FF3D4000B for ; Thu, 13 Feb 2025 16:21:10 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739463671; a=rsa-sha256; cv=none; b=1Akak3nqefDH67L0qF49irTam9FYtSCI63puu7Kyxp1dTSQEAUd3ljJepKiwgeHsS4CGDs dDj3cNhhlgIDDFuTkI81KVvKQJpnhiycW6XX5hx9rnUXv0CeJ6EJRKArKnGiQHlq6e+u/6 NXHs68vVUurFDvuiPopMYn3oYEr6l8A= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739463671; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q9PFwVYBOVbL4bQOQKCEq5HQ+oSbeU6m4cTyKaYbdd4=; b=YvmOeTaV54pR0VqbYmo+bkpEcnDLo9Y+KN0ItvWlherFspRww64ubuaQUe0ygSNAEmyd1H TJUXjCDnPZOyldyKwgUwooICohPXVYtBJmpyu3qD1DnJ0a1M1+I5JS5P8hjVLI6rNiM+7b MiM9ZvM+B6NkWrIBbHdTiGGqrznCVso= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tibr7-000000003xx-0vS0; Thu, 13 Feb 2025 11:14:25 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Rik van Riel , Manali Shukla Subject: [PATCH v11 07/12] x86/mm: use INVLPGB in flush_tlb_all Date: Thu, 13 Feb 2025 11:13:58 -0500 Message-ID: <20250213161423.449435-8-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250213161423.449435-1-riel@surriel.com> References: <20250213161423.449435-1-riel@surriel.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 2FF3D4000B X-Stat-Signature: 9y7iq6sa64za948cjybgt7euw1h4rau1 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739463670-308966 X-HE-Meta: U2FsdGVkX1+i08vHWSb9L+8in0vBMjCLQEDbgEtyJyWqCDynS2X61VFfEb3ldTJbNZuDbwXmQQ08/D4m4cOX7bsm3OzK4X4Y9tArnRK/pGWeMIYd7xr566ks3nCJhsc49ATYDlGy5XDo65VhXNFRZ1jj/snZ5gbLMjaWAYKuC4p7M0o7mkIfzxiWHiRjue/6m3yPyCn6FdwCuGqUOHCVCsCMGuToK3+utdFdRxPcgCIOTIP+tLZKVoX5eKEektaiRpwXrdhDRrwA3kHKyJYH5eGya/1aHvM7+KTIdKK0itrXiOa4MceCXL7xE1z1fq7nmtIOpTN6G9kyFBZ1oYA4xWFcSPIvCBdukhT478IEALlKxgZVuw9Ali2hARp9wEc7Wt9hv7bTNRKDsRWVUq2PTsYlU07ULrqpccMH95ZTvgI8rvCRe+YL3s/orBaWqTpMaHcIjhzogfIe2oybz/tpu646uSlxkWjplVCbG++4dVRpzHH5sXiyvGxU0Y9i8ey6voR1bafz5tV7icpQcd2l1n1Trp+BMIvTJsizN8w+FK3emchS+j/UghxjsS1gMlWxIub5ppCOffbXO4BOnT24sE0r0yscLWH11b2U8UafQG/6+OXBlz5l/vurpLVTTMzwNCAelbHSqddv9rJ0XfGm+6wq2/tW/6kb0piJQUCd1PBs9r96vpAipQNlfwVW9BEy1zVWDdCwwjub5W9coXj5Fxxf0Pyrsedf+T8xH8TS2URr/+RzYLpHa5i7a1gUEKL1C0hYzvKXjhf5Y0XBdJIUVVExGQOBk8tImT2I0vt39Pgy+J27BvJyIlxIzeaUcsZRHpDI7P13kz+CCa43fkwVT2T8s/Z/8TcQnEhHnTywr1GHGJE5FDf0cRK0yi+6gxjkBp9kxVOzlM12QMKw1Lvuen0nELm5Y1+TGdEYkcjxf511JXfUopI88RgDrzeuzSMjHi0ojdmSvqh3WoRnJPO N50xLTk5 xmuDdPS9HxW7AswinEZlO44aAhj+Asut5ArLlYPTCsHVx8vztJ7BtW/Ji5Rgv+AeB/p9YKVjDi0uJcVF63UAeB+fFUFa/5J1NW3e6IbVJsXTu5MEpNn1xETMRnXe7iGJHvm5lyrNZ2lEte379tyzOeF3ZsXkmLn3OeBI3GqizrX4N3Es+rQwK72oaWqbhUSulfpvF+/KbrZfbioGPDadMjHuZ2pN6ka7ftiabYq7HO2ELYRSwY6n4qUlcwq5ls4QvHZjN0GJUWC5APmpLdak7d7YcD410NmWVtRqQwpLzynMioCNz+yulW5JXfh2b/NndhEKiEQehDdqqU+coa8oMcEeqZDub6ABltYCVfLA0Sefub7BASph+tqpXJrw+kav3x47k+7CzrE7igiO2v0jmqj7DJR6bOHorvWrNcdTS17TB//7fuAfrnslG0WKpGJ2F/qJPWy5c1aKR5zWrdLv2UcjfuiA5PrAxunYRvEe1IvcUr2ltcodIWtz4TA9Cn4Cn8B+5oR1d7dqnAoKZekLylgjA810nKaiLH39/KuFw4FWWfp3oNrvmjwdOEM2gEeN8tkVtKgWqgClUF9ey3k3tm1yE2z5hS3/8EoBA84WHzv2e6OM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The flush_tlb_all() function is not used a whole lot, but we might as well use broadcast TLB flushing there, too. Signed-off-by: Rik van Riel Tested-by: Manali Shukla Tested-by: Brendan Jackman Tested-by: Michael Kelley --- arch/x86/mm/tlb.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index ce9df82754ce..3c29ef25dce4 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1065,6 +1065,16 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, } +static bool broadcast_flush_tlb_all(void) +{ + if (!cpu_feature_enabled(X86_FEATURE_INVLPGB)) + return false; + + guard(preempt)(); + invlpgb_flush_all(); + return true; +} + static void do_flush_tlb_all(void *info) { count_vm_tlb_event(NR_TLB_REMOTE_FLUSH_RECEIVED); @@ -1073,6 +1083,8 @@ static void do_flush_tlb_all(void *info) void flush_tlb_all(void) { + if (broadcast_flush_tlb_all()) + return; count_vm_tlb_event(NR_TLB_REMOTE_FLUSH); on_each_cpu(do_flush_tlb_all, NULL, 1); }