From patchwork Thu Feb 13 16:13:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13973649 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937D5C021A0 for ; Thu, 13 Feb 2025 16:20:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 339066B0092; Thu, 13 Feb 2025 11:20:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E65F6B0093; Thu, 13 Feb 2025 11:20:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D55E6B0095; Thu, 13 Feb 2025 11:20:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C996A6B0092 for ; Thu, 13 Feb 2025 11:20:51 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 32410C05C2 for ; Thu, 13 Feb 2025 16:20:51 +0000 (UTC) X-FDA: 83115435102.22.DBC06E5 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf15.hostedemail.com (Postfix) with ESMTP id 6249DA0002 for ; Thu, 13 Feb 2025 16:20:49 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739463649; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y4BkN4UDnn45Ns4YQ+te9m/mGXyQZUGxlySO84t8JQ8=; b=M3IOdDE/rlWzYfevAY96wXRX+rRjWdM+9+S98B81YvmFq5UgPKReSnAX9Mv7WrRSt44VLE r4paqSxI0AdZcCscLkbd7NPjcN7InFYslukpCXTT2ghDYyl9VU9eqbjfDoQhpbaUo/++sT exkJHY/489PQFe8Bk9N2UxPgvVztnec= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739463649; a=rsa-sha256; cv=none; b=6P978OJnfRd0FNrNfRV6AvDtmTL/guX5pPt7++z6ecNdZxVL6l477aWprknbsN04hoflAN fZLwcrW2oiNn8c7JRvbr85n/Hc4hKqYWF8oRhFx/S+EEBvALCWxK59K2trKkQ4LuUL8LGn t76D49XyvaNqEZOw38QYaNIUS0NHLhQ= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tibr7-000000003xx-1037; Thu, 13 Feb 2025 11:14:25 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Rik van Riel , Manali Shukla Subject: [PATCH v11 08/12] x86/mm: use broadcast TLB flushing for page reclaim TLB flushing Date: Thu, 13 Feb 2025 11:13:59 -0500 Message-ID: <20250213161423.449435-9-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250213161423.449435-1-riel@surriel.com> References: <20250213161423.449435-1-riel@surriel.com> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6249DA0002 X-Stat-Signature: u6sdijmskzzc7sum3n54mjm9pdfong3b X-Rspam-User: X-HE-Tag: 1739463649-143566 X-HE-Meta: U2FsdGVkX1/lVnqj+JNV1NVdC48+bLG2TQyUTsZQ5mNNfBEnQSLyguQ+U0kAD6ZoAow1Nbnd8nj9cqL+FCFl6AZa9I/8zbLctXR3OgsEzLUNu3dk4QozjjW5OayLctY5zBRSd2YMXT9gDhHR+BUj1LoS5Gez8rNoCpzjuLW5GSVp7LnVKrMm8971qQp/8f8PfluF0w6AzTyZ0rKk9erV4UfkU6TheuFCYozNhN4wIlEdtEGyDIx5KYzTUicxsmrJDXAD8y5+Dk++qHtKGeOt1pCiI3KkLzgHQa1iYb62bQmbkhqMmx2m0UhuSElbrO0t14PqtZfsKeDV0uu/xFueX+iCBvGENFOWp/mhWWiX7RGScJwscNAiutNkLU91VZGR0iFHhidKMBRUKaxSC+v6n9/OoV7pAOHbdazplAPHrIrMZNgDiVS/lMDNF2MhhjAtMdLTsrEpu8HPXnchziRpvKnvfGVCHGtXzsk+Hu8Zn9/SZeWwSy+eTqxZMkzK4RKYvOrh9EVBsS9ig3UUVOU4rzvBsIhUW2yxardOAnk/cakZdp7fQxq5zJcXTg2LGwNZgZWDenWHW+F2A1s1x7FuYh5ZAMdYH9AlQXabsey/7RWMHubk6MCbdtqjOp11sJhUEV4+mLqz3J78IwRQlJYbHT67oXka8IUqqndCRMMjnpRVgqTaEebAY37aBWiiO4zmCkBOTgfmeKqzZyXzaoo3ox0RT/F6fSvisue+4nqtI9KWuoz7sOXnGTwR+gfcmXk5tF4Bj2dLaqWQFX1EBQuZucznuctgPTkaWfwPB7g1KkNLNMHsGKAz3Vq57//veC//91nBoy/mAULxej0LZUr1ITu2nLCVYwuAQeXvUef2dfaQwu8r+jMGDfu/wwwaKBWjFQGAmOZHdBxVvWNodjoJTLUGD3GLbF/VlgQwsJzmLsF6oWa4FhjgFwzXfMSRSWIjWVwfJvpxdy+NSKLX3E5 1tPutxHW Mo8Ud2AYqWfUTPXTTlU1JA7ykTm3UTwjxW7bthsjl5DxMNRWUOoFCIHghJVl8GCi/kC+eeJPXFMxGmT5z4kWRi67eLSLS3XES+LKB0h2sDgpblrIZtYRM3na/3+oqVmrvSfBMM5zPyuw4XJ6o2crB78fHlp9yueh0Rho/IKiVYp9+EpaqHgLmV7limoqbCE1kj7HACvzOy19tQJB/T07fwU3rZUV4vqnUV7MZ0CEUAtxL1n+/4nWoEUo7uLo/J1Q8fQx3DHoS8Bic0Y30oEaWQQ8pzYJHryuJpcyd9YHchCKtL+ZnJElLhVZhIQ/ZZu0pSPWr8eQuGUiWOTvBuzs2izWnnCAHJf4ftZIogMuii+vjSzyCTxP3oyDk4IxWXtEw50fTnhPrdDpEkw0fm3XnS9KGWOmgspINwDfLP4cnsKz9zpNo7/CDexI5AXu8AtXrklye47mwytBaD+2h/+W6uL4yop6qbUvRgGgmxH/jW6J/d6QU+HplV9VXQ3d/pbEZpgKlzvIVD/Ni+OfmhoSLP53yiPoiwK5lby93 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In the page reclaim code, we only track the CPU(s) where the TLB needs to be flushed, rather than all the individual mappings that may be getting invalidated. Use broadcast TLB flushing when that is available. Signed-off-by: Rik van Riel Tested-by: Manali Shukla Tested-by: Brendan Jackman Tested-by: Michael Kelley --- arch/x86/mm/tlb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index 3c29ef25dce4..de3f6e4ed16d 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1316,7 +1316,9 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch) * a local TLB flush is needed. Optimize this use-case by calling * flush_tlb_func_local() directly in this case. */ - if (cpumask_any_but(&batch->cpumask, cpu) < nr_cpu_ids) { + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { + invlpgb_flush_all_nonglobals(); + } else if (cpumask_any_but(&batch->cpumask, cpu) < nr_cpu_ids) { flush_tlb_multi(&batch->cpumask, info); } else if (cpumask_test_cpu(cpu, &batch->cpumask)) { lockdep_assert_irqs_enabled();