From patchwork Thu Feb 13 22:46:42 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13974133 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 133BFC021A0 for ; Thu, 13 Feb 2025 22:47:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3D46280009; Thu, 13 Feb 2025 17:47:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DEE69280001; Thu, 13 Feb 2025 17:47:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1D1E280009; Thu, 13 Feb 2025 17:47:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9A9B4280001 for ; Thu, 13 Feb 2025 17:47:13 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 25CBE8164D for ; Thu, 13 Feb 2025 22:47:13 +0000 (UTC) X-FDA: 83116408746.19.CBA9E99 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf15.hostedemail.com (Postfix) with ESMTP id 3A6B1A0002 for ; Thu, 13 Feb 2025 22:47:11 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Yz8Awu83; spf=pass (imf15.hostedemail.com: domain of 3bnauZwYKCFkJLI5E27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--surenb.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3bnauZwYKCFkJLI5E27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739486831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hOJYwLimtWGBUdGEfM7iYC8bKir+nyDvGIJQLaOGSbI=; b=OsjGlJKtLaWiBrqVG1BlJqjyT8uIyjudbMIqqzWpTD3zwUiuioiH8UWnSGgdTDOm5mtXIS H8+SCbrQy7RBOs1TrQSa0ROgpQPwQPiJfBeZ7Nws6dxIXfYfvZO9C4vkh8Yn8RGwjiNE1P BmTVWhhzycp20tEYfHUUeaHb9nNfy8s= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Yz8Awu83; spf=pass (imf15.hostedemail.com: domain of 3bnauZwYKCFkJLI5E27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--surenb.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=3bnauZwYKCFkJLI5E27FF7C5.3FDC9ELO-DDBM13B.FI7@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739486831; a=rsa-sha256; cv=none; b=nmziGtq1bHd+JSEv0lrMvWkkLLSL6FVcCKtd84DLIS8FjNjvmDgL/0oB0PxzHPvtyja1Fr yE2TeBZMhdTTGap3eCNzUJnfsCc3bZzzQvSWn9ZVHDlokBkwPrlElFry+xIAzdkXwe52Qv O4fjy9RH91TiMZQhRjcWOuaHeV1FZWg= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2fa34df4995so4972790a91.0 for ; Thu, 13 Feb 2025 14:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1739486830; x=1740091630; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=hOJYwLimtWGBUdGEfM7iYC8bKir+nyDvGIJQLaOGSbI=; b=Yz8Awu83thrQcMACo21Jww4dIR3SvGWnbk3qbqaBrxjxUFwF3TCsbyg8Z1T4Okabkc T34FmnhsSR05kg0ux9gs1mfeVECnwkqJQbnOPsXQabVSlTmZb4EMh7Rdbig+pTQdg3Tr gbYrTVBee7d39YD8b8FdFEXKMpIPF8fuSuuFh8q5AHxyE+6y4hKP3HaFM2JV5GUYzKp9 YSf41jhTWfkNegxLBZ6EjaG5sGnG1GUaHxDCSu0M+sczmZeXDNEQ+JJjevlCKcbp1vwp +XCslB9+kAsXK3+ynGVg+JnZDjUcCF+jDgu5VbXDgaXN58FNo6FtT01wgbxs96V2OPgm Czmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739486830; x=1740091630; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hOJYwLimtWGBUdGEfM7iYC8bKir+nyDvGIJQLaOGSbI=; b=CZs/+m/RPkg9IIk0937vn3K4HlWAD83ydS5G2KNY/qarO5xz12r5c1RJLTCRHUTqsH c2YllK9b5wHA3FXMDXZWLjBFJP6j2H1pmhqsuAznzRKY1tNdQIwp9KLTBVLh4zAT/gFA 3kvWZYt3UtX+OHkwajfalH/vZCxHZS0tg53na0vkJypvirJEsBqJXZHfun6qus+OLYyT v9l5CFVq9G9PRxZN7HcOqqnbTNhtrFoQgNlQqVCf7/0t+iE0pBh4M+R/uegH/34vnJQ5 mf3gXxFFKi+ZdPWAy5Qs47imsy9SBmdNEPO+C0Yu/loe09tPr4dmo/8/u5xKhDPZ4YoS PW0A== X-Forwarded-Encrypted: i=1; AJvYcCX9GpOoBdSEV8n1Xm77oPTmCOqYi6bRYiyfzM6SWIhFZhhWllVqurNmMWc+q1bUwgM2aQpxQ9qVNw==@kvack.org X-Gm-Message-State: AOJu0YyvgKSeH+3vSgUdR0gxjMDBTn1jBt5wDjh28AbWnJtCyxfUmeom LogLK8VgMW/WfOW1QFBJfmUOS5g8aSufCnepYou14qQjI+ZUatRtaRwZza1hJHIcfij6w6TBJiC kPw== X-Google-Smtp-Source: AGHT+IEOMdpbXGqVMbthd+OaRfeUWGsGbBZNR4yGOFrRj8/MuVDw8EpNm8XS12LJXdTQ6lIEpIij678/S+8= X-Received: from pjur3.prod.google.com ([2002:a17:90a:d403:b0:2fa:27e2:a64d]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5245:b0:2ee:f687:6adb with SMTP id 98e67ed59e1d1-2fbf5bc1df4mr12403072a91.3.1739486830202; Thu, 13 Feb 2025 14:47:10 -0800 (PST) Date: Thu, 13 Feb 2025 14:46:42 -0800 In-Reply-To: <20250213224655.1680278-1-surenb@google.com> Mime-Version: 1.0 References: <20250213224655.1680278-1-surenb@google.com> X-Mailer: git-send-email 2.48.1.601.g30ceb7b040-goog Message-ID: <20250213224655.1680278-6-surenb@google.com> Subject: [PATCH v10 05/18] mm: mark vmas detached upon exit From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: peterz@infradead.org, willy@infradead.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, david.laight.linux@gmail.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, lokeshgidra@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, klarasmodin@gmail.com, richard.weiyang@gmail.com, corbet@lwn.net, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, surenb@google.com X-Rspam-User: X-Rspamd-Queue-Id: 3A6B1A0002 X-Stat-Signature: j7fxb4y1s69i71c63fsciwiurbxim8f4 X-Rspamd-Server: rspam03 X-HE-Tag: 1739486831-596630 X-HE-Meta: U2FsdGVkX1+tv27Pcu2jN3GnokOpuNiOslclyC6WR0Hro2tAQnxBPa6PYii165ENKBDQ1Dh12o9VqrUPiTa28fMgDbTYxT4FQs87LiH91jgB3ADsgbKf8/Zpa5ULq+WUptWgjqVOKGwSfx7MF/+D9SS99lJjolvqhzv5Eg4ebWD233XxfC8EP75g4aipTdFJfz+FEgSXKurzU4Y915q+h/wc9v/XBCg65MyHIDSjXN0EC4g2mlBnxA62zGWrRhjp9aZs8JXyNVfzxFmHBsTLgzrhbgSDoTgfW8sjfjLIle2lo9FfsAC+kEiAyY6emclaSWgf9jfEl3yX5NBC3G8cDKWIe01vYXyIkq+wEIvtmCE7Qpp4SQHPHcYxobyk0WojiNoGwNtgfw7fxg/RZz4weAv3kiqDZ9cgIYWqXrVAf01P2Ai+1/q1t3fFu+xltFSupMACDmX/Dg0+QbrpQGqIaNL8JT4TJ0Ya61tUqajV+ZdQeid84u9dptB5juWN8yAC/Guh6GwieMGw2IxZLYCebNWWuWcaMce1Wl2vJ1yTFRK0ZMU2KR75ZnxEetXMxe5Y5u7bSzbKRQPvTCJ5bVTrX7TLG4P51MCuBRAi4Eh1qqCvsNaW+cf6tJFS0hhbGy6FoRoDpyuuJBZicLfddQAFAOq0ETFZI7iQXTDpMwQRlYAefSoC7qqaBMlmX+c4X0S7SENRZffZfzew+ngKGPcKtl+vKHIY21PJYsY3b8XOIR3cFgwS/Ujr3ZCAEPf9yTiwBbAuChAfzVSh/yblQypME2ucjl9k5fpS3VpmiErFqzFVT0u0nEDqcfAGgmeEA4qKdUc9YJxILR81Bwgh3fg2abF7J334nJuSuIOJnw0cl6hrMSzBGyftGGNDifXoQ95eEQcsDlfnciP2gNtxdkhZoESZUvJXq3Y22TWn2PJ77VDJXqZyqqHMFwVU++SDIw3QYkShC21ZZwbC87uQlRg dcbbzZpJ XLPxGlgwJiQf2ZkYfl6LTaaPHQJDKR3F1mmp3ugE9L2LdDCoXzsTZKHBQtWSwsc9mjFVL/KefyERcHyMJTNRybhVtR0P/6AdUlagCLMJFaTLdZZTrLQgz6QgmF3Nyp22IF92dnBKhwSIBKMaFHebWR+HATf8o66ZzEUl+hxrPuLR/Gbvnhxctw2/emV1rC8IbHO9NicuoGqpkcUKQtPpVumIpHQHwnoHF3DlrUc+mKZ3Thzl1FlBOSp4uiiYMuJTpnKy+pjvKS9phzC+I2Nr3COAxrc/ftf4xMeeIUW0v10aL5jbzOWPHH6fB+cLXBUqcljUDJzBxAg6agXGOdjJD+V39Ze1wzU0zazL5rIeYaOmlonOcmKf18FgzR5iOQQjCE1hAmr/1j2wnUt0EZ6ttFCGFgRrVpH90Nx0E/wgay0ZSSlFdw+k8weTxx/sTHm4SuFlawfzkgM9tg7ECjQcfBF/TK348ZJBKDeWCrADrXxQxU2k4dWEp3XHHiHtoOcKGm0jxMpl+6oLmei0uY2aDOPGY6MFWk0FL7G55h8UvvGVKKAhCo6rWkheshuk58g9bD5oJRyRF/hCMRD3KjN3081fV88kikFaJ7tUf3Ok4rM7bK4qRR8BS3nPlvSsKhpry72fMsKnV0jVePWlWE9iEtKDxlKdVRtsdzonc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: When exit_mmap() removes vmas belonging to an exiting task, it does not mark them as detached since they can't be reached by other tasks and they will be freed shortly. Once we introduce vma reuse, all vmas will have to be in detached state before they are freed to ensure vma when reused is in a consistent state. Add missing vma_mark_detached() before freeing the vma. Signed-off-by: Suren Baghdasaryan Reviewed-by: Vlastimil Babka Reviewed-by: Lorenzo Stoakes --- Changes since v9 [1]: - Add Reviewed-by, per Lorenzo Stoakes [1] https://lore.kernel.org/all/20250111042604.3230628-6-surenb@google.com/ mm/vma.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/vma.c b/mm/vma.c index f72b73f57451..a16a83d0253f 100644 --- a/mm/vma.c +++ b/mm/vma.c @@ -427,10 +427,12 @@ void remove_vma(struct vm_area_struct *vma, bool unreachable) if (vma->vm_file) fput(vma->vm_file); mpol_put(vma_policy(vma)); - if (unreachable) + if (unreachable) { + vma_mark_detached(vma); __vm_area_free(vma); - else + } else { vm_area_free(vma); + } } /*