From patchwork Mon Feb 17 04:21:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Waiman Long X-Patchwork-Id: 13977054 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBFD2C021A0 for ; Mon, 17 Feb 2025 04:21:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23A936B00D9; Sun, 16 Feb 2025 23:21:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EB1B6B00DA; Sun, 16 Feb 2025 23:21:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B27B6B00DB; Sun, 16 Feb 2025 23:21:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E340D6B00D9 for ; Sun, 16 Feb 2025 23:21:27 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5E783A14D3 for ; Mon, 17 Feb 2025 04:21:27 +0000 (UTC) X-FDA: 83128137414.05.107C870 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 9E200160006 for ; Mon, 17 Feb 2025 04:21:25 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Npj71b4t; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739766085; a=rsa-sha256; cv=none; b=sMl9U4L84vWnj6z7UVicJbjBvDiD094NM010VA0UCMD8GodMFbtXqHZfBLSWVYc6cNEw2f MCuyF5/v07Vg/ZhEKRJohssFDeUKCSyz+bUz3i56tfszSQERufFkGBnYWw8TybraPzNDLf VptdSXWDc/B8zZXYCCYFDuN73A1/Plo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Npj71b4t; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739766085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=YqbMpBl1Nw5n1bOPGE94JMKO6OVu4WYCnIOo4Qkr9yc=; b=qwj7clMXBowO+WYGfHVeHOE23NwnAZ8/TdhKe9R0OgF+RApW9hvEjfImS4/f7SXeDSChy+ X79A+1Q6tnbpmmElV+BUfCFhM/yyFifymF3HvbM+OxDB0BHMFFldfrxyGBZer3nbVNKuDf gZyQVEKZMMa7vUMN3h7njjzBOy1Lx8o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739766084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YqbMpBl1Nw5n1bOPGE94JMKO6OVu4WYCnIOo4Qkr9yc=; b=Npj71b4t3pBMdVKW8To/1dtnQbh7Kdz4wngmVhYm355AHN2AF113JhFrt/FByidNBARnil A4pbgnp1QwnOnOmvx54/QKS8PPybyrty3T8L1FQAC9UhjeT7liDFszSak7a1BrDV0XsDJT D9i4Y+bzuOv53eQ+gEU0zFVMHcrw8Oc= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-72Bo0qNkMOOtvPEmGFO3cg-1; Sun, 16 Feb 2025 23:21:21 -0500 X-MC-Unique: 72Bo0qNkMOOtvPEmGFO3cg-1 X-Mimecast-MFC-AGG-ID: 72Bo0qNkMOOtvPEmGFO3cg_1739766080 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2541D1800875; Mon, 17 Feb 2025 04:21:19 +0000 (UTC) Received: from llong-thinkpadp16vgen1.westford.csb (unknown [10.22.64.83]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 31E31300018D; Mon, 17 Feb 2025 04:21:15 +0000 (UTC) From: Waiman Long To: Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Cc: kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Nico Pache , Waiman Long Subject: [PATCH v3] kasan: Don't call find_vm_area() in RT kernel Date: Sun, 16 Feb 2025 23:21:08 -0500 Message-ID: <20250217042108.185932-1-longman@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Queue-Id: 9E200160006 X-Rspamd-Server: rspam12 X-Stat-Signature: u6bwqkzujdidc8d5i78mj394mr3yajou X-HE-Tag: 1739766085-814288 X-HE-Meta: U2FsdGVkX1+qhsK6K8V60R1JQmjyxl2AFkHMNsPVVm5YDcA9ukp7UxUUAKkwNdazTdpBBsgA0IXlLpPbLQ4QoIJgd+DfVq7fw8vejkK2PSH/JJkB+Ovt1/RggkLanCBpJcH40n7cB7/3h3km0C+afN9qd4RDIR+1MlyGkx5tRHFkkz5aMTH7MeqBTa9pGOSp0xMmUZ+hbX9MaVVjpwb75JJlRtMizxGSJ9J/uT4eD0vY0SxJMQknFw+knJYkNVBv3rlO3mAY2v1kAlAyCYb6rPOSUbc69geblQ7OsJ1hQCChxLNHd7ARB+dntSfylhPay/yyKeStOAaq+Wx9KS3wb0SdqYDJuuo2CCW8JagSKfhdDLyK2RgbeoZYA4tjoUCBpePlfB2Ce3MTy+1xbI8zYAbbN8ICFd3lk/F0aoBX+1Ji1zCH1KVG1SlVMHjVHE2uQJEDt7hj1YN+E3L0h6LGuRX+iAIt5zhGqk4NHekO7oGR1cnBQvlMkCuseUu7QhqJ146UW/nG8k5o4clQKONhE19HaCGWqDVNzvPqHHl7jAWhk0W1kyFnlXo+NHwhPfnGQNPbxV0DpctkNDJTZMUlcQssPR4VQ1xu7cEvbEmcv6VOMHZCnz4a2YcuzjrWXYnkSK+TzI5BkbcLgRlbCv57SOF7JUTu+k+5zEE9PiSgZZOyje0bDscmTPW+uUge4/RlwUh0J+Wh05H2037SaxjYto+48AE2Z7/snKCzZ+rnPFOi7ysd0LtBs8QOR0Q1D6NKSgiOkZOLtGhxk2qYlHUcMmgTGv3EpIAPgIvT4HqDCybZFj9TRQCmejVnWnYaZ3BYKl6vt/8CcxYkAyeytppAxTXd3cTbvPGPb3A9KtCRtplLc3EbvQA+ZG6gK0ghDK4RzieOeg8TmQUjT/sTLkClXtLwhLA9xeG2T6y5LcbEgksCMs8MoSbZAokdY5t6kUOorwgk3nmQpigdy8VYKoK CjtmETyE YXAM9yvGAg1ib7oXAmgy1yxQFPM92MkPHYjC7Yj9vaveyfyDd26GDjOR6bi0KlBR0iSHk5j9WdVxlqAv5PiByUF4eMAeDCvHrd17CLHhrfdCvmdnQW7S/m2W++W36dsQFmEmmlemyrmSK6WZ8HkA4PPrK6MteaLSMLVpv2aMgtY+SvaARmlL81qDptPt1cL+y6K+9YeXbQS7oBXdOZSt1Yk/6nu8WJEK70Z2TETjC31/LtMKPbQM5N2GUMYeBU3KGPAsVHBnGxR7TioQkQp7A72LUqmM7vksyQ2kFHULetxgJPwgIUFW8Us7itufEMv0HZKcm366glzdxKEsNHa/OgLlz3fwSMq0sZKFcfsWUVDgmEPOw33/IBD3JWpdCZF/NrOCYG9UriYDVvF1BzeTutmqReqcxMoLoTh9ke6ibphMTTrnRBJ4mJ27C5UP2xHyIrKCm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The following bug report appeared with a test run in a RT debug kernel. [ 3359.353842] BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48 [ 3359.353848] in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 140605, name: kunit_try_catch [ 3359.353853] preempt_count: 1, expected: 0 : [ 3359.353933] Call trace: : [ 3359.353955] rt_spin_lock+0x70/0x140 [ 3359.353959] find_vmap_area+0x84/0x168 [ 3359.353963] find_vm_area+0x1c/0x50 [ 3359.353966] print_address_description.constprop.0+0x2a0/0x320 [ 3359.353972] print_report+0x108/0x1f8 [ 3359.353976] kasan_report+0x90/0xc8 [ 3359.353980] __asan_load1+0x60/0x70 Commit e30a0361b851 ("kasan: make report_lock a raw spinlock") changes report_lock to a raw_spinlock_t to avoid a similar RT problem. The print_address_description() function is called with report_lock acquired and interrupt disabled. However, the find_vm_area() function still needs to acquire a spinlock_t which becomes a sleeping lock in the RT kernel. IOW, we can't call find_vm_area() in a RT kernel and changing report_lock to a raw_spinlock_t is not enough to completely solve this RT kernel problem. Fix this bug report by skipping the find_vm_area() call in this case and just print out the address as is. For !RT kernel, follow the example set in commit 0cce06ba859a ("debugobjects,locking: Annotate debug_object_fill_pool() wait type violation") and use DEFINE_WAIT_OVERRIDE_MAP() to avoid a spinlock_t inside raw_spinlock_t warning. Fixes: e30a0361b851 ("kasan: make report_lock a raw spinlock") Signed-off-by: Waiman Long Reviewed-by: Sebastian Andrzej Siewior --- mm/kasan/report.c | 43 ++++++++++++++++++++++++++++++------------- 1 file changed, 30 insertions(+), 13 deletions(-) [v3] Rename helper to print_vmalloc_info_set_page. diff --git a/mm/kasan/report.c b/mm/kasan/report.c index 3fe77a360f1c..7c8c2e173aa4 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -370,6 +370,34 @@ static inline bool init_task_stack_addr(const void *addr) sizeof(init_thread_union.stack)); } +/* + * RT kernel cannot call find_vm_area() in atomic context. For !RT kernel, + * prevent spinlock_t inside raw_spinlock_t warning by raising wait-type + * to WAIT_SLEEP. + */ +static inline void print_vmalloc_info_set_page(void *addr, struct page **ppage) +{ + if (!IS_ENABLED(CONFIG_PREEMPT_RT)) { + static DEFINE_WAIT_OVERRIDE_MAP(vmalloc_map, LD_WAIT_SLEEP); + struct vm_struct *va; + + lock_map_acquire_try(&vmalloc_map); + va = find_vm_area(addr); + if (va) { + pr_err("The buggy address belongs to the virtual mapping at\n" + " [%px, %px) created by:\n" + " %pS\n", + va->addr, va->addr + va->size, va->caller); + pr_err("\n"); + + *ppage = vmalloc_to_page(addr); + } + lock_map_release(&vmalloc_map); + return; + } + pr_err("The buggy address %px belongs to a vmalloc virtual mapping\n", addr); +} + static void print_address_description(void *addr, u8 tag, struct kasan_report_info *info) { @@ -398,19 +426,8 @@ static void print_address_description(void *addr, u8 tag, pr_err("\n"); } - if (is_vmalloc_addr(addr)) { - struct vm_struct *va = find_vm_area(addr); - - if (va) { - pr_err("The buggy address belongs to the virtual mapping at\n" - " [%px, %px) created by:\n" - " %pS\n", - va->addr, va->addr + va->size, va->caller); - pr_err("\n"); - - page = vmalloc_to_page(addr); - } - } + if (is_vmalloc_addr(addr)) + print_vmalloc_info_set_page(addr, &page); if (page) { pr_err("The buggy address belongs to the physical page:\n");