From patchwork Fri Feb 21 18:25:47 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Jackman X-Patchwork-Id: 13986163 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35768C021B3 for ; Fri, 21 Feb 2025 18:26:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4D6C28001E; Fri, 21 Feb 2025 13:26:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD84028000C; Fri, 21 Feb 2025 13:26:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B051A28001E; Fri, 21 Feb 2025 13:26:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 892FF28000C for ; Fri, 21 Feb 2025 13:26:07 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 416041A1D22 for ; Fri, 21 Feb 2025 18:26:07 +0000 (UTC) X-FDA: 83144781174.22.0630890 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf24.hostedemail.com (Postfix) with ESMTP id 6CEAF18000D for ; Fri, 21 Feb 2025 18:26:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Md19y49o; spf=pass (imf24.hostedemail.com: domain of 3O8W4ZwgKCOwXOQYaObPUccUZS.QcaZWbil-aaYjOQY.cfU@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3O8W4ZwgKCOwXOQYaObPUccUZS.QcaZWbil-aaYjOQY.cfU@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740162364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tBZNxOekeKV0LYb007rKOQkv4qSAcfWIVKd3wLeISbE=; b=vankM11QHDhHzvzQME776zY7sCqtAHUuVv1K0MT58x570y1F0FnU/auO5sRUyRh4B9wesq oZSRqs6iibDU9ebvmIGrg/MwFTPe++j1mm8Q0nAH6fksvlVOVQ2spNlijpw9v+QCiLV/DP rODuy2E1QEo9WjMNi/YOSjMuGZlslGk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Md19y49o; spf=pass (imf24.hostedemail.com: domain of 3O8W4ZwgKCOwXOQYaObPUccUZS.QcaZWbil-aaYjOQY.cfU@flex--jackmanb.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3O8W4ZwgKCOwXOQYaObPUccUZS.QcaZWbil-aaYjOQY.cfU@flex--jackmanb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740162364; a=rsa-sha256; cv=none; b=FHb5xqTwcUurnACCy/6HFmy+QxbjDUkHIZ+5ZlPa7glnnCyT3oE8Kz6q04KVZM5vPzoG0q dWLnmr3sIWnxm44L6Q3J5ch4T0p9Q+qL5+Am4ZtTb9dnLxR8KJO+oWtSuPK3Ky+gk8YOo4 sRZdz+FBjkhQJBoWu7Kk9D1hz/ePauU= Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4399a5afc72so12232945e9.3 for ; Fri, 21 Feb 2025 10:26:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740162363; x=1740767163; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tBZNxOekeKV0LYb007rKOQkv4qSAcfWIVKd3wLeISbE=; b=Md19y49oBnEfrjH//f91BtQNRRBT8NKDBtrg8W57F+TDI6jWRgVq4tO/TxZSKOUpMG AMkPPQlwtmnKVEUW8r4RONG/fC/aixnUrlCbvNhq7uvlWdGk4GP5pqqCnstKK3/jzUvi WdfCTfnmlyWEWoM2hAQvLGzjGQM7DopVTKpsJhq/5EBDhLmq4caeC31RgRj6C2YtyrkN 8rVQrcn/kgAsceAjgS/ewbDca5y3R6qhE/mcKQTteQAOet8P8z6mc5pRfhgha9PfYgTk 7xaos/iIeMWaH3zSBX6Yrs4LzuDktzaukPhgl94SCwy/L4YaqRr3maGcTgJBac3FC8tS EjRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740162363; x=1740767163; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tBZNxOekeKV0LYb007rKOQkv4qSAcfWIVKd3wLeISbE=; b=juMMp/yPdPnn57pnXwWctnjZpFLOu6vNAqiuezO//LTCFz/6P/p/TE3F+nNwe2i4/5 Cau2iLWnCw8+caS0TJSFBpqeoCMId2eahs2jzRsgwlFQFcZ3BJvmGhf4IAl+U3LmuZEs 2Y2a6VAY/2E5nPV4ru0M109IBQsF8QnGP6ePzuzuvxNpZSHjyVI4Z+90Wg19tebYu7+V CkH6zU1irywHmLBHNe2NyYvf0Z2zdcpWGEvHqQcDZErFC/r9nBfJ+ve3Y7H+pBkhjZO5 nQgxX6nSL84IEbfNNxERmfe0BN5fnONF83VxxNeVWDLtr8R0RXilzTrDUed0bJ7gkGf6 BcPg== X-Forwarded-Encrypted: i=1; AJvYcCVJlEbQYTzfpJE9m0DUXhRk/mL1n9sR9z/OWTOmrRTDLJHg+pGcApX33AQQqPKzs4dZNTJYm3Q1Lg==@kvack.org X-Gm-Message-State: AOJu0YzCOzf06XUQR/ad+TX/K8q7Ax6SIewbFbGFeJt7POP2HPSO8r69 aR5Oaj0oDY6EMGDzdQ2XM8z0wMbHMYDXyj8ak1sOIMCyd7BNDOXXlLm20VXMe09pFwH6LcaSBGI uYyXfDgwoZQ== X-Google-Smtp-Source: AGHT+IExPP5BlXnuhegFwP5+f6OWmFBTfcOqXQgMBOZhO/TZNpjmVHE5y8AbHxBbpzzmIk1bu6Aq9tp7s4OWUQ== X-Received: from wmbay5.prod.google.com ([2002:a05:600c:1e05:b0:439:9541:1cf5]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:4e06:b0:439:9274:81d0 with SMTP id 5b1f17b1804b1-439af0d5031mr28996635e9.1.1740162363271; Fri, 21 Feb 2025 10:26:03 -0800 (PST) Date: Fri, 21 Feb 2025 18:25:47 +0000 In-Reply-To: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> Mime-Version: 1.0 References: <20250221-mm-selftests-v2-0-28c4d66383c5@google.com> X-Mailer: b4 0.15-dev Message-ID: <20250221-mm-selftests-v2-8-28c4d66383c5@google.com> Subject: [PATCH v2 8/9] selftests/mm: Skip map_populate on weird filesystems From: Brendan Jackman To: Lorenzo Stoakes , Andrew Morton , Shuah Khan Cc: Dev Jain , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6CEAF18000D X-Stat-Signature: hdo5has78uq19w7456u9za6p7zgp8nyx X-Rspam-User: X-HE-Tag: 1740162364-116538 X-HE-Meta: U2FsdGVkX1+8fNYmZjMAKFcgoBWEqZKTEH3KMPGy/+YrMyhxTAlXJ5C2pJ8+bCTZPaRHf+Nw9rFbsb7ncWoIJDN4Dy7SQefsCnuy6uShhIRbBLc1ePupl7Uif/ZATDRGJuvTF7ynmCsIZ6Lymzb/EiMKrYxZGr4XSu6wkFq/FvtNcPba29saWSV6jizXRdL5NjESvuBfEB1Vt966hfCIPXOdI5w10ppFSCARvEZmp4UxwS8djtQmXu63BLA0ycdzCWg5sVumP0wJjMOHB1T50bL/lsTxGeKsR8ErSKA3Wzoqtq78JBcThtacrbxePumrRA3AITw5cX3MGsKmSZgBA/o7SFH9y8drZJS++DXmIVaLcY4g9UuMHrgBOgx24GArCDFtVLL51C9SFyMQ5TxygY6ujLlR3J4TipuhMMUgGeLo15fobiy2tO9hlX+IAmrF33fLvDt8C3O3vnHJc3NIg4Yfp4VUXsATgvrwpB5GyfTx/mmp4rC9JFs6mitmxVMQvd3s8SiTYik7gukZ0zGpPwvCYiPK0fzcVDVRf0i1/MsiF+xNZLQGgZh3mP6y8dBpPINRueB6Y5MzioZ91/UB3Q5Nmmf55bcqCgMh7uPyWwj/zoxQ1Vl0DeMMO6XsP914fwS2YqGMr/SMax/DhCWWUMAm8zg65W9lo8H4qROY/IN2/V5PhU+FdXPDeoukUFuMqMDUVy/Qxb43AqE+cDw6aGPH/GpKEeky+lK5Okf/4GmZOvPVevhdRbJmS5Fwca9RsY5M19snfCLFeMFmhLWWcte7V+eLS0dFLEt3V9kGT+mXpzmzAUehZHj+QF4kcJrRa5oT12nucwswwIGSNwfjtYtOV+sCgReNdT/LcuCaQach0h/qbeWxTfeWB4Sud7+va1mlX8egM4kyxlHknzMFo4D55TZ+5oTbL5JsmOxUL1O89elF0QashgqU5AMX8QS8efQrDj8saxhwliIRfCZ CWUSBQvs Mpkl1DkgZ+7AzfESnu6Oxg+XlemnxZW9FFdi4AVJrPwq/54G2moCJFDTo5+GTIA6yxTvA0lIX4pQgYP0VP1SE7XzJoC6XfnecZHEPf+R6yaFE6oQuNXK1yfGkeiMS5n0Oicz2bYOT/0WxqQw1FGiN4AtQFY/vitahp47b0W+uosQfEDV+CMxvX9jJCIKUs4EaUXNbZH3jeDyaeJ/3JJWXDiyp359+td9YkXoSnHFExgI6M5J8TboDksZK4/Kvf3niWTfw/U3TpsMkUImFSOdOvVrgGqIHBGaFFb0jOMklKMCQqRlFhUmOxCzQzFc0ffS2fd3xm4ljwQDwy+Q+5z+RHF8VG5RML8T3sEMnHqGHu9GVZLhtePycAxfbX9FoizQrAasqBLGnC7YY2hw2wqerTg93RdwrkDkdK2W8Zw00VieIDTiO20mqqpUXfmnoqx4o8gjVphOd9cmJ8qZr2txd2FVZLmfANwJEvsxJk5dNCdE4zHPcsoIVptc60Aowzmdwk1qajY8Mz3wwy+M7TW0hZL/wEe7OAeuG8zjSrbgU5EF3WiCMnzbQrLYsoIgwYTrstgnLZ8/yiH93CL8ph2hZonl/z/qL9U/C7KclI6b4r6IoOuY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.300557, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It seems that 9pfs does not allow truncating unlinked files, Mark Brown has noted that NFS may also behave this way. It doesn't seem quite right to call this a "bug" but it's probably a special enough case that it makes sense for the test to just SKIP if it happens. Signed-off-by: Brendan Jackman --- tools/testing/selftests/mm/map_populate.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/selftests/mm/map_populate.c b/tools/testing/selftests/mm/map_populate.c index 5c8a53869b1bd287b09a250edf628a66c25c2439..cdd88531dd9fe98f2d25edf4878659767c919e8e 100644 --- a/tools/testing/selftests/mm/map_populate.c +++ b/tools/testing/selftests/mm/map_populate.c @@ -87,6 +87,13 @@ int main(int argc, char **argv) BUG_ON(!ftmp, "tmpfile()"); ret = ftruncate(fileno(ftmp), MMAP_SZ); + if (ret < 0 && errno == ENOENT) { + /* + * This probably means tmpfile() made a file on a filesystem + * that doesn't handle temporary files the way we want. + */ + ksft_exit_skip("ftruncate(fileno(tmpfile())) gave ENOENT, weird filesystem?"); + } BUG_ON(ret, "ftruncate()"); smap = mmap(0, MMAP_SZ, PROT_READ | PROT_WRITE,