From patchwork Fri Feb 21 00:53:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rik van Riel X-Patchwork-Id: 13984680 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD44DC021B3 for ; Fri, 21 Feb 2025 00:55:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 406EC280009; Thu, 20 Feb 2025 19:55:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 319996B00AD; Thu, 20 Feb 2025 19:55:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 145786B00AE; Thu, 20 Feb 2025 19:55:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E8BBD6B00AD for ; Thu, 20 Feb 2025 19:55:10 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8E36D8021E for ; Fri, 21 Feb 2025 00:55:10 +0000 (UTC) X-FDA: 83142132780.17.B6DCA9D Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf16.hostedemail.com (Postfix) with ESMTP id 17DC5180006 for ; Fri, 21 Feb 2025 00:55:08 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740099309; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hF8xMwU6gtFHerZ+8FO0Ift86ipYBUao4K8kpXc1fTk=; b=hTd8z8xFXyW1OZPDZXrQfJSMLeJLw4Hfb797F3tGZd0Elg/LnqG/h0tly90I3w0AcaayWa A4HQX+sCqayaiC3KCs7SfXCyREAk/+Gm96FH18WXWPC7zDUXHPYYsIgXA9w9eq9OYs921F YG/10ci+QmOXvI9WWLToerfVvun0oNI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740099309; a=rsa-sha256; cv=none; b=GQl4jZ4Y6UEOxTD6RC/YKGW/fcEilmQYwEEgux+0rBsS9c/biwJvhAeZuO5lP52lNqvmAU jRdipqvoegohuwIDKfC+ENw8ZQn0KQ5IHmf6ZcQG9u67TSfYRa+lxHaZR/WU0K24q9lLLn r2zvnJUGSvGh8h2Mk4gzKGnl4RoD48I= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tlHIZ-000000003Qf-15zW; Thu, 20 Feb 2025 19:53:47 -0500 From: Rik van Riel To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, Rik van Riel Subject: [PATCH v12 06/16] x86/mm: use INVLPGB for kernel TLB flushes Date: Thu, 20 Feb 2025 19:53:05 -0500 Message-ID: <20250221005345.2156760-7-riel@surriel.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250221005345.2156760-1-riel@surriel.com> References: <20250221005345.2156760-1-riel@surriel.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 17DC5180006 X-Stat-Signature: hxswjh38y7m54umn1ftxf1wq5atpk461 X-HE-Tag: 1740099308-377796 X-HE-Meta: U2FsdGVkX1/gSHjhoID21GPKWmQbqRUI5ieYn720WR8JY3Qv59nmwLNTNFKrxpzy8hc/cbga9IFf5dibzrQRND2+xfDdZqJwnktpPhKS6qZE3YXvnkwplF+qJy8i/8EzcmRKvjbixaBJIMYLFw/b2/Egko9RNdYTUG8mPKytZ8nYwWfDvdzmorR0GElUQ9NyKLLoZn6V2o7RYn5S7iTMniq5BW5aLwhpL4XZzvRCpps/ytDrpjkVzRbXiZm0kK8D8Uaxbj0vfNyUjCGU1R76Zd1tCG0lul2iHIlhZ2wKo/5/oD8U6hv6TFT/82Na468LXG6gJCPVNWYjtaS5mvE+8O4gblMTTwsYnUttVlrcVMXWs/oQJS6GkZvJ2xBDTAzPsISK7fN96sV1jUVlqbTDsBv88QjNhVP7ij5hyTkhcSfnyWmcwZxbP7E0llAQATwuMlowXfaImRHnLMfB7NuaGq+IN0x0v+3NHVmSDHHYA4V5wwCqtwhAHWREJjgN7D4bNTW6OLIEEayQB/DjKOwsJfxdUBcp2Dz6qHE92RykbIYwbO//dTOGvnu4PiF7bcqzo2tcdM5C0eGLb32dh9eMJMCW8kiv8JaatACPyjv4gcwPquwufSBoU02spxxd/KwE5JplJ8dyXvaISXV5vUzlPgvBXn2Le5l3cpejbtlHHkSsLGdCsvFIIDpOf5weRJ0QudWLCTVlxVcN95q1v5eZxhvviaX1+jzwQDRNDZO46gaZqFgyOzsuTc2Tq9aXzvPyfVcoiaBrNBUZM4/fC9smu3Kl6sDKKHxTJjc+g+560ndDkE/jbl6Ixf2VknzWMHmuZYmMUW1yExIlSVtH45bfkL5PtEpwsfCZvNUv6og5jacETMCEvg7esKoUMNPHh3+PbOuy+jfjSKzgvezT5Ctq12L+DfMqAa1OOVN838f0iidnuCanqOf2d+g+Vukl/mrKma4Kj68gJdMMCI1rr6i iIoGJdn/ inlx4hUqoOeE7on8Q7BOpNQkGjI+sDN/H1umFda8JpxZ72X/DF1rR4JRBBjwn+c/mkrIAYsFPhsQ8sBG3SBhBYme+q+/7WjEWYVE8jzL1+Zwf5oYfdyTU98iedMRn0JyXUJtuPIK4hLoPQTxkDhMgSZ6Ee2yLyPkkhQNEjwrbraacB6CB54FTf7c4hbxz9prmPiVSoxBmb8W9qnw+FyWgK7oDYtl0vh8rV2gAQJJ9oXRpvo3Mwbpg7sapH608qdzRgXzt2nkA99gulUnjwAttUbtBV+X0x+ok2IgGyLh4jq7kd4JtKlp0dO/AHZA4DpwAutb1k3XJIeGiCBV3LIfBgHC0FcF9KaeBzxhYcxvVo3oIKZy2fLKwR92p7mdzTwuHzlhm2E0K7iCRUQT+CMBDgw9M8xNP+WtvZ7q6DY8PzoakHCAuiythjkXQKPHZglNeXeLg/HMpL6tWMO/7R0eR328/eSSBgYkkhpnm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Use broadcast TLB invalidation for kernel addresses when available. Remove the need to send IPIs for kernel TLB flushes. Signed-off-by: Rik van Riel Reviewed-by: Nadav Amit Tested-by: Manali Shukla Tested-by: Brendan Jackman Tested-by: Michael Kelley --- arch/x86/mm/tlb.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index dbcb5c968ff9..59396a3c6e9c 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1077,6 +1077,20 @@ void flush_tlb_all(void) on_each_cpu(do_flush_tlb_all, NULL, 1); } +static bool invlpgb_kernel_range_flush(struct flush_tlb_info *info) +{ + unsigned long addr; + unsigned long nr; + + for (addr = info->start; addr < info->end; addr += nr << PAGE_SHIFT) { + nr = (info->end - addr) >> PAGE_SHIFT; + nr = clamp_val(nr, 1, invlpgb_count_max); + invlpgb_flush_addr_nosync(addr, nr); + } + __tlbsync(); + return true; +} + static void do_kernel_range_flush(void *info) { struct flush_tlb_info *f = info; @@ -1087,6 +1101,22 @@ static void do_kernel_range_flush(void *info) flush_tlb_one_kernel(addr); } +static void kernel_tlb_flush_all(struct flush_tlb_info *info) +{ + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + invlpgb_flush_all(); + else + on_each_cpu(do_flush_tlb_all, NULL, 1); +} + +static void kernel_tlb_flush_range(struct flush_tlb_info *info) +{ + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + invlpgb_kernel_range_flush(info); + else + on_each_cpu(do_kernel_range_flush, info, 1); +} + void flush_tlb_kernel_range(unsigned long start, unsigned long end) { struct flush_tlb_info *info; @@ -1097,9 +1127,9 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end) TLB_GENERATION_INVALID); if (info->end == TLB_FLUSH_ALL) - on_each_cpu(do_flush_tlb_all, NULL, 1); + kernel_tlb_flush_all(info); else - on_each_cpu(do_kernel_range_flush, info, 1); + kernel_tlb_flush_range(info); put_flush_tlb_info(); }