From patchwork Fri Feb 21 22:38:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13986408 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1CD5C021B6 for ; Fri, 21 Feb 2025 22:38:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B810628001C; Fri, 21 Feb 2025 17:38:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73AD7280019; Fri, 21 Feb 2025 17:38:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F18A28001D; Fri, 21 Feb 2025 17:38:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A9171280016 for ; Fri, 21 Feb 2025 17:38:33 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4C03E1208E6 for ; Fri, 21 Feb 2025 22:38:33 +0000 (UTC) X-FDA: 83145417306.06.D494188 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 4E8781C0005 for ; Fri, 21 Feb 2025 22:38:31 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=fNM7nLrE; spf=none (imf20.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740177511; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rJT3XHCnmeFYD6/zws/j5/iie6UCiOo1LUIbVleTx0A=; b=1AfYl5snh/EtJlTPf2LeQJjvCvv2JkjBRuxrV8D0aOFQGVw/z0oEv+132D1G18+IE/IzA7 YyMLYPpMqM44T23gOFKJBFKClaftnj8zfcv7q/N4lKcnPHMEK4RL0RkINuT9a9OrCndL7r aA2ct5aJGPfpqunpzsETXFhqA4Sw0A0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=fNM7nLrE; spf=none (imf20.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740177511; a=rsa-sha256; cv=none; b=DNwKu3g1sSNcpNuLaQRyqL2fltWo/eFTZVAItq4FliTrZaaW2hfpHqlMYeM53QACOpuzKk QIQmQdErKEIf5MOE2eqTS3kXtv5NQ+NNxeLUVKdvrv0vuSSctQ6jGcFdw8DfWend8nEQE5 8O6bgUs3Ojmi/O4uFa4RWOmPfSyn/1A= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=rJT3XHCnmeFYD6/zws/j5/iie6UCiOo1LUIbVleTx0A=; b=fNM7nLrEP3BEk0dY3WSxjlab7o 6lNb3AIH3BFvSoLugZ4WNdP7IG8Cg8W2ch0jq0AhMywPJKPaiogqFwSJZ0ECdy04X3UTKESBvU3PK JLx5CfzV5CaKjs818jt1jtN+H1FfwqHJX8EgMqHeh9vUT2+WlVUy1uNkgTfJ1gfYl0+3CcDLUxUUM qurRxxCwJtcyZ6hdL9364M+WTQuluLk41RQbAQkWKGiYdDig5Ixpr43QFsEpKnObdxnu1YrnaG8US RCV/7DPIvZHWOrh2rN57C9HA5SQCON7LK59aMOl8vXC4bqPmhEug6c9iaai5HcqdDKE0ssxa0/RZY ckh02Tog==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tlbf7-000000073DB-3iIF; Fri, 21 Feb 2025 22:38:25 +0000 From: Luis Chamberlain To: brauner@kernel.org, akpm@linux-foundation.org, hare@suse.de, willy@infradead.org, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org Cc: john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com, mcgrof@kernel.org Subject: [PATCH v3 5/8] fs/buffer fs/mpage: remove large folio restriction Date: Fri, 21 Feb 2025 14:38:20 -0800 Message-ID: <20250221223823.1680616-6-mcgrof@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250221223823.1680616-1-mcgrof@kernel.org> References: <20250221223823.1680616-1-mcgrof@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 4E8781C0005 X-Stat-Signature: as68j8emw8n7pckqkma6ofpszzt5ws19 X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspamd-Server: rspam03 X-Rspam: Yes X-HE-Tag: 1740177511-427282 X-HE-Meta: U2FsdGVkX18w3xvKw2Am8b/OFbPGcmZ9a2LogBIT2or/os6fKy4d0Fk4MNqfK1KlRHqvIms0iOL6MM210nXVjz/2QjLfzHbHyraEXwP6VTHX9AKnkB9OioPGJIMoonFIFz1R5Iw0OodKaD/JiTiUSZUi4db0pUqP5MxdiIvBRWWPHDXbGuDZcPtcoXYLDGy+PFQq2XftA8R7bOziJXhC7JNIOHzArT02XUK3RctJqEmlxH4UBCtkBM2baFQKqGY5haE/urRUzCQZuGaWa+FPIXqA9Rumwax1UbPeAufu5TKOcaDf2lB12OT9mN0N6pFMvjMPIBFEQszUXbKH6QVwZW3wfKRHd54heEA0kOlYHHsIjcZBt9C3+dAx+6+87v7HFycmwWdBrpmrzh3Vyj0xYCCLwYKfM+b91sl54q/OZo08pV4Mi/8kUy3Ml3Al4VSbkqK5ounjx5Mmhb6C/9XiMF5POUX/tEidC1s6AZlQvTbQyGnobNzwPNumH3ouwAFmfv8m5z6I/Fl6WmVWFVM/mgiAfLKVe5Witmi5JPDjfQTfcBeQtsT4L9r2neVKJAUW4DC5HUXb+4meibG3mVaz1P6qAfwXTDknimThD06l/G460FsPWFaUbyiCAtSHksBGke5GGepJxl+AnFFS+4/RaAlayEU/USErISGgp8ik9vsLBy3DyLnS8gGzmcR9OLtcmKF4z3obWKzIdOWnh3fBuQrpoWAZkhI/+sQ1j4gAoGEzc/SPUmpmSHkuKZ+zkXHqQFMS36XBYwlBWB/fDbK//FcXCubmC49xcghKg96Kr1NSC1SwzZwa+Fs/u/iBx75+JzW4UjdYuak3RSRYop3OM0SN0SdB5YJ/X4V7UbqT2fJllRkwosj1f4+GFUqGi/5y978r4Ni4N5vxTuhp+5bQkfrtux5PZ4fWmy7G/y8gDmDIKbOGGvqI7wRu4cyyPOcuKooBzQ7022PYwFTigsP RQD73RBo vp/Fjj4oxqoAlx4kpWAANG35oICh232Log+mryWpiaFCSFirLAo8Ozb8Etyw3mkCXysKS6731mJjBdSF0PPh/Y56WgUjYByE7q+f9K8hCENnRMbUBoytsM49ICM9rO/31GAubyKyycl6TUsNjof3SAqisYYKDd+gdWYnxCm6yVC2Iy1E79zeMlNFyZDpSwmQ4O6mvkznYONL8mmF640mOS82SonYOYOCLZHUzXc9CdzdWaJcaxWIEElcObgvtn+d1DiIhdG4WHl+1QTxoADLbkPilgBLQEvD4M47ULjvRhD3hpIiXj3IN5JQY+3KcjQYyvD9x334tLXv3AKoQiyjroI4p92slUEpaLi8XB7rVvyjz+aV0mIN8xRualAldwVmPAK9C+XSAzNJeW2PPcO6nQHXGC+YLYuP3Sk8Y5a4ZFTc3WfVsszwjMdDWs817ym+r6FQeCJ1lInO9CGsLbM8+If2ZtGJx/m02nUh7n9QTQYUgyuMKwB5q8Kvp493L8VyYMPE/W053V5r33zbp73lUKGeT5QuJFAW63dAGtoDNNCfaKzkJX9o0wJNn+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000036, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Now that buffer-heads has been converted over to support large folios we can remove the built-in VM_BUG_ON_FOLIO() checks which prevents their use. Reviewed-by: Hannes Reinecke Reviewed-by: Matthew Wilcox (Oracle) Signed-off-by: Luis Chamberlain --- fs/buffer.c | 2 -- fs/mpage.c | 3 --- 2 files changed, 5 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 167fa3e33566..194eacbefc95 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2371,8 +2371,6 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) if (IS_ENABLED(CONFIG_FS_VERITY) && IS_VERITY(inode)) limit = inode->i_sb->s_maxbytes; - VM_BUG_ON_FOLIO(folio_test_large(folio), folio); - head = folio_create_buffers(folio, inode, 0); blocksize = head->b_size; diff --git a/fs/mpage.c b/fs/mpage.c index 9c8cf4015238..ad7844de87c3 100644 --- a/fs/mpage.c +++ b/fs/mpage.c @@ -170,9 +170,6 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) unsigned relative_block; gfp_t gfp = mapping_gfp_constraint(folio->mapping, GFP_KERNEL); - /* MAX_BUF_PER_PAGE, for example */ - VM_BUG_ON_FOLIO(folio_test_large(folio), folio); - if (args->is_readahead) { opf |= REQ_RAHEAD; gfp |= __GFP_NORETRY | __GFP_NOWARN;