From patchwork Fri Feb 21 22:38:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13986413 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A49D8C021B5 for ; Fri, 21 Feb 2025 22:38:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9064F280019; Fri, 21 Feb 2025 17:38:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 477C228001D; Fri, 21 Feb 2025 17:38:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E634E28000F; Fri, 21 Feb 2025 17:38:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1694228000F for ; Fri, 21 Feb 2025 17:38:34 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B569FB19B1 for ; Fri, 21 Feb 2025 22:38:33 +0000 (UTC) X-FDA: 83145417306.26.D6ACD2D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 05A4418000A for ; Fri, 21 Feb 2025 22:38:31 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KovaJ9el; spf=none (imf06.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740177512; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uqPIF+VvQBHBH50rSFfIRgR8/dA90Fp8sC9NPmrqGVY=; b=GNlVcx00K/TYHgMeEwY03tjqzK7ePfxfkvipULDr/48srZvBAZ09KGcC1t3Ff3ATt8Jh1N ajRjA7dlWwv9vWKe1m7pNyA6Tun47qKSvs3bPwZzxqdiinKMFJHK5Gdbn33IX0wg+vCEUd sXuXxTIoxzLCcWQz5TDclSq0VJgy5dg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740177512; a=rsa-sha256; cv=none; b=RjmUEgMXHZVeJcpIJwC4/UVzxKwPtyYvC/kw5k0Yju5D8n6nTVMXLNT9/RxjtR+LIoomwK qXEtzFG+hEKhOLwsdTvwXpLh/tHZHtI9oGKQxzINEPqo8qJXLMZBpjom8Ppi43zLD9g9MK khBhxP6KaiUIdv+rfvTFJYKmRxckGNM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=KovaJ9el; spf=none (imf06.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=uqPIF+VvQBHBH50rSFfIRgR8/dA90Fp8sC9NPmrqGVY=; b=KovaJ9elkLijktp/Abx8dRypXr DRIMF2gDcno3sOYSd7AGjBhj7LPwqbloLT/XVcG9RyJjaqI0uBUiA0CHb97ewv5bYFhn04oQmPtqJ l9yUhtcJXseNVC7p6LDh8imdU0/Htn7uzKBiNWzZfcKCSixHqG1iZ3KmQJOEdWnvNH6jIf2Q5sPaV xv9i4Tb8GOLEZEeiRfuTie8IDbiq+Ce++8Kzl6AYKumyoPHbtCeAirWEII6l6/u5NLm/2BmmwCx2A sB8eSjBO5fTJeTXRUXGEzwTD1o1+uGCxPwQy+zwwJC1zFciCUVgZqlyDFUmwxhnQLEzs7RNExo3Cw kHeAkTkQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tlbf7-000000073DF-40fU; Fri, 21 Feb 2025 22:38:25 +0000 From: Luis Chamberlain To: brauner@kernel.org, akpm@linux-foundation.org, hare@suse.de, willy@infradead.org, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org Cc: john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com, mcgrof@kernel.org Subject: [PATCH v3 7/8] block/bdev: lift block size restrictions to 64k Date: Fri, 21 Feb 2025 14:38:22 -0800 Message-ID: <20250221223823.1680616-8-mcgrof@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250221223823.1680616-1-mcgrof@kernel.org> References: <20250221223823.1680616-1-mcgrof@kernel.org> MIME-Version: 1.0 X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam-User: X-Rspamd-Queue-Id: 05A4418000A X-Rspamd-Server: rspam07 X-Stat-Signature: 68cdr8op7hya9o1xs3417zo15syf8rm3 X-Rspam: Yes X-HE-Tag: 1740177511-709464 X-HE-Meta: U2FsdGVkX19J2Fx83SE5A6e1Rzr2AbPk3MuY9py0qmsM4veanNzPG6J2PONZqoGnvpLms+fd35+8NaiS25qkNhezo/i9Tx9V7cUVGhqHuTbYIWIb24UQN1U+PosO38k5xYLbjgSyHVw2xaciqTwcnp2duL9BhrTx9kW3FkVyjSgJ8XRb0xFv50BNw14SIqptzo7XjC48ZYgP/8qy0rSvkyhwZl9qOlLWVnzKLGgCqx4KYTr7IMnQ/CyiX7dQ0bZXOc/g9gCeOow7BF5c6aZMPeRZg6wsyIVT/vCRgX4awZjfcTLrK2Y4EfQa5ywl0h9oUCsrrIrCKc8svgvBjwMvV1gR2dMj82htgBzUgn0qHZvlXmmSm7hQIjFz0Yl1sG3tBim/GLayAI3xFxX5mBiiHRkn6+/SAz80bveUR9APJ2cZ4sg41nyRBl+7qXmeVhKrIEV+j7So3U2ce3Ox9Tet6eE+9H8ZD09eUYS8xMF5HbbafHp2IfO7hHr+EInJmVaZC6Qm73llh8Yi+awxXQUtIDsxpHlvdtnqZKCl/746EEfbVU5hso4+ArmB9L74XfB8OTpGzlYC3ScQR8U+JZOJpyt0Y/N8wT86de/9hwg4oWXm8Z3TzNRNRPglT6AHITM1k90dB5StILZnImjdsBExK6aj9tPNFfu9CwjOn38n07PjR5qM4ZpDFufQQYp1mjBS4NPkhccCrXlbgQ+m3vbzdxQoWdkxSgEOAPyJVc7jv7P0jvMhY0LyCn5plhTedURPDsG1Pji0nHZyJuyrdYK1Wo769bGZ6eQsSRlP1L4ZmmV22uaB7Gkr4envv0nc0hdIM7fWNHeXGSrdGXhiUFU2QyD3XulkPRDZBlP2Yy9HUp7EJ1FeeYxwCVnUMGHBB55M5ZO/JuwtXRCsGJH/8cKyEyTJc/bUFApx/g94YJOhwuAAH18fXHsnyCJ2OqzLjj0orvOcyLa3NsF7/oSBXOd KQrrJ578 nrgVMYIev9F1kaJNkISBD3pD+Jiv+cosiNXgtyIviyaQwkO+zXJlCDi6Qil1j6cRE3DZNQBSmJ7KGp1ypvqZ0ebISB6whWtIsDq81mg3WKXUenwB3phNAQYjn6a3gQu7xZl4XY/QtoibjJIym+r7CgOjYK1Dz+ip/pm/ZLNKwPH2mYZkDrP/uLOn1Bs6u48uYzisHYVJY/SdO1Nko+i/DqMmHZBnndRwAihz0NCUzit8o11Ca6B+UEFDSlltTmSI8ah7yVLoLnw/8FV1QJ5vyH2fbJzdUb5yf2XZwV69wfqGZYZnTCDJyLVM1MbZr7KUeNzYVGMkn3r82HEHRDgHrhDnpB5q1XBlWBQ+xGAGCwiEvTt8KGKosr6QPfEnucvuZd2ng7GAnMXCH1uXw9PqJfLXFEx9RITNFFDPBcwqs9TmeHvBKdP2Huh0xuR0T6e/RZ1iDtAM7EOsboszKQUB8F73aSuP7hRmVaPz4HzRD9N2BW5IZeZNGSgfCEQIuCQuW3wmM6vLWq5glRr8uvLxFdPV2iLCx48ZI2+eBjxNNOZOiedQPL0F0gGIwmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We now can support blocksizes larger than PAGE_SIZE, so in theory we should be able to lift the restriction up to the max supported page cache order. However bound ourselves to what we can currently validate and test. Through blktests and fstest we can validate up to 64k today. Reviewed-by: Hannes Reinecke Reviewed-by: Matthew Wilcox (Oracle) Signed-off-by: Luis Chamberlain --- block/bdev.c | 3 +-- include/linux/blkdev.h | 8 +++++++- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/block/bdev.c b/block/bdev.c index 8aadf1f23cb4..22806ce11e1d 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -183,8 +183,7 @@ int sb_set_blocksize(struct super_block *sb, int size) { if (set_blocksize(sb->s_bdev_file, size)) return 0; - /* If we get here, we know size is power of two - * and it's value is between 512 and PAGE_SIZE */ + /* If we get here, we know size is validated */ sb->s_blocksize = size; sb->s_blocksize_bits = blksize_bits(size); return sb->s_blocksize; diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 248416ecd01c..a97428e8bbbe 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -267,10 +267,16 @@ static inline dev_t disk_devt(struct gendisk *disk) return MKDEV(disk->major, disk->first_minor); } +/* + * We should strive for 1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER) + * however we constrain this to what we can validate and test. + */ +#define BLK_MAX_BLOCK_SIZE SZ_64K + /* blk_validate_limits() validates bsize, so drivers don't usually need to */ static inline int blk_validate_block_size(unsigned long bsize) { - if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize)) + if (bsize < 512 || bsize > BLK_MAX_BLOCK_SIZE || !is_power_of_2(bsize)) return -EINVAL; return 0;