From patchwork Fri Feb 21 22:38:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 13986405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E0A2C021B3 for ; Fri, 21 Feb 2025 22:38:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FB2E280018; Fri, 21 Feb 2025 17:38:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F0711280017; Fri, 21 Feb 2025 17:38:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D566A28001C; Fri, 21 Feb 2025 17:38:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A543C280015 for ; Fri, 21 Feb 2025 17:38:33 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 54ACFC08E3 for ; Fri, 21 Feb 2025 22:38:33 +0000 (UTC) X-FDA: 83145417306.29.19906C3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 63A0580004 for ; Fri, 21 Feb 2025 22:38:31 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=qfI+6CVA; spf=none (imf30.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740177511; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dPYsaEMRasFiFhMNTtOpkluc57HIzwvU4rUiMYmi9nk=; b=1v8ap4mKLHgEYC8jxAioi6FLen3qPp80LFlJK8/FV4VKspu9SsjbcQyimLXHtv9betIZ6+ V7ElQFfJm5hC2bM98JttSF0VosXb3Zkw8mheWw8aCwpmOXNOUt4yq5gewYjYU9SkmZhzLU 5xuvJ2YUHYfpgbdPyZEvR7iMxu/TZng= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=qfI+6CVA; spf=none (imf30.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740177511; a=rsa-sha256; cv=none; b=dmUrBzzGcn5pZzw/Mv1WskGNWcy19YiyPDIrKE5cdEXIXrORNPXiSWAr4QwuSt5XgbAHqg VjHR5n+0+rVOqdQWkOraLKcf8mu8ugjXP/l9OOyVP6+Zvc3qUB9uDmlseBmt/mqD1jWTma 12Du33SMFyU1pAwWd+Zr1UVx96f2pok= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description; bh=dPYsaEMRasFiFhMNTtOpkluc57HIzwvU4rUiMYmi9nk=; b=qfI+6CVA3tipgW2HoFB+Sph6kC ojVbYPteH2HN9YNIRQNgabxVOxbyu3vzNyWvcv3QbydCSqjtYEdETy6GhjYsXGmXOCgLRADt5Riul gId1AxDN9dF2oJR5t3/LL0ik7MU+eLrERaAhdwNDmE+OwEgiGDfgIepYOT7kwkzzJ7oOkWQt5vtyx f9kws4SbOJoxp26AbIBPJq6lE0zge4Mc3mCg891tFx45dI0gbb4dw2do/e3cbtflZ1JWK7hmP3Fxk oeIUsxXFbB/ahkHzLQcFsLTsiMgkf978tsMNCly6+41cEHR4AljXIfdUIbUuP0CE6LZ+QsyN1B5cn gBsm3zOQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tlbf7-000000073DH-49mH; Fri, 21 Feb 2025 22:38:25 +0000 From: Luis Chamberlain To: brauner@kernel.org, akpm@linux-foundation.org, hare@suse.de, willy@infradead.org, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org Cc: john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com, mcgrof@kernel.org Subject: [PATCH v3 8/8] bdev: use bdev_io_min() for statx block size Date: Fri, 21 Feb 2025 14:38:23 -0800 Message-ID: <20250221223823.1680616-9-mcgrof@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250221223823.1680616-1-mcgrof@kernel.org> References: <20250221223823.1680616-1-mcgrof@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Queue-Id: 63A0580004 X-Stat-Signature: kgz3ijr9yfcz71mfz11kdjz4msoq81d5 X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspamd-Server: rspam03 X-Rspam: Yes X-HE-Tag: 1740177511-149635 X-HE-Meta: U2FsdGVkX18LMMb+Bp9KgrOyY+6DYqCzj0PI93jdLG8rFnUuN6CyBcPgrV+DyksA03YwNN8mdt7kuzaw9sEFuqCDTmrBPB4UK6ytOc06oViiWeFanuTKe+tBx1SnmxN0ytgNkAfRfNvcGwGjBKaFIhAGiAjHggxNwJyMcc4njgTlqHqyJ+jIohaDTdA1s+RoCdF1796dgnNToXiQrZNFGZFYq00DtlcdPSb8KodudLQMOZrgFQvPGbDn1rM8PjJybTCMUGH23opeL6hGaHpbvPk8GRwrY+Y+lA2NSNXDa4JXWfFw3ECW5tVeuyVd7+som1KsFfE1zU5sZoJV69iPDR+SxmVR77qCaYoveIC8I6Oc+VbDDhauvt5xqdEjXKyEV1D/9CeSUdy09ns4Fr6iFs1v/7wbX1eVB8cgkdEqhrH2uTQLBZjIdaTlN0onhNzTp2l3VmfHlx0J6p7px1BFic5J524Lvb5ZtPjjgh3V4MOxvJUke35RZsvbpN1bF3G9U+7B1R3uwbpEbvq9bO2LGu9tZ1UrtHFLIiI4oAe2Rof7r6iwqqstT5h4BU2gEpnHOXIJs/NdZ7ZgeuNxdXhqanuUm1xA7TwD5cObYZ+EiTAvXUmec2GUI8824qr+UFJah67soin35ytdGDslZo/3w4fKMDfFjs4q/ePflNBOvkCENcx5IY7v3JoHPy+ENceDj8HEvrS8rKpmHgK5ybAMAKmPKvnCpbfBjRRR90TFzX2ktudrIvCRuNamGBoAOgKrRQVwhbflT7SxMCxhKFpPCY3aVcaptHkMLVNYUH/FeWPcsUo/7RhXkSEZasQ84NoR5Es6Nd0XMIUpcazFpLivNJbZvRzLgzOk4kuOJ9BBrtROJFOlFxBa6M3eDPuqApEFZSulm5eAj2djs9KPHFMSj/HHnwQVvEzip/kLAeGxx7UcvXn6PW4pJaYD2KXK8iNxU0NP5lIqwx4VkTM5f+H K1/al1oZ XF34ehwpg8tbeK0Qy1EW1OLKnsMvHqnepvVsKjbT51EGAX6DlECWYLTSeVepxX6gcBBHOkwm4tgOocdnvhLYE3tmU1OreL5itLetu/2gPEw92+2j51ysL0Ozqd14FN+kMMjnTYTgPRtT+ggMSUVSzMISryBo17DxVvwPFGuQVJiI833o2iaQcO5TDG27Z8CK2GwG1QVzGeuIXBbAZrjskIwESjUi1NVUimoTJYRAcC6R8wqBwrFM7eVoH9vI1H9Teci9BRMp2SbVENgzLQADHIGR5Fz9MJIiuNZtx5iM9GmDIlmyxFK5iFBbHOYyd77fWQS1XOfed8Pn6lIHYjOjRCjnqjPamrXKTPVRwCxrGCwv7DVZ0VzzxNituqk8lS/ZRetOCzJQ6r+bequFz9gx/rnFC2P7t+vpufWzx4IdTmouV5NWQCVz7fdIwxNBcQ0mKQAVVuZFlqhxae/B7fawLIryWLiS4aoGNd84UhevVhH7gOMAnaUmJKBhFgaKcSS05X7I3nhqCigJjxCINtMfu1Uvl/2OjkrsTNmY5mPZlgVuci/8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: You can use lsblk to query for a block device block device block size: lsblk -o MIN-IO /dev/nvme0n1 MIN-IO 4096 The min-io is the minimum IO the block device prefers for optimal performance. In turn we map this to the block device block size. The current block size exposed even for block devices with an LBA format of 16k is 4k. Likewise devices which support 4k LBA format but have a larger Indirection Unit of 16k have an exposed block size of 4k. This incurs read-modify-writes on direct IO against devices with a min-io larger than the page size. To fix this, use the block device min io, which is the minimal optimal IO the device prefers. With this we now get: lsblk -o MIN-IO /dev/nvme0n1 MIN-IO 16384 And so userspace gets the appropriate information it needs for optimal performance. This is verified with blkalgn against mkfs against a device with LBA format of 4k but an NPWG of 16k (min io size) mkfs.xfs -f -b size=16k /dev/nvme3n1 blkalgn -d nvme3n1 --ops Write Block size : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 0 | | 2048 -> 4095 : 0 | | 4096 -> 8191 : 0 | | 8192 -> 16383 : 0 | | 16384 -> 32767 : 66 |****************************************| 32768 -> 65535 : 0 | | 65536 -> 131071 : 0 | | 131072 -> 262143 : 2 |* | Block size: 14 - 66 Block size: 17 - 2 Algn size : count distribution 0 -> 1 : 0 | | 2 -> 3 : 0 | | 4 -> 7 : 0 | | 8 -> 15 : 0 | | 16 -> 31 : 0 | | 32 -> 63 : 0 | | 64 -> 127 : 0 | | 128 -> 255 : 0 | | 256 -> 511 : 0 | | 512 -> 1023 : 0 | | 1024 -> 2047 : 0 | | 2048 -> 4095 : 0 | | 4096 -> 8191 : 0 | | 8192 -> 16383 : 0 | | 16384 -> 32767 : 66 |****************************************| 32768 -> 65535 : 0 | | 65536 -> 131071 : 0 | | 131072 -> 262143 : 2 |* | Algn size: 14 - 66 Algn size: 17 - 2 Reviewed-by: Hannes Reinecke Signed-off-by: Luis Chamberlain --- block/bdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/bdev.c b/block/bdev.c index 22806ce11e1d..3bd948e6438d 100644 --- a/block/bdev.c +++ b/block/bdev.c @@ -1276,9 +1276,6 @@ void bdev_statx(struct path *path, struct kstat *stat, struct inode *backing_inode; struct block_device *bdev; - if (!(request_mask & (STATX_DIOALIGN | STATX_WRITE_ATOMIC))) - return; - backing_inode = d_backing_inode(path->dentry); /* @@ -1305,6 +1302,8 @@ void bdev_statx(struct path *path, struct kstat *stat, queue_atomic_write_unit_max_bytes(bd_queue)); } + stat->blksize = bdev_io_min(bdev); + blkdev_put_no_open(bdev); }