| Message ID | 20250226070202.95062-3-gmonaco@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Hi Gabriele,
kernel test robot noticed the following build errors:
[auto build test ERROR on ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7]
url: https://github.com/intel-lab-lkp/linux/commits/Gabriele-Monaco/sched-Add-prev_sum_exec_runtime-support-for-RT-DL-and-SCX-classes/20250226-150508
base: ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7
patch link: https://lore.kernel.org/r/20250226070202.95062-3-gmonaco%40redhat.com
patch subject: [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct
config: arm-randconfig-001-20250227 (https://download.01.org/0day-ci/archive/20250227/202502271525.N9ZL15lR-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250227/202502271525.N9ZL15lR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502271525.N9ZL15lR-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/build_bug.h:5,
from include/linux/bitfield.h:10,
from arch/arm/include/asm/ptrace.h:13,
from arch/arm/include/asm/processor.h:14,
from include/linux/sched.h:13,
from kernel/rseq.c:11:
kernel/rseq.c: In function '__rseq_handle_notify_resume':
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:57:69: note: in expansion of macro '__trace_if_value'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~~~~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/asm-generic/rwonce.h:44:43: note: in expansion of macro '__unqual_scalar_typeof'
44 | #define __READ_ONCE(x) (*(const volatile __unqual_scalar_typeof(x) *)&(x))
| ^~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
50 | __READ_ONCE(x); \
| ^~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/asm-generic/rwonce.h:50:9: note: in expansion of macro '__READ_ONCE'
50 | __READ_ONCE(x); \
| ^~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
include/linux/typecheck.h:12:25: warning: comparison of distinct pointer types lacks a cast [-Wcompare-distinct-pointer-types]
12 | (void)(&__dummy == &__dummy2); \
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:128:10: note: in expansion of macro 'typecheck'
128 | (typecheck(unsigned long, a) && \
| ^~~~~~~~~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
>> kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
| ^~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:542:9: note: in expansion of macro '_compiletime_assert'
542 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:9: note: in expansion of macro 'compiletime_assert'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~~~~~~
include/asm-generic/rwonce.h:36:28: note: in expansion of macro '__native_word'
36 | compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long), \
| ^~~~~~~~~~~~~
include/asm-generic/rwonce.h:49:9: note: in expansion of macro 'compiletime_assert_rwonce_type'
49 | compiletime_assert_rwonce_type(x); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/rseq.c:423:40: note: in expansion of macro 'READ_ONCE'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~
kernel/rseq.c:423:55: error: 'struct mm_struct' has no member named 'mm_cid_next_scan'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/compiler.h:57:52: note: in definition of macro '__trace_if_var'
57 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
| ^~~~
kernel/rseq.c:423:9: note: in expansion of macro 'if'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~
include/linux/jiffies.h:138:33: note: in expansion of macro 'time_after'
138 | #define time_before(a,b) time_after(b,a)
| ^~~~~~~~~~
kernel/rseq.c:423:23: note: in expansion of macro 'time_before'
423 | if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
| ^~~~~~~~~~~
include/linux/compiler.h:55:28: note: in expansion of macro '__trace_if_var'
55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
| ^~~~~~~~~~~~~~
include/linux/compiler_types.h:522:17: note: in expansion of macro 'if'
522 | if (!(condition)) \
| ^~
include/linux/compiler_types.h:530:9: note: in expansion of macro '__compiletime_assert'
530 | __compiletime_assert(condition, msg, prefix, suffix)
vim +423 kernel/rseq.c
390
391 /*
392 * This resume handler must always be executed between any of:
393 * - preemption,
394 * - signal delivery,
395 * and return to user-space.
396 *
397 * This is how we can ensure that the entire rseq critical section
398 * will issue the commit instruction only if executed atomically with
399 * respect to other threads scheduled on the same CPU, and with respect
400 * to signal handlers.
401 */
402 void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
403 {
404 struct task_struct *t = current;
405 unsigned long now = jiffies;
406 int ret, sig;
407
408 if (unlikely(t->flags & PF_EXITING))
409 return;
410
411 /*
412 * regs is NULL if and only if the caller is in a syscall path. Skip
413 * fixup and leave rseq_cs as is so that rseq_sycall() will detect and
414 * kill a misbehaving userspace on debug kernels.
415 */
416 if (regs) {
417 ret = rseq_ip_fixup(regs);
418 if (unlikely(ret < 0))
419 goto error;
420 }
421 if (unlikely(rseq_update_cpu_node_id(t)))
422 goto error;
> 423 if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan)))
424 task_queue_mm_cid(t);
425 return;
426
427 error:
428 sig = ksig ? ksig->sig : 0;
429 force_sigsegv(sig);
430 }
431
Hi Gabriele, kernel test robot noticed the following build errors: [auto build test ERROR on ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7] url: https://github.com/intel-lab-lkp/linux/commits/Gabriele-Monaco/sched-Add-prev_sum_exec_runtime-support-for-RT-DL-and-SCX-classes/20250226-150508 base: ac9c34d1e45a4c25174ced4fc0cfc33ff3ed08c7 patch link: https://lore.kernel.org/r/20250226070202.95062-3-gmonaco%40redhat.com patch subject: [PATCH v10 2/3] sched: Move task_mm_cid_work to mm work_struct config: arc-randconfig-002-20250227 (https://download.01.org/0day-ci/archive/20250227/202502271546.WRb9VN4H-lkp@intel.com/config) compiler: arc-elf-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250227/202502271546.WRb9VN4H-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202502271546.WRb9VN4H-lkp@intel.com/ All errors (new ones prefixed by >>): kernel/sched/core.c: In function 'sched_tick': >> kernel/sched/core.c:5667:21: error: 'RSEQ_UNPREEMPTED_THRESHOLD' undeclared (first use in this function) 5667 | if (rtime > RSEQ_UNPREEMPTED_THRESHOLD) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ kernel/sched/core.c:5667:21: note: each undeclared identifier is reported only once for each function it appears in vim +/RSEQ_UNPREEMPTED_THRESHOLD +5667 kernel/sched/core.c 5629 5630 /* 5631 * This function gets called by the timer code, with HZ frequency. 5632 * We call it with interrupts disabled. 5633 */ 5634 void sched_tick(void) 5635 { 5636 int cpu = smp_processor_id(); 5637 struct rq *rq = cpu_rq(cpu); 5638 /* accounting goes to the donor task */ 5639 struct task_struct *donor; 5640 struct rq_flags rf; 5641 unsigned long hw_pressure; 5642 u64 resched_latency, rtime; 5643 5644 if (housekeeping_cpu(cpu, HK_TYPE_KERNEL_NOISE)) 5645 arch_scale_freq_tick(); 5646 5647 sched_clock_tick(); 5648 5649 rq_lock(rq, &rf); 5650 donor = rq->donor; 5651 rtime = donor->se.sum_exec_runtime - donor->se.prev_sum_exec_runtime; 5652 5653 psi_account_irqtime(rq, donor, NULL); 5654 5655 update_rq_clock(rq); 5656 hw_pressure = arch_scale_hw_pressure(cpu_of(rq)); 5657 update_hw_load_avg(rq_clock_task(rq), rq, hw_pressure); 5658 5659 if (dynamic_preempt_lazy() && tif_test_bit(TIF_NEED_RESCHED_LAZY)) 5660 resched_curr(rq); 5661 5662 donor->sched_class->task_tick(rq, donor, 0); 5663 if (sched_feat(LATENCY_WARN)) 5664 resched_latency = cpu_resched_latency(rq); 5665 calc_global_load_tick(rq); 5666 sched_core_tick(rq); > 5667 if (rtime > RSEQ_UNPREEMPTED_THRESHOLD) 5668 rseq_preempt(donor); 5669 scx_tick(rq); 5670 5671 rq_unlock(rq, &rf); 5672 5673 if (sched_feat(LATENCY_WARN) && resched_latency) 5674 resched_latency_warn(cpu, resched_latency); 5675 5676 perf_event_task_tick(); 5677 5678 if (donor->flags & PF_WQ_WORKER) 5679 wq_worker_tick(donor); 5680
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 0234f14f2aa6b..e748cf51e0c32 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -889,6 +889,10 @@ struct mm_struct { * mm nr_cpus_allowed updates. */ raw_spinlock_t cpus_allowed_lock; + /* + * @cid_work: Work item to run the mm_cid scan. + */ + struct work_struct cid_work; #endif #ifdef CONFIG_MMU atomic_long_t pgtables_bytes; /* size of all page tables */ @@ -1185,6 +1189,8 @@ enum mm_cid_state { MM_CID_LAZY_PUT = (1U << 31), }; +extern void task_mm_cid_work(struct work_struct *work); + static inline bool mm_cid_is_unset(int cid) { return cid == MM_CID_UNSET; @@ -1257,12 +1263,14 @@ static inline int mm_alloc_cid_noprof(struct mm_struct *mm, struct task_struct * if (!mm->pcpu_cid) return -ENOMEM; mm_init_cid(mm, p); + INIT_WORK(&mm->cid_work, task_mm_cid_work); return 0; } #define mm_alloc_cid(...) alloc_hooks(mm_alloc_cid_noprof(__VA_ARGS__)) static inline void mm_destroy_cid(struct mm_struct *mm) { + disable_work(&mm->cid_work); free_percpu(mm->pcpu_cid); mm->pcpu_cid = NULL; } diff --git a/include/linux/rseq.h b/include/linux/rseq.h index bc8af3eb55987..3e708e2e5e459 100644 --- a/include/linux/rseq.h +++ b/include/linux/rseq.h @@ -7,6 +7,8 @@ #include <linux/preempt.h> #include <linux/sched.h> +#define RSEQ_UNPREEMPTED_THRESHOLD (100ULL * 1000000) /* 100ms */ + /* * Map the event mask on the user-space ABI enum rseq_cs_flags * for direct mask checks. diff --git a/include/linux/sched.h b/include/linux/sched.h index 9632e3318e0d6..2fd65f125153d 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1397,7 +1397,6 @@ struct task_struct { int last_mm_cid; /* Most recent cid in mm */ int migrate_from_cpu; int mm_cid_active; /* Whether cid bitmap is active */ - struct callback_head cid_work; #endif struct tlbflush_unmap_batch tlb_ubc; @@ -2254,4 +2253,10 @@ static __always_inline void alloc_tag_restore(struct alloc_tag *tag, struct allo #define alloc_tag_restore(_tag, _old) do {} while (0) #endif +#ifdef CONFIG_SCHED_MM_CID +extern void task_queue_mm_cid(struct task_struct *curr); +#else +static inline void task_queue_mm_cid(struct task_struct *curr) { } +#endif + #endif diff --git a/kernel/rseq.c b/kernel/rseq.c index 2cb16091ec0ae..c684622b16f03 100644 --- a/kernel/rseq.c +++ b/kernel/rseq.c @@ -402,6 +402,7 @@ static int rseq_ip_fixup(struct pt_regs *regs) void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs) { struct task_struct *t = current; + unsigned long now = jiffies; int ret, sig; if (unlikely(t->flags & PF_EXITING)) @@ -419,6 +420,8 @@ void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs) } if (unlikely(rseq_update_cpu_node_id(t))) goto error; + if (t->mm && !time_before(now, READ_ONCE(t->mm->mm_cid_next_scan))) + task_queue_mm_cid(t); return; error: diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 9aecd914ac691..97f0d41c70bc3 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5639,7 +5639,7 @@ void sched_tick(void) struct task_struct *donor; struct rq_flags rf; unsigned long hw_pressure; - u64 resched_latency; + u64 resched_latency, rtime; if (housekeeping_cpu(cpu, HK_TYPE_KERNEL_NOISE)) arch_scale_freq_tick(); @@ -5648,6 +5648,7 @@ void sched_tick(void) rq_lock(rq, &rf); donor = rq->donor; + rtime = donor->se.sum_exec_runtime - donor->se.prev_sum_exec_runtime; psi_account_irqtime(rq, donor, NULL); @@ -5663,7 +5664,8 @@ void sched_tick(void) resched_latency = cpu_resched_latency(rq); calc_global_load_tick(rq); sched_core_tick(rq); - task_tick_mm_cid(rq, donor); + if (rtime > RSEQ_UNPREEMPTED_THRESHOLD) + rseq_preempt(donor); scx_tick(rq); rq_unlock(rq, &rf); @@ -10530,22 +10532,16 @@ static void sched_mm_cid_remote_clear_weight(struct mm_struct *mm, int cpu, sched_mm_cid_remote_clear(mm, pcpu_cid, cpu); } -static void task_mm_cid_work(struct callback_head *work) +void task_mm_cid_work(struct work_struct *work) { unsigned long now = jiffies, old_scan, next_scan; - struct task_struct *t = current; struct cpumask *cidmask; - struct mm_struct *mm; + struct mm_struct *mm = container_of(work, struct mm_struct, cid_work); int weight, cpu; - SCHED_WARN_ON(t != container_of(work, struct task_struct, cid_work)); - - work->next = work; /* Prevent double-add */ - if (t->flags & PF_EXITING) - return; - mm = t->mm; - if (!mm) - return; + /* We are the last user, process already terminated. */ + if (atomic_read(&mm->mm_count) == 1) + goto out_drop; old_scan = READ_ONCE(mm->mm_cid_next_scan); next_scan = now + msecs_to_jiffies(MM_CID_SCAN_DELAY); if (!old_scan) { @@ -10558,9 +10554,9 @@ static void task_mm_cid_work(struct callback_head *work) old_scan = next_scan; } if (time_before(now, old_scan)) - return; + goto out_drop; if (!try_cmpxchg(&mm->mm_cid_next_scan, &old_scan, next_scan)) - return; + goto out_drop; cidmask = mm_cidmask(mm); /* Clear cids that were not recently used. */ for_each_possible_cpu(cpu) @@ -10572,6 +10568,8 @@ static void task_mm_cid_work(struct callback_head *work) */ for_each_possible_cpu(cpu) sched_mm_cid_remote_clear_weight(mm, cpu, weight); +out_drop: + mmdrop(mm); } void init_sched_mm_cid(struct task_struct *t) @@ -10584,23 +10582,14 @@ void init_sched_mm_cid(struct task_struct *t) if (mm_users == 1) mm->mm_cid_next_scan = jiffies + msecs_to_jiffies(MM_CID_SCAN_DELAY); } - t->cid_work.next = &t->cid_work; /* Protect against double add */ - init_task_work(&t->cid_work, task_mm_cid_work); } -void task_tick_mm_cid(struct rq *rq, struct task_struct *curr) +/* Call only when curr is a user thread. */ +void task_queue_mm_cid(struct task_struct *curr) { - struct callback_head *work = &curr->cid_work; - unsigned long now = jiffies; - - if (!curr->mm || (curr->flags & (PF_EXITING | PF_KTHREAD)) || - work->next != work) - return; - if (time_before(now, READ_ONCE(curr->mm->mm_cid_next_scan))) - return; - - /* No page allocation under rq lock */ - task_work_add(curr, work, TWA_RESUME); + /* Ensure the mm exists when we run. */ + mmgrab(curr->mm); + queue_work(system_unbound_wq, &curr->mm->cid_work); } void sched_mm_cid_exit_signals(struct task_struct *t) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index c8512a9fb0229..37a2e2328283e 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -3630,7 +3630,6 @@ extern int use_cid_lock; extern void sched_mm_cid_migrate_from(struct task_struct *t); extern void sched_mm_cid_migrate_to(struct rq *dst_rq, struct task_struct *t); -extern void task_tick_mm_cid(struct rq *rq, struct task_struct *curr); extern void init_sched_mm_cid(struct task_struct *t); static inline void __mm_cid_put(struct mm_struct *mm, int cid) @@ -3899,7 +3898,6 @@ static inline void switch_mm_cid(struct rq *rq, static inline void switch_mm_cid(struct rq *rq, struct task_struct *prev, struct task_struct *next) { } static inline void sched_mm_cid_migrate_from(struct task_struct *t) { } static inline void sched_mm_cid_migrate_to(struct rq *dst_rq, struct task_struct *t) { } -static inline void task_tick_mm_cid(struct rq *rq, struct task_struct *curr) { } static inline void init_sched_mm_cid(struct task_struct *t) { } #endif /* !CONFIG_SCHED_MM_CID */
Currently, the task_mm_cid_work function is called in a task work triggered by a scheduler tick to frequently compact the mm_cids of each process. This can delay the execution of the corresponding thread for the entire duration of the function, negatively affecting the response in case of real time tasks. In practice, we observe task_mm_cid_work increasing the latency of 30-35us on a 128 cores system, this order of magnitude is meaningful under PREEMPT_RT. Run the task_mm_cid_work in a new work_struct connected to the mm_struct rather than in the task context before returning to userspace. This work_struct is initialised with the mm and disabled before freeing it. The queuing of the work happens while returning to userspace in __rseq_handle_notify_resume, maintaining the checks to avoid running more frequently than MM_CID_SCAN_DELAY. To make sure this happens predictably also on long running tasks, we trigger a call to __rseq_handle_notify_resume also from the scheduler tick if the runtime exceeded a 100ms threshold. The main advantage of this change is that the function can be offloaded to a different CPU and even preempted by RT tasks. Moreover, this new behaviour is more predictable with periodic tasks with short runtime, which may rarely run during a scheduler tick. Now, the work is always scheduled when the task returns to userspace. The work is disabled during mmdrop, since the function cannot sleep in all kernel configurations, we cannot wait for possibly running work items to terminate. We make sure the mm is valid in case the task is terminating by reserving it with mmgrab/mmdrop, returning prematurely if we are really the last user while the work gets to run. This situation is unlikely since we don't schedule the work for exiting tasks, but we cannot rule it out. Fixes: 223baf9d17f2 ("sched: Fix performance regression introduced by mm_cid") Signed-off-by: Gabriele Monaco <gmonaco@redhat.com> --- include/linux/mm_types.h | 8 +++++++ include/linux/rseq.h | 2 ++ include/linux/sched.h | 7 +++++- kernel/rseq.c | 3 +++ kernel/sched/core.c | 47 +++++++++++++++------------------------- kernel/sched/sched.h | 2 -- 6 files changed, 37 insertions(+), 32 deletions(-)