From patchwork Tue Mar 4 13:58:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Borislav Petkov X-Patchwork-Id: 14000780 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24E56C282D2 for ; Tue, 4 Mar 2025 13:58:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B02E3280003; Tue, 4 Mar 2025 08:58:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB372280004; Tue, 4 Mar 2025 08:58:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95434280003; Tue, 4 Mar 2025 08:58:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6E8C86B008A for ; Tue, 4 Mar 2025 08:58:39 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 306411C53A8 for ; Tue, 4 Mar 2025 13:58:39 +0000 (UTC) X-FDA: 83184023958.24.B08941A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 8B3B0140015 for ; Tue, 4 Mar 2025 13:58:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=A7wXgql1; spf=pass (imf23.hostedemail.com: domain of bp@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=bp@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741096717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UauOJjf3CILBed2OKV/Xg7yN/eQK6t+qTH1V1u1wbJA=; b=bxEncVwG0G+On4PnlPa/YhT3ohWnww50of3iM4QQuaqEFvL9yk/ZheWPmdb4HqPpA20SNs jay0/uz8UqAGcbSKEyG6jBONyrCF2iola8NA+t3pju1h+Z+KLoTIFl3rZPlSh6/AryU1dE rYxi8N81IUNFDvjgk7Gbeh3OaiMw0jo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=A7wXgql1; spf=pass (imf23.hostedemail.com: domain of bp@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=bp@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741096717; a=rsa-sha256; cv=none; b=vx7dXd/rGtTysFpTT5or2Kqhe0xHeELhL6VYpceIAMJj8fA6cMDZYBGAV7mOQ/Z/xo7bwo tnY4laVcEx+dyZTOnaT/L4Uj9c9IObjATsURZjiOfWNzKi6V19K9uQ2iOOBo7SdYnb/sdu XqTjksbyQMRvdY07JWKLENYSMxnX+to= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0504E5C5D57; Tue, 4 Mar 2025 13:56:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A76C2C4CEE9; Tue, 4 Mar 2025 13:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741096716; bh=SCBkxqxjfa8HkA0BTRuWWUnRPjL2osKJM/O5wsn1zgg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A7wXgql127OzEvUasxqBMsRN6H4aOQJkUBD9QFFp0MlWYDxeAMoemW1MSkD4DdFqs Y+dzSoFejSn2qTJdDM/MMYQzqDcJHWXSkBLHFhvyJlXZnqTc+q9qU4EfWlJiPxNMri 4Ub42ppW+HYV/33X/CNhXK9xRzE0lEcRMQ2a+lFHZggSFPa8OWGKesGc7na8LhUotY 13TM2ptAtVMkYvywbkYqXhdYkHXtIFNDSsoD1E3T7O4ctYWFvG24yllC8qH3EJqjd5 ScPHoLs5KpaTir7CU2nrRL173YHIC5U/nkdibqRywUCjXPphsc/MxLuXvYg+Gj3Uqi 61rZwEDraemlg== From: Borislav Petkov To: riel@surriel.com Cc: Manali.Shukla@amd.com, akpm@linux-foundation.org, andrew.cooper3@citrix.com, jackmanb@google.com, jannh@google.com, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhklinux@outlook.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, x86@kernel.org, zhengqi.arch@bytedance.com, Borislav Petkov Subject: [PATCH v15 04/11] x86/mm: Use INVLPGB for kernel TLB flushes Date: Tue, 4 Mar 2025 14:58:09 +0100 Message-ID: <20250304135816.12356-5-bp@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250304135816.12356-1-bp@kernel.org> References: <20250304135816.12356-1-bp@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: wzm8n8bhuya7rzajnjsa41q6tyk4qcya X-Rspamd-Queue-Id: 8B3B0140015 X-Rspamd-Server: rspam07 X-HE-Tag: 1741096717-51723 X-HE-Meta: U2FsdGVkX18KnDsaTbthlUd0/R5F8MOpMBv1g//H3nFNTWA0kQkuJizGEMmaqGW94Fgiqpu6172IXIfweUlICWM9J0kxDN+tMa66hTJzYeI5H2IHC3QxVY06r1saZdfgDnvBMt9yaMq0vRqFa4v0nuUB9UVADVuWt8iFChu4nVu1i1JvNklG0zSvGC0vXycyxeKZfIOua2QIkF7pe5CELkCWDP+kKx4zKdZ5F4eXsXRIqtUuN2MW5aY06oYqnbK8rQLPuM778uEqFLXMrlF+yzYUQ/JgI668h1eF1R4MWqPHiHFFPG05Jcn7mSB03JcA/lrPXGb5URbKyuBW9H9B5jG7Aldc7ViZUYUgYWqIFZsBhMFD4jZuOMlXIxyrHkl8t7SgiHyf/6fTp3qbJKI6H3T7j82LlUgKh1D4dgOh3gFZlB1mFYDAUM/k2C+sGCZsdCcW8Mc8EXLeFtno9TxVpDoouDV3Oh05/EMyxWfcm14FIX76hgFl+idwLDJWtvieEMKEv+CH/sEzq7MjFM1WSRIxUOJ0gS9GFcVFymt5mzwRhZ4XMupRl2rOW74tcVGVTp0kLHqKMW/FrNpCH1jQKdlWJ/StgLJ4lZ1qVL02x+GJxwG4vKsCRsnOOYewVA8U3F1YxzAh2kXbokzUwyjitI0Qd+MLh1GAsw9Wkge/PGCsNcEQT00937YcZ+5TsMQNP5qw0k4ZFPwiOPa2ejgcyMalkQyCYnx0tb3/HxmEKZsWb4pJJJRr/mszgDewxa+wLnomNDxV4L6grTs2c/TL5WhBCpBaycrPAV/zeF1p6OyjrGyU+7A7mBetz7yLIN9fxKwhfQkmUqDuCzthCcZhr6+2/Q0+aZbbe8a6Ecxe/4Bl/QfftiwfeY1stsRVjJq5++5D4Z0cYwrWz1iarAJBJmSb4kF1j7oGpDHHZMOhvN8eQ42+37KJtpxYmpomp1QoYuKDXP3os3y6PnnypCP EKOW9y2R NodiIgyEMTgqIjJJ9w0+559d+jpULrwesaF8qqWcgHDsgETZopKPdd8/Dc3NrSyQE9CC2fbp0kzNPyNQ9W+d8PLf6WiC3TsPEv4uuqOUsTVU+evWhdQq8SVRmrXhKvoqtPiBLtXM0Bf1rQbvgaaRiYQ8QZsh1FiIuzvWJzC+zinxxTQ3qciZAlsCI8cFtmZiOk8WiNoAXSmlTwxtSUfyT1PfLAMJG1dBvqfVtHXvYmxTiU76/Vc37DwwXrQeM4/7N3pY8a/JsMN1TuKjBUi7Q070l8t8uZYZ67tGNgSIwoJMe4qS3WAyUpU0TWIaVfhBKw35nO+G2shH2IecJ3GByuAYQbewY0FO1JxXeFSoIVVlJqMw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Rik van Riel Use broadcast TLB invalidation for kernel addresses when available. Remove the need to send IPIs for kernel TLB flushes. [ bp: Integrate dhansen's comments additions, merge the flush_tlb_all() change into this one too. ] Signed-off-by: Rik van Riel Signed-off-by: Borislav Petkov (AMD) Link: https://lore.kernel.org/r/20250226030129.530345-5-riel@surriel.com --- arch/x86/mm/tlb.c | 48 +++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 44 insertions(+), 4 deletions(-) diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c index dbcb5c968ff9..8cd084bc3d98 100644 --- a/arch/x86/mm/tlb.c +++ b/arch/x86/mm/tlb.c @@ -1064,7 +1064,6 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, mmu_notifier_arch_invalidate_secondary_tlbs(mm, start, end); } - static void do_flush_tlb_all(void *info) { count_vm_tlb_event(NR_TLB_REMOTE_FLUSH_RECEIVED); @@ -1074,7 +1073,32 @@ static void do_flush_tlb_all(void *info) void flush_tlb_all(void) { count_vm_tlb_event(NR_TLB_REMOTE_FLUSH); - on_each_cpu(do_flush_tlb_all, NULL, 1); + + /* First try (faster) hardware-assisted TLB invalidation. */ + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + invlpgb_flush_all(); + else + /* Fall back to the IPI-based invalidation. */ + on_each_cpu(do_flush_tlb_all, NULL, 1); +} + +/* Flush an arbitrarily large range of memory with INVLPGB. */ +static void invlpgb_kernel_range_flush(struct flush_tlb_info *info) +{ + unsigned long addr, nr; + + for (addr = info->start; addr < info->end; addr += nr << PAGE_SHIFT) { + nr = (info->end - addr) >> PAGE_SHIFT; + + /* + * INVLPGB has a limit on the size of ranges it can + * flush. Break up large flushes. + */ + nr = clamp_val(nr, 1, invlpgb_count_max); + + invlpgb_flush_addr_nosync(addr, nr); + } + __tlbsync(); } static void do_kernel_range_flush(void *info) @@ -1087,6 +1111,22 @@ static void do_kernel_range_flush(void *info) flush_tlb_one_kernel(addr); } +static void kernel_tlb_flush_all(struct flush_tlb_info *info) +{ + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + invlpgb_flush_all(); + else + on_each_cpu(do_flush_tlb_all, NULL, 1); +} + +static void kernel_tlb_flush_range(struct flush_tlb_info *info) +{ + if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) + invlpgb_kernel_range_flush(info); + else + on_each_cpu(do_kernel_range_flush, info, 1); +} + void flush_tlb_kernel_range(unsigned long start, unsigned long end) { struct flush_tlb_info *info; @@ -1097,9 +1137,9 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end) TLB_GENERATION_INVALID); if (info->end == TLB_FLUSH_ALL) - on_each_cpu(do_flush_tlb_all, NULL, 1); + kernel_tlb_flush_all(info); else - on_each_cpu(do_kernel_range_flush, info, 1); + kernel_tlb_flush_range(info); put_flush_tlb_info(); }