From patchwork Tue Mar 4 21:19:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14001423 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85B1AC282D0 for ; Tue, 4 Mar 2025 21:19:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A25C6B0085; Tue, 4 Mar 2025 16:19:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 12BEB6B0088; Tue, 4 Mar 2025 16:19:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE6D46B0092; Tue, 4 Mar 2025 16:19:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C5DF86B0085 for ; Tue, 4 Mar 2025 16:19:20 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 78FC91A0601 for ; Tue, 4 Mar 2025 21:19:20 +0000 (UTC) X-FDA: 83185134480.07.C5E321A Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id D97C6120003 for ; Tue, 4 Mar 2025 21:19:18 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dPOgLZev; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741123158; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rlqU+kqW9ukYbDzlv4i2J5UucOp6MMEB0oVQStqLbnU=; b=a9FeoI9lY9KwmMoED7GQo/PFWnrBMkzM8Q1wvp2ptOeBL3On8BirQKRmkqv/zVCxnzIBU2 yCct/EWoQWyUaXv3fOt1iVz5QjSqg2IlcNYOdQnTHzmVt0FZPcKD+2tL2BooQkHTvJBXWd +c5Ld3/2OJlxjSTefNnlCTuvPtPYd8g= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dPOgLZev; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741123158; a=rsa-sha256; cv=none; b=51jV5aPYBLit0uN8okYxGtAObFGlBWazOF+TXFoCQzr6jyaKp3ZTi2ARv6+i9moDIzXSGt GBxa2dP1MksdVaFehbB1zHnA4I09bOurQmbXOzccrCS0ArNJf3KOUaHA8A5UuHJYEhWD3i spBIPWOtO5s2jNcxC+i4d8iu9FQdclA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7F217A45F87; Tue, 4 Mar 2025 21:13:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C948EC4CEE5; Tue, 4 Mar 2025 21:19:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741123158; bh=1+GLBKsLzSxJFQ7DWFpnQ3RNIvFxJfA/ezMRoeI16Y8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dPOgLZevkRvv7BLRFMCqBUuVRZGPlsN3CRS72TzgxGKYe0HfDe6lxR8n2UmyNc768 JGMTJ5QSmwvaJDLrkIK1Wo8y0357xd7Y+GaxxDa6dcrtti3tJcE3bO98fw57l4VpQU eMzvTQMcgCr3stTR9Lj3KufTiP3onmpvw4Ra9zpe7FsKOisvmvwVcoW/b3Z8KNXG3s Pu1yLZj6amxGpf/SryrRWQlM31f6MPN60U9DC+zNLLBhj0i4iCSEfHzJDuts7HqMDp X+/+NUomBDp5hzyCriU0l0T7KjDX6siT8E2FF2n3KIWwK0Ru5GI8OZrGn6sOsdV8Qf PkVpilH0sKigQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 1/9] mm/damon/core: introduce damos->ops_filters Date: Tue, 4 Mar 2025 13:19:05 -0800 Message-Id: <20250304211913.53574-2-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250304211913.53574-1-sj@kernel.org> References: <20250304211913.53574-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D97C6120003 X-Stat-Signature: monpcckbtiidifqekqcoggtr8eo7w1m4 X-HE-Tag: 1741123158-9979 X-HE-Meta: U2FsdGVkX1/6A4s2n+Q0GLJ8X+1XKVJjDqGrPN90CuvSWOorJndhDiFnxcLQcY/rRddeqasrSGQcEJ38XPBNNdNS7PHmXhJHeDw+aCME929HMPMlpS1vWWWDTYAtjM1+dXTkS9TA6/LtTgFVIEiX5pMmP9duyFrONznvHwCkGOaXbqKP/ELYmM4eo8yEo0MzI2DRk/bR2FHG7+c4QFwoWkXq6bZ/YloScUjZPS68sotba2V0mpzCUtVgkJ1XrVus04BNgeMJpNX2xofT1R7k11jLqL4QPgw0ALVnjOARCLW++930tTsZmK4+sbDA+8C7pxvvTWBIiekIBIaLy0dmR/KWd0vCgtdflziy2mnN+bSnzewMHGDpo7E23iKwhF8t0+owVSdSF5JUVRaoIFUGEyKAhidebFA30/LhgJilZILzLbrdgyxtPKu9NNc1KTUTZzpJiXapb4Tpymgd6e7H+JQvCtQdxLKPtRpBjQE0/3V2MQIqtLuB73TpiWBCSnkCwhjzpvpigH8mVa/vSvVMB5CECFeCD7n9Qzmekyf7v/DQEiJH3UYhMbbkLUrsaOL8zyx1a7eemYeoi57V39M+KOjp65x9dIszbO+KTomyF8aQQREMRa5grOpdWyu1da1BQoTD+XdGZemVp6pQnJUw34vLTdDWG4fq7I/bcv9AKQlvTNe7b6jSSa/OyBvbdsmnhNPRJzOxjPb6pU8mbaYSjBdsl7CQhXw0DhMxPWnm2EbYBswILtvX9ueG/WqArGuLMpU0+OaDfx02irpVqMAPLJ26XIhWXlVca28qUt76gtplg4zocXBYUbKCYolHXuMUfEWpsdP/LqhC3B/T1CjtOJ4q/nb+r5zTaomiW+ORAW4/BuxSnF7Czd0yTPOb/KXJA7uf1iqVELRBCcPCEilZGdcNwf+m+m6eXJPTYV+1yFJPxMBV1JkR06BiM83EhOljd1J+CYg8Zn2fXYCxCNq nOfFMHio EPDj0c/oMSaCUZAaZpuo+HgaCceFslZ8bvNx+rQOhDFrNJ7stdT7cYlk+ZbKp8Mwus44f5MmInldlJhieSo93i1YeyA6ivPNrN5FDCPfKzMcLrqvzVADy0ioQDWpPhrBF3dbPJUgc3BWMJ0vW3lA+4s/h1TR3Z0dwQzmjKxaj/Sjv15yMXEC9CVoUryy+ZCizKfQB3SHzA10u+TXGrlD7YRvffmQrUuB8VnYACr26eWxVdipmeFBkPZKInBML5ZHKFZ+vLrMYVoT4m78VjzmRy+f9Rg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMOS filters can be categorized into two groups depending on which layer they are handled, namely core layer and ops layer. The groups are important because the filtering behavior depends on evaluation sequence of filters, and core layer-handled filters are evaluated before operations layer-handled ones. The behavior is clearly documented, but the implementation is bit inefficient and complicated. All filters are maintained in a single list (damos->filters) in mix. Filters evaluation logics in core layer and operations layer iterates all the filters on the list, while skipping filters that should be not handled by the layer of the logic. It is inefficient. Making future extensions having differentiations for filters of different handling layers will also be complicated. Add a new list that will be used for having all operations layer-handled DAMOS filters to DAMOS scheme data structure. Also add the support of its initialization and basic traversal functions. Signed-off-by: SeongJae Park --- include/linux/damon.h | 8 ++++++++ mm/damon/core.c | 1 + 2 files changed, 9 insertions(+) diff --git a/include/linux/damon.h b/include/linux/damon.h index b3e2c793c1f4..7f76e2e99f37 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -448,6 +448,7 @@ struct damos_access_pattern { * @wmarks: Watermarks for automated (in)activation of this scheme. * @target_nid: Destination node if @action is "migrate_{hot,cold}". * @filters: Additional set of &struct damos_filter for &action. + * @ops_filters: ops layer handling &struct damos_filter objects list. * @last_applied: Last @action applied ops-managing entity. * @stat: Statistics of this scheme. * @list: List head for siblings. @@ -508,6 +509,7 @@ struct damos { int target_nid; }; struct list_head filters; + struct list_head ops_filters; void *last_applied; struct damos_stat stat; struct list_head list; @@ -858,6 +860,12 @@ static inline unsigned long damon_sz_region(struct damon_region *r) #define damos_for_each_filter_safe(f, next, scheme) \ list_for_each_entry_safe(f, next, &(scheme)->filters, list) +#define damos_for_each_ops_filter(f, scheme) \ + list_for_each_entry(f, &(scheme)->ops_filters, list) + +#define damos_for_each_ops_filter_safe(f, next, scheme) \ + list_for_each_entry_safe(f, next, &(scheme)->ops_filters, list) + #ifdef CONFIG_DAMON struct damon_region *damon_new_region(unsigned long start, unsigned long end); diff --git a/mm/damon/core.c b/mm/damon/core.c index 9d37d3664030..5415b7603d01 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -375,6 +375,7 @@ struct damos *damon_new_scheme(struct damos_access_pattern *pattern, scheme->next_apply_sis = 0; scheme->walk_completed = false; INIT_LIST_HEAD(&scheme->filters); + INIT_LIST_HEAD(&scheme->ops_filters); scheme->stat = (struct damos_stat){}; INIT_LIST_HEAD(&scheme->list);