From patchwork Wed Mar 5 18:15:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14003139 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD5F2C19F32 for ; Wed, 5 Mar 2025 18:34:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1418D280007; Wed, 5 Mar 2025 13:32:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3DB8280008; Wed, 5 Mar 2025 13:32:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB321280007; Wed, 5 Mar 2025 13:32:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B9A36280003 for ; Wed, 5 Mar 2025 13:32:27 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B6684120995 for ; Wed, 5 Mar 2025 18:16:25 +0000 (UTC) X-FDA: 83188302330.12.7CABF84 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id A64D21A0022 for ; Wed, 5 Mar 2025 18:16:23 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=d+BXnAC1; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741198583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2EnwLdV4eUuwHuHWB+mdBgYmAvPDUfga/FjqwCYNsCI=; b=x281PklhuGGMOx9VFKjBau0L+bp8RmiFdpiKhW3Bq6cripxF18rwYxTl18rweg+GpwKKCF O3Y2UI4+XRPQ+RBro5XsMDeXAjczh7D+lsCxdKfMrgof8FjbkaFBHJdUovK+9TTuM5Tmvb YTRIZFZSzspQk7cOZRzYrJDDg/gwqu0= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=d+BXnAC1; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741198583; a=rsa-sha256; cv=none; b=WCxdej0aX4Hk9aSrTa/TWibawUZJwoi3wDPfKAM/ieje0849M7ptwdbfes34yM53HODXvy +c2v0H6OBA8vmLcAcAEqnpY1hFYfkkmqb2TOFVoBVVpwlu5KnTh/6ZIC7YEC8h4J2xh4SI HQLJpoYZ3ae6ByWS5yj8LLREweFfgtM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D54A45C6BAE; Wed, 5 Mar 2025 18:14:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39959C4CEF2; Wed, 5 Mar 2025 18:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741198582; bh=k3u/LxEMkFkS7mrfeSjLL0Nnr2JwC5q9oxYyj2TJeAI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d+BXnAC1TkoainkqZ1u199F1FvvZiZ34Ndk/rNCx/M/1t+E94AGj5Quk5hqfuBfOR M1YClyfRGCUP1WoVAujO8KEYZPzAM5nyE+V9w6X04oqWzXMx1S63w8kjugzVIQPUqT vyzywq6x4ps9bDMoX5nQ0n4xouj/atCwPePYKOQDZ9OKJUcyAhG1rAbQvIxrVUDWuc fUV1pP5jvKW6nsjwv7a+fJk5BM7bKW+1NdufBwSEcLDO2AH5PRhrJ8rKbQOMJzAtor VkesKLWj63wstq8GYdHeUtU7YoUmatCsQXyNU7EPPvlIriyjFwml6cKma9iQLIPNg/ DVjdb/F+G4fYA== From: SeongJae Park To: Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 02/16] mm/madvise: split out populate behavior check logic Date: Wed, 5 Mar 2025 10:15:57 -0800 Message-Id: <20250305181611.54484-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305181611.54484-1-sj@kernel.org> References: <20250305181611.54484-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A64D21A0022 X-Rspam-User: X-Stat-Signature: manj4f785tk6gnpsbc7xtoowqmw5mpzu X-HE-Tag: 1741198583-45393 X-HE-Meta: U2FsdGVkX19bPNYbJyFLWAHkUsJeuN41B8IungKYFg6yXqj1jNDnrMbi9yIVq0bGzxHA7ehUXVYYTyLNtRdGi9ERhDeHoM4b8O07dTalc9yXvmLC/DOXCMyEo8sr/M+C2MfsZ3haVwGRC1DXp8LH/v/aQBb1L6Ik7wXZf/N1fSLsPn6/qHtRQBxfRdJELfAdhMTsB//B+fqlFpTa7BIM/vk+xT+3JGxqwqxCqTi7zuBDX5/vnQ3+6gkBoVN7c08aNFS4z4M6yQQjBhsNo7/k7gF2KAmuRMRUTLLG/O6wWic70ajWKDT3UDIBSt0Y9vCDK71tr60HivXs2WnJmQR5cRUeQiY0pLJ5oxv9RjxfOenC9fgYMXtXEmUij7Eu1OiV+C0YdWvdfM8zahLlvRxjrXkGchPiBynq+BDikZ3NXWh47IxKmlGU6zRc/7zYSh9IYkoEZQg35SNti5vf2Djs4+MWOWZO+20b4Vp1wlkCQ228kPmIBQi4YQiHlECDHibQZDR5gJl9aWKTUUH20SCL22dlxiIZ0bfj2lxfyFLZ7z37vk6B2jNiYRBtCd8oZl//16fUaofgDJqmkq1LSRn77PleUe+nGB3YviLH6TUMfge8p+VBff+uwxPYX/BuWet4Q+xv6/nKJ8oFRJ4+3TSPlhuH4/V3wIFERIv5VNEs1S+YXj9G/mFou+PX2mf6Tt/TKjBEaP82GbVU4OqUZLn6NwZ/ty06RD92zlhqk1Jjl/B8evmQGBMUsJ9Zz2Nls3zxmiB8249OHhEycn7aufpCXKRMo80PIXrPaajgt/S6CqdaNcEtuoklTa4rgb6AoPmcbqy7njBT8lKaeT17w8MABxjtrwuPzuERVdHYAvTCRu5CWhwOypUgqE3lQgexRsymE+IbpzuypHhWXuSP9qZBUCeU+Ac8FlT6XJpfmapUW5hCGwftz/eE74Llm1qwRU/nXeNWjcKuYKZiI5K7pFA Ihpbtx32 jh2qmgCxV5pDSRp6AMmOz4BWzxyU5R86X2DNVgdQZM8jc9vk6K+z5XquMwUXOd9vTWrd43FQXyKooLvaPdQS/mB4EDV5jJ4Mc5t5R0nZ5wVQePwCPKICvhKftbkWQlFoF+eXvTI2r72Yt5hrW5tIzg+zsMetYFW9MLuF1Gu5RTnXk76fvS6iF+qE7BB/D7L/4k+b99mtVUU8N6g/hKeJjKtR33LUmWcj09wZx4iOGK1PcG0A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: madvise_do_behavior() has a long open-coded 'behavior' check for MADV_POPULATE_{READ,WRITE}. It adds multiple layers[1] and make the code arguably take longer time to read. Like is_memory_failure(), split out the check to a separate function. This is not technically removing the additional layer but discourage further extending the switch-case. Also it makes madvise_do_behavior() code shorter and therefore easier to read. [1] https://lore.kernel.org/bd6d0bf1-c79e-46bd-a810-9791efb9ad73@lucifer.local Signed-off-by: SeongJae Park --- mm/madvise.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index dbc8fec05cc6..4a91590656dc 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1633,6 +1633,17 @@ static bool is_valid_madvise(unsigned long start, size_t len_in, int behavior) return true; } +static bool is_memory_populate(int behavior) +{ + switch (behavior) { + case MADV_POPULATE_READ: + case MADV_POPULATE_WRITE: + return true; + default: + return false; + } +} + static int madvise_do_behavior(struct mm_struct *mm, unsigned long start, size_t len_in, size_t len, int behavior) { @@ -1646,16 +1657,11 @@ static int madvise_do_behavior(struct mm_struct *mm, end = start + len; blk_start_plug(&plug); - switch (behavior) { - case MADV_POPULATE_READ: - case MADV_POPULATE_WRITE: + if (is_memory_populate(behavior)) error = madvise_populate(mm, start, end, behavior); - break; - default: + else error = madvise_walk_vmas(mm, start, end, behavior, madvise_vma_behavior); - break; - } blk_finish_plug(&plug); return error; }