From patchwork Wed Mar 5 18:16:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14003132 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F54C19F32 for ; Wed, 5 Mar 2025 18:33:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 003C86B0083; Wed, 5 Mar 2025 13:31:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF7036B0085; Wed, 5 Mar 2025 13:31:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBF286B0088; Wed, 5 Mar 2025 13:31:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B79696B0083 for ; Wed, 5 Mar 2025 13:31:55 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 604FCA8A64 for ; Wed, 5 Mar 2025 18:16:30 +0000 (UTC) X-FDA: 83188302540.19.E403038 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 471754001F for ; Wed, 5 Mar 2025 18:16:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E5tb1b18; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741198588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5q2DxNxGxUIL8xwUArZDlH1QNLyPFugpXdGg9n9dPsc=; b=3M7InAia+nXlLepG37UBsaYBTPRHTQW+5qOaBbHN1+L+uAPmGBgi9xFojhY6wmKeSH/feY 1LjLw+DpADTvGJaJSYGLA/iNKT8EZklg10bfubHoe9CRogp1wPf7gruZuHfVNTmZzW8FB1 RDfBUCcR+RYQWYMKSd4Wm/6MLVeZ7oY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=E5tb1b18; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741198588; a=rsa-sha256; cv=none; b=3hmhmjMAT5XlNTnFiBvr4uFMVrYx5JHEdTI9dbCm2PXJFOBktMDlXL3SAAjDI/mTHOppl8 FlegDiVJFG4eKIyNmteWzyA3KlYR5qTTPWzSOcEDw0VvAjHoLcIF+D9HI4UpAFT9wXNljc jZrX1zWmuhV9BnyWTu2/eRcCLS85KIM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 561BF5C6BE0; Wed, 5 Mar 2025 18:14:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7FBFC4CED1; Wed, 5 Mar 2025 18:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741198587; bh=OqLt2zId8LUFKARGxIVzcXznGs9Ytza2liDWujZpc8Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E5tb1b18FoCnv4378bvS3h3FozmbWmysT2y3RwuHzECCmJPFN9mtaSFgXIRlhhSQP NyjxjtXqPftmaLx3OTJhNzZNB0lE/f9exNaPLlRczJhYQ6ln/Xq8ZwyeZ6Aj/xk1NJ HBuMny/ZCKifdmvK3jAb65tdp0uY5mnirM6RyPEaonb9YW7JmIg5W24imxDPppoKJw hC5hGKAVqNNVLiH1G3FPg/mRTHxy+fpG/IvWx5jvkF5zrGVDT0R1f8vW4LJiEZBf5T fQmHOeNyU5pRA/ixwasJ+S2kiqveFW4zNS2NpGcWVuuYUbTlC6zcHerl3AXN0y+BOJ VPl9SODsmawoA== From: SeongJae Park To: Cc: SeongJae Park , "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 06/16] mm/madvise: pass madvise_behavior struct to madvise_vma_behavior() Date: Wed, 5 Mar 2025 10:16:01 -0800 Message-Id: <20250305181611.54484-7-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250305181611.54484-1-sj@kernel.org> References: <20250305181611.54484-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 471754001F X-Rspam-User: X-Stat-Signature: 9te74h3ceq9ca9mmqa5tm3osz4dmszkt X-HE-Tag: 1741198588-848059 X-HE-Meta: U2FsdGVkX1+rMVHmOAePi285GVcK+uLEN6C4L0YeJEi1WsRckxO2RdFcQzfMbFLzUb4RSq/EORZl8Bl+S/Fd6C0JylaKtF+A4y5B6pI/kubvU33fmp398zN0/wmBattlJnRUTXpQQcMvzwqE0bAO0iPvoGv/UbIcXhmIaCteM6qyXhGJ5LHTG4MnkGPguqn4ZC8LtaPUEvf/XGkFCbpY4NTHXafD88NWpi/piOLTM0/hiTDefyPh5j9c5jK/adSjKgzhhsaunQ9nXfeX7hRe1Hs8PrOPg6WHLIFT2W7HF3Go7Gl2E+Xlfwv0CTeyD16FbEtutiLbXik2xCWsqbpMT3c2MLqHZKWfDQTWEwJt0ElqD9hH6YvqCd9YqSf8QjLCcejbp85wySR8NVjALl1+CBmgwCAqIQQr3ImvQC6Hr5xZEE1R9nsVFegWp/fHjrDFxJlMv0DqPN+Leu7ezlZgWjb4/9AWrKTL7KCbxLD1rAPVjHCXfwv9DH+41zgImMLaAce5ryeWLigcbSCKacvQ30v4vqY49fZSumuQt1g3d1Hcn2sGZT6ICEyTxkZ8VPehkGfo+3lFeaFkfIlkjQTs79yuILNY2XRCgywuMD9IUjKXQ3KGy/IQSwpKZ4Y5UY9RqTkNy5nLBUCZlubv8rPpOSDApksiDGOOSZWlkDjDAPSi793HzzaBqdaWLG0oIn0d+LpoY64PhpoxnWiV/8ROxOOQrQvXSX8qxrSAqwP4+H/DDjmtEfz3AUFe0ENNxNlpGo4ZHORFvtZWfYzM/N+bym2GVnxdhVNlNuSPg7ZVydQcnJLZ0p5HnDgVMekMBR6cHID9EC8wZWUqhAjSpij9cfYmsb/LZf9XQ7HRpd0qu9n8bZCxFL4DtT1gIZ5rqtykXwRVFxb2oXCHwK2uUIKaxi5sYGNpzVQH4qTODETTF3LlBVfv1sG0L4+l1clKbC61/CZs4WbMnHsui86yFNG VkuYScw+ dV94Cowrv9F6bctml2rC45Pih/Ri52KeUZfty1GId8FXq6geHxDd5S1CX4gwPX66H+MgfGaubzGg35WRpL0ZIC4Wz+URPwvKtRvZtTKkAeFhLzoIlPxcOWb9eWiSe/u4SzgehWKCCWyHQ4OPulPS2HhvrlGYteOBooJR2iL5XqI4n5HA0XE/goKolEoj5hkss+HN1qt56mfH2WPFkrYJg8wQtYxqigNAdCfXBy115VlHC1w303dyNMpkMFvgGUTq8iSDU3xYKUUXhwEwd1dR9EWaSmF5xjtWKEAOL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Most internal madvise logics are executed by madvise_walk_vmas() visit function, namely madvise_vma_behavior(). The function receives only a single behavior value, so difficult to extend for tlb flushes batching and potential future optimizations that may require information more than single behavior value. Modify it to receive 'struct madvise_behavior' object instead, for upcoming tlb flushes batching change and possible future optimizations. Signed-off-by: SeongJae Park --- mm/madvise.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 3346e593e07d..8c4c128eaeb7 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1241,6 +1241,10 @@ static long madvise_guard_remove(struct vm_area_struct *vma, &guard_remove_walk_ops, NULL); } +struct madvise_behavior { + int behavior; +}; + /* * Apply an madvise behavior to a region of a vma. madvise_update_vma * will handle splitting a vm area into separate areas, each area with its own @@ -1249,8 +1253,10 @@ static long madvise_guard_remove(struct vm_area_struct *vma, static int madvise_vma_behavior(struct vm_area_struct *vma, struct vm_area_struct **prev, unsigned long start, unsigned long end, - unsigned long behavior) + unsigned long behavior_arg) { + struct madvise_behavior *arg = (struct madvise_behavior *)behavior_arg; + int behavior = arg->behavior; int error; struct anon_vma_name *anon_name; unsigned long new_flags = vma->vm_flags; @@ -1665,10 +1671,6 @@ static bool is_memory_populate(int behavior) } } -struct madvise_behavior { - int behavior; -}; - static int madvise_do_behavior(struct mm_struct *mm, unsigned long start, size_t len_in, struct madvise_behavior *madv_behavior) @@ -1687,7 +1689,8 @@ static int madvise_do_behavior(struct mm_struct *mm, if (is_memory_populate(behavior)) error = madvise_populate(mm, start, end, behavior); else - error = madvise_walk_vmas(mm, start, end, behavior, + error = madvise_walk_vmas(mm, start, end, + (unsigned long)madv_behavior, madvise_vma_behavior); blk_finish_plug(&plug); return error;