From patchwork Thu Mar 6 02:10:31 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuai Xue X-Patchwork-Id: 14003741 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA826C28B22 for ; Thu, 6 Mar 2025 02:10:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5984280008; Wed, 5 Mar 2025 21:10:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B8C88280006; Wed, 5 Mar 2025 21:10:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2D15280008; Wed, 5 Mar 2025 21:10:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7EEFE280006 for ; Wed, 5 Mar 2025 21:10:42 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D4B0C1A0DD4 for ; Thu, 6 Mar 2025 02:10:43 +0000 (UTC) X-FDA: 83189497566.13.90811CF Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf29.hostedemail.com (Postfix) with ESMTP id D679112000E for ; Thu, 6 Mar 2025 02:10:41 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="GATmpJ/z"; spf=pass (imf29.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741227042; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zNNjpjby7OEVOGOuCOx/+9vNU60KKs/GI6CHsj1/Iek=; b=eFB7X06qdSWIp84OyprTofdSLAI/YylU5VGD4ZzNdKKKJkvCDihx/hGLQUSU2IPVKJw3OW GrgRL7/kCxwwpjHdUcnZZf0/C3MOSToT0ysQuhUL+EXSA9EOzuTU5NYJncwJeVhU/Mkvbt p2b2aD9kn9ckRhTXLep8OgPfnCsUcBU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="GATmpJ/z"; spf=pass (imf29.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.132 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741227042; a=rsa-sha256; cv=none; b=KAhkO71pzFvGCiouRI+bIMaxgSbBe9M/gjtUFdmJG1kpMTxQIDZh+FljPSPgcuFZ82kyDp 2oOlZaLaE93ttOHczlTak5rkKYJsdXBlkFzMdUg0P6v2anrqAyeGj9sKNXXp/stReQzIGz OqksnuqYThAyT6m1zNizL26+dbYyq3w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1741227039; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=zNNjpjby7OEVOGOuCOx/+9vNU60KKs/GI6CHsj1/Iek=; b=GATmpJ/z18XaQ835Tf33p+yR/ngR0R5TiVsrb1U28BN4p6D7CiuNKpKvTseRRmp/hZZTHXBBA9apGHiX1lgvvFcdBe/zLTNjMwxLBP9yW8JX1qd4EYcXFbfEjRHn4/odFHKkSmTvf63HwcBEOrtQrFDq1Mol5x20PCI6rrfdOUo= Received: from localhost.localdomain(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WQmzy09_1741227036 cluster:ay36) by smtp.aliyun-inc.com; Thu, 06 Mar 2025 10:10:36 +0800 From: Shuai Xue To: tony.luck@intel.com, bp@alien8.de, peterz@infradead.org, catalin.marinas@arm.com, yazen.ghannam@amd.com, akpm@linux-foundation.org, linmiaohe@huawei.com, nao.horiguchi@gmail.com Cc: tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, jpoimboe@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, tianruidong@linux.alibaba.com Subject: [PATCH v3 3/3] mm: memory-failure: Enhance comments for return value of memory_failure() Date: Thu, 6 Mar 2025 10:10:31 +0800 Message-ID: <20250306021031.5538-4-xueshuai@linux.alibaba.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20250306021031.5538-1-xueshuai@linux.alibaba.com> References: <20250306021031.5538-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 X-Stat-Signature: deiwxy5tqk8ziraom4rri5ad9ob1whx6 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D679112000E X-Rspam-User: X-HE-Tag: 1741227041-484959 X-HE-Meta: U2FsdGVkX1/Jxx6taX0C5qibSqlVMEwwvDLkq3Xst1C6AepcOyO/6Be6kgVsPJcgQylM+bdICv0ph1IgqWBTOfytwjuh58u/RU1+teanCFrSEKHRNMGuDfCpt0sxtthaPRHsyfH9CWxLXWirxw8f+JSTeWoHHWiRGc7QeD0ESaxv7Aodjtz5mXRAJjvtrjd6VUjnCoTLSU1RvwyvQYboVGT/0U25m5vC66B6TiJf6vJZ0dbYKil80jCtCW5S/eM7178jfI8O7Y9h5nAHDE97DEfPoKSm6I3ijysiudD3Gf5lPtD0VZeLqj/Fk3YCFXBoJJb6iijO6D4HAWBr24iYbk2PBudhwP6y0nXPBg91tr83zIf2He0R1WuH+sqCZIsZGEJuj8I9oJhdac5L5qtxIZkNdtR4S8knIYwr5wsabEGPvjEiYdypi314WuBOCDfuE8cPodARqzlc9x8Gd1HIViXQ75FRXJ9QM83AeiHZYozHSaLxnqd0woSixWXspoArWjdHc97M/YaXJokS+GcLSlwmjHXiYQKk16+bYm97raycwCdi5Yj76ugTVTFBhh93ZTfVIRRGdjqUoTttsEaqSgDuN9UX4etaCxMk3pBi/zZl6KC/92a2OIcwinjOunyCthHcG6fVnGpaEV9zdCmQ9Xxb1HNGKAFMcve1XHY5bdSq95XohvX+G20MaZ6Wjg8KEh6NVbTl2WPcJHaR3TcUqI+v01BGbJgDDb5VSEfTJo8Imtu7BUwFbzU/b0j60Ssvdk4ji+3Gsbp4lpH8vL/uguCxlaojxjZs5wrjgeRLma2UWVW/9wa9SbOD2j+vF3Q5VPSJs0czUKVfJ0/r6VmtSjV1ErMzRZm8EHYzpNEex2XcMSLfkAgYiP+ZlTDkEqva2/7xw7LV3Do6Z+oqWUXwbp7TLJZ4HjdhodvCY3s5K3CZzH3jUI9fJdrFTF9wEri1i2mbkSMxjWOvIu5bhwp lujfak3Z b6bFtfPdviWO7/bWZBMiASYMSIyuY6i9RBRn8/aRTvLRzpO5FLAszkBhXbZTlP5AM2bYYUcaCX1eZZDMrEYuO8P99x+LPJ8w2RwzH19hL19AtBpPQtOWv2qM0k7LhZ8lT8JdMdmR7t7z4iw6J66dtSKNj9d5To6xK8Xu/enFsoNUnM2upxPAGfJE7NtmjQFHYx1kFVM68avfh6nwxYGX+Fr1Hyv0USfPh4fXoH3ieOOSjvewhojW3m2OeVomJXLrZZvCCXfnYLGoBCZExq8VYosyXeifLpJQvR9KlDYz4kA+PEvdHNVAtOu3afEdpF4xPK3OQWfa6hrRTiXbMY949tBQBh4nhFS9NAPg/KpyX5s/awvLEQG4kGZZ1PzVbsfXtYhcmYWFfNHitkpcsDrjk7a3zaEfcwBtVaFcn0i2dhVCf3LkgXGU0OtnfJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The comments for the return value of memory_failure are not complete, supplement the comments. Signed-off-by: Shuai Xue Reviewed-by: Jarkko Sakkinen Reviewed-by: Jonathan Cameron Reviewed-by: Yazen Ghannam Reviewed-by: Jane Chu Acked-by: Miaohe Lin --- mm/memory-failure.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index b037952565be..8649849bcdb4 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2216,9 +2216,13 @@ static void kill_procs_now(struct page *p, unsigned long pfn, int flags, * Must run in process context (e.g. a work queue) with interrupts * enabled and no spinlocks held. * - * Return: 0 for successfully handled the memory error, - * -EOPNOTSUPP for hwpoison_filter() filtered the error event, - * < 0(except -EOPNOTSUPP) on failure. + * Return: + * 0 - success, + * -ENXIO - memory not managed by the kernel + * -EOPNOTSUPP - hwpoison_filter() filtered the error event, + * -EHWPOISON - the page was already poisoned, potentially + * kill process, + * other negative values - failure. */ int memory_failure(unsigned long pfn, int flags) {