From patchwork Thu Mar 6 05:45:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bharata B Rao X-Patchwork-Id: 14003848 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4EEC282DE for ; Thu, 6 Mar 2025 05:49:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD6FD280006; Thu, 6 Mar 2025 00:49:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B61DD280005; Thu, 6 Mar 2025 00:49:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B416280006; Thu, 6 Mar 2025 00:49:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 77CD3280005 for ; Thu, 6 Mar 2025 00:49:00 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 77E7C1CA35C for ; Thu, 6 Mar 2025 05:49:01 +0000 (UTC) X-FDA: 83190047682.24.21BE394 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2046.outbound.protection.outlook.com [40.107.94.46]) by imf09.hostedemail.com (Postfix) with ESMTP id 6482F140007 for ; Thu, 6 Mar 2025 05:48:58 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=RZ2SfdV+; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf09.hostedemail.com: domain of bharata@amd.com designates 40.107.94.46 as permitted sender) smtp.mailfrom=bharata@amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1741240138; a=rsa-sha256; cv=pass; b=nc5BO2kpPOc9AsKLIKAxdCf3PgwgyBMH5v4kLpix61f0igvF5VxqqmD/kO7QpBpLSQl+SY Mls2BeAK33P1zwMd3iQr8nFvNf9zNyeLsnPjSSggbns9hew8Qc3DUzHWpGXcQQdNrUE9mp 1+vs1k7TgGZwNWeuy61flkCIT70WPi4= ARC-Authentication-Results: i=2; imf09.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=RZ2SfdV+; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf09.hostedemail.com: domain of bharata@amd.com designates 40.107.94.46 as permitted sender) smtp.mailfrom=bharata@amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741240138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L0Ndj2upTDNcAeObFctsa70itOmQpn0tcJK4ZgSMTeY=; b=VmAuxH0iu+ZkUfc9wx6gx/+qyHSOAyRViMeGdv0iqcHb316bLtXwOCpjuoocTDZrE6dNaR s8DRoUKbHZV7y/eY3yq8wbdYxznszyYRhqmaALXSYS4nSCSzwnIj9QzwmsehZGZW6Bdflu JZzCvAKL6OqkLCt8VaXhFau5Aij31bE= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xCT1GsWWk34tpTfQQgf99NKvnmJsM1si86SaFIrgv8Y2smkBcqLc62yi7t2ITDkIPunXJ34QPJMC90xER8xRk9rxcZ9uaNHlBnMpewmx1048Bopw/ZTvJl8rt6joFWXxqcLRBs06Up+Ydms0ZyZsI7tpz2h/wQP8IOrKuKlKIFDN05xreS0muIiJVsZWDOthiBdFIjygAbvoRqIWoKZDbBaF3LPWg6REmEPkVBrPaO+94FGEMQiNJEMuH9L9yGeaQleEcGau7hEanMAq/4UZ+zZJum8GDqPvxfepAycqBx7LZJ56t8Qf8Ix93Sbd/6vAfQ2unAFblVxPq6zmoK3LVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L0Ndj2upTDNcAeObFctsa70itOmQpn0tcJK4ZgSMTeY=; b=kV8QeVFjJqMN80tlWEUkjnnJ99WrfPUyR/SH9ANop8Mi8TJGCcVW0o9kmCgSVQvoGhByek6Aavb+H0uNnBvpSRGe14Agz/tOMIxRyJZs9fRVQ1Jxt2PJfscyM2JLDUV2F5N1AvvBpNKcyManFRa4eYxQyD7aw75enx5A/+lIQitEd6TgkPTIVdr1V+S3FKM/8ng6KcU5JiFIjoq53NRQBm0RwSqq25b+Bs3j8NeuR/FgdSiv8zsSGKCShN7zzmmZ4c++9pSxMudO8ZlWLyTa4FaY8GQTeKLyzx+LPIYGc3v84wUcraE4SGgyqvooZyvS6RP8VUAOeW0s4dXv1KmNBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L0Ndj2upTDNcAeObFctsa70itOmQpn0tcJK4ZgSMTeY=; b=RZ2SfdV+Cp5+1NsYwlEWFZZwV07QHda3XVkOGEo55xXjFPKwDCmgENZ6LcYAU4TxMx/EyKoayPZRoDAgaV/Q0KJQE91Y9m/La6PyftjosKm6JdQeWq0Y6xgfj74h76UCdzZXrZ5FRi04Y1gNTIl5YDMr0m3kc3jDKiRFS3CRLco= Received: from BN0PR04CA0113.namprd04.prod.outlook.com (2603:10b6:408:ec::28) by PH7PR12MB8106.namprd12.prod.outlook.com (2603:10b6:510:2ba::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Thu, 6 Mar 2025 05:48:52 +0000 Received: from BL02EPF0001A0FA.namprd03.prod.outlook.com (2603:10b6:408:ec:cafe::9a) by BN0PR04CA0113.outlook.office365.com (2603:10b6:408:ec::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8511.17 via Frontend Transport; Thu, 6 Mar 2025 05:48:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A0FA.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.8511.15 via Frontend Transport; Thu, 6 Mar 2025 05:48:52 +0000 Received: from BLR-L-BHARARAO.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Wed, 5 Mar 2025 23:48:41 -0600 From: Bharata B Rao To: , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Bharata B Rao Subject: [RFC PATCH 4/4] x86: ibs: Enable IBS profiling for memory accesses Date: Thu, 6 Mar 2025 11:15:32 +0530 Message-ID: <20250306054532.221138-5-bharata@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250306054532.221138-1-bharata@amd.com> References: <20250306054532.221138-1-bharata@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A0FA:EE_|PH7PR12MB8106:EE_ X-MS-Office365-Filtering-Correlation-Id: d29b96e1-9abc-4b22-afb6-08dd5c72934c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700013|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: 5U+1RGArTFxV6bVbuT4JAc6TWwHesgkeMv6dYtuNWUXCRuKJlunwuVZGrPX6wQWlhI8n0Jj6+/axbSCZUGVO5VRwAj8150wBYW6yV1zXWQlLEZ40ll6PzHxHdUr67czReJGi3LORUPA+A4XUF3KpIizOdroxlN0y8tpk9jwqjqAvdKEdDV2rosca6K61cdxd9ExAin4tGYLOuC35trn9sARUY5XN3Ixu+Nat6Gl4DwFAY6RsPo1ZsUAeM9tOUpZsz7OeHDxCOWcpn4LRy/l6QzPZXNdG72RBbMrl/y+Rp8ZNUY5YAD3r4X5dnVInn5ngjkE8lm29PEmLSNK7gMNJClFDpiGcnWcu+3n0RPTBTp34bqQx2Be3CmanTfC+Sx78pvGkQHVOAsQgD9Po7c+eAp3XrWJjYAHnAyJ9HPObnsVVgWFMdXEtedJNkfuSJ0N3GXN5vu2E3PbTLGlP6LPIX7z2bu5Bqp/yxsiA8kXow9JtTuRYfiB4i3gwbnWOZD/H2ZPvCRV58i0BgOTr+hcyI2k3mHkCTrpkEw8p1GPW0Z949tB9fZX5WxCFK3RlF45GwYIKwjbU7q9ieBi48cnfKPSDg3Gkin7sAR+jtliTUnuvq3789F7P14Z9k1hYBVjkgTqefn6MXZjAwEoWKTelqsxKmIv3y3p+ytiu2G9TbkbStZyZb9C5gIBi1B9jM4XwWF34jjchtRGx3c5HpTlVYT0qsTszbj9G+tQo82pTV3xRYy+jlTB/V/VfwgmTc3w1XjHUi/wXIXj/YK9pEY03eMN48SeaHWuQ+q0JwnpIR7KRwtdSHkH8SM2HR1unzw9Gt/PQHz0U1+wEw+rRaeBwgV+BYRBMnn3UkQr9kd8ZFgQm1nDd4dOiP5o5HZJlbMG70mU/XDmGf6MzvGJroS1DSvDb+rTuHVU6iSpIhTWIzghKPwLgvb7xG34VbylSOexvB70Bo1QzqGf5Sd+Y9Nye2RGu0x55bLD02FsXJu45zz3yFdiq+adgHwnyMoPWUIoJv9HFu4qcSnKyq/cowJJQJ9tC2RM6whJ4yLKnhBdVwCtDAYdD1TWYJvPPgUPRXQ/q9b4zDr/mgxUKSBspzwW5f9aMco3idcwQNHdYzN7eSckiq8xAl3Lc9l/gzxoYqUkfWqDtxbbaZHr9THgNO4Yp0PSEphb7pAJvz0/2U6/ij1+bW3BcwFOzj5HvCTeSQghgHN6epLIEfqXmAPeFbD/sV7+kf0X3EVokzTzD0CsVm9/HpB6Do7lBdwOk2lDqkzMTQ0OleIQ80lahCqe1NoZgvshvHVMONOA1x9Xy2129jHWauzxpoWn0SINuPR302aqj9bJGCCagnFHjdTCrybriLoQOaB4yAl+B/cbtJcT5mnBQMykRHX+wpNVJuCDYjI8IEs07r3YZdLte9dz67a1uXMz4mvfqvPgewK1zYYzPb0x1WIx/i4ZfYUfkcFnZVsU3fW9+Y5HBMGyYhxZErXZ4wElWIyRSLOhYsBe/3KGrg7U= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700013)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2025 05:48:52.3157 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d29b96e1-9abc-4b22-afb6-08dd5c72934c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A0FA.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8106 X-Rspamd-Queue-Id: 6482F140007 X-Stat-Signature: yxkjw3usdocnnqg4gq6daojjuixasjso X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741240138-73321 X-HE-Meta: U2FsdGVkX182enIpOXMXukKVVVMoyLt6ZrgqG+pW9A3wrVAPzb0Yfxwtc4rvcXlMHdSU6cmHTglwt0eQ2Q7YklQSNbEDnwBkVD1svXu0ergEWK25SELplbo9SR4WWclzzt/I/+IFjHODuw0OW54Gvk3pZiIOs2Vl0qbkeB+jRaUHF5RwrmOYILqRBt+TYKJ9VnCr89/5h0Q6UMpZcLR5+xTkpfEL8qFHmhVRpP4GkmsvRah5/PI+xCNAjL99Qlwl0kllb7od57ySW2wYlQB2I/HuL5ZPb+S8Q8e8L0RNaR0BRFlHxvjDpfE/qFDD1ezkx8/jZYq4jnT+6qLR8JMM1mq77QnoilhudJuyE9wAYtYc7tzBgCltJw/IcVGMRp1Np0rYjnAlFIX/DBdmGvzMaNWQDrCh6A0VnncDJPHCdAMHpRddkUcBHSR/dlHS3He7/K4h/39iLCryfzf4t7P7rffFBCOFPlXi9sXUjaOAP0ZzanR3ojGf7jOGKVNpaiycfvQGXUSx1VJlnYIA1v9G+ZFWfDDuKf9AOqV6z4hiZi8cziO7dsG3wQqcVspqLk6eYbr7jsYaq9c9kLkJbjjSKcSHoAwc5MhqHTJfw6S9Gs0+rEkorBB5G/sPkek9nWlheUUbsXwzaztWQkf8a7pWxqCWP+F8TmzWO5ByG3d58Un8Qjszs+ibB6SHgcSF8JZojbdRfgOnlxCDHpTBvWZWkH/eUgzaVI1OYtW8B8QG60bfBg1Hzw8KPqSko11eqBR5CZ8ZWVoIjOO/UhQ22pz7f6YkyrBgExT1mvTTD71tYzp1GrOp+GV1a0wSrHRsF+fcLlvd+hEHbQeNtj9jajmBvsl3zlfY/RZRL5pJPx/2YIA4wufV4aaOZ+ZUJvpAOGkg/GQibXQelvUW0gjkY8aA5tJGIxNmY/6IDTy+qxLSR50NTr7ZYDQ5NOOc3eQleD/EUAzZzOV4FLVoYZRv7ID 7VWFase7 dXr+FlpXovFv8h1EYugJdAW6wP4SHhP9aN/zDCYtE+M+0GmlWU9PaLWgSafQV11TJbL93ZTYewg7ZaVOm0wWivmS1Q1JbnEwH4jDRzEQFgyOfL/vTdk+/BNxX8wwnNgSuMgaeF4vaj0XKsCnig9MCz8HWHaljR+c7UdgaMczsBIq982La4/AZUTId6Ajryvg9UP8DgpfpaE2u7VIDQlTk+40UXr1A9LkUm+OmiLeJ+YvL7SE3SquinqC71U3J2V+fnJeyNS05fpRv8C+/NzqUtZaurxiYBA9ZiIWM2Zp9yG/p+10G7TzcNHm01H7CFsPH6XilUE1yfvV7N49qZy6UHnRfdUCSzT1BoudrkEQQcsJDTLxuBnMxAcVGwERd6lTZlIp0o7XuoNfOAgLIPx+ejZGqBgZf5NrdhoX5uvhxQJzSXb/J6arwcrWBAnn0piZB52DThu9bvXUcRrsQSYg9pAxx2FcIv7jagOaXIfke/nY/3PVS045JolcELjsKrn1QNDAuABFCgZ4+ut4MmkddEcOX43ZWHXx/1F+2re+fqmNkSOxxSsR5tAplFM/au5GrVsom X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Enable IBS memory access data collection for user memory accesses by programming the required MSRs. The profiling is turned ON only for user mode execution and turned OFF for kernel mode execution. Profiling is explicitly disabled for NMI handler too. TODOs: - IBS sampling rate is kept fixed for now. - Arch/vendor separation/isolation of the code needs relook. Signed-off-by: Bharata B Rao --- arch/x86/include/asm/entry-common.h | 3 +++ arch/x86/include/asm/hardirq.h | 2 ++ arch/x86/include/asm/ibs.h | 2 ++ arch/x86/mm/ibs.c | 32 +++++++++++++++++++++++++++++ 4 files changed, 39 insertions(+) diff --git a/arch/x86/include/asm/entry-common.h b/arch/x86/include/asm/entry-common.h index 77d20555e04d..8127111c6ad3 100644 --- a/arch/x86/include/asm/entry-common.h +++ b/arch/x86/include/asm/entry-common.h @@ -9,10 +9,12 @@ #include #include #include +#include /* Check that the stack and regs on entry from user mode are sane. */ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs) { + hw_access_profiling_stop(); if (IS_ENABLED(CONFIG_DEBUG_ENTRY)) { /* * Make sure that the entry code gave us a sensible EFLAGS @@ -98,6 +100,7 @@ static inline void arch_exit_to_user_mode_prepare(struct pt_regs *regs, static __always_inline void arch_exit_to_user_mode(void) { amd_clear_divider(); + hw_access_profiling_start(); } #define arch_exit_to_user_mode arch_exit_to_user_mode diff --git a/arch/x86/include/asm/hardirq.h b/arch/x86/include/asm/hardirq.h index 6ffa8b75f4cd..b928fbbcf3e5 100644 --- a/arch/x86/include/asm/hardirq.h +++ b/arch/x86/include/asm/hardirq.h @@ -91,4 +91,6 @@ static __always_inline bool kvm_get_cpu_l1tf_flush_l1d(void) static __always_inline void kvm_set_cpu_l1tf_flush_l1d(void) { } #endif /* IS_ENABLED(CONFIG_KVM_INTEL) */ +#define arch_nmi_enter() hw_access_profiling_stop() +#define arch_nmi_exit() hw_access_profiling_start() #endif /* _ASM_X86_HARDIRQ_H */ diff --git a/arch/x86/include/asm/ibs.h b/arch/x86/include/asm/ibs.h index b5a4f2ca6330..6b480958534e 100644 --- a/arch/x86/include/asm/ibs.h +++ b/arch/x86/include/asm/ibs.h @@ -2,6 +2,8 @@ #ifndef _ASM_X86_IBS_H #define _ASM_X86_IBS_H +void hw_access_profiling_start(void); +void hw_access_profiling_stop(void); extern bool arch_hw_access_profiling; #endif /* _ASM_X86_IBS_H */ diff --git a/arch/x86/mm/ibs.c b/arch/x86/mm/ibs.c index 5c966050ad86..961d0c67ca50 100644 --- a/arch/x86/mm/ibs.c +++ b/arch/x86/mm/ibs.c @@ -15,6 +15,7 @@ bool arch_hw_access_profiling; static u64 ibs_config __read_mostly; static u32 ibs_caps; +#define IBS_SAMPLE_PERIOD 10000 #define IBS_NR_SAMPLES 50 /* @@ -99,6 +100,36 @@ static void ibs_irq_handler(struct irq_work *i) schedule_work_on(smp_processor_id(), &ibs_work); } +void hw_access_profiling_stop(void) +{ + u64 ops_ctl; + + if (!arch_hw_access_profiling) + return; + + rdmsrl(MSR_AMD64_IBSOPCTL, ops_ctl); + wrmsrl(MSR_AMD64_IBSOPCTL, ops_ctl & ~IBS_OP_ENABLE); +} + +void hw_access_profiling_start(void) +{ + u64 config = 0; + unsigned int period = IBS_SAMPLE_PERIOD; + + if (!arch_hw_access_profiling) + return; + + /* Disable IBS for kernel thread */ + if (!current->mm) + goto out; + + config = (period >> 4) & IBS_OP_MAX_CNT; + config |= (period & IBS_OP_MAX_CNT_EXT_MASK); + config |= ibs_config; +out: + wrmsrl(MSR_AMD64_IBSOPCTL, config); +} + /* * IBS NMI handler: Process the memory access info reported by IBS. * @@ -305,6 +336,7 @@ static int __init ibs_access_profiling_init(void) x86_amd_ibs_access_profile_startup, x86_amd_ibs_access_profile_teardown); + arch_hw_access_profiling = true; pr_info("IBS setup for memory access profiling\n"); return 0; }