From patchwork Thu Mar 6 17:59:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 14005066 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA3DFC28B24 for ; Thu, 6 Mar 2025 17:59:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C46B28000A; Thu, 6 Mar 2025 12:59:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF2D3280003; Thu, 6 Mar 2025 12:59:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D41E028000A; Thu, 6 Mar 2025 12:59:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ACDA1280003 for ; Thu, 6 Mar 2025 12:59:25 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B1551122046 for ; Thu, 6 Mar 2025 17:59:25 +0000 (UTC) X-FDA: 83191888290.12.8B2928D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf10.hostedemail.com (Postfix) with ESMTP id 1E33AC0011 for ; Thu, 6 Mar 2025 17:59:23 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="G/nQTPBz"; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741283964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DnGjfzwePJI8dPbw7cgFIQJDRUdQE7hYnkAlMhYQ9g4=; b=Z12z98pipbCe1O/8UFoMRHO5aufGLPhN4QTqa1iu9X/M9s/yE89Tou5elT1k74H2MT4cpD GZGGVcYAo44aleXdjHa5/Da4jq10yoSmfdVr1X2mYenimjTDwzKfMV2IN9CYboWibWyUWT jxPFFNqqEaSUt53OvkXlOvHR+DBoNnQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741283964; a=rsa-sha256; cv=none; b=bYNcvEpyPLF72kanWS83o8/3o04yVISIwt6NqIzgFN84udqJRnW6IHW4szEB+BpjkHg5Nu o8PtMXgz4ARms9pX/yXiBymare2zAalmUQUbXflwI3xCR1esf37UY1XT2z2k7l6l1JmwLd SMsjJkGc5RNMglWZs6+11emaoGbkomA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="G/nQTPBz"; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C42F3A450E3; Thu, 6 Mar 2025 17:53:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1167BC4CEEA; Thu, 6 Mar 2025 17:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741283963; bh=MsBfeedR0E0avwOTjpu2VsFxt43snXdrtNBJJKsBtYo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G/nQTPBzQrtpc5jfIx22kSnzs/KBPP9QCYN85wNLoqhwXrsVCXcSEy5U+RE50RNnl W7dqDVpn1T1x5/GZwFQTa0Uew+C/LSV/h/l5T07mMca38oJUdAJJYEQuq7HXQxrcKJ gypqc4h2FpWf0bqO7keCsYhEEP7IuJBBQIejEhxuZiq7v9EjFPGK2Gp3n5TAQsn4E6 ZSQVQCW+INhCa0N1HUhw2mMqzA2wiXsYqGCM3e2yYvLKhXMZ7Sc1tFMQUYW2Wmzf9P LS/b7ym8umSgYcZRIpoy6mswvy0yiAv/3qfwagcc/JgcaMpFQW0YnSzblrJF7pVLVO t18FzFkNOb65w== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 09/13] mm/damon: remove damon_callback->private Date: Thu, 6 Mar 2025 09:59:04 -0800 Message-Id: <20250306175908.66300-10-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250306175908.66300-1-sj@kernel.org> References: <20250306175908.66300-1-sj@kernel.org> MIME-Version: 1.0 X-Stat-Signature: zbooptkmy3r583q7q59su4jkrq7ud7dz X-Rspamd-Queue-Id: 1E33AC0011 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1741283963-909605 X-HE-Meta: U2FsdGVkX19w1cPXjPNyKldxFjfapdbW/uvNy3PvmliOh7q9n092xQQ2QwbUt8IlYrZYb8PBO9swn8SG/XK1LNsakdk0n9KKT3GqpNIl1cNdwtnERkEGe98KA8bkIKfwQqb1Qt9K1QrROrnhZHiZF5TSatxeGepCFoFh/yjMwHqiT8BiZL+6y5OkRdP6lgvAQYOY5LevFsf80ghVBBSlLonhjeT5DbdpZfAqktcR4F+Ug264GUYT6eWRqfwJ7YgaKUd9PKgBntHSWKhKu/SnV5psKEwYnfl0xHG41xXvwiePdBGMsrbTTrCBIehoJBjkzktFOd/XRn9DmlegHV7+VLcmVXTyhb1ylEZhimgxmM7O1nCfWzjsQWQFpok8sDreyXTxHEo4PkihaU+vcmvg8TBMpwItjQB3enI07N0LYhsAuqeUl744krwLCPFr2RrgdFTYJYOHepqaSeNdNTsBlAvltH0IAcU4CQjr1T/aBuANC7B4tJPewzHl4WvSnH1WYQtB7TEq8+8dOyPIFA6Sa0d31JyDZGMYewN3I0SWTaZq1sMiKs2XVrMdA1sn5dpN958QUJxF7ACkTcQ2BCp1g2NYY7VlA/RCPoS9J+SI5lEXW12P4lF4oB1XPiTHUc2rFmEXd117MeNpCbNE2t6aDYoxEPR2IMrgdnVEzomOpVJ1vVIPyAM8yBPldUWDJUuNjc2mWmPDQ52Mag8rtLQOwhIScFn+S4om7jXvhk5jtrP4cXHmQfcVeInzY70BVuDbWF82JvBOotyHK+r0G0qYxul+nN6IlJtM0K6PziAXIyNN60XvHEAyBBqZCLqEMAjPZGYcg2/W43EW/OCJyY1T/X8cbzgbKeDXLyHV3/5o7ZW85MBrkqc0lPlLVV8qb/HzkL+9gsWLzA3mwyfkqUWgR0z5DB5cmAlLt+2OPP3fmo/0+bm6JhWhLVK7daKp2WlYYR/MnwhNofYaWp9t3yR lnpgmxUb ONi7Vz7E3+gAvrXRJ0T3IJpWhZyZqf+MLPXvNYunS/6G0x2PzlTSkPnl3iM32m6gDDvbsWMK6/5LdUoM4FELQ2QCy6T2qPDjUM9R3bNxsBbcXUBl7EDElvLO3s0v2WdxF80YuuOEuIm+QFBt4N7g5+QW2cjdfim9m2kD2cufColk62luE0HyEfc65WvcQRJ6YdHVd4avnhJ1SgDAxuwNDfEE1rDmtacwJFCAx0mEXoqRn+XKSHOAxawL69bbwIulKTZOrgL1aVvncR19eOdbBaFbRbA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The field was added to let users keep their personal data to use inside of the callbacks. However, no one is actively using that now. Remove it. Signed-off-by: SeongJae Park --- include/linux/damon.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index eed008b64a23..dab4bb0fe39d 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -609,12 +609,10 @@ struct damon_operations { * @after_aggregation: Called after each aggregation. * @before_damos_apply: Called before applying DAMOS action. * @before_terminate: Called before terminating the monitoring. - * @private: User private data. * * The monitoring thread (&damon_ctx.kdamond) calls @before_start and * @before_terminate just before starting and finishing the monitoring, - * respectively. Therefore, those are good places for installing and cleaning - * @private. + * respectively. * * The monitoring thread calls @after_wmarks_check after each DAMON-based * operation schemes' watermarks check. If users need to make changes to the @@ -630,8 +628,6 @@ struct damon_operations { * If any callback returns non-zero, monitoring stops. */ struct damon_callback { - void *private; - int (*before_start)(struct damon_ctx *context); int (*after_wmarks_check)(struct damon_ctx *context); int (*after_sampling)(struct damon_ctx *context);